[Bug 656082] Review Request: cprops - library of C prototyping functions, mostly searching
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=656082 Philip Prindeville phil...@redfish-solutions.com changed: What|Removed |Added Flag||fedora-cvs+ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 656082] Review Request: cprops - library of C prototyping functions, mostly searching
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=656082 Jerry James loganje...@gmail.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #21 from Jerry James loganje...@gmail.com 2012-01-26 14:50:42 EST --- Looks good. All of the MUST items are now satisfied. This package is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 656082] Review Request: cprops - library of C prototyping functions, mostly searching
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=656082 Thomas Spura toms...@fedoraproject.org changed: What|Removed |Added Flag|fedora-cvs+ | --- Comment #22 from Thomas Spura toms...@fedoraproject.org 2012-01-26 20:43:28 EST --- Unsetting fedora-cvs+ as there is no SCM request anywhere. See here, for how to ask for new branches: http://fedoraproject.org/wiki/Package_SCM_admin_requests -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 656082] Review Request: cprops - library of C prototyping functions, mostly searching
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=656082 --- Comment #23 from Philip Prindeville phil...@redfish-solutions.com 2012-01-26 20:56:21 EST --- New Package SCM Request === Package Name: libcprops Short Description: C prototyping tools Owners: philipp Branches: f16 el6 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 656082] Review Request: cprops - library of C prototyping functions, mostly searching
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=656082 Philip Prindeville phil...@redfish-solutions.com changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 656082] Review Request: cprops - library of C prototyping functions, mostly searching
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=656082 --- Comment #24 from Jon Ciesla limburg...@gmail.com 2012-01-26 21:17:48 EST --- Summary name and SCM request name don't match, please correct. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 656082] Review Request: cprops - library of C prototyping functions, mostly searching
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=656082 --- Comment #19 from Philip Prindeville phil...@redfish-solutions.com 2012-01-24 18:17:18 EST --- Updated: http://fedorapeople.org/~philipp/libcprops-0.1.12-1.fc16.src.rpm http://fedorapeople.org/~philipp/libcprops.spec $ rpmlint libcprops.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpmlint libcprops-0.1.12-1.fc16.src.rpm libcprops.src: W: spelling-error %description -l en_US trie - tire, true, tie libcprops.src: W: spelling-error %description -l en_US tcp - pct, tsp, tip libcprops.src: W: spelling-error %description -l en_US http - HTTP libcprops.src: W: spelling-error %description -l en_US api - pi, ape, apt libcprops.src: W: spelling-error %description -l en_US dbms - DBMS, dims, dams 1 packages and 0 specfiles checked; 0 errors, 5 warnings. $ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 656082] Review Request: cprops - library of C prototyping functions, mostly searching
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=656082 --- Comment #20 from Philip Prindeville phil...@redfish-solutions.com 2012-01-24 18:39:31 EST --- And post-install: $ rpmlint libcprops libcprops-devel libcprops.x86_64: W: spelling-error %description -l en_US trie - tire, true, tie libcprops.x86_64: W: spelling-error %description -l en_US tcp - pct, tsp, tip libcprops.x86_64: W: spelling-error %description -l en_US http - HTTP libcprops.x86_64: W: spelling-error %description -l en_US api - pi, ape, apt libcprops.x86_64: W: spelling-error %description -l en_US dbms - DBMS, dims, dams libcprops.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libcp_dbms_mysql.so.0.0.0 linux-vdso.so.1 libcprops.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libcprops.so.15.0.0 linux-vdso.so.1 libcprops.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libcp_dbms_postgres.so.0.0.0 linux-vdso.so.1 2 packages and 0 specfiles checked; 0 errors, 8 warnings. $ I'm told that the warnings for linux-vdso can be safely ignored as they're an artifact of the x86_64. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 656082] Review Request: cprops - library of C prototyping functions, mostly searching
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=656082 --- Comment #17 from Philip Prindeville phil...@redfish-solutions.com 2012-01-09 13:42:22 EST --- (In reply to comment #16) If you don't intend to use this spec file for an EPEL package, then you can delete the following spec file elements, all of which are unnecessary in every current Fedora release: the BuildRoot tag, rm -rf $RPM_BUILD_ROOT at the top of %install, the entire %clean script, and %defattr in the %files sections. Actually, I do intend to publish it on EPEL just as soon as it gets accepted on Fedora. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 656082] Review Request: cprops - library of C prototyping functions, mostly searching
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=656082 --- Comment #18 from Philip Prindeville phil...@redfish-solutions.com 2012-01-09 13:56:15 EST --- Applied patches in comment 14 and comment 15 upstream. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 656082] Review Request: cprops - library of C prototyping functions, mostly searching
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=656082 Jerry James loganje...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|loganje...@gmail.com Flag||fedora-review? --- Comment #12 from Jerry James loganje...@gmail.com 2011-12-14 12:32:06 EST --- I'll take this review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 656082] Review Request: cprops - library of C prototyping functions, mostly searching
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=656082
--- Comment #13 from Jerry James loganje...@gmail.com 2011-12-14 13:44:06 EST
---
Created attachment 546853
-- https://bugzilla.redhat.com/attachment.cgi?id=546853
Patch to support mysql builds
This isn't a requirement, just a suggestion. If you add the attached patch as
Patch0, add a %bcond_without for mysql, add this:
%if %with mysql
BuildRequires: mysql-devel
%endif
add %patch0 to %prep, and add this to the configure invocation:
%{?with_mysql:--with-mysql-includes=%{_includedir}/mysql} \
%{?with_mysql:--with-mysql-libs=%{_libdir}/mysql}
then it is possible to build with mysql support, too. It might also be worth
poking upstream about using standard autoconf macros, like AC_CHECK_HEADERS and
AC_CHECK_LIB so we don't have to patch their broken shell scripts. :-)
Sorry, I use mysql a lot at work, so I wondered why support wasn't included.
I'll stop being distracted now and get back to the review...
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 656082] Review Request: cprops - library of C prototyping functions, mostly searching
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=656082 Jerry James loganje...@gmail.com changed: What|Removed |Added Attachment #546853|0 |1 is obsolete|| --- Comment #14 from Jerry James loganje...@gmail.com 2011-12-14 15:26:32 EST --- Created attachment 546873 -- https://bugzilla.redhat.com/attachment.cgi?id=546873 Patch to support mysql builds It turns out the previous patch wasn't quite sufficient. Upstream has a bug in their source code that results in unsatisfiable references to symbols in the shared library. This new patch fixes that, too. Upstream should apply the db_mysql.c portion of the patch, regardless of what they think of the rest. OK, I'm really, really doing the rest of the review now. Really. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 656082] Review Request: cprops - library of C prototyping functions, mostly searching
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=656082 --- Comment #15 from Jerry James loganje...@gmail.com 2011-12-14 15:34:30 EST --- Created attachment 546876 -- https://bugzilla.redhat.com/attachment.cgi?id=546876 Patch to fix the link If you run rpmlint on the *installed* libcprops package, not the binary RPM, then you'll see lots of warnings like this: $ rpmlint libcprops libcprops-devel ... libcprops.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcprops.so.10.4.0 SSL_free libcprops.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcprops.so.10.4.0 SSL_CTX_free libcprops.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcprops.so.10.4.0 X509_NAME_get_text_by_NID libcprops.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcprops.so.10.4.0 pthread_detach libcprops.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcprops.so.10.4.0 SSL_get_error ... libcprops.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcp_dbms_postgres.so.0.0.0 cp_string_destroy libcprops.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcp_dbms_postgres.so.0.0.0 cp_hash_int libcprops.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcp_dbms_postgres.so.0.0.0 intdup libcprops.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcp_dbms_postgres.so.0.0.0 cp_hash_compare_int ... libcprops.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libcp_dbms_postgres.so.0.0.0 /lib64/libdl.so.2 libcprops.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libcp_dbms_postgres.so.0.0.0 /lib64/libpthread.so.0 libcprops.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libcp_dbms_postgres.so.0.0.0 /usr/lib64/libssl.so.10 These warnings indicate the the shared libraries are not being linked properly. This patch fixes part of the problem. To fix the rest, drop this into your spec file, in between the %configure invocation and the make invocation: sed -e 's|^hardcode_libdir_flag_spec=.*|hardcode_libdir_flag_spec=|g' \ -e 's|^runpath_var=LD_RUN_PATH|runpath_var=DIE_RPATH_DIE|g' \ -e 's|func_apped|func_append|' \ -e 's|CC -shared|CC -shared -Wl,--as-needed|' \ -i libtool The first two expressions are from https://fedoraproject.org/wiki/Packaging:Guidelines#Removing_Rpath. You didn't have problems with rpath before, because libtool only sets the rpath if the object being created is linked against something. The third expression fixes bug 759376. Normally, you could fix the unused-direct-shlib-dependency warnings by adding -Wl,--as-needed to LDFLAGS, but that doesn't work when using libtool due to http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=347650, The fourth expression is a cheap and dirty workaround for that problem. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 656082] Review Request: cprops - library of C prototyping functions, mostly searching
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=656082
--- Comment #16 from Jerry James loganje...@gmail.com 2011-12-14 16:09:59 EST
---
Question 1: why is the release number 0.1, instead of 1?
Question 2: wouldn't http://cprops.sourceforge.net/ be a better value for URL?
If you don't intend to use this spec file for an EPEL package, then you can
delete the following spec file elements, all of which are unnecessary in every
current Fedora release: the BuildRoot tag, rm -rf $RPM_BUILD_ROOT at the top
of %install, the entire %clean script, and %defattr in the %files sections.
Note that the rpmlint output below is from the installed packages, not the
binary RPMs, and was created with the changes in comment 15 applied.
+: OK
-: must be fixed
=: should be fixed (at your discretion)
N: not applicable
MUST:
[=] rpmlint output:
libcprops.x86_64: W: spelling-error %description -l en_US trie - tire, true,
tie
libcprops.x86_64: W: spelling-error %description -l en_US tcp - pct, tsp, tip
libcprops.x86_64: W: spelling-error %description -l en_US http - HTTP
libcprops.x86_64: W: spelling-error %description -l en_US api - pi, ape, apt
libcprops.x86_64: W: spelling-error %description -l en_US dbms - DBMS, dims,
dams
libcprops.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libcprops.so.10.4.0 linux-vdso.so.1
libcprops.x86_64: W: shared-lib-calls-exit /usr/lib64/libcprops.so.10.4.0
exit@GLIBC_2.2.5
libcprops.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libcp_dbms_postgres.so.0.0.0 linux-vdso.so.1
libcprops.x86_64: W: no-documentation
2 packages and 1 specfiles checked; 0 errors, 9 warnings.
Those are all innocuous, except for the shared-lib-calls-exit warning. Please
check with upstream about returning an error code instead of exiting.
[+] follows package naming guidelines
[+] spec file base name matches package name
[-] package meets the packaging guidelines: only one small problem, the devel
package should require the main package like this, as documented at
https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package:
Requires: %{name}%{?_isa} = %{version}-%{release}
[+] package uses a Fedora approved license
[+] license field matches the actual license
[-] license file is included in %doc: please add it. Consider adding README to
%doc, too, and maybe even the example directory.
[+] spec file is in American English
[+] spec file is legible
[+] sources match upstream: md5sum is da30a8bdc34cee023372bdbb7352ee76 for both
[+] package builds on at least one primary arch (tried x86_64)
[N] appropriate use of ExcludeArch
[+] all build requirements in BuildRequires
[N] spec file handles locales properly
[+] ldconfig in %post and %postun
[+] no bundled copies of system libraries
[+] no relocatable packages
[-] package owns all directories that it creates: it does not own
/usr/include/cprops. Get rid of the * on the end of the %files entry, so
that it reads:
%{_includedir}/cprops/
[+] no files listed twice in %files
[+] proper permissions on files
[+] consistent use of macros
[+] code or permissible content
[N] large documentation in -doc
[+] no runtime dependencies in %doc
[+] header files in -devel
[N] static libraries in -static
[+] .so in -devel
[+] -devel requires main package
[+] package contains no libtool archives
[N] package contains a desktop file, uses desktop-file-install
[+] package does not own files/dirs owned by other packages
[+] all filenames in UTF-8
SHOULD:
[N] query upstream for license text
[N] description and summary contain available translations
[+] package builds in mock: tried fedora-rawhide-i386
[+] package builds on all supported arches: tried i386 and x86_64
[+] package functions as described: light testing only
[+] sane scriptlets
[+] subpackages require the main package
[N] placement of pkgconfig files
[N] file dependencies versus package dependencies
[N] package contains man pages for binaries/scripts
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 656082] Review Request: cprops - library of C prototyping functions, mostly searching
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=656082 --- Comment #11 from Philip Prindeville phil...@redfish-solutions.com 2011-12-09 22:25:08 EST --- Updating again: http://fedorapeople.org/~philipp/libcprops-0.1.10-0.1.fc16.src.rpm http://fedorapeople.org/~philipp/libcprops.spec [philipp@builder SPECS]$ rpmlint libcprops.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. [philipp@builder SPECS]$ rpmlint ../SRPMS/libcprops-0.1.10-0.1.fc16.src.rpm libcprops.src: W: spelling-error %description -l en_US trie - tire, true, tie libcprops.src: W: spelling-error %description -l en_US tcp - pct, tsp, tip libcprops.src: W: spelling-error %description -l en_US http - HTTP libcprops.src: W: spelling-error %description -l en_US api - pi, ape, apt libcprops.src: W: spelling-error %description -l en_US dbms - DBMS, dims, dams 1 packages and 0 specfiles checked; 0 errors, 5 warnings. [philipp@builder SPECS]$ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 656082] Review Request: cprops - library of C prototyping functions, mostly searching
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=656082 --- Comment #10 from Philip Prindeville phil...@redfish-solutions.com 2011-11-24 17:08:35 EST --- Updated to official release: http://fedorapeople.org/~philipp/libcprops-0.1.9-0.1.fc16.src.rpm http://fedorapeople.org/~philipp/libcprops.spec [philipp@builder SPECS]$ rpmlint libcprops.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. [philipp@builder SPECS]$ rpmlint ../SRPMS/libcprops-0.1.9-0.1.fc16.src.rpm libcprops.src: W: spelling-error %description -l en_US trie - tire, true, tie libcprops.src: W: spelling-error %description -l en_US tcp - pct, tsp, tip libcprops.src: W: spelling-error %description -l en_US http - HTTP libcprops.src: W: spelling-error %description -l en_US api - pi, ape, apt libcprops.src: W: spelling-error %description -l en_US dbms - DBMS, dims, dams 1 packages and 0 specfiles checked; 0 errors, 5 warnings. [philipp@builder SPECS]$ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 656082] Review Request: cprops - library of C prototyping functions, mostly searching
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=656082 Philip Prindeville phil...@redfish-solutions.com changed: What|Removed |Added Summary|Review Request: libcprops - |Review Request: cprops - |library of C prototyping|library of C prototyping |functions, mostly searching |functions, mostly searching -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
