[Bug 661154] Review Request: votca-csg - VOTCA coarse graining engine

2010-12-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=661154

--- Comment #19 from Fedora Update System upda...@fedoraproject.org 
2010-12-24 19:27:48 EST ---
votca-csg-1.0.1-2.fc13, votca-tools-1.0.1-2.fc13 has been pushed to the Fedora
13 stable repository.  If problems still persist, please make note of it in
this bug report.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 661154] Review Request: votca-csg - VOTCA coarse graining engine

2010-12-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=661154

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||votca-csg-1.0.1-2.fc14
 Resolution||ERRATA
Last Closed||2010-12-24 19:27:18

Bug 661154 depends on bug 661143, which changed state.

Bug 661143 Summary: Review Request: votca-tools - VOTCA tools library
https://bugzilla.redhat.com/show_bug.cgi?id=661143

   What|Old Value   |New Value

 Resolution||ERRATA
 Status|ON_QA   |CLOSED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 661154] Review Request: votca-csg - VOTCA coarse graining engine

2010-12-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=661154

--- Comment #18 from Fedora Update System upda...@fedoraproject.org 
2010-12-24 19:27:06 EST ---
votca-csg-1.0.1-2.fc14, votca-tools-1.0.1-2.fc14 has been pushed to the Fedora
14 stable repository.  If problems still persist, please make note of it in
this bug report.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 661154] Review Request: votca-csg - VOTCA coarse graining engine

2010-12-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=661154

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA

--- Comment #17 from Fedora Update System upda...@fedoraproject.org 
2010-12-17 03:20:18 EST ---
votca-csg-1.0.1-2.fc14, votca-tools-1.0.1-2.fc14 has been pushed to the Fedora
14 testing repository.  If problems still persist, please make note of it in
this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update votca-csg votca-tools'.  You
can provide feedback for this update here:
https://admin.fedoraproject.org/updates/votca-csg-1.0.1-2.fc14,votca-tools-1.0.1-2.fc14

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 661154] Review Request: votca-csg - VOTCA coarse graining engine

2010-12-15 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=661154

--- Comment #13 from Fedora Update System upda...@fedoraproject.org 
2010-12-15 05:57:32 EST ---
votca-csg-1.0.1-2.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/votca-csg-1.0.1-2.fc14

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 661154] Review Request: votca-csg - VOTCA coarse graining engine

2010-12-15 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=661154

--- Comment #14 from Fedora Update System upda...@fedoraproject.org 
2010-12-15 05:57:35 EST ---
votca-csg-1.0.1-2.fc13 has been submitted as an update for Fedora 13.
https://admin.fedoraproject.org/updates/votca-csg-1.0.1-2.fc13

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 661154] Review Request: votca-csg - VOTCA coarse graining engine

2010-12-15 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=661154

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 661154] Review Request: votca-csg - VOTCA coarse graining engine

2010-12-15 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=661154

--- Comment #15 from Fedora Update System upda...@fedoraproject.org 
2010-12-15 06:00:19 EST ---
votca-csg-1.0.1-2.fc13,votca-tools-1.0.1-2.fc13 has been submitted as an update
for Fedora 13.
https://admin.fedoraproject.org/updates/votca-csg-1.0.1-2.fc13,votca-tools-1.0.1-2.fc13

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 661154] Review Request: votca-csg - VOTCA coarse graining engine

2010-12-15 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=661154

--- Comment #16 from Fedora Update System upda...@fedoraproject.org 
2010-12-15 06:01:21 EST ---
votca-csg-1.0.1-2.fc14,votca-tools-1.0.1-2.fc14 has been submitted as an update
for Fedora 14.
https://admin.fedoraproject.org/updates/votca-csg-1.0.1-2.fc14,votca-tools-1.0.1-2.fc14

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 661154] Review Request: votca-csg - VOTCA coarse graining engine

2010-12-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=661154

--- Comment #6 from Dominik 'Rathann' Mierzejewski r...@greysector.net 
2010-12-14 06:00:27 EST ---
Ahem, it should be:

2 ./share/template/template.cc is missing licencing information.

3. Timestamps are not preserved in make install.

of course. :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 661154] Review Request: votca-csg - VOTCA coarse graining engine

2010-12-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=661154

Dominik 'Rathann' Mierzejewski r...@greysector.net changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|nob...@fedoraproject.org|r...@greysector.net
   Flag||fedora-review?

--- Comment #5 from Dominik 'Rathann' Mierzejewski r...@greysector.net 
2010-12-14 05:58:36 EST ---
Source matches upstream:

$ md5sum votca-csg-1.0.1.tar.gz*
855fec6510665d45d81c4987f62b95b2  votca-csg-1.0.1.tar.gz
855fec6510665d45d81c4987f62b95b2  votca-csg-1.0.1.tar.gz.1

Comments:

1. Typo:
%package devel
...
Requires:   votka-tools-devel

./share/template/template.cc is missing licencing information

2. Timestamps are not preserved in make install.

Otherwise the package looks fine.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 661154] Review Request: votca-csg - VOTCA coarse graining engine

2010-12-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=661154

--- Comment #7 from Christoph Junghans jungh...@votca.org 2010-12-14 06:25:21 
EST ---
(In reply to comment #6)
 2 ./share/template/template.cc is missing licencing information.
I added licensing information:
http://code.google.com/p/votca/source/detail?r=99793a446a09f4e2f78bf05cd015fa362a162b70repo=csg

Should it also be added to the Makefile in ./share/template/ ?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 661154] Review Request: votca-csg - VOTCA coarse graining engine

2010-12-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=661154

--- Comment #8 from Jussi Lehtola jussi.leht...@iki.fi 2010-12-14 07:51:02 
EST ---
Fixed 1 and 3. 2 will be fixed when upstream (Christoph) makes a new release.

http://theory.physics.helsinki.fi/~jzlehtol/rpms/votca-csg.spec
http://theory.physics.helsinki.fi/~jzlehtol/rpms/votca-csg-1.0.1-2.fc14.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 661154] Review Request: votca-csg - VOTCA coarse graining engine

2010-12-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=661154

--- Comment #9 from Dominik 'Rathann' Mierzejewski r...@greysector.net 
2010-12-14 09:06:40 EST ---
(In reply to comment #7)
 (In reply to comment #6)
  2 ./share/template/template.cc is missing licencing information.
 I added licensing information:

Good, thanks.

 Should it also be added to the Makefile in ./share/template/ ?

I don't think that's necessary.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 661154] Review Request: votca-csg - VOTCA coarse graining engine

2010-12-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=661154

Dominik 'Rathann' Mierzejewski r...@greysector.net changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+

--- Comment #10 from Dominik 'Rathann' Mierzejewski r...@greysector.net 
2010-12-14 09:10:19 EST ---
(In reply to comment #8)
 Fixed 1 and 3. 2 will be fixed when upstream (Christoph) makes a new release.
 
 http://theory.physics.helsinki.fi/~jzlehtol/rpms/votca-csg.spec
 http://theory.physics.helsinki.fi/~jzlehtol/rpms/votca-csg-1.0.1-2.fc14.src.rpm

Perfect. The packages is now APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 661154] Review Request: votca-csg - VOTCA coarse graining engine

2010-12-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=661154

Jussi Lehtola jussi.leht...@iki.fi changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #11 from Jussi Lehtola jussi.leht...@iki.fi 2010-12-14 11:42:09 
EST ---
Thanks a lot for the review!

New Package SCM Request
===
Package Name: votca-csg
Short Description: VOTCA coarse-graining engine
Owners: jussilehtola
Branches: F-13 F-14
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 661154] Review Request: votca-csg - VOTCA coarse graining engine

2010-12-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=661154

--- Comment #12 from Jason Tibbitts ti...@math.uh.edu 2010-12-14 11:50:55 EST 
---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 661154] Review Request: votca-csg - VOTCA coarse graining engine

2010-12-08 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=661154

--- Comment #2 from Christoph Junghans jungh...@votca.org 2010-12-08 08:06:03 
EST ---
Notes from my side:
- coarse-graining is spelled correctly.
- we have man pages in the next release.
- there is doxygen documentation through 'make html'

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 661154] Review Request: votca-csg - VOTCA coarse graining engine

2010-12-08 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=661154

--- Comment #3 from Jussi Lehtola jussi.leht...@iki.fi 2010-12-08 08:23:06 
EST ---
(In reply to comment #2)
 Notes from my side:
 - coarse-graining is spelled correctly.

Spellings are made coherent in the next revision.

 - there is doxygen documentation through 'make html'

Doesn't seem so:

Making html in doc
make[2]: Entering directory `/builddir/build/BUILD/votca-csg-1.0.1/share/doc'
make[2]: Leaving directory `/builddir/build/BUILD/votca-csg-1.0.1/share/doc'
make[2]: *** No rule to make target `Doxyfile', needed by `html'.  Stop.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 661154] Review Request: votca-csg - VOTCA coarse graining engine

2010-12-08 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=661154

--- Comment #4 from Christoph Junghans jungh...@votca.org 2010-12-08 08:30:29 
EST ---
(In reply to comment #3)
  - there is doxygen documentation through 'make html'
 Doesn't seem so:
 Making html in doc
 make[2]: Entering directory `/builddir/build/BUILD/votca-csg-1.0.1/share/doc'
 make[2]: Leaving directory `/builddir/build/BUILD/votca-csg-1.0.1/share/doc'
 make[2]: *** No rule to make target `Doxyfile', needed by `html'.  Stop.
Ah, I see. The Doxygen file is missing in the dist tarball, I fixed it for the
next release.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 661154] Review Request: votca-csg - VOTCA coarse graining engine

2010-12-08 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=661154

Jussi Lehtola jussi.leht...@iki.fi changed:

   What|Removed |Added

 Depends on||661143
  Alias||votca-csg

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 661154] Review Request: votca-csg - VOTCA coarse graining engine

2010-12-07 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=661154

Jussi Lehtola jussi.leht...@iki.fi changed:

   What|Removed |Added

 CC||jungh...@votca.org

--- Comment #1 from Jussi Lehtola jussi.leht...@iki.fi 2010-12-07 17:22:29 
EST ---
*** Bug 659972 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review