[Bug 662301] Review Request: plotdrop - A minimal GNOME front-end to Gnuplot
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=662301 --- Comment #18 from Fedora Update System upda...@fedoraproject.org 2011-02-15 16:25:35 EST --- plotdrop-0.5.3-5.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 662301] Review Request: plotdrop - A minimal GNOME front-end to Gnuplot
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=662301 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||plotdrop-0.5.3-5.fc14 Resolution||ERRATA Last Closed||2011-02-15 16:25:40 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 662301] Review Request: plotdrop - A minimal GNOME front-end to Gnuplot
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=662301 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #17 from Fedora Update System upda...@fedoraproject.org 2011-02-06 15:20:55 EST --- plotdrop-0.5.3-5.fc14 has been pushed to the Fedora 14 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update plotdrop'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/plotdrop-0.5.3-5.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 662301] Review Request: plotdrop - A minimal GNOME front-end to Gnuplot
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=662301 --- Comment #16 from Fedora Update System upda...@fedoraproject.org 2011-02-05 14:29:17 EST --- plotdrop-0.5.3-5.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/plotdrop-0.5.3-5.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 662301] Review Request: plotdrop - A minimal GNOME front-end to Gnuplot
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=662301 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 662301] Review Request: plotdrop - A minimal GNOME front-end to Gnuplot
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=662301 Arun SAG saga...@gmail.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #14 from Arun SAG saga...@gmail.com 2011-01-31 07:45:06 EST --- New Package CVS Request === Package Name: plotdrop Short Description: A minimal GNOME front-end to Gnuplot Owners: sagarun Branches: F-14 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 662301] Review Request: plotdrop - A minimal GNOME front-end to Gnuplot
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=662301 --- Comment #15 from Jason Tibbitts ti...@math.uh.edu 2011-01-31 11:45:42 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 662301] Review Request: plotdrop - A minimal GNOME front-end to Gnuplot
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=662301
Mohamed El Morabity pikachu.2...@gmail.com changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #13 from Mohamed El Morabity pikachu.2...@gmail.com 2011-01-31
02:58:05 EST ---
I think it's OK now. Here is the review.
MUST: rpmlint must be run on every package.
-OK, no significant warnings
MUST: The package must be named according to the Package Naming Guidelines.
-OK
MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
-OK
MUST: The package must meet the Packaging Guidelines.
-OK
MUST: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines.
-OK
MUST: The License field in the package spec file must match the actual license.
-OK, all files under GPLv2 license
MUST: If (and only if) the source package includes the text of the license(s)
in
its own file, then that file, containing the text of the license(s) for
the package must be included in %doc.
-OK
MUST: The spec file must be written in American English.
-OK
MUST: The spec file for the package MUST be legible.
-OK
MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL.
-OK, md5sum = 8eaf3a8385832b15bb54dd6f435a3df6
MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture.
-OK
MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch.
-N/A
MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional.
-OK
MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
-N/A
MUST: Every binary RPM package (or subpackage) which stores shared library
files
(not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun.
-N/A
MUST: Packages must NOT bundle copies of system libraries.
-OK
MUST: If the package is designed to be relocatable, the packager must state
this
fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
-N/A
MUST: A package must own all directories that it creates. If it does not create
a directory that it uses, then it should require a package which does
create that directory.
OK
MUST: A Fedora package must not list a file more than once in the spec file's
%files listings.
-OK
MUST: Permissions on files must be set properly. Executables should be set with
executable permissions, for example. Every %files section must include a
%defattr(...) line.
-OK
MUST: Each package must consistently use macros.
-OK
MUST: The package must contain code, or permissable content.
-OK
MUST: Large documentation files must go in a -doc subpackage.
-N/A
MUST: If a package includes something as %doc, it must not affect the runtime
of
the application. To summarize: If it is in %doc, the program must run
properly if it is not present.
-OK
MUST: Header files must be in a -devel package.
-N/A
MUST: Static libraries must be in a -static package.
-N/A
MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1),
then library files that end in .so (without suffix) must go in a -devel
package.
-N/A
MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency: Requires: %{name} =
%{version}-%{release}.
-N/A
MUST: Packages must NOT contain any .la libtool archives, these must be removed
in the spec if they are built.
-N/A
MUST: Packages containing GUI applications must include a %{name}.desktop file,
and that file must be properly installed with desktop-file-install in the
%install section.
-OK
MUST: Packages must not own files or directories already owned by other
packages.
-OK
MUST: All filenames in rpm packages must be valid UTF-8.
-OK
This package is APPROVED!
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
[Bug 662301] Review Request: plotdrop - A minimal GNOME front-end to Gnuplot
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=662301 --- Comment #11 from Mohamed El Morabity pikachu.2...@gmail.com 2011-01-26 01:50:32 EST --- Ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 662301] Review Request: plotdrop - A minimal GNOME front-end to Gnuplot
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=662301 --- Comment #12 from Arun SAG saga...@gmail.com 2011-01-26 02:17:56 EST --- SPEC : http://sagarun.fedorapeople.org/SPECS/plotdrop.spec SRPM : http://sagarun.fedorapeople.org/SRPMS/plotdrop-0.5.3-5.fc14.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 662301] Review Request: plotdrop - A minimal GNOME front-end to Gnuplot
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=662301
--- Comment #9 from Arun SAG saga...@gmail.com 2011-01-09 04:19:57 EST ---
(In reply to comment #8)
(In reply to comment #7)
PREFIX cannot be replaced with %{_prefix} since Makefile uses PREFIX.
What Terje says here is that you should use PREFIX=%{_prefix} instead
of PREFIX=/usr .
oh ok. I totally missed the point. Updated my spec.
SPEC : http://sagarun.fedorapeople.org/SPECS/plotdrop.spec
SRPM : http://sagarun.fedorapeople.org/SRPMS/plotdrop-0.5.3-4.fc14.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 662301] Review Request: plotdrop - A minimal GNOME front-end to Gnuplot
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=662301 --- Comment #10 from Mohamed El Morabity pikachu.2...@gmail.com 2011-01-09 07:48:55 EST --- Your package looks very good at this point. Anyway, isn't it obvious for a gnuplot GUI to require gnuplot? Please add gnuplot as Requires. Once this done, I will certainly approve your package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 662301] Review Request: plotdrop - A minimal GNOME front-end to Gnuplot
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=662301
--- Comment #8 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2011-01-09
02:18:46 EST ---
(In reply to comment #7)
PREFIX cannot be replaced with %{_prefix} since Makefile uses PREFIX.
What Terje says here is that you should use PREFIX=%{_prefix} instead
of PREFIX=/usr .
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 662301] Review Request: plotdrop - A minimal GNOME front-end to Gnuplot
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=662301 --- Comment #6 from Mohamed El Morabity pikachu.2...@gmail.com 2011-01-05 18:56:34 EST --- Ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 662301] Review Request: plotdrop - A minimal GNOME front-end to Gnuplot
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=662301
Terje Røsten terje...@phys.ntnu.no changed:
What|Removed |Added
CC||terje...@phys.ntnu.no
--- Comment #4 from Terje Røsten terje...@phys.ntnu.no 2010-12-14 02:51:46
EST ---
Minor issue: use the %{_prefix} macro as PREFIX argument.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 662301] Review Request: plotdrop - A minimal GNOME front-end to Gnuplot
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=662301 --- Comment #3 from Arun SAG saga...@gmail.com 2010-12-12 11:55:31 EST --- I agree with your point regarding CFLAGS. But, PREFIX is not useless when building plotdrop. CFLAGS uses DATADIR , DATADIR uses PREFIX. If you do not use PREFIX /usr/local/share will be come as your data directory. SPEC URL:http://sagarun.fedorapeople.org/SPECS/plotdrop.spec SRPM URL: http://sagarun.fedorapeople.org/SRPMS/plotdrop-0.5.3-2.fc13.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 662301] Review Request: plotdrop - A minimal GNOME front-end to Gnuplot
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=662301
--- Comment #2 from Mohamed El Morabity pikachu.2...@gmail.com 2010-12-12
09:46:19 EST ---
It seems the Fedora standard flags are not used at all to compile plotdrop. To
fix it, add this in %prep:
sed -i s/CFLAGS = /CFLAGS += / Makefile
And in %build :
export CFLAGS=$RPM_OPT_FLAGS
make %{?_smp_mflags}
(setting PREFIX is useless when building plotdrop).
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 662301] Review Request: plotdrop - A minimal GNOME front-end to Gnuplot
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=662301 Mohamed El Morabity pikachu.2...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||pikachu.2...@gmail.com AssignedTo|nob...@fedoraproject.org|pikachu.2...@gmail.com Flag||fedora-review? --- Comment #1 from Mohamed El Morabity pikachu.2...@gmail.com 2010-12-11 06:23:58 EST --- i will review it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
