[Bug 665168] Review Request: nautilus-sendto-trac - Nautilus context menu for sending files to Trac
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=665168 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||nautilus-sendto-trac-0.3.1- ||2.fc14 Resolution||ERRATA Last Closed||2011-02-09 15:19:32 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 665168] Review Request: nautilus-sendto-trac - Nautilus context menu for sending files to Trac
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=665168 --- Comment #13 from Fedora Update System upda...@fedoraproject.org 2011-02-09 15:19:27 EST --- nautilus-sendto-trac-0.3.1-2.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 665168] Review Request: nautilus-sendto-trac - Nautilus context menu for sending files to Trac
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=665168 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #12 from Fedora Update System upda...@fedoraproject.org 2011-02-01 15:54:43 EST --- nautilus-sendto-trac-0.3.1-2.fc14 has been pushed to the Fedora 14 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update nautilus-sendto-trac'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/nautilus-sendto-trac-0.3.1-2.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 665168] Review Request: nautilus-sendto-trac - Nautilus context menu for sending files to Trac
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=665168 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 665168] Review Request: nautilus-sendto-trac - Nautilus context menu for sending files to Trac
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=665168 --- Comment #11 from Fedora Update System upda...@fedoraproject.org 2011-01-31 13:30:55 EST --- nautilus-sendto-trac-0.3.1-2.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/nautilus-sendto-trac-0.3.1-2.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 665168] Review Request: nautilus-sendto-trac - Nautilus context menu for sending files to Trac
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=665168 --- Comment #10 from Dennis Gilmore den...@ausil.us 2011-01-30 19:05:45 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 665168] Review Request: nautilus-sendto-trac - Nautilus context menu for sending files to Trac
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=665168 --- Comment #9 from Mat Booth fed...@matbooth.co.uk 2011-01-29 17:27:24 EST --- Thanks, Fabian. New Package SCM Request === Package Name: nautilus-sendto-trac Short Description: Nautilus context menu for sending files to Trac Owners: mbooth Branches: F14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 665168] Review Request: nautilus-sendto-trac - Nautilus context menu for sending files to Trac
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=665168 Mat Booth fed...@matbooth.co.uk changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 665168] Review Request: nautilus-sendto-trac - Nautilus context menu for sending files to Trac
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=665168 Fabian Affolter fab...@bernewireless.net changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #8 from Fabian Affolter fab...@bernewireless.net 2011-01-28 13:14:48 EST --- [x] Package successfully compiles and builds into binary RPMs on at least one supported architecture Tested F-14: https://koji.fedoraproject.org/koji/taskinfo?taskID=2748094 Tested F-15: https://koji.fedoraproject.org/koji/taskinfo?taskID=2748103 [x] Timestamps preserved with cp and install [x] Package functions as described I see no further blocker, package APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 665168] Review Request: nautilus-sendto-trac - Nautilus context menu for sending files to Trac
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=665168 --- Comment #7 from Mat Booth fed...@matbooth.co.uk 2011-01-19 13:51:10 EST --- Spec URL: http://mbooth.fedorapeople.org/reviews/nautilus-sendto-trac.spec SRPM URL: http://mbooth.fedorapeople.org/reviews/nautilus-sendto-trac-0.3.1-2.fc14.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 665168] Review Request: nautilus-sendto-trac - Nautilus context menu for sending files to Trac
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=665168 --- Comment #6 from Fabian Affolter fab...@bernewireless.net 2011-01-17 11:27:51 EST --- (In reply to comment #3) (In reply to comment #2) [!] Timestamps preserved with cp and install Thanks for taking the time to review this package, but could you explain that a little more? I don't use either of those commands in the SPEC file... It's about the installation: 'make install DESTDIR=$RPM_BUILD_ROOT INSTALL=install -p' instead of 'make install DESTDIR=$RPM_BUILD_ROOT' Actually I'm not sure if it's needed because there is not much in this package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 665168] Review Request: nautilus-sendto-trac - Nautilus context menu for sending files to Trac
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=665168 Fabian Affolter fab...@bernewireless.net changed: What|Removed |Added CC||fab...@bernewireless.net --- Comment #1 from Fabian Affolter fab...@bernewireless.net 2011-01-11 14:54:58 EST --- This package fails to build. http://koji.fedoraproject.org/koji/taskinfo?taskID=2715761 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 665168] Review Request: nautilus-sendto-trac - Nautilus context menu for sending files to Trac
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=665168
Fabian Affolter fab...@bernewireless.net changed:
What|Removed |Added
Status|NEW |ASSIGNED
AssignedTo|nob...@fedoraproject.org|fab...@bernewireless.net
Flag||fedora-review?
--- Comment #2 from Fabian Affolter fab...@bernewireless.net 2011-01-11
15:05:48 EST ---
Package Review
==
Package:
Key:
- = N/A
x = Check
! = Problem
? = Not evaluated
=== REQUIRED ITEMS ===
[x] Package is named according to the Package Naming Guidelines
[x] Spec file name must match the base package %{name}, in the format
%{name}.spec
[x] Package meets the Packaging Guidelines
[!] Package successfully compiles and builds into binary RPMs on at least one
supported architecture
Tested: http://koji.fedoraproject.org/koji/taskinfo?taskID=2715761
[x] Rpmlint output:
Source RPM:
[...@laptop023 SRPMS]$ rpmlint nautilus-sendto-trac-0.3-1.fc14.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
Binary RPM(s):
[...@laptop023 x86_64]$ rpmlint nautilus-sendto*
2 packages and 0 specfiles checked; 0 errors, 0 warnings.
[x] Package is not relocatable
[-] Buildroot is correct (if it's still used)
master : %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
spec file:
[x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
[x] License field in the package spec file matches the actual license
License type: GPLv2+
[x] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc
[x] Spec file is legible and written in American English
[x] Sources used to build the package matches the upstream source, as provided
in the spec URL
Upstream source: 9ff3f6c57e7bce802e71e9f2a4146094
nautilus-sendto-trac-0.3.tar.gz
Build source:9ff3f6c57e7bce802e71e9f2a4146094
nautilus-sendto-trac-0.3.tar.gz
[x] Package is not known to require ExcludeArch
[-] Architecture independent packages have: BuildArch: noarch
[x] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[-] The spec file handles locales properly. %find_lang used for locales
[x] %{optflags} or RPM_OPT_FLAGS are honoured
[-] ldconfig called in %post and %postun if required
[-] %install starts with rm -rf %{buildroot} or $RPM_BUILD_ROOT (if it's still
used)
[-] Package must own all directories that it creates
[x] Package requires other packages for directories it uses
[x] Package does not own files or directories owned by other packages
[x] Package does not contain duplicates in %files
[x] Permissions on files are set properly. %defattr(-,root,root,-) is in every
%files section
[x] Package uses nothing in %doc for runtime
[-] Package has a %clean section, which contains rm -rf %{buildroot} or
$RPM_BUILD_ROOT (if it's still used)
[-] Included tests passed successfully
[x] Package consistently uses macros
[x] Package contains code, or permissable content
[x] Included filenames are in UTF-8
[-] Large documentation files are in a -doc subpackage, if required
[-] Header files (.h) in -devel subpackage, if present
[-] Fully versioned dependency in subpackage, if present
[-] Static libraries (.a) in -static subpackage, if present
[-] Package requires pkgconfig, if .pc files are present
[-] Development .so files in -devel subpackage, if present
[x] Package does not contain any libtool archives (.la)
[x] -debuginfo subpackage is present and looks complete
[x] No pre-built binaries (.a, .so*, executable)
[-] Package contains a properly installed .desktop file if it is a GUI
application
[-] Follows desktop entry spec
[-] Valid .desktop Name
[-] Valid .desktop GenericName
[-] Valid .desktop Categories
[-] Valid .desktop StartupNotify
[-] .desktop file installed with desktop-file-install in %install
=== SUGGESTED ITEMS ===
[!] Timestamps preserved with cp and install
[x] Uses parallel make (%{?_smp_mflags})
[x] Latest version is packaged
[-] Package does not include license text files separate from upstream
[-] Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available
[?] Package functions as described
[-] Scriptlets must be sane, if used
[-] The placement of pkgconfig(.pc) files is correct
[-] File based requires are sane
[x] Changelog in allowed format
- The package builds on F14 -
[Bug 665168] Review Request: nautilus-sendto-trac - Nautilus context menu for sending files to Trac
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=665168 --- Comment #3 from Mat Booth fed...@matbooth.co.uk 2011-01-11 16:50:47 EST --- (In reply to comment #2) [!] Timestamps preserved with cp and install Thanks for taking the time to review this package, but could you explain that a little more? I don't use either of those commands in the SPEC file... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 665168] Review Request: nautilus-sendto-trac - Nautilus context menu for sending files to Trac
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=665168 --- Comment #4 from Mat Booth fed...@matbooth.co.uk 2011-01-11 18:10:11 EST --- Regarding the build failures, it would seem that the reason it fails in rawhide is because nautilus-sendto is built against gtk3 (it is built against gtk2 in F14) and there has been an API change between gtk2 and gtk3 that affects this package. I am the upstream developer, so I will try to fix it so that the same version of nautilus-sendto-trac builds under both environments. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 665168] Review Request: nautilus-sendto-trac - Nautilus context menu for sending files to Trac
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=665168 --- Comment #5 from Mat Booth fed...@matbooth.co.uk 2011-01-11 20:14:07 EST --- Spec URL: http://mbooth.fedorapeople.org/reviews/nautilus-sendto-trac.spec SRPM URL: http://mbooth.fedorapeople.org/reviews/nautilus-sendto-trac-0.3.1-1.fc14.src.rpm Build issues should be fixed now. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
