[Bug 665733] Review Request: Coin3 - High-level 3D visualization library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=665733

Susi Lehtola  changed:

   What|Removed |Added

 Blocks|505154 (FE-SCITECH) |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=505154
[Bug 505154] Tracker: Review Requests for Science and Technology related
packages
-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 665733] Review Request: Coin3 - High-level 3D visualization library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=665733

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

   Fixed In Version|Coin3-3.1.3-7.fc22  |Coin3-3.1.3-7.fc20



--- Comment #44 from Fedora Update System upda...@fedoraproject.org ---
Coin3-3.1.3-7.fc20 has been pushed to the Fedora 20 stable repository.  If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 665733] Review Request: Coin3 - High-level 3D visualization library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=665733

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

   Fixed In Version|Coin3-3.1.3-7.fc21  |Coin3-3.1.3-7.fc22



--- Comment #43 from Fedora Update System upda...@fedoraproject.org ---
Coin3-3.1.3-7.fc22 has been pushed to the Fedora 22 stable repository.  If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 665733] Review Request: Coin3 - High-level 3D visualization library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=665733

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||Coin3-3.1.3-7.fc21
 Resolution|--- |ERRATA
Last Closed||2015-03-04 05:24:19



--- Comment #42 from Fedora Update System upda...@fedoraproject.org ---
Coin3-3.1.3-7.fc21 has been pushed to the Fedora 21 stable repository.  If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 665733] Review Request: Coin3 - High-level 3D visualization library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=665733

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #38 from Fedora Update System upda...@fedoraproject.org ---
Coin3-3.1.3-6.fc20 has been pushed to the Fedora 20 testing repository.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 665733] Review Request: Coin3 - High-level 3D visualization library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=665733



--- Comment #40 from Fedora Update System upda...@fedoraproject.org ---
Coin3-3.1.3-7.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/Coin3-3.1.3-7.fc21

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 665733] Review Request: Coin3 - High-level 3D visualization library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=665733



--- Comment #39 from Fedora Update System upda...@fedoraproject.org ---
Coin3-3.1.3-7.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/Coin3-3.1.3-7.fc20

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 665733] Review Request: Coin3 - High-level 3D visualization library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=665733



--- Comment #41 from Fedora Update System upda...@fedoraproject.org ---
Coin3-3.1.3-7.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/Coin3-3.1.3-7.fc22

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 665733] Review Request: Coin3 - High-level 3D visualization library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=665733

Jon Ciesla limburg...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 665733] Review Request: Coin3 - High-level 3D visualization library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=665733



--- Comment #36 from Fedora Update System upda...@fedoraproject.org ---
Coin3-3.1.3-6.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/Coin3-3.1.3-6.fc20

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 665733] Review Request: Coin3 - High-level 3D visualization library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=665733



--- Comment #37 from Fedora Update System upda...@fedoraproject.org ---
Coin3-3.1.3-6.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/Coin3-3.1.3-6.fc21

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 665733] Review Request: Coin3 - High-level 3D visualization library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=665733

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 665733] Review Request: Coin3 - High-level 3D visualization library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=665733

Richard Shaw hobbes1...@gmail.com changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|hobbes1...@gmail.com



--- Comment #31 from Richard Shaw hobbes1...@gmail.com ---
(In reply to Ralf Corsepius from comment #30)
 (In reply to Richard Shaw from comment #28)
  2. Fedora 20 is the oldest supported release so the conditional really isn't
  needed, but if you're supporting older Fedora installations locally then
  let's keep it.
 The freetype2 f20 conditional _is_ required to be able to support fc20:
 ...
 %if 0%{?fedora}  20
 # Incompatibility:  
 # Fedora  20 has /usr/include/freetype2/
 # Fedora = 20 has /usr/include/freetype2/freetype
 sed -i -e 's,freetype/,freetype2/,' src/glue/freetype.{h,cpp}
 %endif
 ...
 The package does not build on fc20 without it, because the freetype header
 location has changed in Fedora.

Whoops, I read that as = for some reason. 


 Anyway, with current boost, removing the bundled boost headers doesn't seem
 to cause any immediate malfunction or break down.

Ok sounds good, so if upstream does start using boost more extensively we stay
out of trouble as far as bundling goes we just have to make sure a future boost
update doesn't break things.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 665733] Review Request: Coin3 - High-level 3D visualization library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=665733



--- Comment #32 from Ralf Corsepius rc040...@freenet.de ---
I wasn't able to build earlier today, seemingly because mirrormanager once more
wasn't able to sync the Fedora 22 and rawhide repos (yum in mock was sending me
around the globe without being able to find a functional mirror).
Meanwhile, at least some mirrors seem to have synced.

New, updated version (*-6):
Spec URL: http://corsepiu.fedorapeople.org/packages/Coin3.spec
SRPM URL: http://corsepiu.fedorapeople.org/packages/Coin3-3.1.3-6.fc23.src.rpm

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 665733] Review Request: Coin3 - High-level 3D visualization library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=665733



--- Comment #30 from Ralf Corsepius rc040...@freenet.de ---
(In reply to Richard Shaw from comment #28)
 Ok, first a couple of non-blockers from a spec review:
 
 1. Group tags have not been required for some time.
I prefer keeping Group tags.

 2. Fedora 20 is the oldest supported release so the conditional really isn't
 needed, but if you're supporting older Fedora installations locally then
 let's keep it.
The freetype2 f20 conditional _is_ required to be able to support fc20:
...
%if 0%{?fedora}  20
# Incompatibility:  
# Fedora  20 has /usr/include/freetype2/
# Fedora = 20 has /usr/include/freetype2/freetype
sed -i -e 's,freetype/,freetype2/,' src/glue/freetype.{h,cpp}
%endif
...
The package does not build on fc20 without it, because the freetype header
location has changed in Fedora.

 One blocker from a spec review:
 
 Recently the use of the %license macro for marking what part of the
 documentation is the license became part of the packaging guidelines.
Well, I repeatedly pronounced my opinion on this topic in hopefully
non-misunderstandable ways, so I am not going to repeat them here, again.

 Detailed review:
 
 There are some mixed licenses found by licensecheck but most of them don't
 look like they make it into the library or binaries so can be ignored.
Like many other packages, Coin uses the GPLv2 as an umbrella-license. The
package as a whole currently is GPLv2'ed, even though it contains files under
other licenses.

 One I'm unsure of is the bundled boost headers. The readme in the include
 directory indicated they're used for the testsuite and don't make it into
 the binaries but mentions they could at a future date, however, grepping
 through the sources I'm not so sure that hasn't already happened:
Coin3 uses some boost-templates (headers) internally, but the installed headers
don't carry any deps on the boost-headers nor do the coin libraries carry and
reference to the boost-runtime libs.

 Alternatively it looks like all of the include uses system include
 formatting instead of pointing specifically to the bundled ones so I wonder
 if we could add a BuildRequires for boost and rm -rf the bundled headers?
Well, it's a double-edged sword, with pros and cons, each. Buying-in upstream
boost bug-fixes, vs. upstream boost introducing incompatibilities and breaking
the package.

Anyway, with current boost, removing the bundled boost headers doesn't seem to
cause any immediate malfunction or break down.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 665733] Review Request: Coin3 - High-level 3D visualization library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=665733

Richard Shaw hobbes1...@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
  Flags||fedora-review+



--- Comment #33 from Richard Shaw hobbes1...@gmail.com ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
 supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
 are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
 in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.

= SHOULD items =

Generic:
[x]: If the source package does not include license text(s) as a separate file
 from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[x]: Scriptlets must be sane, if used.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[?]: Package should compile and build into binary rpms on all supported
 architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
 

[Bug 665733] Review Request: Coin3 - High-level 3D visualization library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=665733

Ralf Corsepius rc040...@freenet.de changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #34 from Ralf Corsepius rc040...@freenet.de ---
Thank you very much for the review, Richard! 

... 4+ years after initial submission ... 

New Package SCM Request
===
Package Name: Coin3
Short Description: High-level 3D visualization librar
Upstream URL: https://bitbucket.org/Coin3D/coin/wiki/Home
Owners: corsepiu
Branches: f22 f21 f20
InitialCC:

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 665733] Review Request: Coin3 - High-level 3D visualization library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=665733



--- Comment #35 from Ralf Corsepius rc040...@freenet.de ---
Arg, cut'n'pasto ...

New Package SCM Request
===
Package Name: Coin3
Short Description: High-level 3D visualization library
Upstream URL: https://bitbucket.org/Coin3D/coin/wiki/Home
Owners: corsepiu
Branches: f22 f21 f20
InitialCC:

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 665733] Review Request: Coin3 - High-level 3D visualization library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=665733



--- Comment #28 from Richard Shaw hobbes1...@gmail.com ---
Ok, first a couple of non-blockers from a spec review:

1. Group tags have not been required for some time.
2. Fedora 20 is the oldest supported release so the conditional really isn't
needed, but if you're supporting older Fedora installations locally then let's
keep it.

One blocker from a spec review:

Recently the use of the %license macro for marking what part of the
documentation is the license became part of the packaging guidelines.

Detailed review:

There are some mixed licenses found by licensecheck but most of them don't look
like they make it into the library or binaries so can be ignored.

One I'm unsure of is the bundled boost headers. The readme in the include
directory indicated they're used for the testsuite and don't make it into the
binaries but mentions they could at a future date, however, grepping through
the sources I'm not so sure that hasn't already happened:

$ grep -r boost . | grep include
./engines/SoHeightMapToNormalMap.cpp:#include boost/scoped_array.hpp
./profiler/SoProfilingReportGenerator.cpp:#include boost/scoped_array.hpp
./profiler/SoScrollingGraphKit.cpp:#include boost/scoped_ptr.hpp
./profiler/SoScrollingGraphKit.cpp:#include boost/scoped_array.hpp
./profiler/SoScrollingGraphKit.cpp:#include boost/intrusive_ptr.hpp
./profiler/SoProfilerVisualizeKit.cpp:#include boost/scoped_ptr.hpp
./profiler/SoProfilerTopKit.cpp:#include boost/intrusive_ptr.hpp
./profiler/SoNodeVisualize.cpp:#include boost/scoped_ptr.hpp
./scxml/SoScXMLStateMachine.cpp:#include boost/scoped_ptr.hpp
./scxml/SoScXMLStateMachine.cpp:#include boost/intrusive_ptr.hpp
./scxml/ScXMLStateMachine.cpp:#include boost/scoped_ptr.hpp
./scxml/ScXMLState.cpp:#include boost/scoped_ptr.hpp
./scxml/ScXMLHistory.cpp:#include boost/scoped_ptr.hpp
./scxml/ScXMLInitial.cpp:#include boost/scoped_ptr.hpp
./coindefs.h:#include boost/detail/workaround.hpp /* For BOOST_WORKAROUND */
./glue/dl.cpp:  Boost. The boost headers can be found under \c include/ in the
Coin
./actions/SoGLRenderAction.cpp:#include boost/scoped_ptr.hpp
./actions/SoGLRenderAction.cpp:#include boost/scoped_array.hpp
./xml/document.cpp:#include boost/scoped_array.hpp
./xml/document.cpp:#include boost/scoped_array.hpp
./nodes/SoVertexAttribute.cpp:#include boost/scoped_ptr.hpp
./navigation/SoScXMLRotateUtils.cpp:#include boost/scoped_ptr.hpp
./navigation/SoScXMLRotateUtils.cpp:#include boost/intrusive_ptr.hpp
./navigation/SoScXMLPanUtils.cpp://#include boost/intrusive_ptr.hpp
./navigation/SoScXMLSpinUtils.h:#include boost/intrusive_ptr.hpp

Not all of those look like they're related to the testsuite but you're far more
familiar with the package.

Alternatively it looks like all of the include uses system include formatting
instead of pointing specifically to the bundled ones so I wonder if we could
add a BuildRequires for boost and rm -rf the bundled headers?

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 665733] Review Request: Coin3 - High-level 3D visualization library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=665733



--- Comment #29 from Richard Shaw hobbes1...@gmail.com ---
FWIW, I was taking a break from something else I was working on and decided to
try adding boost-devel and rm -rf include/boost and was able to build packages
for rawhide. 

I also watched the build since rawhide is using gcc 5.0.0 now and I didn't see
a bunch of warnings so that's good.

The only other thing fedora-review complained about directly was the size of
the documentation in the -devel package. It should (but is not required to) be
moved to a -doc noarch package.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 665733] Review Request: Coin3 - High-level 3D visualization library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=665733



--- Comment #26 from Ralf Corsepius rc040...@freenet.de ---
(In reply to Ralf Corsepius from comment #25)
 Likely I'll revisit my packaging and publish updated versions later this
 week.
Sorry, took a little longer than a week to get back to it:

New versions:
Spec URL: http://corsepiu.fedorapeople.org/packages/Coin3.spec
SRPM URL: http://corsepiu.fedorapeople.org/packages/Coin3-3.1.5-1.fc23.src.rpm

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 665733] Review Request: Coin3 - High-level 3D visualization library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=665733



--- Comment #27 from Ralf Corsepius rc040...@freenet.de ---
(In reply to Ralf Corsepius from comment #26)
 (In reply to Ralf Corsepius from comment #25)
  Likely I'll revisit my packaging and publish updated versions later this
  week.
 Sorry, took a little longer than a week to get back to it:
 
 New versions:
 Spec URL: http://corsepiu.fedorapeople.org/packages/Coin3.spec
 SRPM URL:
 http://corsepiu.fedorapeople.org/packages/Coin3-3.1.5-1.fc23.src.rpm
Oops, typo:

Spec URL: http://corsepiu.fedorapeople.org/packages/Coin3.spec
SRPM URL: http://corsepiu.fedorapeople.org/packages/Coin3-3.1.3-5.fc23.src.rpm

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 665733] Review Request: Coin3 - High-level 3D visualization library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=665733



--- Comment #25 from Ralf Corsepius rc040...@freenet.de ---
(In reply to Richard Shaw from comment #24)
 Ralf, do you still want to pursue this review?
Thanks for your interest - Yes, I am. I am still using Coin3 and would be
interested to see Coin3 in Fedora.

I am also aware, the packaging I have on fedorapeople.org has issues with newer
Fedoras, but I due to the disinterest Fedora had exposed, I haven't updated
these packages and am using local packages, instead.

Likely I'll revisit my packaging and publish updated versions later this week.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 665733] Review Request: Coin3 - High-level 3D visualization library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=665733



--- Comment #24 from Richard Shaw hobbes1...@gmail.com ---
Ralf, do you still want to pursue this review? The lack of this package in
Fedora is becoming a serious problem.

(In reply to Ralf Corsepius from comment #22)
 I had fixed this build breakdown back in Spring, but seem to have missed to
 update the package on fedorapeople.org ;)
 
 Anyway, here's a another update:
 Spec URL: http://corsepiu.fedorapeople.org/packages/Coin3.spec
 SRPM URL:
 http://corsepiu.fedorapeople.org/packages/Coin3-3.1.3-4.fc20.src.rpm
 
 Scratch-build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5835545
 
 # rpmlint results/Coin3-*x86_64*
 Coin3.x86_64: W: shared-lib-calls-exit /usr/lib64/libCoin.so.60.1.3
 exit@GLIBC_2.2.5

Should be reported upstream, but no, not a blocker.


 Coin3.x86_64: E: incorrect-fsf-address /usr/share/doc/Coin3/LICENSE.GPL

Same


 Coin3-devel.x86_64: W: read-error /usr/lib64/pkgconfig/Coin.pc [Errno 2] No
 such file or directory:
 '/tmp/rpmlint.Coin3-devel-3.1.3-4.fc20.x86_64.rpm.0V_Ey7//usr/lib64/
 pkgconfig/Coin.pc'

Weird...

If you want to move forward I suggest we do a re-review just to be safe as the
packaging guidelines have changed quite a bit.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 665733] Review Request: Coin3 - High-level 3D visualization library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=665733

Dominik 'Rathann' Mierzejewski domi...@greysector.net changed:

   What|Removed |Added

 Blocks||505154 (FE-SCITECH)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=505154
[Bug 505154] Tracker: Review Requests for Science and Technology related
packages
-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 665733] Review Request: Coin3 - High-level 3D visualization library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=665733

Bill Nottingham nott...@redhat.com changed:

   What|Removed |Added

 CC|package-review@lists.fedora |
   |project.org |
 CC|nott...@redhat.com  |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 665733] Review Request: Coin3 - High-level 3D visualization library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=665733



--- Comment #22 from Ralf Corsepius rc040...@freenet.de ---
I had fixed this build breakdown back in Spring, but seem to have missed to
update the package on fedorapeople.org ;)

Anyway, here's a another update:
Spec URL: http://corsepiu.fedorapeople.org/packages/Coin3.spec
SRPM URL: http://corsepiu.fedorapeople.org/packages/Coin3-3.1.3-4.fc20.src.rpm

Scratch-build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5835545

# rpmlint results/Coin3-*x86_64*
Coin3.x86_64: W: shared-lib-calls-exit /usr/lib64/libCoin.so.60.1.3
exit@GLIBC_2.2.5
Coin3.x86_64: E: incorrect-fsf-address /usr/share/doc/Coin3/LICENSE.GPL
Coin3-devel.x86_64: W: read-error /usr/lib64/pkgconfig/Coin.pc [Errno 2] No
such file or directory:
'/tmp/rpmlint.Coin3-devel-3.1.3-4.fc20.x86_64.rpm.0V_Ey7//usr/lib64/pkgconfig/Coin.pc'
Coin3-devel.x86_64: W: manual-page-warning
/usr/share/man/man3/SoCamera.3coin3.gz 458: warning: macro `Jitter'' not
defined
Coin3-devel.x86_64: W: dangerous-command-in-%post rm
3 packages and 0 specfiles checked; 1 errors, 4 warnings.

All these are bogus rsp. neglible.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=LuEe0nZ5Mva=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 665733] Review Request: Coin3 - High-level 3D visualization library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=665733

Christopher Meng cicku...@gmail.com changed:

   What|Removed |Added

 CC||cicku...@gmail.com



--- Comment #23 from Christopher Meng cicku...@gmail.com ---
I just want to know if I can add copyright header in the spec?

I want to add such things to all packages I submitted.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=nzuWqIdwvMa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 665733] Review Request: Coin3 - High-level 3D visualization library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=665733



--- Comment #21 from John Morris j...@zultron.com ---
Builds are choking on freetype.cpp on fc19 and fc20 (el6 and fc18 ok):

freetype.cpp:1394:1: warning: unused parameter 'vertex_data'
[-Wunused-parameter]
 flwft_combineCallback(GLdouble coords[3], GLvoid * vertex_data, GLfloat
weight[4], int **dataOut)
 ^
freetype.cpp:1394:1: warning: unused parameter 'weight' [-Wunused-parameter]
make[4]: Leaving directory `/builddir/build/BUILD/Coin-3.1.3/src/fonts'
make[4]: *** [freetype.lo] Error 1
make[3]: Leaving directory `/builddir/build/BUILD/Coin-3.1.3/src'
make[3]: *** [all-recursive] Error 1
make[2]: Leaving directory `/builddir/build/BUILD/Coin-3.1.3/src'
make[2]: *** [all] Error 2
make[1]: Leaving directory `/builddir/build/BUILD/Coin-3.1.3'
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2

http://koji.fedoraproject.org/koji/taskinfo?taskID=5782168
http://koji.fedoraproject.org/koji/taskinfo?taskID=5782181

I was unable to complete a build using 'fedora-review'.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=eJ9ewVvG12a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 665733] Review Request: Coin3 - High-level 3D visualization library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=665733



--- Comment #20 from John Morris j...@zultron.com ---
Hi Ralf, thanks, very glad!  I'll look at it this weekend.  Thanks-

John

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=q2J1y0FaVia=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 665733] Review Request: Coin3 - High-level 3D visualization library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=665733

--- Comment #19 from Ralf Corsepius rc040...@freenet.de ---
(In reply to John Morris from comment #18)
 Hi Ralf, if you're not interested in having this package reviewed,
I am interested in having this package reviewed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=Xq9CNA17QLa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 665733] Review Request: Coin3 - High-level 3D visualization library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=665733

Ralf Corsepius rc040...@freenet.de changed:

   What|Removed |Added

 Whiteboard|StalledSubmitter|

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=PETI0tScqYa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 665733] Review Request: Coin3 - High-level 3D visualization library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=665733

--- Comment #18 from John Morris j...@zultron.com ---
Hi Ralf, if you're not interested in having this package reviewed, I'd like to
walk the package through review myself and become the maintainer.  Any
objections?  Thanks-

John

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=lKNSY2MWQBa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 665733] Review Request: Coin3 - High-level 3D visualization library

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=665733

--- Comment #17 from Ralf Corsepius rc040...@freenet.de 2012-04-30 06:38:39 
EDT ---
(In reply to comment #16)
 I just don't see how ignoring me benefited either one of us or the review and
 only caused unnecessary frustration and delay.
Sure, but there are situations, when people turn away and leave others alone.
In this case because I had wanted to avoid silly and non-helpfule disputes.

Now, this review request was closed, with me noticing too late, because I was
busy with other subjects and had not looked into the mails related to this
review.

This certainly is an incident, which improves my moot towards Fedora in general
;)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 665733] Review Request: Coin3 - High-level 3D visualization library

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=665733

--- Comment #15 from Ralf Corsepius rc040...@freenet.de 2012-04-29 13:09:15 
EDT ---
(In reply to comment #13) 
 Can I assume that you're ignoring me since you're obviously active on the
 mailing list but have not responded on this review request in over 4 months?

No, I initially did not respond, because I do not agree with our review and
your proposal.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 665733] Review Request: Coin3 - High-level 3D visualization library

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=665733

--- Comment #16 from Richard Shaw hobbes1...@gmail.com 2012-04-29 13:18:22 
EDT ---
Well it's supposed to be a back and forth discussion. I haven't made any
demands. I simply made arguments for certain things and was expecting you to do
the same, otherwise what's the point of peer review? 

I just don't see how ignoring me benefited either one of us or the review and
only caused unnecessary frustration and delay.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 665733] Review Request: Coin3 - High-level 3D visualization library

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=665733

Jason Tibbitts ti...@math.uh.edu changed:

   What|Removed |Added

 CC||package-review@lists.fedora
   ||project.org
  Status Whiteboard||StalledSubmitter

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 665733] Review Request: Coin3 - High-level 3D visualization library

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=665733

Richard Shaw hobbes1...@gmail.com changed:

   What|Removed |Added

 Status|ASSIGNED|NEW

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 665733] Review Request: Coin3 - High-level 3D visualization library

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=665733

Richard Shaw hobbes1...@gmail.com changed:

   What|Removed |Added

 Blocks|458975(Pivy)|

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 665733] Review Request: Coin3 - High-level 3D visualization library

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=665733

--- Comment #13 from Richard Shaw hobbes1...@gmail.com 2012-04-06 17:20:11 
EDT ---
Ralf,

Can I assume that you're ignoring me since you're obviously active on the
mailing list but have not responded on this review request in over 4 months?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 665733] Review Request: Coin3 - High-level 3D visualization library

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=665733

--- Comment #12 from Richard Shaw hobbes1...@gmail.com 2012-02-27 16:16:32 
EST ---
Created attachment 566143
  -- https://bugzilla.redhat.com/attachment.cgi?id=566143
Updated Coin3 spec file

Ralf,

I've fixed the 3 concerns I had and I'm attaching the new spec file for your
review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 665733] Review Request: Coin3 - High-level 3D visualization library

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=665733

--- Comment #11 from Richard Shaw hobbes1...@gmail.com 2012-01-30 16:12:48 
EST ---
FYI,

SMESH has now been accepted at RPM Fusion.

Thanks,
Richard

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 665733] Review Request: Coin3 - High-level 3D visualization library

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=665733

--- Comment #10 from Richard Shaw hobbes1...@gmail.com 2011-12-27 11:39:52 
EST ---
Ralf,

I just wanted to check in with you. I've gotten OCE accepted at RPM Fusion and
will soon submit smesh for Fedora so Coin3 is my last major requirement for
FreeCAD.

Thanks,
Richard

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 665733] Review Request: Coin3 - High-level 3D visualization library

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=665733

--- Comment #7 from Ralf Corsepius rc040...@freenet.de 2011-12-02 10:29:33 
EST ---
(In reply to comment #6)
 Ping?

Why are you pinging? The packages from comment #4 are current.

And no, I do not want to rename this package into Coin and want to keep
Coin2/Coin3 in parallel, because they are not 100% compatible (as you
experienced with Pivy) and because of licensing issues (Coin1 was LGPL,
Coin2/Coin3 are GPLv2 (Note GPLv2, not GPLv2+; The next Coin likely will be
BSD).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 665733] Review Request: Coin3 - High-level 3D visualization library

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=665733

--- Comment #8 from Richard Shaw hobbes1...@gmail.com 2011-12-02 12:15:35 EST 
---
(In reply to comment #7)
 (In reply to comment #6)
  Ping?
 
 Why are you pinging? The packages from comment #4 are current.

Because it wasn't a rhetorical question and because you didn't answer the
question until now :)

 And no, I do not want to rename this package into Coin and want to keep
 Coin2/Coin3 in parallel, because they are not 100% compatible (as you
 experienced with Pivy) and because of licensing issues (Coin1 was LGPL,
 Coin2/Coin3 are GPLv2 (Note GPLv2, not GPLv2+; The next Coin likely will be
 BSD).

That's all I was looking for was an explanation.

I build packages on F15 x86_64 which have the following rpmlint output:

$ rpmlint *.rpm
Coin3.src:57: W: unversioned-explicit-provides pkgconfig(Coin)
Coin3.x86_64: W: shared-lib-calls-exit /usr/lib64/libCoin.so.60.1.3
exit@GLIBC_2.2.5
Coin3.x86_64: E: incorrect-fsf-address /usr/share/doc/Coin3-3.1.3/LICENSE.GPL
Coin3-devel.x86_64: W: read-error /usr/lib64/pkgconfig/Coin.pc [Errno 2] No
such file or directory:
'/tmp/rpmlint.Coin3-devel-3.1.3-2.fc15.x86_64.rpm.oOzNpI//usr/lib64/pkgconfig/Coin.pc'
Coin3-devel.x86_64: W: dangerous-command-in-%post rm
4 packages and 0 specfiles checked; 1 errors, 4 warnings.

I think most of this can be ignored either because it's an artifact of
alternatives (unversioned-explicit-provides, read-error,
dangerous-command-in-%post) or upstream is currently unlikely to to care
(shared-lib-calls-exit, incorrect-fsf-address).

The only change I feel pretty strongly about is creating a separate doc
sub-package. Currently the devel package is 55MB, most of which is
documentation and  the most common use is more likely to be from someone, like
myself, that just needs it as a build requirement and have no intention of
doing any direct development using Coin3.

Full review to follow.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 665733] Review Request: Coin3 - High-level 3D visualization library

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=665733

--- Comment #9 from Richard Shaw hobbes1...@gmail.com 2011-12-02 12:49:51 EST 
---
+: OK
-: must be fixed
=: should be fixed (at your discretion)
?: Question or clairification needed
N: not applicable

MUST:
[+] rpmlint output: shown in comment.
[+] follows package naming guidelines
[+] spec file base name matches package name
[+] package meets the packaging guidelines
[+] package uses a Fedora approved license: GPLv2+
[+] license field matches the actual license: Actual source is GPLv2.
[+] license file is included in %doc: LICENSE.GPL
[+] spec file is in American English
[+] spec file is legible
[+] sources match upstream: md5sum matches (1538682f8d92cdf03e845c786879fbea)
[+] package builds on at least one primary arch: Tested F15 x86_64
[N] appropriate use of ExcludeArch
[+] all build requirements in BuildRequires
[N] spec file handles locales properly
[+] ldconfig in %post and %postun
[+] no bundled copies of system libraries
[N] no relocatable packages
[+] package owns all directories that it creates
[+] no files listed twice in %files
[+] proper permissions on files
[+] consistent use of macros
[+] code or permissible content
[=] large documentation in -doc
[+] no runtime dependencies in %doc
[+] header files in -devel
[N] static libraries in -static
[+] .so in -devel
[?] -devel requires main package
[+] package contains no libtool archives
[N] package contains a desktop file, uses desktop-file-install/validate
[+] package does not own files/dirs owned by other packages
[+] all filenames in UTF-8

SHOULD:
[+] query upstream for license text
[N] description and summary contains available translations
[+] package builds in mock
[+] package builds on all supported arches: Tested x86_64
[?] package functions as described: Used as BR for two other programs.
[+] sane scriptlets
[+] subpackages require the main package
[+] placement of pkgconfig files
[N] file dependencies versus package dependencies
[+] package contains man pages for binaries/scripts

Only 3 items remain:

1. Spec file says GPLv2+ not GPLv2.
2. The question about a doc package
3. The Require of the main package from the devel package is not arch specific
but the -devel package is not noarch. 

In %package devel change:
Requires: %{name} = %{version}-%{release}
to
Requires: %{name}%{?_isa} = %{version}-%{release}

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 665733] Review Request: Coin3 - High-level 3D visualization library

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=665733

--- Comment #6 from Richard Shaw hobbes1...@gmail.com 2011-12-02 10:02:58 EST 
---
Ping?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 665733] Review Request: Coin3 - High-level 3D visualization library

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=665733

--- Comment #5 from Richard Shaw hobbes1...@gmail.com 2011-11-08 09:37:39 EST 
---
Ralf,

Can you respond to comment #3? I did a quick search:

# repoquery --whatrequires Coin2
Coin2-devel-0:2.5.0-10.fc15.i686
Coin2-devel-0:2.5.0-10.fc15.x86_64
SIMVoleon-0:2.0.1-11.fc15.i686
SIMVoleon-0:2.0.1-11.fc15.x86_64
SoQt-0:1.5.0-2.fc15.i686
SoQt-0:1.5.0-2.fc15.x86_64

And it appears that only SoQt and SIMVoleon require Coin2 and I've successfully
built them against Coin3.

Is there a reason we can just make this package Coin and obsolete Coin2?

Thanks,
Richard

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 665733] Review Request: Coin3 - High-level 3D visualization library

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=665733

--- Comment #4 from Ralf Corsepius rc040...@freenet.de 2011-11-07 22:47:27 
EST ---
(In reply to comment #2)
 (In reply to comment #1)
  1. Are you planning on building for EL5?
 Well, note the age of this submission (~ 1 year) - It predates this change in
 Fedora - and the history of this package (Coin[12] packages's spec. This
 rpm'specs origins are much older than Fedora - Can now be cleaned up ;)

Done.

  3. Ok, in %configure I made quite a few changes. I went ahead and took
  advantage of all the options that seemed appropriate. Here's my version, 
  keep
  in mind I removed all the alternative stuff for my personal build:
  
  %configure \
  --includedir=%{_includedir}/Coin3 \
  --htmldir=%{_datadir}/doc/Coin3 \
  --disable-dependency-tracking \
  --enable-shared \
  --disable-dl-libbzip2 \
  --disable-dl-glu \
  --disable-dl-zlib \
  --disable-dl-freetype \
  --disable-dl-fontconfig \
  --disable-spidermonkey \
  --enable-man \
  --enable-html \
  --enable-3ds-import \
  CPPFLAGS=$(pkg-config --cflags freetype2)
  
  The htmldir environment variable worked but since it offered a --htmldir 
  option

The configure script treats --htmldir equivalently to passing 
htmldir to configure. As htmldir also works for Coin  3, while --htmldir
doesn't, I'll continue using htmldir=

  If this is truly documentation, should it not go in
  /usr/share/doc/... and not /usr/share/...?
 I don't recall the details - Could be an artefact from Coin1 and Coin2 or a
 side effect of coin-config's habit to hard-code paths.
 To be checked.

It's not an artefact. Coin spans up a documentation system of its own for Coin
and its frontends (SoQt, SoGtk, SoWin, etc.). I.e. it expects a common
documentation root directory to install its frontends' html documentation into.

This doesn't fit into rpm's /usr/share/doc usage.

  4. %files:
  
  %doc AUTHORS COPYING README* LICENSE* THANKS FAQ*
  
  - The README* also grabs readme's for windows and mac so change to:
  
  %doc AUTHORS COPYING README README.UNIX LICENSE* THANKS FAQ*
 OK, I'll look into this.
Done. All README.*'s are gone (Comprising README.UNIX, which only contains an
install howto)

 An updated package to come sometime next week.

Here it is:

 http://corsepiu.fedorapeople.org/packages/Coin3.spec
 http://corsepiu.fedorapeople.org/packages/Coin3-3.1.3-2.fc17.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 665733] Review Request: Coin3 - High-level 3D visualization library

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=665733

--- Comment #3 from Richard Shaw hobbes1...@gmail.com 2011-11-05 10:01:57 EDT 
---
Ok, everything looks good otherwise, but if you don't mind, can you explain why
we need a Coin2 and Coin3? 

Is there software in Fedora that relies on Coin2 still? In my pursuit to build
FreeCAD I was working on Pivy which wanted Coin3, so I ended up building it
from your SRPM and also rebuilding SoQt and SIMVoleon against it successfully. 

Thanks,
Richard

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 665733] Review Request: Coin3 - High-level 3D visualization library

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=665733

--- Comment #2 from Ralf Corsepius rc040...@freenet.de 2011-11-04 13:17:59 
EDT ---
(In reply to comment #1)
 1. Are you planning on building for EL5?
Well, note the age of this submission (~ 1 year) - It predates this change in
Fedora - and the history of this package (Coin[12] packages's spec. This
rpm'specs origins are much older than Fedora - Can now be cleaned up ;)

 2. I had managed to get a build before getting your email response. Just to 
 see
 how minimal I could go I stripped out a bunch of stuff including:
 
 # bogus permissions
 find . \( -name '*.h' -o -name '*.cpp' -o -name '*.c' \) -a -executable -exec
 chmod -x {} \;
 
 rpmlint only complained about files in one directory so I replaced the above
 with:

The files with bogus permission repeatedly changed in Coin's history. 
I once decided to use the generic permission fix axe, because it turned
tiresome to chase permissions ;)

 3. Ok, in %configure I made quite a few changes. I went ahead and took
 advantage of all the options that seemed appropriate. Here's my version, keep
 in mind I removed all the alternative stuff for my personal build:
 
 %configure \
 --includedir=%{_includedir}/Coin3 \
 --htmldir=%{_datadir}/doc/Coin3 \
 --disable-dependency-tracking \
 --enable-shared \
 --disable-dl-libbzip2 \
 --disable-dl-glu \
 --disable-dl-zlib \
 --disable-dl-freetype \
 --disable-dl-fontconfig \
 --disable-spidermonkey \
 --enable-man \
 --enable-html \
 --enable-3ds-import \
 CPPFLAGS=$(pkg-config --cflags freetype2)
 
 The htmldir environment variable worked but since it offered a --htmldir 
 option
 I went ahead and used it. If this is truly documentation, should it not go in
 /usr/share/doc/... and not /usr/share/...?
I don't recall the details - Could be an artefact from Coin1 and Coin2 or a
side effect of coin-config's habit to hard-code paths.

To be checked.

 I also got rid of the coin_includedir and coin_htmldir.
Your preference - mine is different, because these reduce size of the diffs
between Coin1, Coin2 and Coin3 and eases comparing the specs.

 4. %files:
 
 %doc AUTHORS COPYING README* LICENSE* THANKS FAQ*
 
 - The README* also grabs readme's for windows and mac so change to:
 
 %doc AUTHORS COPYING README README.UNIX LICENSE* THANKS FAQ*
OK, I'll look into this.

 Nit-picks:
 
 5. I like %{buildroot} but the guidelines say just be consistent :)
I hate %{buildroot} and am not using it anywhere inside of my specs ;)

 6. There's a blank line in the middle of your BuildRequires. It looks like
 you're separating the GL/X stuff from everything else. If you're not going to
 put in a comment, it would be better to remove the blank line.
OK, will check.

 Other:
 
 The alternatives doesn't bother me but you'll have to explain the i18n 
 problems
 to me...
The source code is written using some ISO8859 variant as being used in Norway.

This causes doxygen to generate ISO8859 encoded docs and causes doxygen to get
confused on some characters. IIRC, there also where some doxygen constructs
inside of doxygen comments in the source-code, which newer doxygen handles
differently than older doxygens. - I'll try to check.

An updated package to come sometime next week.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 665733] Review Request: Coin3 - High-level 3D visualization library

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=665733

Richard Shaw hobbes1...@gmail.com changed:

   What|Removed |Added

 Blocks||458975

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 665733] Review Request: Coin3 - High-level 3D visualization library

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=665733

Richard Shaw hobbes1...@gmail.com changed:

   What|Removed |Added

 CC||hobbes1...@gmail.com
 AssignedTo|nob...@fedoraproject.org|hobbes1...@gmail.com
   Flag||fedora-review?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 665733] Review Request: Coin3 - High-level 3D visualization library

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=665733

Richard Shaw hobbes1...@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

--- Comment #1 from Richard Shaw hobbes1...@gmail.com 2011-11-01 09:34:42 EDT 
---
1. Are you planning on building for EL5? If not then the following can go away.

BuildRoot:, rm -rf $RPM_BUILD_ROOT from %install, %clean entirely, %defarrt
from %files


2. I had managed to get a build before getting your email response. Just to see
how minimal I could go I stripped out a bunch of stuff including:

# bogus permissions
find . \( -name '*.h' -o -name '*.cpp' -o -name '*.c' \) -a -executable -exec
chmod -x {} \;

rpmlint only complained about files in one directory so I replaced the above
with:

chmod -x src/xml/expat/*.c

It reduced the build time quite a bit. Nothing that would matter for koji, but
significant for experimental building on my own machine :)


3. Ok, in %configure I made quite a few changes. I went ahead and took
advantage of all the options that seemed appropriate. Here's my version, keep
in mind I removed all the alternative stuff for my personal build:

%configure \
--includedir=%{_includedir}/Coin3 \
--htmldir=%{_datadir}/doc/Coin3 \
--disable-dependency-tracking \
--enable-shared \
--disable-dl-libbzip2 \
--disable-dl-glu \
--disable-dl-zlib \
--disable-dl-freetype \
--disable-dl-fontconfig \
--disable-spidermonkey \
--enable-man \
--enable-html \
--enable-3ds-import \
CPPFLAGS=$(pkg-config --cflags freetype2)

The htmldir environment variable worked but since it offered a --htmldir option
I went ahead and used it. If this is truly documentation, should it not go in
/usr/share/doc/... and not /usr/share/...?

I also got rid of the coin_includedir and coin_htmldir. They're not used very
much and if you're not familiar with the package and you're looking in %files
you have to go back to the top of the spec to see how they're defined. 

4. %files:

%doc AUTHORS COPYING README* LICENSE* THANKS FAQ*

- The README* also grabs readme's for windows and mac so change to:

%doc AUTHORS COPYING README README.UNIX LICENSE* THANKS FAQ*


Nit-picks:

5. I like %{buildroot} but the guidelines say just be consistent :)

6. There's a blank line in the middle of your BuildRequires. It looks like
you're separating the GL/X stuff from everything else. If you're not going to
put in a comment, it would be better to remove the blank line.


Other:

The alternatives doesn't bother me but you'll have to explain the i18n problems
to me...

Thanks,
Richard

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review