[Bug 667416] Review Request: util-linux - rename from util-linux-ng
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=667416 Dan Horák changed: What|Removed |Added Status|NEW |ASSIGNED CC||d...@danny.cz AssignedTo|nob...@fedoraproject.org|d...@danny.cz Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 667416] Review Request: util-linux - rename from util-linux-ng
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=667416 --- Comment #1 from Dan Horák 2011-01-07 10:30:50 EST --- formal review is here, see the notes explaining OK* and BAD statuses below: OK source files match upstream: 5dcb211602b1639a6cda5055f02245b8f94d0559 util-linux-2.19-rc1.tar.bz2 OK package meets naming and versioning guidelines. OK specfile is properly named, is cleanly written and uses macros consistently. OK dist tag is present. OK license field matches the actual license. BAD license is open source-compatible. License text included in package. OK latest version is being packaged. OK BuildRequires are proper. OK compiler flags are appropriate. OK package builds in mock (Rawhide/x86_64). OK debuginfo package looks complete. BAD rpmlint is silent. BAD final provides and requires look sane. N/A %check is present and all tests pass. OK shared libraries are added to the regular linker search paths with proper scriptlets OK owns the directories it creates. OK doesn't own any directories it shouldn't. OK no duplicates in %files. OK file permissions are appropriate. OK correct scriptlets present. OK code, not content. OK documentation is small, so no -docs subpackage is necessary. OK %docs are not necessary for the proper functioning of the package. OK headers in -devel OK pkgconfig files in -devel OK no libtool .la droppings. OK not a GUI app. - the uuidd, libmount, libblkid, libuuid subpackages must include their license text as %doc - rpmlint throws a lot of warnings/errors, mostly can be ignored I think, but they deserve a review - the compatibility Provides/Obsoletes should be cleaned up for the update path I suggest to use "Obsoletes: util-linux-ng < 2.19" (instead of < 2.18.1) - you can drop the Buildroot tag and the clean section, they are not needed in recent Fedoras (and next RHEL) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 667416] Review Request: util-linux - rename from util-linux-ng
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=667416 --- Comment #2 from Karel Zak 2011-01-10 16:13:10 EST --- (In reply to comment #1) > - the uuidd, libmount, libblkid, libuuid subpackages must include their > license > text as %doc Fixed. > - rpmlint throws a lot of warnings/errors, mostly can be ignored I think, but > they deserve a review I fixed some warnings. > - the compatibility Provides/Obsoletes should be cleaned up > for the update path I suggest to use "Obsoletes: util-linux-ng < 2.19" > (instead of < 2.18.1) Fixed. > - you can drop the Buildroot tag and the clean section, they are not needed in > recent Fedoras (and next RHEL) Fixed. The rpm and spec at fedorapeople.org has been update. I have also added a new code for mtab to specfile. Please, review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 667416] Review Request: util-linux - rename from util-linux-ng
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=667416
--- Comment #3 from Dan Horák 2011-01-17 05:29:06 EST ---
there are few issues remaining
- dracut contains "Requires: mount" and new util-linux doesn't provide that,
will be fixed in dracut package
- the architecture list "sparc sparcv9 sparc64" should be replaced with
%{sparc}
- the architecture list in "cytune_arch" should contain %{arm} instead of
armv4l
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 667416] Review Request: util-linux - rename from util-linux-ng
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=667416 --- Comment #4 from Karel Zak 2011-01-17 06:13:19 EST --- Fixed and srpm and spec at fedorapeople.org updated. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 667416] Review Request: util-linux - rename from util-linux-ng
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=667416 Dan Horák changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #5 from Dan Horák 2011-01-17 06:15:40 EST --- All issues are fixed now, new dracut package is also built. This package rename is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
