[Bug 667997] Review Request: rubygem-rack-mount - Stackable dynamic tree based Rack router
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=667997 Vít Ondruch vondr...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE Last Closed||2011-01-28 08:21:22 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 667997] Review Request: rubygem-rack-mount - Stackable dynamic tree based Rack router
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=667997 Vít Ondruch vondr...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #6 from Vít Ondruch vondr...@redhat.com 2011-01-26 08:11:57 EST --- New Package SCM Request === Package Name: rubygem-rack-mount Short Description: Stackable dynamic tree based Rack router Owners: vondruch Branches: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 667997] Review Request: rubygem-rack-mount - Stackable dynamic tree based Rack router
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=667997
--- Comment #5 from Vít Ondruch vondr...@redhat.com 2011-01-26 08:09:59 EST
---
Spec URL: http://people.redhat.com/vondruch/rubygem-rack-mount.spec
SRPM URL:
http://people.redhat.com/vondruch/rubygem-rack-mount-0.6.13-3.fc14.src.rpm
(In reply to comment #4)
* MUST: Packages must NOT bundle copies of system libraries, rack-mount
vendorizes the multimap and regin gems, these need to be separated into
their
own rpms
Bundled gems removed and added dependencies instead.
Hrm, the code you added to the specfile doesn't quite accomplish this,
instead
of the rm -rf gems/... line you need
rm -rf %{buildroot}%{geminstdir}/lib/rack/mount/vendor
I've verified it builds and the test suite still works as intended after this
fix.
Huh ... I must be blind :) Fixed. Thank you.
* Koji build is green:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2730211
* Feel free to tar up the upstream test suite and Rakefile and include
and run
them in the rpm's check section. Not a requirement for approval though.
Test suite is executed now during build. Note, however, that the test suite
is
not bundled into resulting package.
Thanks, though I'm getting the following error when I run this:
mkdir /var/tmp/rack-mount-0.6.13
mkdir: cannot create directory `/var/tmp/rack-mount-0.6.13': File exists
error: Bad exit status from /var/tmp/rpm-tmp.3WMbc3 (%check)
The following accomplishes the same thing and works locally
%check
pushd %{buildroot}%{gemdir}
tar xzvf %{SOURCE1}
ruby -rrubygems -I%{buildroot}%{geminstdir}/lib -I./test /usr/bin/testrb
test/test_*
rm -rf test/
popd
This happened because build failed for the first time (missing
RUBYOPT=rubygems in mock?). It should not ever happen on Koji. Nevertheless,
I am now cleaning up the test target directory before the test preparation, so
it should not happen anymore.
Thank you for your review.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 667997] Review Request: rubygem-rack-mount - Stackable dynamic tree based Rack router
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=667997 --- Comment #7 from Jason Tibbitts ti...@math.uh.edu 2011-01-26 12:56:59 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 667997] Review Request: rubygem-rack-mount - Stackable dynamic tree based Rack router
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=667997 Bug 667997 depends on bug 672136, which changed state. Bug 672136 Summary: Review Request: rubygem-multimap - Ruby multimap implementation https://bugzilla.redhat.com/show_bug.cgi?id=672136 What|Old Value |New Value Resolution||RAWHIDE Status|ASSIGNED|CLOSED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 667997] Review Request: rubygem-rack-mount - Stackable dynamic tree based Rack router
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=667997 Bug 667997 depends on bug 670930, which changed state. Bug 670930 Summary: Review Request: rubygem-regin - Ruby Regexp Introspection https://bugzilla.redhat.com/show_bug.cgi?id=670930 What|Old Value |New Value Resolution||RAWHIDE Status|ASSIGNED|CLOSED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 667997] Review Request: rubygem-rack-mount - Stackable dynamic tree based Rack router
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=667997 --- Comment #3 from Vít Ondruch vondr...@redhat.com 2011-01-24 08:06:40 EST --- Please see updated package: Spec URL: http://people.redhat.com/vondruch/rubygem-rack-mount.spec SRPM URL: http://people.redhat.com/vondruch/rubygem-rack-mount-0.6.13-2.fc14.src.rpm (In reply to comment #2) Will take this one * $ rpmlint rpmbuild/RPMS/noarch/rubygem-rack-mount-* rpmbuild/SRPMS/rubygem-rack-mount-0.6.13-1.fc14.src.rpm | grep -v unexpanded-macro rubygem-rack-mount.noarch: I: enchant-dictionary-not-found en_US rubygem-rack-mount.src: W: no-cleaning-of-buildroot %clean rubygem-rack-mount.src: W: no-buildroot-tag rubygem-rack-mount.src: W: no-%prep-section rubygem-rack-mount.src: W: no-%build-section rubygem-rack-mount.src: W: no-%clean-section 3 packages and 0 specfiles checked; 0 errors, 76 warnings. Can you add the missing sections (prep, build, clean), the other warnings can be ignored I have added missing sections * Missing dependency, shouldn't rubygem(rack) be a Requires http://rubygems.org/gems/rack-mount Added missing dependencies * MUST: Packages must NOT bundle copies of system libraries, rack-mount vendorizes the multimap and regin gems, these need to be separated into their own rpms Bundled gems removed and added dependencies instead. * Koji build is green: http://koji.fedoraproject.org/koji/taskinfo?taskID=2730211 * Feel free to tar up the upstream test suite and Rakefile and include and run them in the rpm's check section. Not a requirement for approval though. Test suite is executed now during build. Note, however, that the test suite is not bundled into resulting package. Other than that, looks good, thanks for this I cannot provide Koji build results as long as the dependencies are not satisfied. However, if everything goes well, the package should be prepared already. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 667997] Review Request: rubygem-rack-mount - Stackable dynamic tree based Rack router
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=667997
Mohammed Morsi mmo...@redhat.com changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #4 from Mohammed Morsi mmo...@redhat.com 2011-01-24 15:49:42 EST
---
(In reply to comment #3)
Please see updated package:
Spec URL: http://people.redhat.com/vondruch/rubygem-rack-mount.spec
SRPM URL:
http://people.redhat.com/vondruch/rubygem-rack-mount-0.6.13-2.fc14.src.rpm
(In reply to comment #2)
Will take this one
* $ rpmlint rpmbuild/RPMS/noarch/rubygem-rack-mount-*
rpmbuild/SRPMS/rubygem-rack-mount-0.6.13-1.fc14.src.rpm | grep -v
unexpanded-macro
rubygem-rack-mount.noarch: I: enchant-dictionary-not-found en_US
rubygem-rack-mount.src: W: no-cleaning-of-buildroot %clean
rubygem-rack-mount.src: W: no-buildroot-tag
rubygem-rack-mount.src: W: no-%prep-section
rubygem-rack-mount.src: W: no-%build-section
rubygem-rack-mount.src: W: no-%clean-section
3 packages and 0 specfiles checked; 0 errors, 76 warnings.
Can you add the missing sections (prep, build, clean), the other warnings
can
be ignored
I have added missing sections
Looks good.
* Missing dependency, shouldn't rubygem(rack) be a Requires
http://rubygems.org/gems/rack-mount
Added missing dependencies
Looks good.
* MUST: Packages must NOT bundle copies of system libraries, rack-mount
vendorizes the multimap and regin gems, these need to be separated into
their
own rpms
Bundled gems removed and added dependencies instead.
Hrm, the code you added to the specfile doesn't quite accomplish this, instead
of the rm -rf gems/... line you need
rm -rf %{buildroot}%{geminstdir}/lib/rack/mount/vendor
I've verified it builds and the test suite still works as intended after this
fix.
* Koji build is green:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2730211
* Feel free to tar up the upstream test suite and Rakefile and include and
run
them in the rpm's check section. Not a requirement for approval though.
Test suite is executed now during build. Note, however, that the test suite is
not bundled into resulting package.
Thanks, though I'm getting the following error when I run this:
mkdir /var/tmp/rack-mount-0.6.13
mkdir: cannot create directory `/var/tmp/rack-mount-0.6.13': File exists
error: Bad exit status from /var/tmp/rpm-tmp.3WMbc3 (%check)
The following accomplishes the same thing and works locally
%check
pushd %{buildroot}%{gemdir}
tar xzvf %{SOURCE1}
ruby -rrubygems -I%{buildroot}%{geminstdir}/lib -I./test /usr/bin/testrb
test/test_*
rm -rf test/
popd
Other than that, looks good, thanks for this
I cannot provide Koji build results as long as the dependencies are not
satisfied. However, if everything goes well, the package should be prepared
already.
I've verified it builds in a F14 mock environment w/ the regin and multimap
gems pre installed.
Once you make the two changes above (correct the rm -rf command to remove
vendorized libs and fix the %check section so that it doesn't throw error) this
package is
APPROVED
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 667997] Review Request: rubygem-rack-mount - Stackable dynamic tree based Rack router
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=667997 Mohammed Morsi mmo...@redhat.com changed: What|Removed |Added Depends on||672136 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 667997] Review Request: rubygem-rack-mount - Stackable dynamic tree based Rack router
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=667997 Vít Ondruch vondr...@redhat.com changed: What|Removed |Added Depends on||670930 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 667997] Review Request: rubygem-rack-mount - Stackable dynamic tree based Rack router
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=667997 Mohammed Morsi mmo...@redhat.com changed: What|Removed |Added CC||mmo...@redhat.com Flag||fedora-review? --- Comment #2 from Mohammed Morsi mmo...@redhat.com 2011-01-18 19:33:45 EST --- Will take this one * $ rpmlint rpmbuild/RPMS/noarch/rubygem-rack-mount-* rpmbuild/SRPMS/rubygem-rack-mount-0.6.13-1.fc14.src.rpm | grep -v unexpanded-macro rubygem-rack-mount.noarch: I: enchant-dictionary-not-found en_US rubygem-rack-mount.src: W: no-cleaning-of-buildroot %clean rubygem-rack-mount.src: W: no-buildroot-tag rubygem-rack-mount.src: W: no-%prep-section rubygem-rack-mount.src: W: no-%build-section rubygem-rack-mount.src: W: no-%clean-section 3 packages and 0 specfiles checked; 0 errors, 76 warnings. Can you add the missing sections (prep, build, clean), the other warnings can be ignored * Missing dependency, shouldn't rubygem(rack) be a Requires http://rubygems.org/gems/rack-mount * MUST: Packages must NOT bundle copies of system libraries, rack-mount vendorizes the multimap and regin gems, these need to be separated into their own rpms * Koji build is green: http://koji.fedoraproject.org/koji/taskinfo?taskID=2730211 * Feel free to tar up the upstream test suite and Rakefile and include and run them in the rpm's check section. Not a requirement for approval though. Other than that, looks good, thanks for this -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 667997] Review Request: rubygem-rack-mount - Stackable dynamic tree based Rack router
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=667997 Mohammed Morsi mmo...@redhat.com changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|mmo...@redhat.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 667997] Review Request: rubygem-rack-mount - Stackable dynamic tree based Rack router
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=667997 Mohammed Morsi mmo...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 667997] Review Request: rubygem-rack-mount - Stackable dynamic tree based Rack router
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=667997 Minnikhanov minnikha...@gmail.com changed: What|Removed |Added CC||minnikha...@gmail.com --- Comment #1 from Minnikhanov minnikha...@gmail.com 2011-01-07 11:36:29 EST --- *** Bug 668008 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
