[Bug 670127] Review Request: the-board - A space for placing daily records in your GNOME desktop
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=670127 Peter Robinson pbrobin...@gmail.com changed: What|Removed |Added Status|NEW |CLOSED Resolution||RAWHIDE Last Closed||2011-05-07 15:15:23 --- Comment #20 from Peter Robinson pbrobin...@gmail.com 2011-05-07 15:15:23 EDT --- In rawhide and F-15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 670127] Review Request: the-board - A space for placing daily records in your GNOME desktop
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=670127 Bill Nottingham nott...@redhat.com changed: What|Removed |Added Flag||fedora-review+ --- Comment #17 from Bill Nottingham nott...@redhat.com 2011-03-30 11:40:24 EDT --- OK, that works for me. Lucas - if you want to slap a GPLv3 copyright boilerplate on some of the other source files, it would make the situation cleaner for future releases. In any case, approved. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 670127] Review Request: the-board - A space for placing daily records in your GNOME desktop
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=670127 Bill Nottingham nott...@redhat.com changed: What|Removed |Added AssignedTo|mcla...@redhat.com |nott...@redhat.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 670127] Review Request: the-board - A space for placing daily records in your GNOME desktop
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=670127 Cosimo Cecchi ccec...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #18 from Cosimo Cecchi ccec...@redhat.com 2011-03-30 19:46:25 EDT --- New Package SCM Request === Package Name: the-board Short Description: A space for placing daily records in your GNOME desktop Owners: cosimoc Branches: f15 InitialCC: cosimoc -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 670127] Review Request: the-board - A space for placing daily records in your GNOME desktop
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=670127 --- Comment #19 from Jason Tibbitts ti...@math.uh.edu 2011-03-30 20:52:38 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 670127] Review Request: the-board - A space for placing daily records in your GNOME desktop
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=670127 Lucas Rocha lucasr.at.mu...@gmail.com changed: What|Removed |Added CC||lucasr.at.mu...@gmail.com --- Comment #16 from Lucas Rocha lucasr.at.mu...@gmail.com 2011-03-29 11:31:45 EDT --- Hi guys, GPLv3 is my intent. The reason TbBox is licensed LGPLv2+ is because I copied it from litl's LGPLv2+-licensed code which was based on Red Hat's Hippo Canvas. To be honest, I'm not sure what is the legally correct thing to do here. In theory, I can just relicense the code under any version of the GPL since GPLv2[1]. Not sure it matters much. Thanks! [1] http://www.gnu.org/licenses/gpl-faq.html#AllCompatibility -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 670127] Review Request: the-board - A space for placing daily records in your GNOME desktop
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=670127 --- Comment #13 from Cosimo Cecchi ccec...@redhat.com 2011-03-28 09:27:55 EDT --- Ok, I gave this another pass, and upadted the package to the latest 0.1.1.1 too. SPEC: http://people.gnome.org/~cosimoc/the-board-pkg/the-board.spec SRPM: http://people.gnome.org/~cosimoc/the-board-pkg/the-board-0.1.1.1-1.fc15.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 670127] Review Request: the-board - A space for placing daily records in your GNOME desktop
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=670127 --- Comment #14 from Cosimo Cecchi ccec...@redhat.com 2011-03-28 20:19:40 EDT --- Today upstream released a new version, 0.1.2, so I updated the package again. SPEC: http://people.gnome.org/~cosimoc/the-board-pkg/the-board.spec SRPM: http://people.gnome.org/~cosimoc/the-board-pkg/the-board-0.1.2-1.fc15.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 670127] Review Request: the-board - A space for placing daily records in your GNOME desktop
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=670127
--- Comment #15 from Bill Nottingham nott...@redhat.com 2011-03-28 22:04:15
EDT ---
So, looking at the updated version (review appears to have stalled)?:
- Package meets naming and packaging guidelines - OK
- Spec file matches base package name. - OK
- Spec has consistant macro usage. - OK
- Meets Packaging Guidelines. - OK
- License - ***
The license is declared as GPLv3, and that's what's included in the tarball.
However, the only source file with a license is LGPLv2+.
- License field in spec matches - OK (matches COPYING)
- License file included in package - OK
- Spec in American English - OK
- Spec is legible - OK.
- Sources match upstream md5sum:
284162a6a1a6b7762a89b021833a12835a334e535061626269096fb8a96c7e78
/home/notting/prog/rpm/source/the-board-0.1.2.tar.bz2
OK
- Package needs ExcludeArch - N/A
- BuildRequires correct - OK
- Spec handles locales/find_lang - OK
- Package is relocatable and has a reason to be. - N/A
- Package has %defattr and permissions on files is good. - OK
- Package is code or permissible content. - OK
- Doc subpackage needed/used. - N/A
- Packages %doc files don't affect runtime. - OK
- Headers/static libs in -devel subpackage. - OK
- Spec has needed ldconfig in post and postun - OK
- .pc files in -devel subpackage/requires pkgconfig - N/A
- .so files in -devel subpackage. - OK
- -devel package Requires: %{name} = %{version}-%{release} - OK
- .la files are removed. - OK
- Package is a GUI app and has a .desktop file - OK
- Package compiles and builds on at least one arch. - OK (tested x86_64)
- Package has no duplicate files in %files. - OK
- Package doesn't own any directories other packages own. - OK
- Package owns all the directories it creates. - OK
- No rpmlint output:
the-board.x86_64: W: no-manual-page-for-binary the-board
the-board-devel.x86_64: W: no-documentation
the-board-devel.x86_64: W: no-manual-page-for-binary tb-js-unit
the-board-nautilus.x86_64: W: no-documentation
These are all upstream issues, so OK.
- final provides and requires are sane - OK
SHOULD Items:
- Should build in mock. - OK (tested x86_64)
- Should function as described. - OK
- Should have sane scriptlets. - OK
- Should have subpackages require base package with fully versioned depend. -
OK
- Should have dist tag - OK
- Should package latest version - OK
So, the only issue I can see is the license mismatch. Probably just requires a
clarification from upstream that GPLv3 is their intent?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 670127] Review Request: the-board - A space for placing daily records in your GNOME desktop
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=670127 Christoph Wickert cwick...@fedoraproject.org changed: What|Removed |Added Component|0x |Package Review --- Comment #12 from Christoph Wickert cwick...@fedoraproject.org 2011-03-23 05:19:07 EDT --- Peter, midori doesn't like bugzilla and changes the component to the first in the list. Changing it back to 'Package review'. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 670127] Review Request: the-board - A space for placing daily records in your GNOME desktop
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=670127 Peter Robinson pbrobin...@gmail.com changed: What|Removed |Added CC||dw...@infradead.org, ||pbrobin...@gmail.com Component|Package Review |0x -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 670127] Review Request: the-board - A space for placing daily records in your GNOME desktop
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=670127 Christoph Wickert cwick...@fedoraproject.org changed: What|Removed |Added CC||cwick...@fedoraproject.org --- Comment #11 from Christoph Wickert cwick...@fedoraproject.org 2011-02-23 06:54:26 EST --- Please use %global instead of %define, see https://fedoraproject.org/wiki/PackagingDrafts/global_preferred_over_define -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 670127] Review Request: the-board - A space for placing daily records in your GNOME desktop
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=670127 --- Comment #10 from Matthias Clasen mcla...@redhat.com 2011-01-31 20:35:15 EST --- ok, going down the checklist now: rpmlint: see above, ok package name: ok spec file name: ok packaging guidelines: ok, except as noted below license: ok license field: ok license file: ok spec language: ok spec readable: ok upstream sources: ok buildable: ok excludearch: ok buildrequires: ok locale handling: ok ldconfig: need to run /sbin/ldconfig in %post/%postun system libraries: ok, although libtb is a pretty generic name for an app-specific library relocatable: ok directory ownership: I think the -nautilus package should perhaps require nautilus, instead of owning %libdir/nautilus ? at least that's what other -nautilus subpackages do duplicate files: ok file permissions: ok macro use: ok permissible content: ok large docs: ok %doc content: ok headers: ok static libs: ok shared lib symlinks: ok devel dep: ok libtool archives: ok desktop file: ok duplicate ownership: ok utf8 filenames: ok I don't think the-board should ship its own fonts.conf, in particular not one that contains a reference to /home/lucasr/Code... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 670127] Review Request: the-board - A space for placing daily records in your GNOME desktop
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=670127 --- Comment #6 from Cosimo Cecchi ccec...@redhat.com 2011-01-28 12:10:23 EST --- (In reply to comment #5) the errors should be addressed, the warnings are harmless. New SPEC at the same place: http://people.gnome.org/~cosimoc/the-board-pkg/the-board.spec New SRPM: http://people.gnome.org/~cosimoc/the-board-pkg/the-board-0.1.0-4.fc15.src.rpm But still no new libmx in rawhide -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 670127] Review Request: the-board - A space for placing daily records in your GNOME desktop
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=670127 --- Comment #7 from Matthias Clasen mcla...@redhat.com 2011-01-28 13:29:08 EST --- I still get $ rpmlint /var/lib/mock/fedora-rawhide-x86_64/result/*.rpm the-board.x86_64: E: binary-or-shlib-defines-rpath /usr/libexec/the-board-start ['/usr/lib64'] the-board.x86_64: W: no-manual-page-for-binary the-board the-board-devel.x86_64: W: no-documentation the-board-nautilus.x86_64: W: no-documentation 5 packages and 0 specfiles checked; 1 errors, 3 warnings. so I guess --disable-rpath is not good enough -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 670127] Review Request: the-board - A space for placing daily records in your GNOME desktop
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=670127 Colin Walters walt...@redhat.com changed: What|Removed |Added CC||walt...@redhat.com --- Comment #8 from Colin Walters walt...@redhat.com 2011-01-28 14:11:01 EST --- One complicating issue is if the-board uses gobject-introspection, the rpath is necessary for the dumper to work correctly. You'll have to use chrpath --delete after the build is complete. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 670127] Review Request: the-board - A space for placing daily records in your GNOME desktop
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=670127 --- Comment #9 from Cosimo Cecchi ccec...@redhat.com 2011-01-28 15:48:20 EST --- (In reply to comment #8) One complicating issue is if the-board uses gobject-introspection, the rpath is necessary for the dumper to work correctly. You'll have to use chrpath --delete after the build is complete. I tried this method, and setup a mock build myself to verify if it was working correctly this time, and it seems it did. New SPEC at the same place: http://people.gnome.org/~cosimoc/the-board-pkg/the-board.spec New SRPM: http://people.gnome.org/~cosimoc/the-board-pkg/the-board-0.1.0-5.fc15.src.rpm Also, a newer libmx hit rawhide today. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 670127] Review Request: the-board - A space for placing daily records in your GNOME desktop
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=670127
--- Comment #4 from Cosimo Cecchi ccec...@redhat.com 2011-01-21 08:38:03 EST
---
(In reply to comment #3)
You don't need to rm -rf %{buildroot} in %install anymore, and %clean can go
altogether.
Ok, new versions addressing Matthias' review.
SPEC: http://people.gnome.org/~cosimoc/the-board-pkg/the-board.spec
SRPM:
http://people.gnome.org/~cosimoc/the-board-pkg/the-board-0.1.0-3.fc15.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 670127] Review Request: the-board - A space for placing daily records in your GNOME desktop
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=670127 --- Comment #5 from Matthias Clasen mcla...@redhat.com 2011-01-21 10:35:05 EST --- Builds fine in mock after adding libmx-1.1 to a local repo rpmlint output: rpmlint /var/lib/mock/fedora-rawhide-x86_64/result/the-board-*.rpm the-board.x86_64: E: binary-or-shlib-defines-rpath /usr/libexec/the-board-start ['/usr/lib64'] the-board.x86_64: E: zero-length /usr/share/doc/the-board-0.1.0/AUTHORS the-board.x86_64: W: no-manual-page-for-binary the-board the-board-devel.x86_64: W: no-documentation the-board-nautilus.x86_64: W: no-documentation 5 packages and 0 specfiles checked; 2 errors, 3 warnings. the errors should be addressed, the warnings are harmless. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 670127] Review Request: the-board - A space for placing daily records in your GNOME desktop
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=670127
Matthias Clasen mcla...@redhat.com changed:
What|Removed |Added
CC||mcla...@redhat.com
--- Comment #3 from Matthias Clasen mcla...@redhat.com 2011-01-20 14:44:43
EST ---
You don't need to rm -rf %{buildroot} in %install anymore, and %clean can go
altogether.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 670127] Review Request: The Board - A space for placing daily records in your GNOME desktop
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=670127 --- Comment #2 from Cosimo Cecchi ccec...@redhat.com 2011-01-18 09:06:46 EST --- Thanks for the review Fabian. I addressed your comments and suppressed some more warnings from rpmlint, whose output looks pretty OK now. New version SPEC URL: http://people.gnome.org/~cosimoc/the-board-pkg/the-board.spec SRPM URL: http://people.gnome.org/~cosimoc/the-board-pkg/the-board-0.1.0-2.fc15.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 670127] Review Request: the-board - A space for placing daily records in your GNOME desktop
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=670127 Jason Tibbitts ti...@math.uh.edu changed: What|Removed |Added Summary|Review Request: The Board - |Review Request: the-board - |A space for placing daily |A space for placing daily |records in your GNOME |records in your GNOME |desktop |desktop -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 670127] Review Request: The Board - A space for placing daily records in your GNOME desktop
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=670127
Fabian Affolter fab...@bernewireless.net changed:
What|Removed |Added
CC||fab...@bernewireless.net
--- Comment #1 from Fabian Affolter fab...@bernewireless.net 2011-01-17
11:11:29 EST ---
Just some quick comments:
- You are mixing %{buildroot} and $RPM_BUILD_ROOT
- All doc files (README, NEWS, etc) should go to %doc
- 'desktop-file-install' is not used
https://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files
- Isn't RPM picking the gobject-introspection dependency automatically?
- The icon cache update is missing.
https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
