[Bug 670701] Review Request: ghc-ansi-terminal - Haskell ansi-terminal library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=670701 --- Comment #9 from Fedora Update System upda...@fedoraproject.org 2011-02-03 15:19:56 EST --- ghc-ansi-terminal-0.5.5-1.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 670701] Review Request: ghc-ansi-terminal - Haskell ansi-terminal library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=670701 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||ghc-ansi-terminal-0.5.5-1.f ||c14 Resolution||ERRATA Last Closed||2011-02-03 15:20:01 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 670701] Review Request: ghc-ansi-terminal - Haskell ansi-terminal library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=670701 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #8 from Fedora Update System upda...@fedoraproject.org 2011-01-26 15:54:52 EST --- ghc-ansi-terminal-0.5.5-1.fc14 has been pushed to the Fedora 14 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update ghc-ansi-terminal'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/ghc-ansi-terminal-0.5.5-1.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 670701] Review Request: ghc-ansi-terminal - Haskell ansi-terminal library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=670701 --- Comment #7 from Fedora Update System upda...@fedoraproject.org 2011-01-25 22:24:54 EST --- ghc-ansi-terminal-0.5.5-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/ghc-ansi-terminal-0.5.5-1.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 670701] Review Request: ghc-ansi-terminal - Haskell ansi-terminal library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=670701 --- Comment #6 from Jason Tibbitts ti...@math.uh.edu 2011-01-24 12:45:59 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 670701] Review Request: ghc-ansi-terminal - Haskell ansi-terminal library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=670701 Shakthi Kannan shakthim...@gmail.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #5 from Shakthi Kannan shakthim...@gmail.com 2011-01-22 11:29:10 EST --- New Package SCM Request === Package Name: ghc-ansi-terminal Short Description: A library to provide simple ANSI terminal support Owners: shakthimaan chitlesh Branches: F-14 EL-6 InitialCC: haskell-sig -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 670701] Review Request: ghc-ansi-terminal - Haskell ansi-terminal library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=670701 --- Comment #4 from Lakshmi Narasimhan lakshminaras2...@gmail.com 2011-01-21 23:47:15 EST --- Please upgrade to cabal2spec 0.22.4 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 670701] Review Request: ghc-ansi-terminal - Haskell ansi-terminal library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=670701 --- Comment #3 from Lakshmi Narasimhan lakshminaras2...@gmail.com 2011-01-21 23:46:44 EST --- Created attachment 474717 -- https://bugzilla.redhat.com/attachment.cgi?id=474717 Patch for summary and description -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 670701] Review Request: ghc-ansi-terminal - Haskell ansi-terminal library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=670701
Lakshmi Narasimhan lakshminaras2...@gmail.com changed:
What|Removed |Added
Flag||fedora-review+
--- Comment #2 from Lakshmi Narasimhan lakshminaras2...@gmail.com 2011-01-21
23:45:19 EST ---
[+]MUST: rpmlint must be run on every package. The output should be posted in
the review.
rpmlint -i ghc-ansi-terminal.spec f14/ghc-ansi-terminal-*.rpm
ghc-ansi-terminal.i686: W: spelling-error Summary(en_US) Haskell - Gaskell,
Gaitskell, Skellum
The value of this tag appears to be misspelled. Please double-check.
ghc-ansi-terminal.i686: W: spelling-error %description -l en_US Haskell -
Gaskell, Gaitskell, Skellum
The value of this tag appears to be misspelled. Please double-check.
ghc-ansi-terminal.src: W: spelling-error Summary(en_US) Haskell - Gaskell,
Gaitskell, Skellum
The value of this tag appears to be misspelled. Please double-check.
ghc-ansi-terminal.src: W: spelling-error %description -l en_US Haskell -
Gaskell, Gaitskell, Skellum
The value of this tag appears to be misspelled. Please double-check.
ghc-ansi-terminal-devel.i686: W: spelling-error Summary(en_US) Haskell -
Gaskell, Gaitskell, Skellum
The value of this tag appears to be misspelled. Please double-check.
ghc-ansi-terminal-devel.i686: W: spelling-error %description -l en_US Haskell
- Gaskell, Gaitskell, Skellum
The value of this tag appears to be misspelled. Please double-check.
ghc-ansi-terminal-prof.i686: E: devel-dependency ghc-ansi-terminal-devel
Your package has a dependency on a devel package but it's not a devel package
itself.
ghc-ansi-terminal-prof.i686: W: spelling-error %description -l en_US Haskell -
Gaskell, Gaitskell, Skellum
The value of this tag appears to be misspelled. Please double-check.
ghc-ansi-terminal-prof.i686: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.
ghc-ansi-terminal-prof.i686: W: devel-file-in-non-devel-package
/usr/lib/ghc-6.12.3/ansi-terminal-0.5.5/libHSansi-terminal-0.5.5_p.a
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.
4 packages and 1 specfiles checked; 1 errors, 9 warnings.
[+]MUST: The package must be named according to the Package Naming Guidelines.
[+]MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec
[+]MUST: The package must meet the Packaging Guidelines.
Naming-Yes
Version-release - Matches
License - OK
No prebuilt external bits - OK
Spec legibity - OK
Package template - OK, based on cabal2spec-0.22.2. Please upgrade to
cabal2spec 0.22.4
Arch support - OK
Libexecdir - OK
rpmlint - yes
changelogs - OK
Source url tag - OK, validated.
Buildroot is ignored - present anyway. OK, upgrade to cabal2spec 0.22.4
%clean is ignored - present anyway. OK, upgrade to cabal2spec 0.22.4
Build Requires list - OK
Summary and description - OK, patch provides modified summary and
description
API documentation - OK, in devel package (from F14 onwards)
[+]MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines .
License is BSD
[+]MUST: The License field in the package spec file must match the actual
license.
[+]MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
LICENSE file provides the license text. Packaged in base package
[+]MUST: The spec file must be written in American English.
[+]MUST: The spec file for the package MUST be legible.
[+]MUST: The sources used to build the package must match the upstream
source,as provided in the spec URL. Reviewers should use md5sum for this task.
md5sum ansi-terminal-0.5.5.tar.gz
5ad9e6561f0de1a2e98b6c72d119ea75 ansi-terminal-0.5.5.tar.gz
md5sum ghc-ansi-terminal-0.5.5-1.fc14.src/ansi-terminal-0.5.5.tar.gz
5ad9e6561f0de1a2e98b6c72d119ea75
ghc-ansi-terminal-0.5.5-1.fc14.src/ansi-terminal-0.5.5.tar.gz
[+]MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture.
Built on x86 and x86_64
[+]MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch.
[+]MUST: All build dependencies must be listed in BuildRequires.
[NA]MUST: The spec file MUST handle locales properly using the %find_lang macro
[NA]MUST: Packages stores shared library files must call ldconfig in %post and
[Bug 670701] Review Request: ghc-ansi-terminal - Haskell ansi-terminal library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=670701 Shakthi Kannan shakthim...@gmail.com changed: What|Removed |Added CC||fedora-haskell-list@redhat. ||com --- Comment #1 from Shakthi Kannan shakthim...@gmail.com 2011-01-18 21:08:19 EST --- Successful Koji builds for F-14, EL-6: http://koji.fedoraproject.org/koji/taskinfo?taskID=2730313 http://koji.fedoraproject.org/koji/taskinfo?taskID=2730314 $ rpmlint ghc-ansi-terminal.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpmlint ghc-ansi-terminal-0.5.5-1.fc14.src.rpm ghc-ansi-terminal.src: W: spelling-error Summary(en_US) Haskell - Gaskell, Gaitskell, Skellum ghc-ansi-terminal.src: W: spelling-error %description -l en_US Haskell - Gaskell, Gaitskell, Skellum 1 packages and 0 specfiles checked; 0 errors, 2 warnings. $ rpmlint ghc-ansi-terminal-0.5.5-1.fc14.i686.rpm ghc-ansi-terminal.i686: W: spelling-error Summary(en_US) Haskell - Gaskell, Gaitskell, Skellum ghc-ansi-terminal.i686: W: spelling-error %description -l en_US Haskell - Gaskell, Gaitskell, Skellum 1 packages and 0 specfiles checked; 0 errors, 2 warnings. $ rpmlint ghc-ansi-terminal-devel-0.5.5-1.fc14.i686.rpm ghc-ansi-terminal-devel.i686: W: spelling-error Summary(en_US) Haskell - Gaskell, Gaitskell, Skellum ghc-ansi-terminal-devel.i686: W: spelling-error %description -l en_US Haskell - Gaskell, Gaitskell, Skellum 1 packages and 0 specfiles checked; 0 errors, 2 warnings. $ rpmlint ghc-ansi-terminal-prof-0.5.5-1.fc14.i686.rpm ghc-ansi-terminal-prof.i686: E: devel-dependency ghc-ansi-terminal-devel ghc-ansi-terminal-prof.i686: W: spelling-error %description -l en_US Haskell - Gaskell, Gaitskell, Skellum ghc-ansi-terminal-prof.i686: W: no-documentation ghc-ansi-terminal-prof.i686: W: devel-file-in-non-devel-package /usr/lib/ghc-6.12.3/ansi-terminal-0.5.5/libHSansi-terminal-0.5.5_p.a 1 packages and 0 specfiles checked; 1 errors, 3 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 670701] Review Request: ghc-ansi-terminal - Haskell ansi-terminal library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=670701 Lakshmi Narasimhan lakshminaras2...@gmail.com changed: What|Removed |Added CC||lakshminaras2...@gmail.com AssignedTo|nob...@fedoraproject.org|lakshminaras2...@gmail.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
