[Bug 671095] Review Request: rubygem-pr_geohash - GeoHash encode/decode library for pure Ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=671095 Vít Ondruch vondr...@redhat.com changed: What|Removed |Added Status|NEW |CLOSED Resolution||RAWHIDE Last Closed||2011-02-04 06:01:30 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 671095] Review Request: rubygem-pr_geohash - GeoHash encode/decode library for pure Ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=671095 Vít Ondruch vondr...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 671095] Review Request: rubygem-pr_geohash - GeoHash encode/decode library for pure Ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=671095 --- Comment #5 from Kevin Fenzi ke...@tummy.com 2011-02-03 16:14:18 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 671095] Review Request: rubygem-pr_geohash - GeoHash encode/decode library for pure Ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=671095 Michal Fojtik mfoj...@redhat.com changed: What|Removed |Added CC||mfoj...@redhat.com AssignedTo|nob...@fedoraproject.org|mfoj...@redhat.com --- Comment #1 from Michal Fojtik mfoj...@redhat.com 2011-02-02 09:19:20 EST --- Taking this package for an review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 671095] Review Request: rubygem-pr_geohash - GeoHash encode/decode library for pure Ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=671095 Michal Fojtik mfoj...@redhat.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 671095] Review Request: rubygem-pr_geohash - GeoHash encode/decode library for pure Ruby
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=671095
Michal Fojtik mfoj...@redhat.com changed:
What|Removed |Added
Flag||fedora-review?
--- Comment #2 from Michal Fojtik mfoj...@redhat.com 2011-02-02 09:27:38 EST
---
Some notes:
Requires: rubygems = 0
Requires: ruby = 0
BuildRequires: rubygems = 0
BuildRequires: ruby = 0
'= 0' is not necessary here, you can safely omit that
Formal review:
Packages that contain Ruby Gems must be called rubygem-%{gemname} where
gemname is the name from the Gem's specification.
OK
The Source of the package must be the full URL to the released Gem archive;
the version of the package must be the Gem's version
OK
The package must have a Requires and a BuildRequires on rubygems
OK
The package must provide rubygem(%{gemname}) where gemname is the name from
the Gem's specification.
OK
For every dependency on a Gem named gemdep, the package must contain a
Requires on rubygem(%{gemdep}) with the same version constraints as the Gem
OK
The %prep and %build sections of the specfile should be empty.
OK
The Gem must be installed into %{gemdir} defined as
%global gemdir %(ruby -rubygems -e 'puts Gem::dir' 2/dev/null)
OK
The package must own the following files and directories:
%{gemdir}/gems/%{gemname}-%{version}/
%{gemdir}/cache/%{gemname}-%{version}.gem
%{gemdir}/specifications/%{gemname}-%{version}.gemspec
OK
Architecture-specific content must not be installed into %{gemdir}
OK (there is no architecture content)
If the Gem only contains pure Ruby code, it must be marked as BuildArch:
noarch.
OK
All other things looks good to me, so REVIEW+. Please fix that version markers
before you import this package to GIT.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 671095] Review Request: rubygem-pr_geohash - GeoHash encode/decode library for pure Ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=671095 --- Comment #3 from Vít Ondruch vondr...@redhat.com 2011-02-02 11:36:42 EST --- Thank you for your review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 671095] Review Request: rubygem-pr_geohash - GeoHash encode/decode library for pure Ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=671095 --- Comment #4 from Vít Ondruch vondr...@redhat.com 2011-02-02 11:38:22 EST --- New Package SCM Request === Package Name: rubygem-pr_geohash Short Description: GeoHash encode/decode library for pure Ruby Owners: vondruch Branches: InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
