[Bug 671862] Review Request: synapse - gnome-do alternative (no mono)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=671862 --- Comment #19 from Renich Bon Ciric 2011-03-31 03:42:49 EDT --- SPEC: http://renich.fedorapeople.org/SPECS/synapse.spec SRPM: http://renich.fedorapeople.org/SRPMS/synapse-0.2.4.1-3.fc14.src.rpm Changes made... I hope ;) They build fine in mock. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 671862] Review Request: synapse - gnome-do alternative (no mono)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=671862 --- Comment #18 from Renich Bon Ciric 2011-03-31 03:06:29 EDT --- woops, understood ;) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 671862] Review Request: synapse - gnome-do alternative (no mono)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=671862 --- Comment #17 from Mamoru Tasaka 2011-03-31 03:00:44 EDT --- Ah, no, I have not approved this package yet. Please make SCM request for libzeitgeist (which I already approved) first. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 671862] Review Request: synapse - gnome-do alternative (no mono)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=671862 --- Comment #16 from Renich Bon Ciric 2011-03-31 02:58:44 EDT --- New Package SCM Request === Package Name: synapse Short Description: a mono-free alternative to gnome-do Owners: renich mtasaka Branches: f14 f15 InitialCC: renich mtasaka -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 671862] Review Request: synapse - gnome-do alternative (no mono)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=671862 Mamoru Tasaka changed: What|Removed |Added Blocks|177841(FE-NEEDSPONSOR) | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 671862] Review Request: synapse - gnome-do alternative (no mono)
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=671862
Mamoru Tasaka changed:
What|Removed |Added
Status|NEW |ASSIGNED
AssignedTo|nob...@fedoraproject.org|mtas...@ioa.s.u-tokyo.ac.jp
Flag||fedora-review?
--- Comment #15 from Mamoru Tasaka 2011-03-29
14:41:05 EDT ---
For 0.2.4.1-2
* License tag
- The license tag for this package should be "GPLv3+"
* %{?_isa} specific dependency
- Packages between main pkg and subpkgs should be %?_isa specific.
i.e. synapse-devel should have
"Requires: %{name}%{?_isa} = %{version}-%{release}"
https://fedoraproject.org/wiki/Packaging/Guidelines#Requires
* BuildRoot line
- is no longer needed
* Timestamps
- Please add "-p" option to "install" (or "cp") commands when
installing files to keep timestamps on installed files.
https://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps
* %check
- It seems that currently "make check" does nothing, so this can
be removed.
* empty documents
- Unless you have some reason, emtry document files are useless
and should be removed.
> Ok. But, what if someone installs either of them? License and README should be
> in both, don't you think? Maybe the Changelog too?
- Installing -devel subpackage also installs main package because of
packages deps. So including such document files in main package is
sufficient.
> >* "INSTALL" file is generally for people who want to compile / install
> > packages by themselves and not needed for people trying to install
> > them via rpm
>
> I agree... but, since it's part of the package, maybe it shouldn't be
> omitted... maybe somebody want's to verify/upgrade/rebuild the package?
- So as I said, we verify/upgrade/rebuild a package via rpm(build)
and "INSTALL" file need not be installed.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 671862] Review Request: synapse - gnome-do alternative (no mono)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=671862 --- Comment #14 from Renich Bon Ciric 2011-03-29 02:49:58 EDT --- Ok, here are the updated spec and srpm: SPEC: http://renich.fedorapeople.org/SPECS/libzeitgeist.spec SRPM: http://renich.fedorapeople.org/SRPMS/synapse-0.2.4.1-2.fc14.src.rpm I addressed everything... I think... I hope ;=s It works fine now ;) The only thing I want to discuss is this: >* You don't need to install the same document files (in %doc) > in both main and -devel subpackages Ok. But, what if someone installs either of them? License and README should be in both, don't you think? Maybe the Changelog too? >* "INSTALL" file is generally for people who want to compile / install > packages by themselves and not needed for people trying to install > them via rpm I agree... but, since it's part of the package, maybe it shouldn't be omitted... maybe somebody want's to verify/upgrade/rebuild the package? What do you think? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 671862] Review Request: synapse - gnome-do alternative (no mono)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=671862 --- Comment #13 from Mamoru Tasaka 2011-03-28 15:16:10 EDT --- Note that if you want to build synapse with mockbuild, currently you anyway have to tweak config file under /etc/mock because libzeitgeist (listed in synapse's BR) is still under review and not in Fedora's stable repository yet. If you are unsure about how to use pkgs with mockbuild which are not yet in Fedora's repository, I can check BRs for synapse for now. So please address the issues other than BuildRequires and upload new srpm. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 671862] Review Request: synapse - gnome-do alternative (no mono)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=671862 --- Comment #12 from Mamoru Tasaka 2011-03-26 05:22:04 EDT --- (In reply to comment #11) > One question. How do I tell mock to include the vala update? If you want to use packages in testing with mock, you can edit .cfg file under /etc/mock. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 671862] Review Request: synapse - gnome-do alternative (no mono)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=671862 --- Comment #11 from Renich Bon Ciric 2011-03-25 13:40:29 EDT --- Ok. Thank you very much for the reminders and insights. I'll do my best. I will work on it tonight. One question. How do I tell mock to include the vala update? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 671862] Review Request: synapse - gnome-do alternative (no mono)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=671862 --- Comment #10 from Mamoru Tasaka 2011-03-25 06:34:35 EDT --- Some initial notes * The latest version is 0.2.4.1, please upgrade * About lauchpad bug 738153, the fix seems http://bazaar.launchpad.net/~synapse-core/synapse-project/trunk/revision/408 Please consider to apply the patch * Please make it sure that your srpm builds with mockbuild. Your srpm does not build at least without the following BRs: - BuildRequires: intltool BuildRequires: vala BuildRequires: gtk2-devel BuildRequires: libgee-devel BuildRequires: json-glib-devel BuildRequires: libgtkhotkey-devel BuildRequires: unique-devel - You may also want to add "BR: rest-devel" Also I recommend to write one (Build)Requires per line * Please address what I commented on bug 674188, like - BuildRoot: line, %clean, "rm -rf" at the first line of %install, no longer needed - %?_isa specific dependency - "V=1" on make - "INSTALL='install -p'" on make install - "-p" option for keeping timestamp Additional notes * You don't need to install the same document files (in %doc) in both main and -devel subpackages * "INSTALL" file is generally for people who want to compile / install packages by themselves and not needed for people trying to install them via rpm * For installed desktop file, icons under %_datadir/icons, please refer to: https://fedoraproject.org/wiki/Packaging/Guidelines#desktop-file-install_usage https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Icon_Cache -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 671862] Review Request: synapse - gnome-do alternative (no mono)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=671862 --- Comment #9 from Mamoru Tasaka 2011-03-25 04:17:44 EDT --- (In reply to comment #8) > Err... tried updating to 2.4.1 but it requires vala 10.4 and we have 10.3.x... > Maybe I should contact the packager? You mean that needs vala 0.10.4 (not 10.4)? On F-14 vala 0.10.4 is currently in testing. https://admin.fedoraproject.org/updates/vala-0.10.4-1.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 671862] Review Request: synapse - gnome-do alternative (no mono)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=671862 Renich Bon Ciric changed: What|Removed |Added See Also||https://launchpad.net/bugs/ ||738153 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 671862] Review Request: synapse - gnome-do alternative (no mono)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=671862 --- Comment #8 from Renich Bon Ciric 2011-03-25 04:02:35 EDT --- Err... tried updating to 2.4.1 but it requires vala 10.4 and we have 10.3.x... Maybe I should contact the packager? Anyway, this version doesn't work properly. It builds... but it causes experimental feature warnings in vala and it crashes when searching for apps. I think I should contact the vala packager in order to ask for an upgrade? Will it be possible in F14? or F15 only? SPEC: http://renich.fedorapeople.org/SPECS/synapse.spec SRPM: http://renich.fedorapeople.org/SRPMS/synapse-0.2.4-1.fc14.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 671862] Review Request: synapse - gnome-do alternative (no mono)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=671862 Mamoru Tasaka changed: What|Removed |Added CC||mtas...@ioa.s.u-tokyo.ac.jp --- Comment #7 from Mamoru Tasaka 2011-03-24 13:27:51 EDT --- Would you post the spec / srpm URLs for synapse? It seems that they cannot be found any longer. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 671862] Review Request: synapse - gnome-do alternative (no mono)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=671862 Mamoru Tasaka changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 671862] Review Request: synapse - gnome-do alternative (no mono)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=671862 --- Comment #6 from Renich Bon Ciric 2011-02-14 01:45:12 EST --- umm... the spec is here: http://renich.fedorapeople.org/SPECS/libzeitgeist.spec SRPM: http://renich.fedorapeople.org/SRPMS/libzeitgeist-0.3.2-3.fc14.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 671862] Review Request: synapse - gnome-do alternative (no mono)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=671862 Thomas Spura changed: What|Removed |Added Depends on||674188 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 671862] Review Request: synapse - gnome-do alternative (no mono)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=671862 --- Comment #5 from Renich Bon Ciric 2011-01-31 18:01:18 EST --- (In reply to comment #4) > You must open a separate review request for libzeitgeist. Done: https://bugzilla.redhat.com/show_bug.cgi?id=674188 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 671862] Review Request: synapse - gnome-do alternative (no mono)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=671862 --- Comment #4 from Fabian Affolter 2011-01-28 14:46:24 EST --- You must open a separate review request for libzeitgeist. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 671862] Review Request: synapse - gnome-do alternative (no mono)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=671862 --- Comment #3 from Renich Bon Ciric 2011-01-28 13:53:18 EST --- Ups, I'm so sorry; here they are: http://renich.fedorapeople.org/SPECS/libzeitgeist.spec http://renich.fedorapeople.org/SPECS/synapse.spec I updated this because I added more specs and forgot to notify you. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 671862] Review Request: synapse - gnome-do alternative (no mono)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=671862 Fabian Affolter changed: What|Removed |Added CC||fab...@bernewireless.net --- Comment #2 from Fabian Affolter 2011-01-28 03:18:36 EST --- Your links point to the wrong location. Please add only one package to a review request. If another package is needed as a dependency, use the 'Depends on:' bugzilla feature. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 671862] Review Request: synapse - gnome-do alternative (no mono)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=671862 --- Comment #1 from Renich Bon Ciric 2011-01-22 03:53:13 EST --- Spec URL: http://fedorapeople.org/~renich/libzeitgeist.spec SRPM URL: http://fedorapeople.org/~renich/libzeitgeist-0.3.2-1.fc14.src.rpm Description: It's a library to access zeitgeist; used by synapse. By the way, these are my first packages. Guide me into the light! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
