[Bug 672015] Review Request: perl-Eval-Closure - Safely and cleanly create closures via string eval

2011-01-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=672015

Emmanuel Seyman  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||emmanuel.seyman@club-intern
   ||et.fr
 AssignedTo|nob...@fedoraproject.org|emmanuel.seyman@club-intern
   ||et.fr
   Flag||fedora-cvs?

--- Comment #1 from Emmanuel Seyman  
2011-01-23 06:32:12 EST ---
Taking.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 672015] Review Request: perl-Eval-Closure - Safely and cleanly create closures via string eval

2011-01-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=672015

Emmanuel Seyman  changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+

--- Comment #2 from Emmanuel Seyman  
2011-01-23 07:14:41 EST ---

 - = N/A
 x = Check
 ! = Problem
 ? = Not evaluated

=== REQUIRED ITEMS ===
 [x] Package is named according to the Package Naming Guidelines.
 [x] Spec file name must match the base package %{name}, in the format
%{name}.spec.
 [x] Package meets the Packaging Guidelines including the Perl specific items
 [x] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
 Tested on: http://koji.fedoraproject.org/koji/taskinfo?taskID=2737923

 [x] Rpmlint output:

perl-Eval-Closure.src: W: spelling-error %description -l en_US inlined ->
unlined, inline, inclined
perl-Eval-Closure.src: W: spelling-error %description -l en_US accessors ->
accessory, accessorize, successors
perl-Eval-Closure.src: W: spelling-error %description -l en_US runtime -> run
time, run-time, runtish
perl-Eval-Closure.src: W: spelling-error %description -l en_US evals -> vales,
valse, evils
perl-Eval-Closure.src: W: spelling-error %description -l en_US evaled ->
evaded, evaluated, evaluate
perl-Eval-Closure.noarch: W: spelling-error %description -l en_US inlined ->
unlined, inline, inclined
perl-Eval-Closure.noarch: W: spelling-error %description -l en_US accessors ->
accessory, accessorize, successors
perl-Eval-Closure.noarch: W: spelling-error %description -l en_US runtime ->
run time, run-time, runtish
perl-Eval-Closure.noarch: W: spelling-error %description -l en_US evals ->
vales, valse, evils
perl-Eval-Closure.noarch: W: spelling-error %description -l en_US evaled ->
evaded, evaluated, evaluate
2 packages and 1 specfiles checked; 0 errors, 10 warnings.

 [x] Package is not relocatable.
 [x] Buildroot is correct

No Buildroot specified, default is used.

 [x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
 [x] License field in the package spec file matches the actual license.
 License type: GPL+ or Artistic
 [x] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
 [x] Spec file is legible and written in American English.
 [x] Sources used to build the package matches the upstream source, as provided
in the spec URL.

aba60e35313642cf0b7b40c1d94e47e3  Eval-Closure-0.01.tar.gz

 [x] Package is not known to require ExcludeArch
 [x] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
 [-] The spec file handles locales properly.
 [-] ldconfig called in %post and %postun if required.
 [x] Package must own all directories that it creates.
 [x] Package requires other packages for directories it uses.
 [x] Package does not contain duplicates in %files.
 [x] Permissions on files are set properly.
 [x] Package consistently uses macros.
 [x] Package contains code, or permissable content.
 [-] Large documentation files are in a -doc subpackage, if required.
 [-] Package uses nothing in %doc for runtime.
 [-] Header files in -devel subpackage, if present.
 [-] Static libraries in -devel subpackage, if present.
 [-] Package requires pkgconfig, if .pc files are present.
 [-] Development .so files in -devel subpackage, if present.
 [-] Fully versioned dependency in subpackages, if present.
 [-] Package does not contain any libtool archives (.la).
 [-] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
 [x] Package does not own files or directories owned by other packages.

=== SUGGESTED ITEMS ===
 [x] Latest version is packaged.
 [x] Package does not include license text files separate from upstream.
 [-] Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
 [x] Reviewer should test that the package builds in mock.
 Tested on: rawhide.x86-64
 [x] Package should compile and build into binary rpms on all supported
architectures.
 Tested on: http://koji.fedoraproject.org/koji/taskinfo?taskID=2737923
 [!] Package has a %clean section, which contains rm -fR $RPM_BUILD_ROOT.
 [?] Package functions as described.
 [-] Scriptlets must be sane, if used.
 [-] The placement of pkgconfig(.pc) files is correct.
 [-] File based requires are sane.
 [x] %check is present and the tests pass

All tests successful.
Files=11, Tests=34,  1 wallclock secs ( 0.04 usr  0.01 sys +  0.37 cusr  0.04
csys =  0.46 CPU)
Result: PASS

APPROVED.

-- 
Configure bu

[Bug 672015] Review Request: perl-Eval-Closure - Safely and cleanly create closures via string eval

2011-01-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=672015

Iain Arnell  changed:

   What|Removed |Added

   Flag|fedora-cvs+ |

--- Comment #3 from Iain Arnell  2011-01-23 11:55:10 EST ---
Thanks for the review. But your mouse seems to have drifted - you set
fedora-cvs flag, not fedora-review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 672015] Review Request: perl-Eval-Closure - Safely and cleanly create closures via string eval

2011-01-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=672015

Emmanuel Seyman  changed:

   What|Removed |Added

   Flag||fedora-review+

--- Comment #4 from Emmanuel Seyman  
2011-01-23 17:07:44 EST ---
(In reply to comment #3)
>
> Thanks for the review. But your mouse seems to have drifted - you set
> fedora-cvs flag, not fedora-review.

Has it been that long since I did a review ? Sorry about that, it's fixed now.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 672015] Review Request: perl-Eval-Closure - Safely and cleanly create closures via string eval

2011-01-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=672015

--- Comment #5 from Iain Arnell  2011-01-23 23:03:19 EST ---
New Package SCM Request
===
Package Name: perl-Eval-Closure
Short Description: Safely and cleanly create closures via string eval
Owners: iarnell
Branches: f13 f14
InitialCC: perl-sig

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 672015] Review Request: perl-Eval-Closure - Safely and cleanly create closures via string eval

2011-01-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=672015

Iain Arnell  changed:

   What|Removed |Added

   Flag||fedora-cvs?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 672015] Review Request: perl-Eval-Closure - Safely and cleanly create closures via string eval

2011-01-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=672015

--- Comment #6 from Jason Tibbitts  2011-01-24 12:46:45 EST 
---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 672015] Review Request: perl-Eval-Closure - Safely and cleanly create closures via string eval

2011-01-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=672015

--- Comment #8 from Fedora Update System  2011-01-25 
02:44:21 EST ---
perl-Eval-Closure-0.01-1.fc13 has been submitted as an update for Fedora 13.
https://admin.fedoraproject.org/updates/perl-Eval-Closure-0.01-1.fc13

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 672015] Review Request: perl-Eval-Closure - Safely and cleanly create closures via string eval

2011-01-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=672015

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 672015] Review Request: perl-Eval-Closure - Safely and cleanly create closures via string eval

2011-01-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=672015

--- Comment #7 from Fedora Update System  2011-01-25 
02:44:14 EST ---
perl-Eval-Closure-0.01-1.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/perl-Eval-Closure-0.01-1.fc14

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 672015] Review Request: perl-Eval-Closure - Safely and cleanly create closures via string eval

2011-01-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=672015

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA

--- Comment #9 from Fedora Update System  2011-01-25 
15:57:00 EST ---
perl-Eval-Closure-0.01-1.fc14 has been pushed to the Fedora 14 testing
repository.  If problems still persist, please make note of it in this bug
report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update perl-Eval-Closure'.  You can
provide feedback for this update here:
https://admin.fedoraproject.org/updates/perl-Eval-Closure-0.01-1.fc14

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 672015] Review Request: perl-Eval-Closure - Safely and cleanly create closures via string eval

2011-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=672015

--- Comment #10 from Fedora Update System  
2011-01-27 23:46:09 EST ---
perl-Eval-Closure-0.02-1.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/perl-Eval-Closure-0.02-1.fc14

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 672015] Review Request: perl-Eval-Closure - Safely and cleanly create closures via string eval

2011-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=672015

--- Comment #11 from Fedora Update System  
2011-01-27 23:46:16 EST ---
perl-Eval-Closure-0.02-1.fc13 has been submitted as an update for Fedora 13.
https://admin.fedoraproject.org/updates/perl-Eval-Closure-0.02-1.fc13

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 672015] Review Request: perl-Eval-Closure - Safely and cleanly create closures via string eval

2011-02-05 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=672015

--- Comment #12 from Fedora Update System  
2011-02-05 17:20:39 EST ---
perl-Eval-Closure-0.02-1.fc14 has been pushed to the Fedora 14 stable
repository.  If problems still persist, please make note of it in this bug
report.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 672015] Review Request: perl-Eval-Closure - Safely and cleanly create closures via string eval

2011-02-05 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=672015

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||perl-Eval-Closure-0.02-1.fc
   ||14
 Resolution||ERRATA
Last Closed||2011-02-05 17:20:44

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 672015] Review Request: perl-Eval-Closure - Safely and cleanly create closures via string eval

2011-02-05 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=672015

Fedora Update System  changed:

   What|Removed |Added

   Fixed In Version|perl-Eval-Closure-0.02-1.fc |perl-Eval-Closure-0.02-1.fc
   |14  |13

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 672015] Review Request: perl-Eval-Closure - Safely and cleanly create closures via string eval

2011-02-05 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=672015

--- Comment #13 from Fedora Update System  
2011-02-05 17:20:52 EST ---
perl-Eval-Closure-0.02-1.fc13 has been pushed to the Fedora 13 stable
repository.  If problems still persist, please make note of it in this bug
report.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review