[Bug 672845] Review Request: rubygem-net-ping - Net::Ping rubygem library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=672845 --- Comment #12 from Lukáš Zapletal l...@redhat.com 2011-04-19 04:31:57 EDT --- The package is in the rawhide. I guess it can be closed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 672845] Review Request: rubygem-net-ping - Net::Ping rubygem library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=672845 Vít Ondruch vondr...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE Last Closed||2011-04-19 05:35:19 --- Comment #13 from Vít Ondruch vondr...@redhat.com 2011-04-19 05:35:19 EDT --- Lets do it :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 672845] Review Request: rubygem-net-ping - Net::Ping rubygem library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=672845 Lukáš Zapletal l...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #10 from Lukáš Zapletal l...@redhat.com 2011-03-29 03:51:27 EDT --- New Package SCM Request === Package Name: rubygem-net-ping Short Description: Net::Ping rubygem library Owners: lzap Branches: f15 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 672845] Review Request: rubygem-net-ping - Net::Ping rubygem library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=672845 --- Comment #11 from Jason Tibbitts ti...@math.uh.edu 2011-03-29 08:10:30 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 672845] Review Request: rubygem-net-ping - Net::Ping rubygem library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=672845 Lukáš Zapletal l...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #8 from Lukáš Zapletal l...@redhat.com 2011-03-28 08:24:37 EDT --- All done. Thank you. New Package SCM Request === Package Name: rubygem-net-ping Short Description: Net::Ping rubygem library Owners: lzap Branches: f15 InitialCC: ruby-sig -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 672845] Review Request: rubygem-net-ping - Net::Ping rubygem library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=672845 --- Comment #9 from Jason Tibbitts ti...@math.uh.edu 2011-03-28 09:58:52 EDT --- This ticket is not assigned to anyone; it should be assigned to the reviewer. ruby-sig is not a valid user. Please fix and re-raise the fedora-cvs flag. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 672845] Review Request: rubygem-net-ping - Net::Ping rubygem library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=672845 Vít Ondruch vondr...@redhat.com changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|vondr...@redhat.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 672845] Review Request: rubygem-net-ping - Net::Ping rubygem library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=672845 Lukáš Zapletal l...@redhat.com changed: What|Removed |Added Flag||needinfo?(vondruch@redhat.c ||om) --- Comment #6 from Lukáš Zapletal l...@redhat.com 2011-03-18 06:45:32 EDT --- Thank to the upstream I managed to have all unit tests working (using mock server) except three: http://koji.fedoraproject.org/koji/getfile?taskID=2923113name=build.log I disabled these. http://lzap.fedorapeople.org/fedora-packaging/rubygem-net-ping/1.4.1-1/ It builds in the Koji without any problems including unit tests. http://koji.fedoraproject.org/koji/taskinfo?taskID=2923143 All remarks were also fixed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 672845] Review Request: rubygem-net-ping - Net::Ping rubygem library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=672845
Vít Ondruch vondr...@redhat.com changed:
What|Removed |Added
Flag|fedora-review?, |fedora-review+
|needinfo?(vondruch@redhat.c |
|om) |
--- Comment #7 from Vít Ondruch vondr...@redhat.com 2011-03-18 07:44:01 EDT
---
* MUST: A package must own all directories that it creates.
- Please add %dir %{geminstdir} at top of the files section to fulfill
this requirement
Please fix the error mentioned above. Otherwise, the package looks good.
APPROVED
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 672845] Review Request: rubygem-net-ping - Net::Ping rubygem library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=672845 --- Comment #5 from Lukáš Zapletal l...@redhat.com 2011-02-25 09:16:19 EST --- Waiting for the upstream. https://github.com/djberg96/net-ping/pull/3 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 672845] Review Request: rubygem-net-ping - Net::Ping rubygem library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=672845 --- Comment #4 from Lukáš Zapletal l...@redhat.com 2011-02-18 10:21:47 EST --- Vito, thanks for the review. All your remarks were included. I also created a subpackage. And you were right - it needs iputils now :-) Tests are failing on our koji due to blocked internet connectivity. Communicating with upstream about this. I will create a patch to disable these tests and upstream will possibly merge it. I will push my changes next week. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 672845] Review Request: rubygem-net-ping - Net::Ping rubygem library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=672845
Vít Ondruch vondr...@redhat.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||vondr...@redhat.com
Flag||fedora-review?
--- Comment #2 from Vít Ondruch vondr...@redhat.com 2011-02-17 11:11:30 EST
---
I am taking this one for review.
* New upstream version available
- Please try to update to the latest version available upstream. 1.4 ATM.
* License
- The code is release under Artistic 2.0 license
https://github.com/djberg96/net-ping/blob/master/README#L41
- Please update the license field accordingly:
License: Artistic 2.0
* Unnecessary macros
- The ruby_sitelib and ruby_sitearch macros are not in use in this package.
Please remove them from top of the spec file.
* Splitting out document files
- Please consider to create -doc subpackage and move the following
files / directories into -doc
---
%doc %{geminstdir}/doc/ping.txt
%doc %{gemdir}/doc/%{gemname}-%{version}
%{geminstdir}/Rakefile
%{geminstdir}/test
%{geminstdir}/net-ping.gemspec
%{geminstdir}/MANIFEST
%{geminstdir}/CHANGES
%{gemdir}/doc/%{gemname}-%{version}
---
* Cleaning
- rm -rf %{buildroot} at the top of %install is no longer needed:
https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean
* Test
- Please add build time test suite execution:
BuildRequires: rubygem(test-unit)
%check
pushd %{buildroot}%{geminstdir}
RUBYOPT=Ilib testrb2 test/test_net_ping.rb
popd
* Koji
- Build looks fine
http://koji.fedoraproject.org/koji/taskinfo?taskID=2846629
* rpmlint
- Everything OK.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 672845] Review Request: rubygem-net-ping - Net::Ping rubygem library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=672845 Lukáš Zapletal l...@redhat.com changed: What|Removed |Added Summary|Review Request: |Review Request: |rubygem-net-ping-1.3.7-1.fc |rubygem-net-ping - |14.src.rpm - Net::Ping |Net::Ping rubygem library |rubygem library | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
