[Bug 673172] Review Request: perl-Perl-Critic-Deprecated - Perl::Critic policies which have been superseded by others
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=673172 Petr Pisar changed: What|Removed |Added Blocks||673197 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 673172] Review Request: perl-Perl-Critic-Deprecated - Perl::Critic policies which have been superseded by others
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=673172 Marcela Mašláňová changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|mmasl...@redhat.com Flag||fedora-review+ --- Comment #1 from Marcela Mašláňová 2011-02-01 10:46:26 EST --- - rpmlint OK - package must be named according to Guidelines OK - spec file name must match the base package %{name} OK - package must meet the Packaging Guidelines OK - package must be licensed with Fedora approved license OK - license field must match actual license OK - text of the license in its own file must be included in %doc OK - sources must match the upstream source OK - package MUST successfully compile and build OK http://koji.fedoraproject.org/koji/taskinfo?taskID=2754775 - architecture listed in ExcludeArch MUST have a bug filed in bugzilla OK - build dependencies must be listed in BuildRequires OK - handle locales properly with %find_lang macro OK - shared library files must call ldconfig in %post(un) OK - packages must NOT bundle system libraries OK - package must own all directories that it creates OK - permissions on files must be set properly OK - package must consistently use macros OK - package must contain code, or permissable content OK - large documentation must go in a -doc OK - %doc must not affect the runtime of the application OK - header files must be in a -devel package OK - static libraries must be in a -static package OK - library files that end in .so (without suffix) must go in a -devel OK - devel package usually require base package OK - packages must NOT contain any .la libtool archives OK - GUI applications must include a %{name}.desktop file OK - packages must not own files or directories already owned by other packages OK rpm -qp --provides ~/Downloads/perl-Perl-Critic-Deprecated-1.108-1.fc15.noarch.rpm perl(Perl::Critic::Deprecated) = 1.108 perl(Perl::Critic::Policy::NamingConventions::ProhibitMixedCaseSubs) = 1.108 perl(Perl::Critic::Policy::NamingConventions::ProhibitMixedCaseVars) = 1.108 perl(Perl::Critic::Utils::PPIRegexp) = 1.108 perl-Perl-Critic-Deprecated = 1.108-1.fc15 rpm -qp --requires ~/Downloads/perl-Perl-Critic-Deprecated-1.108-1.fc15.noarch.rpm perl(:MODULE_COMPAT_5.12.3) perl(Perl::Critic::Policy) >= 1.094 perl(Perl::Critic::Utils) >= 1.094 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(CompressedFileNames) <= 3.0.4-1 perl >= 0:5.006001 perl(base) perl(Carp) perl(English) perl(Exporter) perl(PPI::Node) perl(Readonly) perl(strict) perl(warnings) rpmlib(PayloadIsXz) <= 5.2-1 ACCEPT -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 673172] Review Request: perl-Perl-Critic-Deprecated - Perl::Critic policies which have been superseded by others
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=673172 Marcela Mašláňová changed: What|Removed |Added Flag|fedora-review+ |fedora-review? --- Comment #2 from Marcela Mašláňová 2011-02-01 10:55:36 EST --- rpm -i /home/marca/Downloads/perl-Perl-Critic-Deprecated-1.108-1.fc15.noarch.rpm file /usr/share/man/man3/Perl::Critic::Utils::PPIRegexp.3pm.gz from install of perl-Perl-Critic-Deprecated-1.108-1.fc15.noarch conflicts with file from package perl-Perl-Critic-1.106-1.fc14.noarch file /usr/share/perl5/Perl/Critic/Utils/PPIRegexp.pm from install of perl-Perl-Critic-Deprecated-1.108-1.fc15.noarch conflicts with file from package perl-Perl-Critic-1.106-1.fc14.noarch You should solve this issue before pushing into Fedora. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 673172] Review Request: perl-Perl-Critic-Deprecated - Perl::Critic policies which have been superseded by others
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=673172 Ralf Corsepius changed: What|Removed |Added CC||rc040...@freenet.de --- Comment #3 from Ralf Corsepius 2011-02-01 11:02:56 EST --- OK, Marcela, seemingly you are not interested in discussing the issues @redhat.cz submitted packages are introducing and seem to prefer to implement facts, instead: This package does not install to vendor_dir: %{__perl} Build.PL installdirs=core I guess, I don't have to mention what I think of this? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 673172] Review Request: perl-Perl-Critic-Deprecated - Perl::Critic policies which have been superseded by others
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=673172 --- Comment #4 from Petr Pisar 2011-02-01 12:20:58 EST --- (In reply to comment #2) > rpm -i > /home/marca/Downloads/perl-Perl-Critic-Deprecated-1.108-1.fc15.noarch.rpm > file /usr/share/man/man3/Perl::Critic::Utils::PPIRegexp.3pm.gz from > install of perl-Perl-Critic-Deprecated-1.108-1.fc15.noarch conflicts with file > from package perl-Perl-Critic-1.106-1.fc14.noarch > file /usr/share/perl5/Perl/Critic/Utils/PPIRegexp.pm from install of > perl-Perl-Critic-Deprecated-1.108-1.fc15.noarch conflicts with file from > package perl-Perl-Critic-1.106-1.fc14.noarch > > You should solve this issue before pushing into Fedora. You have out-dated machine probably as current perl-Perl-Critic-1.111-1.fc15.noarch does not contain the module (because it's---deprecated). I'm targeting perl-Perl-Critic-Deprecated to F15 only, so I guess there is no problem. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 673172] Review Request: perl-Perl-Critic-Deprecated - Perl::Critic policies which have been superseded by others
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=673172 --- Comment #5 from Marcela Mašláňová 2011-03-02 08:08:10 EST --- (In reply to comment #4) > (In reply to comment #2) > > rpm -i > > /home/marca/Downloads/perl-Perl-Critic-Deprecated-1.108-1.fc15.noarch.rpm > > file /usr/share/man/man3/Perl::Critic::Utils::PPIRegexp.3pm.gz from > > install of perl-Perl-Critic-Deprecated-1.108-1.fc15.noarch conflicts with > > file > > from package perl-Perl-Critic-1.106-1.fc14.noarch > > file /usr/share/perl5/Perl/Critic/Utils/PPIRegexp.pm from install of > > perl-Perl-Critic-Deprecated-1.108-1.fc15.noarch conflicts with file from > > package perl-Perl-Critic-1.106-1.fc14.noarch > > > > You should solve this issue before pushing into Fedora. > You have out-dated machine probably as current > perl-Perl-Critic-1.111-1.fc15.noarch does not contain the module (because > it's---deprecated). I'm targeting perl-Perl-Critic-Deprecated to F15 only, so > I > guess there is no problem. It's working with current perl-Perl-Critic. Also could you change core back to vendor? Thank you. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 673172] Review Request: perl-Perl-Critic-Deprecated - Perl::Critic policies which have been superseded by others
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=673172 --- Comment #6 from Petr Pisar 2011-03-02 09:17:57 EST --- Installation directory reverted to vendor: Spec URL: http://ppisar.fedorapeople.org/perl-Perl-Critic-Deprecated/perl-Perl-Critic-Deprecated.spec SPRM URL: http://ppisar.fedorapeople.org/perl-Perl-Critic-Deprecated/perl-Perl-Critic-Deprecated-1.108-1.fc16.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 673172] Review Request: perl-Perl-Critic-Deprecated - Perl::Critic policies which have been superseded by others
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=673172 Marcela Mašláňová changed: What|Removed |Added Flag|fedora-review? |fedora-review+ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 673172] Review Request: perl-Perl-Critic-Deprecated - Perl::Critic policies which have been superseded by others
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=673172 Petr Pisar changed: What|Removed |Added Flag||fedora-cvs? --- Comment #7 from Petr Pisar 2011-03-07 08:38:01 EST --- New Package SCM Request === Package Name: perl-Perl-Critic-Deprecated Short Description: Perl::Critic policies which have been superseded by others Owners: ppisar, mmaslano, psabata Branches: InitialCC: perl-sig -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 673172] Review Request: perl-Perl-Critic-Deprecated - Perl::Critic policies which have been superseded by others
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=673172 --- Comment #8 from Jason Tibbitts 2011-03-07 10:25:57 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 673172] Review Request: perl-Perl-Critic-Deprecated - Perl::Critic policies which have been superseded by others
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=673172 Petr Pisar changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||perl-Perl-Critic-Deprecated ||-1.108-1.fc16 Resolution||RAWHIDE Last Closed||2011-03-07 10:51:31 --- Comment #9 from Petr Pisar 2011-03-07 10:51:31 EST --- Thank you for review and repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 673172] Review Request: perl-Perl-Critic-Deprecated - Perl::Critic policies which have been superseded by others
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=673172 Petr Pisar changed: What|Removed |Added Blocks|673197 | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review