[Bug 673784] Rename Request: mingw32-filesystem -> mingw-filesystem - Cross compiler base filesystem and environment
https://bugzilla.redhat.com/show_bug.cgi?id=673784 Erik van Pienbroek changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #35 from Erik van Pienbroek --- Package Change Request == Package Name: mingw-filesystem New Branches: el6 Owners: epienbro InitialCC: -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 673784] Rename Request: mingw32-filesystem -> mingw-filesystem - Cross compiler base filesystem and environment
https://bugzilla.redhat.com/show_bug.cgi?id=673784 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 673784] Rename Request: mingw32-filesystem -> mingw-filesystem - Cross compiler base filesystem and environment
https://bugzilla.redhat.com/show_bug.cgi?id=673784 --- Comment #36 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 673784] Rename Request: mingw32-filesystem -> mingw-filesystem - Cross compiler base filesystem and environment
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=673784 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 673784] Rename Request: mingw32-filesystem -> mingw-filesystem - Cross compiler base filesystem and environment
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=673784 --- Comment #32 from Fedora Update System 2012-02-23 14:24:01 EST --- mingw-filesystem-69-15.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/mingw-filesystem-69-15.fc17 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 673784] Rename Request: mingw32-filesystem -> mingw-filesystem - Cross compiler base filesystem and environment
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=673784 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #33 from Fedora Update System 2012-02-23 17:29:22 EST --- mingw-filesystem-69-15.fc17 has been pushed to the Fedora 17 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 673784] Rename Request: mingw32-filesystem -> mingw-filesystem - Cross compiler base filesystem and environment
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=673784 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||mingw-filesystem-69-15.fc17 Resolution||ERRATA Last Closed||2012-02-28 05:45:05 --- Comment #34 from Fedora Update System 2012-02-28 05:45:05 EST --- mingw-filesystem-69-15.fc17 has been pushed to the Fedora 17 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 673784] Rename Request: mingw32-filesystem -> mingw-filesystem - Cross compiler base filesystem and environment
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=673784 Tim Mayberry changed: What|Removed |Added CC||mojof...@gmail.com --- Comment #18 from Tim Mayberry 2011-04-10 02:36:14 EDT --- (In reply to comment #17) > After discussion with some members of the Fedora MinGW SIG we decided to drop > the 'cross-*' prefix for now and stick with 'mingw-*' as prefix. Support for > Mac OS X may take a long while to get ready (possible even never because of > the > legal issues), so we can use 'mingw-*' for now. We've also filed a ticket at > the Fedora Packaging Committee with a request to approve the (updated) draft > guidelines: https://fedorahosted.org/fpc/ticket/71 > > Updated package: > Spec URL: > http://svn.openftd.org/svn/fedora_cross/mingw-filesystem/mingw-filesystem.spec > SRPM URL: > http://ftd4linux.nl/contrib/mingw-filesystem-66-1.fc15.src.rpm > Hi, I've been trying out the new cross compiler framework from the repository located at: http://build1.openftd.org/fedora-cross/fedora-cross.repo on Fedora 14 I got an error when trying to install mingw32-curl saying there was a missing provides(wldap32.dll). So I added Provides: mingw32(wldap32.dll) to the mingw32-filesystem package(and similarly for the mingw64-filesystem package) and after rebuilding, curl would install fine. Looking at the changelog: * Thu Nov 13 2008 Richard Jones - 35-1 - Added mingw32(wldap32.dll) pseudo-provides. So it seems like it was there at some point but nothing in the changelog indicating why it is no longer. Anyway, hope this is relevant and helps. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 673784] Rename Request: mingw32-filesystem -> mingw-filesystem - Cross compiler base filesystem and environment
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=673784 --- Comment #19 from Erik van Pienbroek 2011-04-10 06:25:58 EDT --- Thanks for spotting this. I've just published an updated package: Spec URL: http://svn.openftd.org/svn/fedora_cross/mingw-filesystem/mingw-filesystem.spec SRPM URL: http://ftd4linux.nl/contrib/mingw-filesystem-67-1.fc15.src.rpm * Sun Apr 10 2011 Erik van Pienbroek - 67-1 - Merged the provides list from the Fedora mingw32-filesystem package Somehow various entries got lost -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 673784] Rename Request: mingw32-filesystem -> mingw-filesystem - Cross compiler base filesystem and environment
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=673784 --- Comment #20 from Richard W.M. Jones 2011-04-10 12:33:25 EDT --- Agreed Tim's analysis is correct. It is (was) a provides that was accidentally dropped. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 673784] Rename Request: mingw32-filesystem -> mingw-filesystem - Cross compiler base filesystem and environment
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=673784
--- Comment #21 from Erik van Pienbroek
2011-04-23 08:26:25 EDT ---
The new packaging guidelines have been approved in the FPC meeting of April 13:
http://meetbot.fedoraproject.org/fedora-meeting/2011-04-13/fpc.2011-04-13-15.59.html
In order to comply with these guidelines, some changes have been applied in the
mingw-filesystem package, so here's a new package which implements everything
mentioned in the packaging guidelines.
Spec URL:
http://svn.openftd.org/svn/fedora_cross/mingw-filesystem/mingw-filesystem.spec
SRPM URL: http://ftd4linux.nl/contrib/mingw-filesystem-68-1.fc15.src.rpm
* Thu Apr 14 2011 Erik van Pienbroek - 68-1
- Make the various macros compliant with the new packaging guidelines:
https://fedorahosted.org/fpc/ticket/71
- Dropped the macro %{_mingw_default_requires} as it isn't needed
anymore with the new guidelines
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 673784] Rename Request: mingw32-filesystem -> mingw-filesystem - Cross compiler base filesystem and environment
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=673784 Erik van Pienbroek changed: What|Removed |Added Blocks||673788 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 673784] Rename Request: mingw32-filesystem -> mingw-filesystem - Cross compiler base filesystem and environment
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=673784 Erik van Pienbroek changed: What|Removed |Added Blocks||673786 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 673784] Rename Request: mingw32-filesystem -> mingw-filesystem - Cross compiler base filesystem and environment
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=673784 Erik van Pienbroek changed: What|Removed |Added Blocks||673790 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 673784] Rename Request: mingw32-filesystem -> mingw-filesystem - Cross compiler base filesystem and environment
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=673784 Erik van Pienbroek changed: What|Removed |Added Blocks||673792 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 673784] Rename Request: mingw32-filesystem -> mingw-filesystem - Cross compiler base filesystem and environment
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=673784 --- Comment #22 from Erik van Pienbroek 2011-05-01 08:46:36 EDT --- Kalev Lember has just applied a change in the current mingw32-filesystem package. To keep everything in sync, I've also applied his change to the new mingw-filesystem package: Spec URL: http://svn.openftd.org/svn/fedora_cross/mingw-filesystem/mingw-filesystem.spec SRPM URL: http://ftd4linux.nl/contrib/mingw-filesystem-69-1.fc15.src.rpm * Sun May 01 2011 Kalev Lember - 69-1 - Override boost library suffix in cmake toolchain file -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 673784] Rename Request: mingw32-filesystem -> mingw-filesystem - Cross compiler base filesystem and environment
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=673784 Michael Cronenworth changed: What|Removed |Added Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 673784] Rename Request: mingw32-filesystem -> mingw-filesystem - Cross compiler base filesystem and environment
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=673784
Michael Cronenworth changed:
What|Removed |Added
AssignedTo|nob...@fedoraproject.org|m...@cchtml.com
Flag||needinfo?(erik-fedora@vanpi
||enbroek.nl)
--- Comment #23 from Michael Cronenworth 2011-05-05 20:32:48
EDT ---
My first review. Go easy on me!
+ OK
! needs attention
rpmlint output:
$ rpmlint mingw-filesystem mingw-filesystem-scripts mingw32-filesystem
mingw64-filesystem
mingw-filesystem.noarch: W: obsolete-not-provided cross-filesystem
mingw-filesystem.noarch: W: no-documentation
mingw-filesystem-scripts.noarch: W: obsolete-not-provided
cross-filesystem-scripts
mingw-filesystem-scripts.noarch: W: only-non-binary-in-usr-lib
mingw-filesystem-scripts.noarch: E: incorrect-fsf-address
/usr/libexec/mingw-scripts
mingw-filesystem-scripts.noarch: E: incorrect-fsf-address
/usr/share/doc/mingw-filesystem-scripts-69/COPYING
mingw32-filesystem.noarch: W: no-documentation
mingw32-filesystem.noarch: W: dangling-symlink /usr/bin/mingw32-configure
/usr/libexec/mingw-scripts
mingw32-filesystem.noarch: W: no-manual-page-for-binary mingw32-configure
mingw64-filesystem.noarch: W: no-documentation
mingw64-filesystem.noarch: W: dangling-symlink /usr/bin/mingw64-configure
/usr/libexec/mingw-scripts
mingw64-filesystem.noarch: W: no-manual-page-for-binary mingw64-configure
4 packages and 0 specfiles checked; 2 errors, 10 warnings.
I don't think the FSF address is an issue, but you may want to correct it. The
rest of the messages look harmless.
+ rpmlint output
+ The package is named according to the latest Fedora MinGW packaging
guidelines
+ The spec file name matches the package base name
+ The package meets the Packaging Guidelines
+ The package is licensed with a Fedora approved license and meets the
Licensing Guidelines.
+ The license field in the spec file matches the actual license
+ The stated license is the same as the one for the corresponding
native Fedora package
+ The package contains the license file (COPYING)
+ Spec file is written in American English
+ Spec file is legible
? Upstream sources match sources in the srpm.
They are all plain-text scripts, but where is upstream?
+ The package builds in koji
http://koji.fedoraproject.org/koji/taskinfo?taskID=3053279
n/a ExcludeArch bugs filed
+ BuildRequires look sane
n/a The spec file MUST handle locales properly
n/a ldconfig in %post and %postun
+ Package does not bundle copies of system libraries
n/a Package isn't relocatable
+ Package owns all directories it creates
+ No duplicate files in %files
+ Permissions are properly set
+ Consistent use of macros
+ The package must contain code or permissible content
n/a Large documentation files should go in -doc subpackage
+ Files marked %doc should not affect package
n/a Header files should be in -devel
Fedora MinGW guidelines allow headers in main package
n/a Static libraries should be in -static
n/a Library files that end in .so must go in a -devel package
n/a -devel must require the fully versioned base
n/a Packages should not contain libtool .la files
Fedora MinGW guidelines allow .la files
n/a Packages containing GUI apps must include %{name}.desktop file
+ Directory ownership sane
+ Filenames are valid UTF-8
If you want to, you can also remove the %clean section and the BuildRoot lines
which are also no longer required in current Fedora releases, before importing
the package to git.
http://fedoraproject.org/wiki/PackagingGuidelines#.25clean
I'll approve it once I know where the upstream is. I feel a comment should be
put where a VC system containing the scripts is. If there is no VC system then
I guess it passes. I don't see a guideline that prohibits script-only packages.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 673784] Rename Request: mingw32-filesystem -> mingw-filesystem - Cross compiler base filesystem and environment
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=673784 Kalev Lember changed: What|Removed |Added CC||ka...@smartlink.ee --- Comment #24 from Kalev Lember 2011-05-06 05:10:41 EDT --- Could you please rebase the rpm changelog on top of the current mingw32-filesystem (and keep rebasing it when there are new changes to mingw32-filesystem)? It's a bit hard to see right now what changes were accidental and what was intended. When importing the rename into Fedora, I think the changes should apply cleanly on the existing package, without rewriting much of the (Fedora package's) history. Comparing the package to the existing mingw32-filesystem, the following symlinks are no longer there. Is it intentional? /usr/bin/mingw32-cmake /usr/bin/mingw32-make /usr/bin/mingw32-pkg-config /usr/bin/mingw32-qmake-qt4 > Obsoletes: cross-filesystem <= 67-1 <= comparision doesn't work as intended here, it's better to use 'Obsoletes: cross-filesystem < 67-2' to take into account the .fcXX prefixes in release. > Requires: setup > Requires: rpm > Requires: rpmlint >= 0.85-2 These requires should surely be in the -scripts subpackage. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 673784] Rename Request: mingw32-filesystem -> mingw-filesystem - Cross compiler base filesystem and environment
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=673784 Erik van Pienbroek changed: What|Removed |Added Flag|needinfo?(erik-fedora@vanpi | |enbroek.nl) | --- Comment #25 from Erik van Pienbroek 2011-05-06 06:22:33 EDT --- Thank you both for reviewing this! Michael: Upstream for this package is the Fedora MinGW SIG. We don't have a separate VCS as we use the Fedora VCS for this The FSF rpmlint warnings have just been fixed I've kept the %clean and BuildRoot lines in so this package can also be built on EL-6. Perhaps those lines can be dropped for EL-6 packages as well, but I couldn't find any documentation about that yet. Kalev: This diverge in changelog history was caused by the fact that a long time ago (back in May 2010) I forked the mingw32 toolchain to add mingw-w64 support. Recently I tried to merge everything back together but apparently some things got lost. I've just re-added the wrapper scripts you mentioned. Wrapper scripts for the mingw-w64 part have also just been added. The original changelog has also been merged now The obsoletes and requires tags should be good now Spec URL: http://svn.openftd.org/svn/fedora_cross/mingw-filesystem/mingw-filesystem.spec SRPM URL: http://ftd4linux.nl/contrib/mingw-filesystem-70-1.fc15.src.rpm * Fri May 06 2011 Erik van Pienbroek - 70-1 - Use the correct FSF-address in some scripts - Moved some Requires tags to the mingw-filesystem-scripts subpackage - Fixed the Obsoletes tags - Re-added the wrapper scripts mingw32-cmake, mingw32-make, mingw32-pkg-config and mingw32-qmake-qt4 - Added the wrapper scripts mingw32-cmake, mingw64-make, mingw64-pkg-config, i686-w64-mingw32-pkg-config, x86_64-w64-mingw32-pkg-config and mingw64-qmake-qt4 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 673784] Rename Request: mingw32-filesystem -> mingw-filesystem - Cross compiler base filesystem and environment
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=673784
--- Comment #26 from Kalev Lember 2011-05-06 07:07:37 EDT
---
The Provides: mingw32() and Provides: mingw64() would probably look better in
alphabetical order.
Sorry for not noticing it earlier, but the Requires: setup, rpm, rpmlint and
BuildRequires: rpmlint were all dropped from mingw32-filesystem a while ago:
http://pkgs.fedoraproject.org/gitweb/?p=mingw32-filesystem.git;a=commit;h=d8bcc2f5ac2ba0cde140fe0682286dfaf5c2a2fb
http://pkgs.fedoraproject.org/gitweb/?p=mingw32-filesystem.git;a=commit;h=7034ac899f074b4bed02090fb271ecb10d7266fb
I think the rationale for NOT Requiring 'setup' and 'rpm' was that these are
all so low level packages that they are in all Fedora installations and
therefore it's not worth requiring them, similar to not requiring the
'filesystem' package.
With rpmlint there's a different story. Rpmlint used to be required dependency
because we install a file in /etc/rpmlint/. However, directory ownership
guidelines were updated a while ago and now it's perfectly fine to have
multiple directory ownership on /etc/rpmlint/ in order to avoid needlessly
dragging in the rpmlint package.
http://fedoraproject.org/wiki/PackagingGuidelines#The_directory_is_owned_by_a_package_which_is_not_required_for_your_package_to_function
I'd suggest the following changes:
-BuildRequires: rpmlint >= 0.85-2
-Requires: setup
-Requires: rpm
-Requires: rpmlint >= 0.85-2
+%dir %{_sysconfdir}/rpmlint
%config(noreplace) %{_sysconfdir}/rpmlint/mingw-rpmlint.config
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 673784] Rename Request: mingw32-filesystem -> mingw-filesystem - Cross compiler base filesystem and environment
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=673784
--- Comment #27 from Michael Cronenworth 2011-05-06 08:47:02
EDT ---
(In reply to comment #26)
> +%dir %{_sysconfdir}/rpmlint
> %config(noreplace) %{_sysconfdir}/rpmlint/mingw-rpmlint.config
Thanks for the help, Kalev.
I think for the rpmlint folder simply:
%{_sysconfdir}/rpmlint
is enough. (no %dir)
After the above fixes are applied I'll give it one more review.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 673784] Rename Request: mingw32-filesystem -> mingw-filesystem - Cross compiler base filesystem and environment
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=673784
--- Comment #28 from Erik van Pienbroek
2011-05-06 11:21:56 EDT ---
For the rpmlint folder I didn't use one global %{_sysconfdir}/rpmlint entry as
the file which is placed in that folder isn't a regular file, but a %config
file.
Spec URL:
http://svn.openftd.org/svn/fedora_cross/mingw-filesystem/mingw-filesystem.spec
SRPM URL: http://ftd4linux.nl/contrib/mingw-filesystem-71-1.fc15.src.rpm
* Fri May 06 2011 Erik van Pienbroek - 71-1
- Dropped the BR and R for setup, rpm and rpmlint as they aren't needed anymore
- Own the folder %{_sysconfdir}/rpmlint (to avoid dependency on rpmlint)
- Sorted the list with mingw32(xxx) and mingw64(xxx) provides for improved
readability
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 673784] Rename Request: mingw32-filesystem -> mingw-filesystem - Cross compiler base filesystem and environment
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=673784 Michael Cronenworth changed: What|Removed |Added Flag||fedora-review+ --- Comment #29 from Michael Cronenworth 2011-05-06 11:48:32 EDT --- Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3054732 Rpmlint: $ rpmlint mingw-filesystem mingw-filesystem-scripts mingw32-filesystem mingw64-filesystem mingw-filesystem.noarch: W: obsolete-not-provided cross-filesystem mingw-filesystem.noarch: W: no-documentation mingw-filesystem-scripts.noarch: W: obsolete-not-provided cross-filesystem-scripts mingw-filesystem-scripts.noarch: W: only-non-binary-in-usr-lib mingw-filesystem-scripts.noarch: E: incorrect-fsf-address /usr/libexec/mingw-scripts mingw32-filesystem.noarch: W: no-documentation mingw32-filesystem.noarch: W: dangling-symlink /usr/bin/mingw32-qmake-qt4 /usr/libexec/mingw-scripts mingw32-filesystem.noarch: W: dangling-symlink /usr/bin/mingw32-cmake /usr/libexec/mingw-scripts mingw32-filesystem.noarch: W: dangling-symlink /usr/bin/mingw32-configure /usr/libexec/mingw-scripts mingw32-filesystem.noarch: W: dangling-symlink /usr/bin/i686-w64-mingw32-pkg-config /usr/libexec/mingw-scripts mingw32-filesystem.noarch: W: dangling-symlink /usr/bin/mingw32-pkg-config /usr/libexec/mingw-scripts mingw32-filesystem.noarch: W: dangling-symlink /usr/bin/mingw32-make /usr/libexec/mingw-scripts mingw32-filesystem.noarch: W: no-manual-page-for-binary mingw32-make mingw32-filesystem.noarch: W: no-manual-page-for-binary i686-w64-mingw32-pkg-config mingw32-filesystem.noarch: W: no-manual-page-for-binary mingw32-qmake-qt4 mingw32-filesystem.noarch: W: no-manual-page-for-binary mingw32-cmake mingw32-filesystem.noarch: W: no-manual-page-for-binary mingw32-configure mingw32-filesystem.noarch: W: no-manual-page-for-binary mingw32-pkg-config mingw64-filesystem.noarch: W: no-documentation mingw64-filesystem.noarch: W: dangling-symlink /usr/bin/mingw64-qmake-qt4 /usr/libexec/mingw-scripts mingw64-filesystem.noarch: W: dangling-symlink /usr/bin/mingw64-configure /usr/libexec/mingw-scripts mingw64-filesystem.noarch: W: dangling-symlink /usr/bin/mingw64-make /usr/libexec/mingw-scripts mingw64-filesystem.noarch: W: dangling-symlink /usr/bin/mingw64-pkg-config /usr/libexec/mingw-scripts mingw64-filesystem.noarch: W: dangling-symlink /usr/bin/mingw64-cmake /usr/libexec/mingw-scripts mingw64-filesystem.noarch: W: dangling-symlink /usr/bin/x86_64-w64-mingw32-pkg-config /usr/libexec/mingw-scripts mingw64-filesystem.noarch: W: no-manual-page-for-binary mingw64-pkg-config mingw64-filesystem.noarch: W: no-manual-page-for-binary mingw64-make mingw64-filesystem.noarch: W: no-manual-page-for-binary x86_64-w64-mingw32-pkg-config mingw64-filesystem.noarch: W: no-manual-page-for-binary mingw64-qmake-qt4 mingw64-filesystem.noarch: W: no-manual-page-for-binary mingw64-cmake mingw64-filesystem.noarch: W: no-manual-page-for-binary mingw64-configure 4 packages and 0 specfiles checked; 1 errors, 30 warnings. Looks like there's still one FSF address issue. The man pages are obvious dupes of native tools so they aren't required. It looks good to me. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 673784] Rename Request: mingw32-filesystem -> mingw-filesystem - Cross compiler base filesystem and environment
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=673784 Erik van Pienbroek changed: What|Removed |Added Flag||fedora-cvs? --- Comment #30 from Erik van Pienbroek 2011-05-06 14:31:42 EDT --- New Package SCM Request === Package Name: mingw-filesystem Short Description: MinGW cross compiler base filesystem and environment Owners: epienbro rjones kalev Branches: InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 673784] Rename Request: mingw32-filesystem -> mingw-filesystem - Cross compiler base filesystem and environment
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=673784 --- Comment #31 from Jason Tibbitts 2011-05-10 11:14:26 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 673784] Rename Request: mingw32-filesystem -> mingw-filesystem - Cross compiler base filesystem and environment
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=673784 Erik van Pienbroek changed: What|Removed |Added Summary|Rename Request: |Rename Request: |mingw32-filesystem -> |mingw32-filesystem -> |cross-filesystem - Cross|mingw-filesystem - Cross |compiler base filesystem|compiler base filesystem |and environment |and environment -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
