[Bug 674007] Review Request: openni-primesense - PrimeSensor/Kinect Modules for OpenNI
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674007 --- Comment #16 from Fedora Update System upda...@fedoraproject.org 2011-03-18 15:26:45 EDT --- openni-primesense-5.0.0.25-0.4.git894cea01.el6 has been pushed to the Fedora EPEL 6 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 674007] Review Request: openni-primesense - PrimeSensor/Kinect Modules for OpenNI
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674007 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||openni-primesense-5.0.0.25- ||0.4.git894cea01.fc14 Resolution||ERRATA Last Closed||2011-03-17 14:53:21 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 674007] Review Request: openni-primesense - PrimeSensor/Kinect Modules for OpenNI
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674007 --- Comment #15 from Fedora Update System upda...@fedoraproject.org 2011-03-17 14:53:16 EDT --- openni-primesense-5.0.0.25-0.4.git894cea01.fc14 has been pushed to the Fedora 14 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 674007] Review Request: openni-primesense - PrimeSensor/Kinect Modules for OpenNI
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674007 --- Comment #14 from Fedora Update System upda...@fedoraproject.org 2011-03-07 21:18:13 EST --- openni-primesense-5.0.0.25-0.4.git894cea01.fc15 has been pushed to the Fedora 15 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 674007] Review Request: openni-primesense - PrimeSensor/Kinect Modules for OpenNI
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674007 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #13 from Fedora Update System upda...@fedoraproject.org 2011-03-04 04:58:23 EST --- openni-primesense-5.0.0.25-0.4.git894cea01.fc14 has been pushed to the Fedora 14 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update openni-primesense'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/openni-primesense-5.0.0.25-0.4.git894cea01.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 674007] Review Request: openni-primesense - PrimeSensor/Kinect Modules for OpenNI
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674007 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 674007] Review Request: openni-primesense - PrimeSensor/Kinect Modules for OpenNI
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674007 --- Comment #10 from Fedora Update System upda...@fedoraproject.org 2011-03-03 16:33:21 EST --- Package openni-primesense-5.0.0.25-0.4.git894cea01.fc14: * should fix your issue, * was pushed to the Fedora 14 updates-testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing openni-primesense-5.0.0.25-0.4.git894cea01.fc14' as soon as you are able to, then reboot. Please go to the following url: https://admin.fedoraproject.org/updates/openni-primesense-5.0.0.25-0.4.git894cea01.fc14 then log in and leave karma (feedback). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 674007] Review Request: openni-primesense - PrimeSensor/Kinect Modules for OpenNI
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674007 --- Comment #11 from Fedora Update System upda...@fedoraproject.org 2011-03-03 16:38:01 EST --- Package openni-primesense-5.0.0.25-0.4.git894cea01.fc15: * should fix your issue, * was pushed to the Fedora 15 updates-testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing openni-primesense-5.0.0.25-0.4.git894cea01.fc15' as soon as you are able to, then reboot. Please go to the following url: https://admin.fedoraproject.org/updates/openni-primesense-5.0.0.25-0.4.git894cea01.fc15 then log in and leave karma (feedback). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 674007] Review Request: openni-primesense - PrimeSensor/Kinect Modules for OpenNI
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674007 --- Comment #12 from Fedora Update System upda...@fedoraproject.org 2011-03-03 16:39:41 EST --- Package openni-primesense-5.0.0.25-0.4.git894cea01.el6: * should fix your issue, * was pushed to the Fedora EPEL 6 updates-testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing openni-primesense-5.0.0.25-0.4.git894cea01.el6' as soon as you are able to, then reboot. Please go to the following url: https://admin.fedoraproject.org/updates/openni-primesense-5.0.0.25-0.4.git894cea01.el6 then log in and leave karma (feedback). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 674007] Review Request: openni-primesense - PrimeSensor/Kinect Modules for OpenNI
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674007 --- Comment #9 from Jason Tibbitts ti...@math.uh.edu 2011-02-28 09:57:11 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 674007] Review Request: openni-primesense - PrimeSensor/Kinect Modules for OpenNI
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674007 Tim Niemueller t...@niemueller.de changed: What|Removed |Added Flag||fedora-cvs? --- Comment #8 from Tim Niemueller t...@niemueller.de 2011-02-27 03:49:17 EST --- New Package SCM Request === Package Name: openni-primesense Short Description: PrimeSensor/Kinect Modules for OpenNI Owners: timn Branches: f14 f15 el5 el6 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 674007] Review Request: openni-primesense - PrimeSensor/Kinect Modules for OpenNI
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674007 --- Comment #6 from Tim Niemueller t...@niemueller.de 2011-02-26 05:05:57 EST --- Spec file changed in place, new SRPM at http://fedorapeople.org/~timn/robotics/openni-primesense-5.0.0.25-0.3.git894cea01.fc14.src.rpm. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 674007] Review Request: openni-primesense - PrimeSensor/Kinect Modules for OpenNI
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674007 Rich Mattes richmat...@gmail.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #7 from Rich Mattes richmat...@gmail.com 2011-02-26 20:38:20 EST --- Great. Mockbuild now works, this package is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 674007] Review Request: openni-primesense - PrimeSensor/Kinect Modules for OpenNI
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=674007
Bug 674007 depends on bug 674006, which changed state.
Bug 674006 Summary: Review Request: openni - Library for human-machine Natural
Interaction
https://bugzilla.redhat.com/show_bug.cgi?id=674006
What|Old Value |New Value
Resolution||ERRATA
Status|ON_QA |CLOSED
--- Comment #5 from Rich Mattes richmat...@gmail.com 2011-02-22 00:58:01 EST
---
Alright, here we go. + is good, - is needs work, NA is not applicable.
MUST items:
[+]: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
$ rpmlint openni-primesense.spec ../RPMS/x86_64/openni-primesense*
openni-primesense.spec: W: invalid-url Source0:
openni-primesense-5.0.0.25-git894cea01.tar.gz
openni-primesense.x86_64: W: no-soname /usr/lib64/libXnDeviceSensorV2.so
openni-primesense.x86_64: W: no-soname /usr/lib64/libXnCore.so
openni-primesense.x86_64: W: no-soname /usr/lib64/libXnFormats.so
openni-primesense.x86_64: W: no-soname /usr/lib64/libXnDeviceFile.so
openni-primesense.x86_64: W: no-soname /usr/lib64/libXnDDK.so
openni-primesense.x86_64: W: no-manual-page-for-binary XnSensorServer
2 packages and 1 specfiles checked; 0 errors, 7 warnings.
These are all OK.
[+]: The package must be named according to the Package Naming Guidelines .
[+]: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
[+]: The package must meet the Packaging Guidelines.
[+]: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines.
[+]: The License field in the package spec file must match the actual license.
[+]: If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.
[+]: The spec file must be written in American English.
[+]: The spec file for the package must be legible.
[+]: The sources used to build the package must match the upstream source, as
provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
OK, instructions for creating snapshot are included.
[-]: The package must successfully compile and build into binary rpms on at
least one primary architecture.
Mockbuild fails with error cannot find jpeglib.h You need to add
BuildRequires: libjpeg-devel
[NA]: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch.
[+]: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines.
[NA]: The spec file must handle locales properly.
[+]: Every binary RPM package (or subpackage) which stores shared library files
(not just symlinks) in any of the dynamic linker's default paths, must call
ldconfig in %post and %postun.
[+]: Packages must NOT bundle copies of system libraries.
[NA]: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package.
[+]: A package must own all directories that it creates. If it does not create
a directory that it uses, then it should require a package which does create
that directory.
[+]: A Fedora package must not list a file more than once in the spec file's
%files listings. (Notable exception: license texts in specific situations)
[+]: Permissions on files must be set properly. Executables should be set with
executable permissions, for example. Every %files section must include a
%defattr(...) line.
[+]: Each package must consistently use macros.
[+]: The package must contain code, or permissable content.
[NA]: Large documentation files must go in a -doc subpackage. (The definition
of large is left up to the packager's best judgement, but is not restricted to
size. Large can refer to either size or quantity). [18]
[+]: If a package includes something as %doc, it must not affect the runtime of
the application.
[NA]: Header files must be in a -devel package.
[NA]: Static libraries must be in a -static package.
[NA]: If a package contains library files with a suffix (e.g. libfoo.so.1.1),
then library files that end in .so (without suffix) must go in a -devel
package.
[NA]: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency: Requires: %{name}%{?_isa} =
%{version}-%{release}
[+]: Packages must NOT contain any .la libtool
[Bug 674007] Review Request: openni-primesense - PrimeSensor/Kinect Modules for OpenNI
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674007 --- Comment #4 from Tim Niemueller t...@niemueller.de 2011-02-19 06:14:19 EST --- (In reply to comment #3) openni-primesense.x86_64: E: setuid-binary /usr/bin/XnSensorServer root 04755L openni-primesense.x86_64: E: non-standard-executable-perm /usr/bin/XnSensorServer 04755L Why does the sensor server binary need a setuid bit? Device permissions should be handled by the udev rule, is there some other reason it needs to be there? That is, indeed, not required anymore. Fixed, it had to be that way before I used the udev rules and I had changed that locally already. openni-primesense.x86_64: W: log-files-without-logrotate /var/log/primesense If there are going to be logs accumulating, you should have a rule to rotate and delete them every so often. It looks like XnSensorServer is creating a folder called XnSensorServer under /var/log/primesense, but I can't get it to add any logfiles. I think they are overwritten, and to use them you need to configure them from your application within OpenNI. The XnSensorServer is started automatically once you request the corresponding device node. A few other things: * The udev rules file mixes ATTRS and SYSFS. SYSFS generates a lot of warning messages at bootup, you should switch to using ATTRS consistently. Fixed. It's the way it came from ROS. * The package has a udev rule, so it needs a Requires: on udev Done. * LibJPEG is bundled with openni-primesense, in Source/External. This should be removed in setup. Done. Uncovered an explicit include External/LibJPEG/jpeglib.h. Really, how do companies survive that have programmers doing stuff like this, and producing code with a virtually infinite number of warnings. Well, it works nevertheless... * The README file doesn't contain any useful end-user information, it's just instructions for building and installing. You don't need to include it as documentation. Removed. Spec file changed in place, new SRPM is at http://fedorapeople.org/~timn/robotics/openni-primesense-5.0.0.25-0.2.git894cea01.fc14.src.rpm. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 674007] Review Request: openni-primesense - PrimeSensor/Kinect Modules for OpenNI
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=674007
--- Comment #3 from Rich Mattes richmat...@gmail.com 2011-02-14 21:34:25 EST
---
I'm getting the following output from rpmlint:
$ rpmlint openni-primesense.spec ../RPMS/x86_64/openni-primesense-*
openni-primesense.spec: W: invalid-url Source0:
openni-primesense-5.0.0.25-git894cea01.tar.gz
OK
openni-primesense.x86_64: W: incoherent-version-in-changelog
5.0.0.24-0.1gitc0e70ea1 ['5.0.0.25-0.1_git894cea01.fc14',
'5.0.0.25-0.1_git894cea01']
The Release: field should read 0.1.git%{gitrev}%{?dist} and changelog entry
should read 5.0.0.24-0.1.gitc0e70ea1 as per the examples given in
http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Pre-Release_packages
(the SVN snapshots examples are most relevant here)
openni-primesense.x86_64: W: no-soname /usr/lib64/libXnDeviceSensorV2.so
openni-primesense.x86_64: W: no-soname /usr/lib64/libXnCore.so
openni-primesense.x86_64: W: no-soname /usr/lib64/libXnFormats.so
openni-primesense.x86_64: W: no-soname /usr/lib64/libXnDeviceFile.so
openni-primesense.x86_64: W: no-soname /usr/lib64/libXnDDK.so
If these are plugin libraries akin to the openni package, this should be ok.
openni-primesense.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/openni-primesense-5.0.0.25/LGPL.txt
openni-primesense.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/openni-primesense-5.0.0.25/README
dos2unix or sed can fix these.
openni-primesense.x86_64: E: setuid-binary /usr/bin/XnSensorServer root 04755L
openni-primesense.x86_64: E: non-standard-executable-perm
/usr/bin/XnSensorServer 04755L
Why does the sensor server binary need a setuid bit? Device permissions should
be handled by the udev rule, is there some other reason it needs to be there?
openni-primesense.x86_64: W: log-files-without-logrotate /var/log/primesense
If there are going to be logs accumulating, you should have a rule to rotate
and delete them every so often. It looks like XnSensorServer is creating a
folder called XnSensorServer under /var/log/primesense, but I can't get it to
add any logfiles.
openni-primesense.x86_64: W: no-manual-page-for-binary XnSensorServer
This is OK
2 packages and 1 specfiles checked; 2 errors, 11 warnings.
A few other things:
* The udev rules file mixes ATTRS and SYSFS. SYSFS generates a lot of warning
messages at bootup, you should switch to using ATTRS consistently.
* The package has a udev rule, so it needs a Requires: on udev
* LibJPEG is bundled with openni-primesense, in Source/External. This should
be removed in setup.
* The README file doesn't contain any useful end-user information, it's just
instructions for building and installing. You don't need to include it as
documentation.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 674007] Review Request: openni-primesense - PrimeSensor/Kinect Modules for OpenNI
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674007 Tim Niemueller t...@niemueller.de changed: What|Removed |Added Flag|fedora-review? | --- Comment #1 from Tim Niemueller t...@niemueller.de 2011-02-02 16:57:33 EST --- Oops, must be set by reviewer. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 674007] Review Request: openni-primesense - PrimeSensor/Kinect Modules for OpenNI
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674007 Tim Niemueller t...@niemueller.de changed: What|Removed |Added Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 674007] Review Request: openni-primesense - PrimeSensor/Kinect Modules for OpenNI
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674007 Rich Mattes richmat...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||richmat...@gmail.com AssignedTo|nob...@fedoraproject.org|richmat...@gmail.com Flag||fedora-review? --- Comment #2 from Rich Mattes richmat...@gmail.com 2011-02-02 18:51:54 EST --- I will handle this review once OpenNI is approved. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 674007] Review Request: openni-primesense - PrimeSensor/Kinect Modules for OpenNI
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674007 Tim Niemueller t...@niemueller.de changed: What|Removed |Added Depends on||674006 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
