[Bug 674009] Review Request: bitten - A continuous integration plugin for Trac
https://bugzilla.redhat.com/show_bug.cgi?id=674009 Tim Niemueller t...@niemueller.de changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #16 from Tim Niemueller t...@niemueller.de --- Package Change Request == Package Name: bitten New Branches: epel7 Owners: timn -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 674009] Review Request: bitten - A continuous integration plugin for Trac
https://bugzilla.redhat.com/show_bug.cgi?id=674009 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 674009] Review Request: bitten - A continuous integration plugin for Trac
https://bugzilla.redhat.com/show_bug.cgi?id=674009 --- Comment #17 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 674009] Review Request: bitten - A continuous integration plugin for Trac
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674009 --- Comment #14 from Fedora Update System upda...@fedoraproject.org 2011-03-10 12:24:17 EST --- bitten-0.6b3-0.3.el5 has been pushed to the Fedora EPEL 5 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 674009] Review Request: bitten - A continuous integration plugin for Trac
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674009 --- Comment #15 from Fedora Update System upda...@fedoraproject.org 2011-03-10 12:26:45 EST --- bitten-0.6b3-0.3.el6 has been pushed to the Fedora EPEL 6 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 674009] Review Request: bitten - A continuous integration plugin for Trac
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674009 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||bitten-0.6b3-0.3.fc14 Resolution||ERRATA Last Closed||2011-03-04 04:53:20 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 674009] Review Request: bitten - A continuous integration plugin for Trac
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674009 --- Comment #13 from Fedora Update System upda...@fedoraproject.org 2011-03-04 04:53:15 EST --- bitten-0.6b3-0.3.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 674009] Review Request: bitten - A continuous integration plugin for Trac
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674009 --- Comment #12 from Fedora Update System upda...@fedoraproject.org 2011-03-02 22:14:21 EST --- bitten-0.6b3-0.3.fc15 has been pushed to the Fedora 15 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 674009] Review Request: bitten - A continuous integration plugin for Trac
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674009 --- Comment #9 from Fedora Update System upda...@fedoraproject.org 2011-02-23 06:18:04 EST --- bitten-0.6b3-0.3.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/bitten-0.6b3-0.3.el5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 674009] Review Request: bitten - A continuous integration plugin for Trac
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674009 --- Comment #8 from Fedora Update System upda...@fedoraproject.org 2011-02-23 06:17:24 EST --- bitten-0.6b3-0.3.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/bitten-0.6b3-0.3.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 674009] Review Request: bitten - A continuous integration plugin for Trac
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674009 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 674009] Review Request: bitten - A continuous integration plugin for Trac
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674009 --- Comment #7 from Fedora Update System upda...@fedoraproject.org 2011-02-23 06:16:48 EST --- bitten-0.6b3-0.3.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/bitten-0.6b3-0.3.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 674009] Review Request: bitten - A continuous integration plugin for Trac
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674009 --- Comment #10 from Fedora Update System upda...@fedoraproject.org 2011-02-23 06:21:05 EST --- bitten-0.6b3-0.3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/bitten-0.6b3-0.3.el6 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 674009] Review Request: bitten - A continuous integration plugin for Trac
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674009 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #11 from Fedora Update System upda...@fedoraproject.org 2011-02-24 01:28:31 EST --- bitten-0.6b3-0.3.fc14 has been pushed to the Fedora 14 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update bitten'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/bitten-0.6b3-0.3.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 674009] Review Request: bitten - A continuous integration plugin for Trac
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674009 --- Comment #6 from Jason Tibbitts ti...@math.uh.edu 2011-02-21 15:30:17 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 674009] Review Request: bitten - A continuous integration plugin for Trac
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674009 Peter Lemenkov lemen...@gmail.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #4 from Peter Lemenkov lemen...@gmail.com 2011-02-20 07:31:05 EST --- OK, looks good now. I can't find any other issues, so this package is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 674009] Review Request: bitten - A continuous integration plugin for Trac
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674009 Tim Niemueller t...@niemueller.de changed: What|Removed |Added Flag||fedora-cvs? --- Comment #5 from Tim Niemueller t...@niemueller.de 2011-02-20 08:57:36 EST --- Thanks for the thorough review. New Package SCM Request === Package Name: bitten Short Description: A continuous integration plugin for Trac Owners: timn Branches: f14 f15 el5 el6 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 674009] Review Request: bitten - A continuous integration plugin for Trac
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674009 --- Comment #3 from Tim Niemueller t...@niemueller.de 2011-02-19 10:00:30 EST --- I have modified the postun script to print a reminder that the user should be deleted if no longer used. Updated spec in place, new SRPM is at http://fedorapeople.org/~timn/bitten/bitten-0.6b3-0.2.fc14.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 674009] Review Request: bitten - A continuous integration plugin for Trac
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=674009
--- Comment #2 from Peter Lemenkov lemen...@gmail.com 2011-02-13 04:20:47 EST
---
Koji scratchbuild for F-15:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2836716
REVIEW:
Legend: + = PASSED, - = FAILED, 0 = Not Applicable
+/- rpmlint is NOT silent
sulaco ~: rpmlint Desktop/bitten-*
bitten.src: W: spelling-error Summary(en_US) plugin - plug in, plug-in,
plugging
bitten-master.noarch: W: spelling-error Summary(en_US) plugin - plug in,
plug-in, plugging
bitten-master.noarch: W: no-documentation
bitten-master.noarch: E: script-without-shebang
/usr/lib/python2.7/site-packages/bitten/templates/bitten_admin_configs.html
bitten-master.noarch: E: script-without-shebang
/usr/lib/python2.7/site-packages/bitten/templates/bitten_config.html
bitten-master.noarch: E: script-without-shebang
/usr/lib/python2.7/site-packages/bitten/templates/bitten_summary_coverage.html
bitten-master.noarch: E: script-without-shebang
/usr/lib/python2.7/site-packages/bitten/templates/bitten_admin_master.html
bitten-master.noarch: E: script-without-shebang
/usr/lib/python2.7/site-packages/bitten/templates/bitten_summary_tests.html
bitten-master.noarch: E: script-without-shebang
/usr/lib/python2.7/site-packages/bitten/templates/bitten_build.html
bitten-slave.noarch: W: no-documentation
bitten-slave.noarch: E: non-readable /etc/bitten-slave.conf 0640
bitten-slave.noarch: W: no-manual-page-for-binary bitten-slave
^^^ these messages already explained in the comment above.
bitten-slave.noarch: W: dangerous-command-in-%postun userdel
^^^ Deleting users automatically is a very very bad practice and should be
omitted entirely. I strongly encourage you to remove the '%postun slave'
section entirely. Let system administrator to decide whether or not to remove
users from the system.
4 packages and 0 specfiles checked; 7 errors, 6 warnings.
sulaco ~:
+ The package is named according to the Package Naming Guidelines.
+ The spec file name matches the base package %{name}, in the format
%{name}.spec.
+ The package meets the Packaging Guidelines.
+ The package is licensed with a Fedora approved license and meets the
Licensing Guidelines.
+ The License field in the package spec file matches the actual license
(3-clause BSD).
+ The file, containing the text of the license(s) for the package, is included
in %doc.
+ The spec file is written in American English.
+ The spec file for the package is legible.
+ The sources used to build the package, match the upstream source, as provided
in the spec URL.
sulaco ~/rpmbuild/SOURCES: sha256sum Bitten-0.6b3.tar.gz*
d3167fe928bb8d61e4367d71a6c286915c58f435b155c1886e0fea141f0501a8
Bitten-0.6b3.tar.gz
d3167fe928bb8d61e4367d71a6c286915c58f435b155c1886e0fea141f0501a8
Bitten-0.6b3.tar.gz.1
sulaco ~/rpmbuild/SOURCES:
+ The package successfully compiles and builds into binary rpms on at least one
primary architecture. See koji links above.
+ All build dependencies are listed in BuildRequires.
0 No need to handle locales.
0 No shared library files.
+ The package does NOT bundle copies of system libraries.
+ The package is not designed to be relocatable.
+ The package owns all directories that it creates.
+ The package does not list a file more than once in the spec file's %files
listings.
+ Permissions on files are set properly.
+ The package has a %clean section, which contains rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
+ The package consistently uses macros.
+ The package contains code, or permissible content.
0 No extremely large documentation files.
+ Anything, the package includes as %doc, does not affect the runtime of the
application.
0 No header files.
0 No static libraries.
0 No pkgconfig(.pc) files.
0 The package doesn't contain library files with a suffix (e.g. libfoo.so.1.1).
0 No devel sub-package.
+ The package does NOT contain any .la libtool archives.
0 Not a GUI application.
+ The package does not own files or directories already owned by other
packages.
+ At the beginning of %install, the package runs rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
+ All filenames in rpm packages are valid UTF-8.
Ok, the only issue is the user removal during uninstalling - please, remove it.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 674009] Review Request: bitten - A continuous integration plugin for Trac
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674009 Peter Lemenkov lemen...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||lemen...@gmail.com AssignedTo|nob...@fedoraproject.org|lemen...@gmail.com Flag||fedora-review? --- Comment #1 from Peter Lemenkov lemen...@gmail.com 2011-02-02 16:01:01 EST --- I'll review it -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
