[Bug 674060] Review Request: rubygem-deltacloud-core - Deltacloud REST API

2011-02-04 Thread bugzilla 
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=674060

--- Comment #4 from Michal Fojtik mfoj...@redhat.com 2011-02-04 06:02:33 EST 
---
(In reply to comment #3)
 * Check
   - pushd ./%{geminstdir} is not stepping into the correct directory. 
 The right one is: pushd %{buildroot}%{geminstdir}

AFAIK it's stepping to buildroot, but I replaced ./ with that macro just for
sure. Thanks for noticing that.

 * Shipping external project
   - This gem bundles external project in support folder. On Fedora shipping
 external project in the same package should (must) be avoided, see:

Ouch, sorry I built that gem in support directory so there was some leftovers.
It should be fixed now.

 https://fedoraproject.org/wiki/Packaging/Guidelines#Bundling_of_multiple_projects
 
 * Missing dependencies
   - Since this is Sinatra application, there have to be specified 
 appropriate dependencies:
 
 Require: rubygem(sinatra)
 BuildRequire: rubygem(sinatra)

Require: rubygem(sinatra) was already here but it was missing in BuildRequire.
Should be fixed now.

   - Missing rubygem-net-ssh dependency. Not sure if it is runtime 
 or just development dependency

That's right, thanks for corrections.

 
   - There are missing plenty of others, such as rack. Please test using mock.

Should be fixed now. Note that other dependencies like 'rubygem-aws' are not
'runtime' dependencies but they are optional. Eg. for using EC2 or other cloud
providers.

 * rpmlint output:
   - Is this package ahead of upstream?
 
 $ rpmlint rubygem-deltacloud-core.spec 
 rubygem-deltacloud-core.spec: W: invalid-url Source0:
   http://gems.rubyforge.org/gems/deltacloud-core-0.2.0.gem 
   HTTP Error 404: Not Found
 0 packages and 1 specfiles checked; 0 errors, 1 warnings.

Yes, I'll need to wait with importing until this package will be available in
upstream (which should happen in next few days).

 
 I am not going forward with this review, since I cannot build on my 
 environment
 due to missing dependencies.

=== v0.2.0-2 ==

Spec URL: http://mifo.sk/RPMS/deltacloud-core.spec
SRPM URL: http://mifo.sk/RPMS/deltacloud-core-0.2.0-2.fc14.src.rpm

Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2761635

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 674060] Review Request: rubygem-deltacloud-core - Deltacloud REST API

2011-02-02 Thread bugzilla 
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=674060

Vít Ondruch vondr...@redhat.com changed:

   What|Removed |Added

 CC||vondr...@redhat.com
 AssignedTo|nob...@fedoraproject.org|vondr...@redhat.com
   Flag||fedora-review?

--- Comment #2 from Vít Ondruch vondr...@redhat.com 2011-02-02 10:27:44 EST 
---
I am taking this one.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 674060] Review Request: rubygem-deltacloud-core - Deltacloud REST API

2011-02-02 Thread bugzilla 
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=674060

Vít Ondruch vondr...@redhat.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 674060] Review Request: rubygem-deltacloud-core - Deltacloud REST API

2011-02-02 Thread bugzilla 
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=674060

--- Comment #3 from Vít Ondruch vondr...@redhat.com 2011-02-02 11:05:25 EST 
---
* Check
  - pushd ./%{geminstdir} is not stepping into the correct directory. 
The right one is: pushd %{buildroot}%{geminstdir}

* Shipping external project
  - This gem bundles external project in support folder. On Fedora shipping
external project in the same package should (must) be avoided, see:

   
https://fedoraproject.org/wiki/Packaging/Guidelines#Bundling_of_multiple_projects

* Missing dependencies
  - Since this is Sinatra application, there have to be specified 
appropriate dependencies:

Require: rubygem(sinatra)
BuildRequire: rubygem(sinatra)

  - Missing rubygem-net-ssh dependency. Not sure if it is runtime 
or just development dependency

  - There are missing plenty of others, such as rack. Please test using mock.

* rpmlint output:
  - Is this package ahead of upstream?

$ rpmlint rubygem-deltacloud-core.spec 
rubygem-deltacloud-core.spec: W: invalid-url Source0:
  http://gems.rubyforge.org/gems/deltacloud-core-0.2.0.gem 
  HTTP Error 404: Not Found
0 packages and 1 specfiles checked; 0 errors, 1 warnings.


I am not going forward with this review, since I cannot build on my environment
due to missing dependencies.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 674060] Review Request: rubygem-deltacloud-core - Deltacloud REST API

2011-02-01 Thread bugzilla 
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=674060

Michal Fojtik mfoj...@redhat.com changed:

   What|Removed |Added

   See Also||https://bugzilla.redhat.com
   ||/show_bug.cgi?id=641400

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 674060] Review Request: rubygem-deltacloud-core - Deltacloud REST API

2011-01-31 Thread bugzilla 
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=674060

--- Comment #1 from Michal Fojtik mfoj...@redhat.com 2011-01-31 09:21:44 EST 
---
rpmlint:

rubygem-deltacloud-core.noarch: W: no-documentation

 - There is a -doc subpackage

rubygem-deltacloud-core.noarch: W: no-manual-page-for-binary deltacloudd

 - Non blocker (?)

rubygem-deltacloud-core.noarch: W: incoherent-init-script-name deltacloud-core
('rubygem-deltacloud-core', 'rubygem-deltacloud-cored')

  - Well, I think for user it's better to keep 'gemname' as a init script name
to avoid confusion. I think there are two options, first to keep name of this
package (rubygem-deltacloud-core) and keep init script name as it is, or second
to rename whole package to 'deltacloud-core'. What do you think ?

1 packages and 0 specfiles checked; 0 errors, 3 warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review