[Bug 674587] Review Request: rubygem-sqlite3 - Allows Ruby scripts to interface with a SQLite3 database
https://bugzilla.redhat.com/show_bug.cgi?id=674587 Troy Dawson changed: What|Removed |Added CC||tdaw...@redhat.com Flags|fedora-cvs+ |fedora-cvs? --- Comment #7 from Troy Dawson --- Package Change Request == Package Name: rubygem-sqlite3 New Branches: epel7 Owners: tdawson -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 674587] Review Request: rubygem-sqlite3 - Allows Ruby scripts to interface with a SQLite3 database
https://bugzilla.redhat.com/show_bug.cgi?id=674587 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 674587] Review Request: rubygem-sqlite3 - Allows Ruby scripts to interface with a SQLite3 database
https://bugzilla.redhat.com/show_bug.cgi?id=674587 --- Comment #8 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 674587] Review Request: rubygem-sqlite3 - Allows Ruby scripts to interface with a SQLite3 database
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674587 Vít Ondruch changed: What|Removed |Added Blocks||667954 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 674587] Review Request: rubygem-sqlite3 - Allows Ruby scripts to interface with a SQLite3 database
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=674587
Mohammed Morsi changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||mmo...@redhat.com
AssignedTo|nob...@fedoraproject.org|mmo...@redhat.com
Flag||fedora-review?
--- Comment #1 from Mohammed Morsi 2011-02-02 14:54:03 EST
---
Will take this one. The package builds fine in koji. Most review guidelines
pass except for the following
* URL and Source0 are wrong, still referring to the sqlite3-ruby package ones,
please update to new locations: http://rubygems.org/gems/sqlite3
* you can remove the BuildRoot tag and the "rm -rf %{buildroot}" at the
beginning of %install
* please change "%define ruby_sitearch" to "%global ruby_sitearch" at the top
of the spec file
* rpmlint looks good
> $ rpmlint rpmbuild/RPMS/x86_64/rubygem-sqlite3-*
> rpmbuild/SRPMS/rubygem-sqlite3-1.3.3-1.fc14.src.rpm
> rubygem-sqlite3.x86_64: I: enchant-dictionary-not-found en_US
Can be ignored
> rubygem-sqlite3.x86_64: W: obsolete-not-provided rubygem-sqlite3-ruby
Believe this is what we intend and can be ignored.
> rubygem-sqlite3-doc.x86_64: W: unexpanded-macro
> /usr/lib/ruby/gems/1.8/doc/sqlite3-1.3.3/ri/SQLite3/Database/authorizer%3d-i.yaml
> %3d
Can be ignored
> rubygem-sqlite3.src:22: W: unversioned-explicit-obsoletes rubygem-sqlite3-ruby
I believe we can ignore this as we should retire the rubygem-sqlite3-ruby
package after this.
Everything else looks good.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 674587] Review Request: rubygem-sqlite3 - Allows Ruby scripts to interface with a SQLite3 database
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674587 --- Comment #2 from Mamoru Tasaka 2011-02-03 04:04:32 EST --- (In reply to comment #1) > > > rubygem-sqlite3.src:22: W: unversioned-explicit-obsoletes > > rubygem-sqlite3-ruby > > I believe we can ignore this as we should retire the rubygem-sqlite3-ruby > package after this. > Well, the upstream may change his thought again and may change the name (although unlikely), so adding version to Obsoletes like "Obsoletes: rubygem-sqlite3-ruby < 1.3.3" is anyway safer (and adding the version should cause no problem). Note that missing version on Obsoletes has causes some nasty problems in the past on other package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 674587] Review Request: rubygem-sqlite3 - Allows Ruby scripts to interface with a SQLite3 database
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=674587
--- Comment #3 from Vít Ondruch 2011-02-03 05:27:31 EST
---
(In reply to comment #1)
> Will take this one. The package builds fine in koji. Most review guidelines
> pass except for the following
>
> * URL and Source0 are wrong, still referring to the sqlite3-ruby package ones,
> please update to new locations: http://rubygems.org/gems/sqlite3
I have updated the Source0 link, however I updated the URL just slightly, still
left it pointing to rubyforge as long as it is not clear what is homepage of
this project. I have risen upstream ticket for clarification:
https://github.com/luislavena/sqlite3-ruby/issues/issue/26
> * you can remove the BuildRoot tag and the "rm -rf %{buildroot}" at the
> beginning of %install
Done
> * please change "%define ruby_sitearch" to "%global ruby_sitearch" at the top
> of the spec file
Done
> * rpmlint looks good
>
> > $ rpmlint rpmbuild/RPMS/x86_64/rubygem-sqlite3-*
> > rpmbuild/SRPMS/rubygem-sqlite3-1.3.3-1.fc14.src.rpm
> > rubygem-sqlite3.x86_64: I: enchant-dictionary-not-found en_US
>
> Can be ignored
>
> > rubygem-sqlite3.x86_64: W: obsolete-not-provided rubygem-sqlite3-ruby
>
> Believe this is what we intend and can be ignored.
>
> > rubygem-sqlite3-doc.x86_64: W: unexpanded-macro
> > /usr/lib/ruby/gems/1.8/doc/sqlite3-1.3.3/ri/SQLite3/Database/authorizer%3d-i.yaml
> > %3d
>
> Can be ignored
>
> > rubygem-sqlite3.src:22: W: unversioned-explicit-obsoletes
> > rubygem-sqlite3-ruby
>
> I believe we can ignore this as we should retire the rubygem-sqlite3-ruby
> package after this.
Version added according to Mamoru's hint. However now, rpmlint complains:
rubygem-sqlite3.x86_64: W: obsolete-not-provided rubygem-sqlite3-ruby
This should be probably ignored as Mamoru stated in email:
- on rawhide (on rawhide only) rubygem-sqlite3 should obsolete
rubygem-sqlite3-ruby (Provides: rubygem(sqlite3-ruby) should _not_ be added
to rubygem-sqlite3, just obsolete rubygem-sqlite3-ruby)
and I am going to push this gem just for rawhide.
> Everything else looks good.
Spec URL: http://people.redhat.com/vondruch/rubygem-sqlite3.spec
SRPM URL:
http://people.redhat.com/vondruch/rubygem-sqlite3-1.3.3-2.fc14.src.rpm
Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2759569
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 674587] Review Request: rubygem-sqlite3 - Allows Ruby scripts to interface with a SQLite3 database
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674587 Mohammed Morsi changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #4 from Mohammed Morsi 2011-02-03 12:05:54 EST --- (In reply to comment #3) > (In reply to comment #1) > > Will take this one. The package builds fine in koji. Most review guidelines > > pass except for the following > > > > * URL and Source0 are wrong, still referring to the sqlite3-ruby package > > ones, > > please update to new locations: http://rubygems.org/gems/sqlite3 > > I have updated the Source0 link, however I updated the URL just slightly, > still > left it pointing to rubyforge as long as it is not clear what is homepage of > this project. I have risen upstream ticket for clarification: > https://github.com/luislavena/sqlite3-ruby/issues/issue/26 > Hrm ok, but 'homepage' for the project at http://rubygems.org/gems/sqlite3 points to https://github.com/luislavena/sqlite3-ruby . Please consider changing this before pushing (or once the upstream bug you filed is resolved). > Version added according to Mamoru's hint. However now, rpmlint complains: > rubygem-sqlite3.x86_64: W: obsolete-not-provided rubygem-sqlite3-ruby > > This should be probably ignored as Mamoru stated in email: > > - on rawhide (on rawhide only) rubygem-sqlite3 should obsolete > rubygem-sqlite3-ruby (Provides: rubygem(sqlite3-ruby) should _not_ be added > to rubygem-sqlite3, just obsolete rubygem-sqlite3-ruby) > > and I am going to push this gem just for rawhide. Sounds good. > > Spec URL: http://people.redhat.com/vondruch/rubygem-sqlite3.spec > SRPM URL: > http://people.redhat.com/vondruch/rubygem-sqlite3-1.3.3-2.fc14.src.rpm > > Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2759569 This Koji url refers to the -1 build, I verified -2 works as well http://koji.fedoraproject.org/koji/taskinfo?taskID=2760161 Everything looks good. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 674587] Review Request: rubygem-sqlite3 - Allows Ruby scripts to interface with a SQLite3 database
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674587 Vít Ondruch changed: What|Removed |Added Flag||fedora-cvs? --- Comment #5 from Vít Ondruch 2011-02-04 02:58:35 EST --- Thank you for your review! New Package SCM Request === Package Name: rubygem-sqlite3 Short Description: Allows Ruby scripts to interface with a SQLite3 database Owners: vondruch Branches: InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 674587] Review Request: rubygem-sqlite3 - Allows Ruby scripts to interface with a SQLite3 database
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674587 --- Comment #6 from Kevin Fenzi 2011-02-06 17:54:43 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 674587] Review Request: rubygem-sqlite3 - Allows Ruby scripts to interface with a SQLite3 database
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674587 Vít Ondruch changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE Last Closed||2011-02-07 00:29:41 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
