[Bug 674673] Review Request: lovelock-backgrounds - Lovelock desktop backgrounds
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674673 Martin Sourada martin.sour...@gmail.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE Last Closed||2011-02-06 10:13:09 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 674673] Review Request: lovelock-backgrounds - Lovelock desktop backgrounds
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674673 --- Comment #4 from Martin Sourada martin.sour...@gmail.com 2011-02-03 03:30:54 EST --- Thanks for the quick review :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 674673] Review Request: lovelock-backgrounds - Lovelock desktop backgrounds
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674673 Martin Sourada martin.sour...@gmail.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #5 from Martin Sourada martin.sour...@gmail.com 2011-02-03 03:33:50 EST --- New Package SCM Request === Package Name: lovelock-backgrounds Short Description: Lovelock desktop backgrounds Owners: mso Branches: InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 674673] Review Request: lovelock-backgrounds - Lovelock desktop backgrounds
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674673 --- Comment #6 from Kevin Fenzi ke...@tummy.com 2011-02-03 16:21:38 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 674673] Review Request: lovelock-backgrounds - Lovelock desktop backgrounds
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674673 Tim Lauridsen t...@rasmil.dk changed: What|Removed |Added Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 674673] Review Request: lovelock-backgrounds - Lovelock desktop backgrounds
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674673 --- Comment #1 from Tim Lauridsen t...@rasmil.dk 2011-02-03 01:56:45 EST --- I will review this bug -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 674673] Review Request: lovelock-backgrounds - Lovelock desktop backgrounds
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674673 Tim Lauridsen t...@rasmil.dk changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|t...@rasmil.dk -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 674673] Review Request: lovelock-backgrounds - Lovelock desktop backgrounds
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674673 Tim Lauridsen t...@rasmil.dk changed: What|Removed |Added Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 674673] Review Request: lovelock-backgrounds - Lovelock desktop backgrounds
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674673 Tim Lauridsen t...@rasmil.dk changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #3 from Tim Lauridsen t...@rasmil.dk 2011-02-03 02:28:43 EST --- APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 674673] Review Request: lovelock-backgrounds - Lovelock desktop backgrounds
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=674673
--- Comment #2 from Tim Lauridsen t...@rasmil.dk 2011-02-03 02:27:41 EST ---
Package Review
==
Key:
- = N/A
x = Check
! = Problem
? = Not evaluated
[x] : MUST - Package successfully compiles and builds into binary rpms on at
least one supported architecture.
[x] : MUST - Buildroot is correct
(%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)).
[x] : MUST - Package has a %clean section, which contains rm -rf %{buildroot}
(or $RPM_BUILD_ROOT).
[x] : MUST - Each %files section contains %defattr
[x] : MUST - Spec file lacks Packager, Vendor, PreReq tags.
[x] : MUST - Package run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) and the
beginning of %install.
[x] : MUST - Package use %makeinstall only when make install DESTDIR=...
doesn't work.
[x] : MUST - Package is named according to the Package Naming Guidelines.
[!] : MUST - Rpmlint output is silent.
rpmlint lovelock-backgrounds-14.90.0-1.fc15.src.rpm
lovelock-backgrounds.src:32: W: macro-in-comment %package
lovelock-backgrounds.src:36: W: macro-in-comment %{name}
lovelock-backgrounds.src:36: W: macro-in-comment %{version}
lovelock-backgrounds.src:36: W: macro-in-comment %{release}
lovelock-backgrounds.src:38: W: macro-in-comment %description
lovelock-backgrounds.src:42: W: macro-in-comment %package
lovelock-backgrounds.src:46: W: macro-in-comment %{name}
lovelock-backgrounds.src:46: W: macro-in-comment %{version}
lovelock-backgrounds.src:46: W: macro-in-comment %{release}
lovelock-backgrounds.src:48: W: macro-in-comment %description
lovelock-backgrounds.src:77: W: macro-in-comment %package
lovelock-backgrounds.src:82: W: macro-in-comment %description
lovelock-backgrounds.src:85: W: macro-in-comment %package
lovelock-backgrounds.src:89: W: macro-in-comment %{name}
lovelock-backgrounds.src:91: W: macro-in-comment %description
lovelock-backgrounds.src:94: W: macro-in-comment %package
lovelock-backgrounds.src:98: W: macro-in-comment %{name}
lovelock-backgrounds.src:100: W: macro-in-comment %description
lovelock-backgrounds.src:133: W: macro-in-comment %files
lovelock-backgrounds.src:134: W: macro-in-comment %defattr
lovelock-backgrounds.src:135: W: macro-in-comment %dir
lovelock-backgrounds.src:135: W: macro-in-comment %{_datadir}
lovelock-backgrounds.src:136: W: macro-in-comment %{_datadir}
lovelock-backgrounds.src:137: W: macro-in-comment %{_datadir}
lovelock-backgrounds.src:138: W: macro-in-comment %{_datadir}
lovelock-backgrounds.src:140: W: macro-in-comment %files
lovelock-backgrounds.src:141: W: macro-in-comment %defattr
lovelock-backgrounds.src:142: W: macro-in-comment %{_datadir}
lovelock-backgrounds.src:143: W: macro-in-comment %{_datadir}
lovelock-backgrounds.src:154: W: macro-in-comment %files
lovelock-backgrounds.src:155: W: macro-in-comment %doc
lovelock-backgrounds.src:156: W: macro-in-comment %defattr
lovelock-backgrounds.src:157: W: macro-in-comment %{_datadir}
lovelock-backgrounds.src:159: W: macro-in-comment %files
lovelock-backgrounds.src:160: W: macro-in-comment %defattr
lovelock-backgrounds.src:161: W: macro-in-comment %{_datadir}
lovelock-backgrounds.src:162: W: macro-in-comment %{_datadir}
lovelock-backgrounds.src:164: W: macro-in-comment %files
lovelock-backgrounds.src:165: W: macro-in-comment %defattr
lovelock-backgrounds.src:166: W: macro-in-comment %{_kde4_datadir}
1 packages and 0 specfiles checked; 0 errors, 40 warnings.
False positives because some sections is commented out
rpmlint lovelock-backgrounds-gnome-14.90.0-1.fc14.noarch.rpm
lovelock-backgrounds-gnome.noarch: W: no-documentation
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
rpmlint lovelock-backgrounds-14.90.0-1.fc14.noarch.rpm
lovelock-backgrounds.noarch: W: no-documentation
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
rpmlint lovelock-backgrounds-kde-14.90.0-1.fc14.noarch.rpm
