[Bug 676930] Review Request: gmock - Google C++ Mocking Framework
https://bugzilla.redhat.com/show_bug.cgi?id=676930 Peter Lemenkov changed: What|Removed |Added CC||lemen...@gmail.com Flags|fedora-cvs+ |fedora-cvs? --- Comment #8 from Peter Lemenkov --- Terje, are you ok with adding a bit more branches for EPEL? I'm going to ask another one - this time for EL7. Package Change Request == Package Name: gmock New Branches: epel7 Owners: peter InitialCC: -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 676930] Review Request: gmock - Google C++ Mocking Framework
https://bugzilla.redhat.com/show_bug.cgi?id=676930 --- Comment #9 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 676930] Review Request: gmock - Google C++ Mocking Framework
https://bugzilla.redhat.com/show_bug.cgi?id=676930 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 676930] Review Request: gmock - Google C++ Mocking Framework
https://bugzilla.redhat.com/show_bug.cgi?id=676930 --- Comment #10 from Fedora Update System --- gmock-1.6.0-3.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/gmock-1.6.0-3.el7 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 676930] Review Request: gmock - Google C++ Mocking Framework
https://bugzilla.redhat.com/show_bug.cgi?id=676930 Fedora Update System changed: What|Removed |Added Fixed In Version||gmock-1.6.0-3.el7 Resolution|NEXTRELEASE |ERRATA --- Comment #11 from Fedora Update System --- gmock-1.6.0-3.el7 has been pushed to the Fedora EPEL 7 stable repository. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 676930] Review Request: gmock - Google C++ Mocking Framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=676930 Terje Røsten changed: What|Removed |Added See Also||https://bugzilla.redhat.com ||/show_bug.cgi?id=527402, ||https://bugzilla.redhat.com ||/show_bug.cgi?id=539613 --- Comment #1 from Terje Røsten 2011-02-11 16:26:14 EST --- Adding ref to older gmock reviews -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 676930] Review Request: gmock - Google C++ Mocking Framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=676930 Haïkel Guémar changed: What|Removed |Added CC||karlthe...@gmail.com AssignedTo|nob...@fedoraproject.org|karlthe...@gmail.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 676930] Review Request: gmock - Google C++ Mocking Framework
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=676930
Haïkel Guémar changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #2 from Haïkel Guémar 2011-02-14 11:27:29
EST ---
gmock (C++ package requires gtest >= 1.5 which is only available for f15+)
MUST: rpmlint must be run on src.rpm and rpm. KO
$ rpmlint -iv mock-1.5.0-1.fc15.src.rpm
gmock.src: I: checking
gmock.src: W: spelling-error %description -l en_US jMock -> j Mock, jock, mock
The value of this tag appears to be misspelled. Please double-check.
gmock.src: W: spelling-error %description -l en_US matchers -> marchers,
matcher, matches
The value of this tag appears to be misspelled. Please double-check.
gmock.src: W: spelling-error %description -l en_US minGW -> mingy, mingle,
Mingus
The value of this tag appears to be misspelled. Please double-check.
gmock.src: I: checking-url http://code.google.com/p/googlemock/ (timeout 10
seconds)
gmock.src:43: W: make-check-outside-check-section # save the rest for use in
make check
Make check or other automated regression test should be run in %check, as they
can be disabled with a rpm macro for short circuiting purposes.
gmock.src: I: checking-url
http://googlemock.googlecode.com/files/gmock-1.5.0.tar.bz2 (timeout 10 seconds)
gmock.src: W: invalid-url Source0:
http://googlemock.googlecode.com/files/gmock-1.5.0.tar.bz2 HTTP Error 404: Not
Found
The value should be a valid, public HTTP, HTTPS, or FTP URL.
$ rpmlint -iv gmock-1.5.0-1.fc15.x86_64.rpm
gmock.x86_64: I: checking
gmock.x86_64: W: spelling-error %description -l en_US jMock -> j Mock, jock,
mock
The value of this tag appears to be misspelled. Please double-check.
gmock.x86_64: W: spelling-error %description -l en_US matchers -> marchers,
matcher, matches
The value of this tag appears to be misspelled. Please double-check.
gmock.x86_64: W: spelling-error %description -l en_US minGW -> mingy, mingle,
Mingus
The value of this tag appears to be misspelled. Please double-check.
gmock.x86_64: I: checking-url http://code.google.com/p/googlemock/ (timeout 10
seconds)
gmock.x86_64: W: shared-lib-calls-exit /usr/lib64/libgmock.so.0.0.0
_exit@GLIBC_2.2.5
This library package calls exit() or _exit(), probably in a non-fork()
context. Doing so from a library is strongly discouraged - when a library
function calls exit(), it prevents the calling program from handling the
error, reporting it to the user, closing files properly, and cleaning up any
state that the program has. It is preferred for the library to return an
actual error code and let the calling program decide how to handle the
situation.
1 packages and 0 specfiles checked; 0 errors, 4 warnings.
$ rpmlint -iv gmock-devel-1.5.0-1.fc15.x86_64.rpm
gmock-devel.x86_64: I: checking
gmock-devel.x86_64: I: checking-url http://code.google.com/p/googlemock/
(timeout 10 seconds)
gmock-devel.x86_64: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.
gmock-devel.x86_64: W: no-manual-page-for-binary gmock-config
Each executable in standard binary directories should have a man page.
gmock-devel.x86_64: W: no-manual-page-for-binary gmock_doctor.py
Each executable in standard binary directories should have a man page.
1 packages and 0 specfiles checked; 0 errors, 3 warnings.
the make check warning is a false positive.
the shared-lib-exit-call warning is non-relevant due to package nature (mocking
framework)
the other warnings are non-relevant.
MUST: package named accordingly to package naming guidelines. OK
MUST: spec file name match %{name} OK
MUST: package meets packaging guidelines OK
MUST: package must be licensed under a fedora-compliant license OK (BSD)
MUST: License field in package spec match actual license OK
MUST: spec in legible american english OK
MUST: sources provided match upstream's OK
provided sources sha1sum: 76d8f5a221c93105304d71e33391dc70af573d6a
upstream sources sha1sum: 76d8f5a221c93105304d71e33391dc70af573d6a
MUST: package successfully compiles on at least one primary architecture (all
of them) OK
MUST: all build dependencies are listed in BR OK
MUST: package must not bundle copies of system libraries. OK
Note: it does bundle google test sources (gtest) but by default it builds
agains system copy.
MUST: package must own all directories it creates. OK
MUST: package does not list a file more than once in %files section. OK
MUST: permissions are properly set. OK
MUST: package consistenly use macros. OK
MUST: package contains permissable content. OK
MUST: package does not own directories owned by other packages. OK
MUST: all filenames in package are valid UT
[Bug 676930] Review Request: gmock - Google C++ Mocking Framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=676930 Terje Røsten changed: What|Removed |Added Status|NEW |ASSIGNED Flag||fedora-cvs? --- Comment #3 from Terje Røsten 2011-02-14 16:35:19 EST --- Thanks for the review! The plan is to update gtest in F14 to 1.5.0. New Package SCM Request === Package Name: gmock Short Description: Google C++ Mocking Framework Owners: terjeros Branches: f14 f15 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 676930] Review Request: gmock - Google C++ Mocking Framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=676930 --- Comment #4 from Jason Tibbitts 2011-02-15 14:29:38 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 676930] Review Request: gmock - Google C++ Mocking Framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=676930 Terje Røsten changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE Last Closed||2011-02-16 02:38:31 --- Comment #5 from Terje Røsten 2011-02-16 02:38:31 EST --- Imported and built. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
