[Bug 676941] Review Request: eiskaltdcpp-gtk - GTK+ frontend to DC++ client library eiskaltdcpp

2015-07-21 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=676941

Miroslav Suchý msu...@redhat.com changed:

   What|Removed |Added

 Status|NEW |CLOSED
 CC||msu...@redhat.com
 Blocks|177841 (FE-NEEDSPONSOR) |201449 (FE-DEADREVIEW)
 Resolution|--- |DEFERRED
Last Closed||2015-07-21 09:08:24



--- Comment #7 from Miroslav Suchý msu...@redhat.com ---
Closing per #6. Feel free to reopen if you want to continue.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
https://bugzilla.redhat.com/show_bug.cgi?id=201449
[Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter
response should be blocking this bug.
-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 676941] Review Request: eiskaltdcpp-gtk - GTK+ frontend to DC++ client library eiskaltdcpp

2011-04-01 Thread bugzilla 
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=676941

--- Comment #5 from Michael Schwendt mschwe...@gmail.com 2011-04-01 12:57:37 
EDT ---
Some more items:


 Requires:   gtk2 = 2.10
 Requires:   glib2 = 2.10
 Requires:   libglade2 = 2.4
 Requires:   gettext
 Requires:   libeiskaltdcpp = %{version}-%{release}

https://fedoraproject.org/wiki/Packaging:Guidelines#Explicit_Requires

For a Fedora Packager it is very important to understand rpmbuild's automatic
dependencies on library SONAMEs.


 5) What does %dir do?

It includes a directory (and just the dir, not any files within the dir) in the
RPM package with proper ownership and permissions. 
https://fedoraproject.org/wiki/Packaging:UnownedDirectories
Under certain circumstances, %dir and recursive inclusion of a directory
compete with eachother with regard to adding an entry for the directory to the
package.


 %files -f %{name}.lang
 %{_datadir}/locale/*/LC_MESSAGES/eiskaltdcpp-gtk.mo

https://fedoraproject.org/wiki/Packaging:Guidelines#Handling_Locale_Files


 %{_mandir}/man1/eiskaltdcpp-gtk.1.gz

Acceptable, but please notice that the gzip compression is applied by rpmbuild
and may change. So, %{_mandir}/man1/eiskaltdcpp-gtk.1* would be safer.


 make install/strip DESTDIR=%{buildroot}

Please investigate what this /strip here does.


 rm -f %{buildroot}/%{_libdir}/libeiskaltdcpp.so.2.2
 rm -f %{buildroot}/%{_datadir}/locale/*/LC_MESSAGES/libeiskaltdcpp.mo

Two commands that ask for an explanation in a comment.


 %{_datadir}/applications/eiskaltdcpp-gtk.desktop

https://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files

[...]

https://fedoraproject.org/wiki/Packaging:Guidelines
https://fedoraproject.org/wiki/Packaging:ReviewGuidelines
https://fedoraproject.org/wiki/PackageMaintainers

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 676941] Review Request: eiskaltdcpp-gtk - GTK+ frontend to DC++ client library eiskaltdcpp

2011-02-19 Thread bugzilla 
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=676941

--- Comment #2 from Patryk Obara dreamer@gmail.com 2011-02-19 17:51:38 
EST ---
Actually, I was wrong about point (4). By looking at different reviews I see
that is required after all.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 676941] Review Request: eiskaltdcpp-gtk - GTK+ frontend to DC++ client library eiskaltdcpp

2011-02-19 Thread bugzilla 
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=676941

Jussi Lehtola jussi.leht...@iki.fi changed:

   What|Removed |Added

 CC||jussi.leht...@iki.fi

--- Comment #3 from Jussi Lehtola jussi.leht...@iki.fi 2011-02-19 18:16:36 
EST ---
(In reply to comment #2)
 Actually, I was wrong about point (4). By looking at different reviews I see
 that is required after all.

It is not required, the reviews you have looked at have been performed
incorrectly, were done a long time ago or were targeting EPEL.

http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag
http://fedoraproject.org/wiki/Packaging/Guidelines#.25clean

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 676941] Review Request: eiskaltdcpp-gtk - GTK+ frontend to DC++ client library eiskaltdcpp

2011-02-19 Thread bugzilla 
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=676941

--- Comment #4 from Patryk Obara dreamer@gmail.com 2011-02-19 18:30:32 
EST ---
(In reply to comment #3)
 (In reply to comment #2)
  Actually, I was wrong about point (4). By looking at different reviews I see
  that is required after all.
 
 It is not required, the reviews you have looked at have been performed
 incorrectly, were done a long time ago or were targeting EPEL.

I was misguided by last comment in this, quite recent, review:
https://bugzilla.redhat.com/show_bug.cgi?id=673919
(there is no mention in there, that it targets EPEL)
 At the beginning of %install, each package MUST run rm -rf %{buildroot} - OK

Thanks for clarification, Jussi :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 676941] Review Request: eiskaltdcpp-gtk - GTK+ frontend to DC++ client library eiskaltdcpp

2011-02-16 Thread bugzilla 
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=676941

Martin Gieseking martin.giesek...@uos.de changed:

   What|Removed |Added

 CC||martin.giesek...@uos.de
 Blocks||177841(FE-NEEDSPONSOR)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review