[Bug 678128] Review Request: cdw - Front-end for tools used for burning data CD/DVD
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678128 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|cdw-0.6.0-8.fc13|cdw-0.6.0-8.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678128] Review Request: cdw - Front-end for tools used for burning data CD/DVD
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678128 --- Comment #28 from Fedora Update System upda...@fedoraproject.org 2011-03-20 23:31:46 EDT --- cdw-0.6.0-8.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678128] Review Request: cdw - Front-end for tools used for burning data CD/DVD
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678128 --- Comment #26 from Fedora Update System upda...@fedoraproject.org 2011-03-14 06:21:04 EDT --- cdw-0.6.0-8.fc14 has been pushed to the Fedora 14 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678128] Review Request: cdw - Front-end for tools used for burning data CD/DVD
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678128 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|cdw-0.6.0-8.fc14|cdw-0.6.0-8.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678128] Review Request: cdw - Front-end for tools used for burning data CD/DVD
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678128 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||cdw-0.6.0-8.fc14 Resolution||ERRATA Last Closed||2011-03-14 06:21:10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678128] Review Request: cdw - Front-end for tools used for burning data CD/DVD
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678128 --- Comment #27 from Fedora Update System upda...@fedoraproject.org 2011-03-14 06:23:38 EDT --- cdw-0.6.0-8.fc13 has been pushed to the Fedora 13 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678128] Review Request: cdw - Front-end for tools used for burning data CD/DVD
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678128 --- Comment #20 from Sergio Belkin seb...@gmail.com 2011-03-05 09:06:24 EST --- New Package SCM Request === Package Name: cdw Short Description: Front-end for tools used for burning data CD/DVD Owners: sebelk Branches: f13 f14 f15 el6 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678128] Review Request: cdw - Front-end for tools used for burning data CD/DVD
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678128 --- Comment #21 from Jason Tibbitts ti...@math.uh.edu 2011-03-05 12:03:26 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678128] Review Request: cdw - Front-end for tools used for burning data CD/DVD
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678128 --- Comment #23 from Fedora Update System upda...@fedoraproject.org 2011-03-05 16:01:21 EST --- cdw-0.6.0-8.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/cdw-0.6.0-8.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678128] Review Request: cdw - Front-end for tools used for burning data CD/DVD
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678128 --- Comment #24 from Fedora Update System upda...@fedoraproject.org 2011-03-05 16:02:31 EST --- cdw-0.6.0-8.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/cdw-0.6.0-8.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678128] Review Request: cdw - Front-end for tools used for burning data CD/DVD
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678128 --- Comment #22 from Fedora Update System upda...@fedoraproject.org 2011-03-05 16:00:04 EST --- cdw-0.6.0-8.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/cdw-0.6.0-8.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678128] Review Request: cdw - Front-end for tools used for burning data CD/DVD
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678128 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678128] Review Request: cdw - Front-end for tools used for burning data CD/DVD
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678128 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #25 from Fedora Update System upda...@fedoraproject.org 2011-03-05 22:42:04 EST --- cdw-0.6.0-8.fc15 has been pushed to the Fedora 15 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update cdw'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/cdw-0.6.0-8.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678128] Review Request: cdw - Front-end for tools used for burning data CD/DVD
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678128 Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #18 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2011-03-04 14:36:20 EST --- Approving. --- This package (cdw) is APPOVED by mtasaka --- -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678128] Review Request: cdw - Front-end for tools used for burning data CD/DVD
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678128 --- Comment #19 from Sergio Belkin seb...@gmail.com 2011-03-04 18:26:56 EST --- New Package SCM Request === Package Name: cdw Short Description: Front-end for tools used for burning data CD/DVD Owners: sebelk Branches: f13 f14 f15 el6 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678128] Review Request: cdw - Front-end for tools used for burning data CD/DVD
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678128 Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678128] Review Request: cdw - Front-end for tools used for burning data CD/DVD
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678128 William Lima wl...@primate.com.br changed: What|Removed |Added CC||wl...@primate.com.br --- Comment #11 from William Lima wl...@primate.com.br 2011-02-28 09:32:31 EST --- why assign yourself to the bug? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678128] Review Request: cdw - Front-end for tools used for burning data CD/DVD
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678128 Sergio Belkin seb...@gmail.com changed: What|Removed |Added AssignedTo|seb...@gmail.com|nob...@fedoraproject.org --- Comment #12 from Sergio Belkin seb...@gmail.com 2011-02-28 09:48:09 EST --- Yup, it was a silly mistake. Removing. I though incorrectly that it was already approved. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678128] Review Request: cdw - Front-end for tools used for burning data CD/DVD
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678128 --- Comment #13 from Sergio Belkin seb...@gmail.com 2011-02-28 09:52:29 EST --- I was tempted for Nobody's working on this, feel free to take it message and that I could do it. Sorry again. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678128] Review Request: cdw - Front-end for tools used for burning data CD/DVD
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=678128
Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed:
What|Removed |Added
Status|NEW |ASSIGNED
AssignedTo|nob...@fedoraproject.org|mtas...@ioa.s.u-tokyo.ac.jp
Flag||fedora-review?
--- Comment #14 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2011-02-28
13:20:06 EST ---
Some comments
* License
- The license tag should be GPLv2+, from source codes and
man file.
* Timestamps
- Please consider to use
-
make install DESTDIR=$RPM_BUILD_ROOT INSTALL=install -p
-
to keep timestamps on installed man file.
? ${LIBS}
- It seems that before setting LIBS environ LIBS is null, and
LIBS=-lm is sufficient.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678128] Review Request: cdw - Front-end for tools used for burning data CD/DVD
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=678128
--- Comment #15 from Sergio Belkin seb...@gmail.com 2011-02-28 14:55:26 EST
---
(In reply to comment #14)
Updated file URL's
***
Spec URL: http://dl.dropbox.com/u/14217893/cdw.spec
SRPM URL: http://dl.dropbox.com/u/14217893/cdw-0.6.0-7.fc16.src.rpm
***
Some comments
* License
- The license tag should be GPLv2+, from source codes and
man file.
You're right. Fixed.
* Timestamps
- Please consider to use
-
make install DESTDIR=$RPM_BUILD_ROOT INSTALL=install -p
-
to keep timestamps on installed man file.
Fixed!
? ${LIBS}
- It seems that before setting LIBS environ LIBS is null, and
LIBS=-lm is sufficient.
Yup, it's null, fixed too!
Thanks Mamoru!
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678128] Review Request: cdw - Front-end for tools used for burning data CD/DVD
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=678128
--- Comment #16 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2011-02-28
16:01:10 EST ---
(In reply to comment #15)
(In reply to comment #14)
* Timestamps
- Please consider to use
-
make install DESTDIR=$RPM_BUILD_ROOT INSTALL=install -p
-
The above line is one line (i.e. INSTALL=install -p is the option
of make command).
to keep timestamps on installed man file.
? ${LIBS}
- It seems that before setting LIBS environ LIBS is null, and
LIBS=-lm is sufficient.
Yup, it's null, fixed too!
This does not seem to be fixed yet.
By the way, now you can use fedorapeople.org site for hosting your srpm
and so on. Please try it, see:
https://fedoraproject.org/wiki/Fedorapeople.org
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678128] Review Request: cdw - Front-end for tools used for burning data CD/DVD
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=678128
--- Comment #17 from Sergio Belkin seb...@gmail.com 2011-02-28 17:13:09 EST
---
(In reply to comment #16)
Hi Mamoru
Firstly the newly files URL's:
***
http://sebelk.fedorapeople.org/cdw-0.6.0-8.fc14.src.rpm
http://sebelk.fedorapeople.org/cdw.spec
***
(In reply to comment #15)
(In reply to comment #14)
* Timestamps
- Please consider to use
-
make install DESTDIR=$RPM_BUILD_ROOT INSTALL=install -p
-
The above line is one line (i.e. INSTALL=install -p is the option
of make command).
Shame on me :(
to keep timestamps on installed man file.
? ${LIBS}
- It seems that before setting LIBS environ LIBS is null, and
LIBS=-lm is sufficient.
Yup, it's null, fixed too!
This does not seem to be fixed yet.
Id. above.
By the way, now you can use fedorapeople.org site for hosting your srpm
and so on. Please try it, see:
https://fedoraproject.org/wiki/Fedorapeople.org
Now those mistakes are fixed and files are in fedorapeople.org :)
Thanks in advance
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678128] Review Request: cdw - Front-end for tools used for burning data CD/DVD
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678128 Raghu Udiyar raghusidda...@gmail.com changed: What|Removed |Added CC||raghusidda...@gmail.com --- Comment #9 from Raghu Udiyar raghusidda...@gmail.com 2011-02-27 09:38:19 EST --- Hi, The package looks good. Now you need to find a sponsor. To do this you can do informal reviews on other packages and reference them here, so that sponsors can see that you have understood the guidelines. You can read more about getting sponsorship here : http://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678128] Review Request: cdw - Front-end for tools used for burning data CD/DVD
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678128 Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed: What|Removed |Added Blocks|177841(FE-NEEDSPONSOR) | --- Comment #10 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2011-02-27 13:52:51 EST --- (Removing NEEDSPONSOR) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678128] Review Request: cdw - Front-end for tools used for burning data CD/DVD
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678128 Sergio Belkin seb...@gmail.com changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|seb...@gmail.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678128] Review Request: cdw - Front-end for tools used for burning data CD/DVD
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678128 --- Comment #8 from Sergio Belkin seb...@gmail.com 2011-02-26 18:32:03 EST --- Hi, I've fixed the lacking of intermediate lines between changelog entries Spec URL: http://dl.dropbox.com/u/14217893/cdw.spec SRPM URL: http://dl.dropbox.com/u/14217893/cdw-0.6.0-6.fc16.src.rpm Thanks in advance -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678128] Review Request: cdw - Front-end for tools used for burning data CD/DVD
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678128 --- Comment #7 from Sergio Belkin seb...@gmail.com 2011-02-24 11:40:04 EST --- Hi, I've resubmitted the spec file because it had an incorrect weekday date in last entry. Because is an error restricted to a spec file I've found not needed to increase the E-V-R. If I'm wrong please let me to know. I've made the terrible and unforgivable mistake :( My little son is on holidays and sometimes I miss something with him play around :) The URL's are the same: Spec URL: http://dl.dropbox.com/u/14217893/cdw.spec SRPM URL: http://dl.dropbox.com/u/14217893/cdw-0.6.0-5.fc16.src.rpm Please, I need your review and your sponsorship. Thanks in advance -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678128] Review Request: cdw - Front-end for tools used for burning data CD/DVD
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=678128
--- Comment #6 from Sergio Belkin seb...@gmail.com 2011-02-22 18:47:51 EST ---
Some
- Minor change in BuildRequires
- Fixed typo in Requires and comment
- Added %%check section
Spec URL: http://dl.dropbox.com/u/14217893/cdw.spec
SRPM URL: http://dl.dropbox.com/u/14217893/cdw-0.6.0-5.fc16.src.rpm
I need your review and your sponsorship. Below you can read my review, rpmlint
output and file list.
MUST ITEMS
[x] rpmlint output
rpmlint -i -v cdw-0.6.0-5.fc16.i686.rpm:
cdw.i686: I: checking
cdw.i686: I: checking-url http://cdw.sourceforge.net/ (timeout 10 seconds)
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
rpmlint -i -v cdw-0.6.0-5.fc16.src.rpm:
cdw.src: I: checking
cdw.src: I: checking-url http://cdw.sourceforge.net/ (timeout 10 seconds)
cdw.src: I: checking-url http://downloads.sourceforge.net/cdw/cdw-0.6.0.tar.gz
(timeout 10 seconds)
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
rpmlint -i -v cdw-0.6.0-5.fc16.x86_64.rpm:
cdw.x86_64: I: checking
cdw.x86_64: I: checking-url http://cdw.sourceforge.net/ (timeout 10 seconds)
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
rpmlint -i -v cdw-debuginfo-0.6.0-5.fc16.i686.rpm:
cdw-debuginfo.i686: I: checking
cdw-debuginfo.i686: I: checking-url http://cdw.sourceforge.net/ (timeout 10
seconds)
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
rpmlint -i -v /home/sergio/rpmbuild/SPECS/cdw.spec:
/home/sergio/rpmbuild/SPECS/cdw.spec: I: checking-url
http://downloads.sourceforge.net/cdw/cdw-0.6.0.tar.gz (timeout 10 seconds)
0 packages and 1 specfiles checked; 0 errors, 0 warnings.
[x] The package is named according to the Package Naming Guidelines .
[x] The spec file name matches the base package %{name}, in the format
%{name}.spec
[x] The package meets the Packaging Guidelines.
[x] The package is licensed with a Fedora approved license and meet the
Licensing Guidelines . (GPLv2)
[x] The License field in the package spec file matches the actual license.
[x] The source package includes the text of the license(s) in its own file,
then that file, containing the text of the license(s) for the package is
included in %doc.
[x] The spec file is written in American English.
[x] The spec file for the package is legible.
[x] The sources used to build the package matches the upstream source, as
provided in the spec URL. md5sum: 808601f91e3aa13e539b98e684cec1a9
[x] The package successfully compiles and builds into binary rpms on two
primary architectures
[x] All build dependencies are listed in BuildRequires
[x] No locale files.
[x] Packages does NOT bundle copies of system libraries.
[x] Package is not designed to be relocatable.
[x] A package owns all directories that it creates. (See below rpm output)
[x] No file listed more than once in the spec file's %files listings.
[x] Permissions on files are set properly. Executables are set with executable
permissions. Every %files section includes a %defattr(...) line.
[x] Each package has consistently use macros.
[x] The package contains codes, or permissable content.
[x] There is no large documentation files
[x] The program runs properly even if %doc it is not present
[x] Packages does not own files or directories already owned by other packages.
[x] All filenames in rpm packages are valid UTF-8.
File list cdw-0.6.0-5.fc16.i686.rpm:
-rwxr-xr-x1 rootroot 224196 feb 22 17:00 /usr/bin/cdw
drwxr-xr-x2 rootroot0 feb 22 17:00
/usr/share/doc/cdw-0.6.0
-rw-r--r--1 rootroot 414 jul 1 2010
/usr/share/doc/cdw-0.6.0/AUTHORS
-rw-r--r--1 rootroot17992 may 30 2002
/usr/share/doc/cdw-0.6.0/COPYING
-rw-r--r--1 rootroot36554 oct 22 16:14
/usr/share/doc/cdw-0.6.0/ChangeLog
-rw-r--r--1 rootroot16394 oct 22 16:21
/usr/share/doc/cdw-0.6.0/NEWS
-rw-r--r--1 rootroot 4492 oct 22 15:46
/usr/share/doc/cdw-0.6.0/README
-rw-r--r--1 rootroot 194 jul 1 2010
/usr/share/doc/cdw-0.6.0/THANKS
-rw-r--r--1 rootroot 8910 feb 22 17:00
/usr/share/man/man1/cdw.1.gz
File list cdw-0.6.0-5.fc16.src.rpm:
-rw-rw-r--1 mockbuilmockbuil 673530 ene 30 23:05
cdw-0.6.0.tar.gz
-rw-rw-r--1 mockbuilmockbuil 1690 feb 22 16:50 cdw.spec
File list cdw-0.6.0-5.fc16.x86_64.rpm:
-rwxr-xr-x1 rootroot 220584 feb 22 17:00 /usr/bin/cdw
drwxr-xr-x2 rootroot0 feb 22 17:00
/usr/share/doc/cdw-0.6.0
-rw-r--r--1 rootroot 414 jul 1 2010
/usr/share/doc/cdw-0.6.0/AUTHORS
-rw-r--r--1 rootroot17992 may 30 2002
/usr/share/doc/cdw-0.6.0/COPYING
-rw-r--r--1 rootroot
[Bug 678128] Review Request: cdw - Front-end for tools used for burning data CD/DVD
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=678128
Patryk Obara dreamer@gmail.com changed:
What|Removed |Added
CC||dreamer@gmail.com
--- Comment #4 from Patryk Obara dreamer@gmail.com 2011-02-19 14:13:15
EST ---
(This is not normal review, because I am novice packager, but a bit of of
feedback):
1) You're missing %doc in your files section, maybe fill it like this:
%files
%defattr(-,root,root,-)
%doc COPYING AUTHORS ChangeLog NEWS README THANKS
it will take named files from unpacked tarball and place it correctly in
%{_docdir}/%{name}-%{version}, where they belong :)
You completely have to do it at least for COPYING file.
2) I don't think you need
%attr(755,root,root) before %{_bindir}/*
make install should already take care of that
3) (aesthetics, it doesn't really matter ;))
- add/remove some spaces before values for fields: Name,Release and Requires -
to make all values start in same column
- remove unneeded multiple spaces after Requires fields
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678128] Review Request: cdw - Front-end for tools used for burning data CD/DVD
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678128 Sergio Belkin seb...@gmail.com changed: What|Removed |Added Version|14 |rawhide --- Comment #2 from Sergio Belkin seb...@gmail.com 2011-02-17 15:32:57 EST --- Hi, I've replaced LDFLAGS for the more suitable variable LIBS on build stage. Spec URL: http://dl.dropbox.com/u/14217893/cdw.spec SRPM URL: http://dl.dropbox.com/u/14217893/cdw-0.6.0-2.fc16.src.rpm rpmlint output: [sergio@peque tmp]$ for i in cdw*2* ~/rpmbuild/SPECS/cdw.spec; do echo rpmlint -i -v $i: rpmlint -i -v $i;done rpmlint -i -v cdw-0.6.0-2.fc16.i686.rpm: cdw.i686: I: checking cdw.i686: I: checking-url http://cdw.sourceforge.net/ (timeout 10 seconds) 1 packages and 0 specfiles checked; 0 errors, 0 warnings. rpmlint -i -v cdw-0.6.0-2.fc16.src.rpm: cdw.src: I: checking cdw.src: I: checking-url http://cdw.sourceforge.net/ (timeout 10 seconds) cdw.src: I: checking-url http://downloads.sourceforge.net/cdw/cdw-0.6.0.tar.gz (timeout 10 seconds) 1 packages and 0 specfiles checked; 0 errors, 0 warnings. rpmlint -i -v cdw-0.6.0-2.fc16.x86_64.rpm: cdw.x86_64: I: checking cdw.x86_64: I: checking-url http://cdw.sourceforge.net/ (timeout 10 seconds) 1 packages and 0 specfiles checked; 0 errors, 0 warnings. rpmlint -i -v cdw-debuginfo-0.6.0-2.fc16.i686.rpm: cdw-debuginfo.i686: I: checking cdw-debuginfo.i686: I: checking-url http://cdw.sourceforge.net/ (timeout 10 seconds) 1 packages and 0 specfiles checked; 0 errors, 0 warnings. rpmlint -i -v cdw-debuginfo-0.6.0-2.fc16.x86_64.rpm: cdw-debuginfo.x86_64: I: checking cdw-debuginfo.x86_64: I: checking-url http://cdw.sourceforge.net/ (timeout 10 seconds) 1 packages and 0 specfiles checked; 0 errors, 0 warnings. rpmlint -i -v /home/sergio/rpmbuild/SPECS/cdw.spec: /home/sergio/rpmbuild/SPECS/cdw.spec: I: checking-url http://downloads.sourceforge.net/cdw/cdw-0.6.0.tar.gz (timeout 10 seconds) 0 packages and 1 specfiles checked; 0 errors, 0 warnings. rpm -qlp output: rpm -qlp cdw-0.6.0-2.fc16.i686.rpm: /usr/bin/cdw /usr/share/man/man1/cdw.1.gz rpm -qlp cdw-0.6.0-2.fc16.x86_64.rpm: /usr/bin/cdw /usr/share/man/man1/cdw.1.gz rpm -qlp cdw-debuginfo-0.6.0-2.fc16.i686.rpm: /usr/lib/debug /usr/lib/debug/.build-id /usr/lib/debug/.build-id/d0 /usr/lib/debug/.build-id/d0/033df2c998822dc41e178a49e65bf00fe8078e /usr/lib/debug/.build-id/d0/033df2c998822dc41e178a49e65bf00fe8078e.debug /usr/lib/debug/usr /usr/lib/debug/usr/bin /usr/lib/debug/usr/bin/cdw.debug /usr/src/debug/cdw-0.6.0 /usr/src/debug/cdw-0.6.0/gnulib /usr/src/debug/cdw-0.6.0/gnulib/lib /usr/src/debug/cdw-0.6.0/gnulib/lib/canonicalize.c /usr/src/debug/cdw-0.6.0/gnulib/lib/canonicalize.h /usr/src/debug/cdw-0.6.0/gnulib/lib/cycle-check.c /usr/src/debug/cdw-0.6.0/gnulib/lib/cycle-check.h /usr/src/debug/cdw-0.6.0/gnulib/lib/dev-ino.h /usr/src/debug/cdw-0.6.0/gnulib/lib/xreadlink.c /usr/src/debug/cdw-0.6.0/src /usr/src/debug/cdw-0.6.0/src/configuration /usr/src/debug/cdw-0.6.0/src/configuration/cdw_config.c /usr/src/debug/cdw-0.6.0/src/configuration/cdw_config.h /usr/src/debug/cdw-0.6.0/src/configuration/cdw_config_ui.c /usr/src/debug/cdw-0.6.0/src/configuration/cdw_config_ui_internals.c /usr/src/debug/cdw-0.6.0/src/configuration/cdw_config_ui_internals.h /usr/src/debug/cdw-0.6.0/src/disc_and_drive /usr/src/debug/cdw-0.6.0/src/disc_and_drive/cdw_cdio.c /usr/src/debug/cdw-0.6.0/src/disc_and_drive/cdw_cdio.h /usr/src/debug/cdw-0.6.0/src/disc_and_drive/cdw_cdio_drives.c /usr/src/debug/cdw-0.6.0/src/disc_and_drive/cdw_cdio_drives.h /usr/src/debug/cdw-0.6.0/src/disc_and_drive/cdw_disc.c /usr/src/debug/cdw-0.6.0/src/disc_and_drive/cdw_disc.h /usr/src/debug/cdw-0.6.0/src/disc_and_drive/cdw_drive.c /usr/src/debug/cdw-0.6.0/src/external_tools /usr/src/debug/cdw-0.6.0/src/external_tools/cdw_cdrecord.c /usr/src/debug/cdw-0.6.0/src/external_tools/cdw_cdrecord_regex.c /usr/src/debug/cdw-0.6.0/src/external_tools/cdw_dvd_rw_format.c /usr/src/debug/cdw-0.6.0/src/external_tools/cdw_dvd_rw_format_regex.c /usr/src/debug/cdw-0.6.0/src/external_tools/cdw_dvd_rw_mediainfo.c /usr/src/debug/cdw-0.6.0/src/external_tools/cdw_dvd_rw_mediainfo_regex.c /usr/src/debug/cdw-0.6.0/src/external_tools/cdw_ext_tools.c /usr/src/debug/cdw-0.6.0/src/external_tools/cdw_ext_tools.h /usr/src/debug/cdw-0.6.0/src/external_tools/cdw_growisofs.c /usr/src/debug/cdw-0.6.0/src/external_tools/cdw_growisofs_regex.c /usr/src/debug/cdw-0.6.0/src/external_tools/cdw_md5sum.c /usr/src/debug/cdw-0.6.0/src/external_tools/cdw_md5sum.h /usr/src/debug/cdw-0.6.0/src/external_tools/cdw_md5sum_regex.c /usr/src/debug/cdw-0.6.0/src/external_tools/cdw_mkisofs.c /usr/src/debug/cdw-0.6.0/src/external_tools/cdw_mkisofs_regex.c /usr/src/debug/cdw-0.6.0/src/external_tools/cdw_regex_dispatch.c
[Bug 678128] Review Request: cdw - Front-end for tools used for burning data CD/DVD
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678128 --- Comment #3 from Sergio Belkin seb...@gmail.com 2011-02-17 22:49:02 EST --- Removed %clean section. Spec URL: http://dl.dropbox.com/u/14217893/cdw.spec SRPM URL: http://dl.dropbox.com/u/14217893/cdw-0.6.0-3.fc16.src.rpm I look forward your review and your sponsorship. Thanks again. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678128] Review Request: cdw - Front-end for tools used for burning data CD/DVD
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678128 Sergio Belkin seb...@gmail.com changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) Alias||cdw -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678128] Review Request: cdw - Front-end for tools used for burning data CD/DVD
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678128 Sergio Belkin seb...@gmail.com changed: What|Removed |Added Version|rawhide |14 --- Comment #1 from Sergio Belkin seb...@gmail.com 2011-02-16 16:08:58 EST --- Hi, I append this rpmlint and rpm output I guess you find useful (this is *not* a new files submission): [sergio@peque SPECS]$ rpmlint -iv /tmp/cdw-0.6.0-1.fc14.src.rpm cdw.src: I: checking cdw.src: I: checking-url http://cdw.sourceforge.net/ (timeout 10 seconds) cdw.src: I: checking-url http://downloads.sourceforge.net/cdw/cdw-0.6.0.tar.gz (timeout 10 seconds) 1 packages and 0 specfiles checked; 0 errors, 0 warnings. [sergio@peque SPECS]$ rpmlint -iv /tmp/cdw-0.6.0-1.fc14.x86_64.rpm cdw.x86_64: I: checking cdw.x86_64: I: checking-url http://cdw.sourceforge.net/ (timeout 10 seconds) 1 packages and 0 specfiles checked; 0 errors, 0 warnings. [sergio@peque SPECS]$ rpmlint -iv cdw.spec cdw.spec: I: checking-url http://downloads.sourceforge.net/cdw/cdw-0.6.0.tar.gz (timeout 10 seconds) 0 packages and 1 specfiles checked; 0 errors, 0 warnings. [sergio@peque SPECS]$ rpmlint -iv ../RPMS/i686/cdw-0.6.0-1.fc14.i686.rpm cdw.i686: I: checking cdw.i686: I: checking-url http://cdw.sourceforge.net/ (timeout 10 seconds) 1 packages and 0 specfiles checked; 0 errors, 0 warnings cdw-debuginfo.i686: I: checking cdw-debuginfo.i686: I: checking-url http://cdw.sourceforge.net/ (timeout 10 seconds) 1 packages and 0 specfiles checked; 0 errors, 0 warnings. [sergio@peque SPECS]$ [sergio@peque SPECS]$ rpm -qlp ../RPMS/i686/cdw-0.6.0-1.fc14.i686.rpm /usr/bin/cdw /usr/share/man/man1/cdw.1.gz [sergio@peque SPECS]$ rpm -qlp /tmp/cdw-0.6.0-1.fc14.x86_64.rpm /usr/bin/cdw /usr/share/man/man1/cdw.1.gz I would appreciate your review and your sponsorship. Thanks in advance! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
