[Bug 678674] Review Request: rubygem-goocanvas - Ruby binding of GooCanvas

2011-12-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=678674

Mamoru Tasaka mtas...@fedoraproject.org changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE
Last Closed||2011-12-23 12:15:57

--- Comment #8 from Mamoru Tasaka mtas...@fedoraproject.org 2011-12-23 
12:15:57 EST ---
Imported. Thank you for review and git procedure. Closing.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 678674] Review Request: rubygem-goocanvas - Ruby binding of GooCanvas

2011-12-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=678674

--- Comment #7 from Jon Ciesla limburg...@gmail.com 2011-12-22 08:14:07 EST 
---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 678674] Review Request: rubygem-goocanvas - Ruby binding of GooCanvas

2011-12-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=678674

--- Comment #4 from Mamoru Tasaka mtas...@fedoraproject.org 2011-12-21 
10:15:15 EST ---
http://mtasaka.fedorapeople.org/Review_request/rubygem-goocanvas/rubygem-goocanvas-1.0.3-1.fc.src.rpm
http://mtasaka.fedorapeople.org/Review_request/rubygem-goocanvas/rubygem-goocanvas.spec

* Thu Dec 22 2011 Mamoru Tasaka mtas...@fedoraproject.org - 1.0.3-1
- 1.0.3

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 678674] Review Request: rubygem-goocanvas - Ruby binding of GooCanvas

2011-12-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=678674

Darryl L. Pierce dpie...@redhat.com changed:

   What|Removed |Added

 CC||dpie...@redhat.com
 AssignedTo|nob...@fedoraproject.org|dpie...@redhat.com
   Flag||fedora-review?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 678674] Review Request: rubygem-goocanvas - Ruby binding of GooCanvas

2011-12-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=678674

Darryl L. Pierce dpie...@redhat.com changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+

--- Comment #5 from Darryl L. Pierce dpie...@redhat.com 2011-12-21 11:13:24 
EST ---
All looks good, with the following notes:

* MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.[1]

  OUTPUT:
mcpierce@mcpierce-laptop:review $ rpmlint
rubygem-goocanvas-1.0.3-1.fc.src.rpm
rubygem-goocanvas.src: E: changelog-time-in-future 2011-12-22
rubygem-goocanvas.src:24: W: mixed-use-of-spaces-and-tabs (spaces: line 24,
tab: line 1)
1 packages and 0 specfiles checked; 1 errors, 1 warnings.

The changelog in the future may just be a timezone issue.


* The package must have a Requires and a BuildRequires on rubygems

I see no such elements in the specfile.

All else looks good. With the Requires/BuildRequires changes made, I approve
this package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 678674] Review Request: rubygem-goocanvas - Ruby binding of GooCanvas

2011-12-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=678674

Mamoru Tasaka mtas...@fedoraproject.org changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Flag||fedora-cvs?

--- Comment #6 from Mamoru Tasaka mtas...@fedoraproject.org 2011-12-21 
23:59:21 EST ---
Thank you for review!

(In reply to comment #5)
 * The package must have a Requires and a BuildRequires on rubygems
 I see no such elements in the specfile.

Since other rubygem-foo-devel or rubygem(bar) has the dependency
for rubygems, I think this isredundant, however if you think it is
preferred I will add when importing this into Fedora git.


New Package SCM Request
===
Package Name:  rubygem-goocanvas
Short Description: Ruby binding of GooCanvas
Owners:mtasaka
Branches:  f16 f15
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 678674] Review Request: rubygem-goocanvas - Ruby binding of GooCanvas

2011-07-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=678674

--- Comment #3 from Mamoru Tasaka mtas...@fedoraproject.org 2011-07-17 
04:47:23 EDT ---
http://mtasaka.fedorapeople.org/Review_request/rubygem-goocanvas/rubygem-goocanvas.spec
http://mtasaka.fedorapeople.org/Review_request/rubygem-goocanvas/rubygem-goocanvas-1.0.0-1.fc.src.rpm

* Sun Jul 17 2011 Mamoru Tasaka mtas...@fedoraproject.org - 1.0.0-1
- 1.0.0
- Kill non-gem support on F-16+

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 678674] Review Request: rubygem-goocanvas - Ruby binding of GooCanvas

2011-04-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=678674

--- Comment #2 from Mamoru Tasaka mtas...@fedoraproject.org 2011-04-09 
13:44:35 EDT ---
http://mtasaka.fedorapeople.org/Review_request/rubygem-goocanvas/rubygem-goocanvas.spec
http://mtasaka.fedorapeople.org/Review_request/rubygem-goocanvas/rubygem-goocanvas-0.90.8-2.fc.src.rpm


* Sun Apr 10 2011 Mamoru Tasaka mtas...@fedoraproject.org - 0.90.8-2
- Some cleanups

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review