[Bug 678728] Review Request: synce-connector - Connection framework and dccm-implementation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678728 --- Comment #14 from Jon Ciesla l...@jcomserv.net 2011-08-23 09:05:38 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678728] Review Request: synce-connector - Connection framework and dccm-implementation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678728 Andreas Bierfert andreas.bierf...@lowlatency.de changed: What|Removed |Added Status|NEW |CLOSED Resolution||RAWHIDE Last Closed||2011-08-23 09:58:19 --- Comment #15 from Andreas Bierfert andreas.bierf...@lowlatency.de 2011-08-23 09:58:19 EDT --- Thanks for the review! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678728] Review Request: synce-connector - Connection framework and dccm-implementation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678728 Markus Mayer lotharl...@gmx.de changed: What|Removed |Added CC||lotharl...@gmx.de --- Comment #8 from Markus Mayer lotharl...@gmx.de 2011-08-22 12:22:11 EDT --- Hi Andreas! If you are still willing to bring to this package to fedora, I would do the review. Creatings Markus -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678728] Review Request: synce-connector - Connection framework and dccm-implementation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678728 --- Comment #9 from Andreas Bierfert andreas.bierf...@lowlatency.de 2011-08-22 13:40:14 EDT --- Hi Markus, yes of course. This would actually fix f16's synce support... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678728] Review Request: synce-connector - Connection framework and dccm-implementation
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=678728
Markus Mayer lotharl...@gmx.de changed:
What|Removed |Added
AssignedTo|nob...@fedoraproject.org|lotharl...@gmx.de
Flag||fedora-review?
--- Comment #10 from Markus Mayer lotharl...@gmx.de 2011-08-22 15:51:11 EDT
---
Hi Andreas!
Formal review:
[OK] MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.[1]
[OK] MUST: The package must be named according to the Package Naming Guidelines
.
[OK] MUST: The spec file name must match the base package %{name}, in the
format %{name}.spec unless your package has an exemption. [2] .
[OK] MUST: The package must meet the Packaging Guidelines .
[OK] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines .
[OK] MUST: The License field in the package spec file must match the actual
license. [3]
[OK] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.[4]
[OK] MUST: The spec file must be written in American English. [5]
[OK] MUST: The spec file for the package MUST be legible. [6]
[OK] MUST: The sources used to build the package must match the upstream
source, as provided in the spec URL. Reviewers should use md5sum for this task.
If no upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
[OK] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture. [7]
[N/A] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line. [8]
[OK] MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
[OK] MUST: The spec file MUST handle locales properly. This is done by using
the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.[9]
[N/A] MUST: Every binary RPM package (or subpackage) which stores shared
library files (not just symlinks) in any of the dynamic linker's default paths,
must call ldconfig in %post and %postun. [10]
[OK] MUST: Packages must NOT bundle copies of system libraries.[11]
[N/A] MUST: If the package is designed to be relocatable, the packager must
state this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker. [12]
[OK] MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory. [13]
[OK] MUST: A Fedora package must not list a file more than once in the spec
file's %files listings. (Notable exception: license texts in specific
situations)[14]
[OK] MUST: Permissions on files must be set properly. Executables should be set
with executable permissions, for example. [15]
[FAIL] MUST: Each package must consistently use macros. [16]
[OK] MUST: The package must contain code, or permissable content. [17]
[N/A] MUST: Large documentation files must go in a -doc subpackage. (The
definition of large is left up to the packager's best judgement, but is not
restricted to size. Large can refer to either size or quantity). [18]
[OK] MUST: If a package includes something as %doc, it must not affect the
runtime of the application. To summarize: If it is in %doc, the program must
run properly if it is not present. [18]
[N/A] MUST: Header files must be in a -devel package. [19]
[N/A] MUST: Static libraries must be in a -static package. [20]
[N/A] MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), then library files that end in .so (without suffix) must go in
a -devel package. [19]
[N/A] MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency: Requires: %{name}%{?_isa} =
%{version}-%{release} [21]
[OK] MUST: Packages must NOT contain any .la libtool archives, these must be
removed in the spec if they are built.[20]
[N/A] MUST: Packages containing GUI applications must include a %{name}.desktop
file, and that file must be properly installed with desktop-file-install in the
[Bug 678728] Review Request: synce-connector - Connection framework and dccm-implementation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678728 --- Comment #11 from Andreas Bierfert andreas.bierf...@lowlatency.de 2011-08-22 16:12:09 EDT --- Thanks for reviewing! Here is a spec with the first two issues fixed. I would like to leave the version information as separate bullet point as with all the other packages I maintain. This has been clarified before and agreed to. http://fedora.lowlatency.de/review/synce-connector-0.15.2-3.fc16.src.rpm http://fedora.lowlatency.de/review/synce-connector.spec * Mon Aug 22 2011 Andreas Bierfert andreas.bierfert[AT]lowlatency.de - 0.15.2-3 - require python for udev scripts - macro cleanups -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678728] Review Request: synce-connector - Connection framework and dccm-implementation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678728 Markus Mayer lotharl...@gmx.de changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #12 from Markus Mayer lotharl...@gmx.de 2011-08-22 16:36:48 EDT --- This package is APPROVED If you are having trouble pushing this package to stable, feel free to contact me. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678728] Review Request: synce-connector - Connection framework and dccm-implementation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678728 Andreas Bierfert andreas.bierf...@lowlatency.de changed: What|Removed |Added Flag||fedora-cvs? --- Comment #13 from Andreas Bierfert andreas.bierf...@lowlatency.de 2011-08-22 16:46:28 EDT --- New Package SCM Request === Package Name: synce-connector Short Description: Connection framework and dccm-implementation Owners: awjb Branches: f16 f15 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678728] Review Request: synce-connector - Connection framework and dccm-implementation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678728 --- Comment #7 from Andreas Bierfert andreas.bierf...@lowlatency.de 2011-07-15 02:06:57 EDT --- Thank you for your comments. synce-connector.x86_64: W: non-conffile-in-etc /etc/dbus-1/system.d/org.synce.dccm.conf From a quick look pulse marks it as config(noreplace) and bluez as config. I guess we are ok here with marking it as config(noreplace). You are right, maybe this should be mentioned in the guidelines somewhere. synce-connector.x86_64: E: non-readable /etc/ppp/peers/synce-bt-peer 0600L Fixed. Installed with default perms. http://fedora.lowlatency.de/review/synce-connector.spec http://fedora.lowlatency.de/review/synce-connector-0.15.2-2.fc16.src.rpm * Fri Jul 15 2011 Andreas Bierfert andreas.bierfert[AT]lowlatency.de - 0.15.2-2 - mark dbus conf as %%config(noreplace) - install peer file with default permissions - pull upstream fix for dccm naming -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678728] Review Request: synce-connector - Connection framework and dccm-implementation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678728 --- Comment #5 from Andreas Bierfert andreas.bierf...@lowlatency.de 2011-07-14 08:41:52 EDT --- Rawhide build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3198492 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678728] Review Request: synce-connector - Connection framework and dccm-implementation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678728 Adam Williamson awill...@redhat.com changed: What|Removed |Added CC||awill...@redhat.com --- Comment #6 from Adam Williamson awill...@redhat.com 2011-07-14 22:07:23 EDT --- rpmlint now returns one error and three warnings: synce-connector.x86_64: E: non-readable /etc/ppp/peers/synce-bt-peer 0600L synce-connector.x86_64: W: non-conffile-in-etc /etc/dbus-1/system.d/org.synce.dccm.conf synce-connector.x86_64: W: no-manual-page-for-binary synce-unlock synce-connector.x86_64: W: no-manual-page-for-binary synce-serial the last two warnings can be ignored, the non-conffile-in-etc might be an issue, but of two other files in that directory that I checked, both were also not marked as config files, so it might be generally the case that these should not be config files (and that might need to be made an exception to the packaging guidelines, I guess). The error may be okay if that file is only ever read as root; is that correct? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678728] Review Request: synce-connector - Connection framework and dccm-implementation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678728 Andreas Bierfert andreas.bierf...@lowlatency.de changed: What|Removed |Added Blocks||701257 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678728] Review Request: synce-connector - Connection framework and dccm-implementation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678728 --- Comment #4 from Andreas Bierfert andreas.bierf...@lowlatency.de 2011-05-23 10:35:33 EDT --- http://fedora.lowlatency.de/review/synce-connector-0.15.2-1.fc15.src.rpm http://fedora.lowlatency.de/review/synce-connector.spec https://koji.fedoraproject.org/koji/taskinfo?taskID=3087529 * Mon May 23 2011 Andreas Bierfert andreas.bierfert[AT]lowlatency.de - 0.15.2-1 - version upgrade -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678728] Review Request: synce-connector - Connection framework and dccm-implementation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678728 --- Comment #3 from Andreas Bierfert andreas.bierf...@lowlatency.de 2011-02-22 16:19:10 EST --- http://fedora.lowlatency.de/review/synce-connector-0.15.1-2.fc14.src.rpm http://fedora.lowlatency.de/review/synce-connector.spec Thank you for you comment. Changed! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678728] Review Request: synce-connector - Connection framework and dccm-implementation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678728 Sergio Belkin seb...@gmail.com changed: What|Removed |Added CC||seb...@gmail.com --- Comment #2 from Sergio Belkin seb...@gmail.com 2011-02-21 11:55:44 EST --- Hi Andreas! Your rpm has some issues: (I am (still) not member of Packaging group, however I hope you find this little review useful): synce-connector.i686: W: non-conffile-in-etc /etc/ppp/peers/synce-bt-peer A non-executable file in your package is being installed in /etc, but is not a configuration file. All non-executable files in /etc should be configuration files. Mark the file as %config in the spec file. http://fedoraproject.org/wiki/Packaging:Guidelines#Configuration_files and http://fedoraproject.org/wiki/Common_Rpmlint_issues#non-conffile-in-etc You could take a look to wvdial spec for example http://pkgs.fedoraproject.org/gitweb/?p=wvdial.git;a=blob;f=wvdial.spec;h=3bfc6ac99840938218ebf0fc53fb0dabd4d997a6;hb=master HTH Greets -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678728] Review Request: synce-connector - Connection framework and dccm-implementation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678728 Andreas Bierfert andreas.bierf...@lowlatency.de changed: What|Removed |Added URL||http://www.synce.org/ Blocks||498409, 498410, 520875, ||582365 --- Comment #1 from Andreas Bierfert andreas.bierf...@lowlatency.de 2011-02-19 00:34:09 EST --- Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=2840167 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
