[Bug 678774] Review Request: libscs - Software Carry-Save Multiple-Precision Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678774 Tim Niemueller changed: What|Removed |Added Blocks||676159 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678774] Review Request: libscs - Software Carry-Save Multiple-Precision Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678774 --- Comment #1 from Tim Niemueller 2011-02-19 09:55:00 EST --- Just after posting I discovered a typo in the configure line, causing the library to be built without MPFR support and thus rendering scs_test_accuracy disfunctional. Spec changed in place, new SRPM is at http://fedorapeople.org/~timn/misc/libscs-1.4.1-2.fc14.src.rpm. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678774] Review Request: libscs - Software Carry-Save Multiple-Precision Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678774 Dmitrij S. Kryzhevich changed: What|Removed |Added Status|NEW |ASSIGNED CC||kr...@land.ru AssignedTo|nob...@fedoraproject.org|kr...@land.ru --- Comment #2 from Dmitrij S. Kryzhevich 2011-02-20 02:01:20 EST --- Why do you move "#include " in scslib-1.4.1/tests/test_accuracy.c? Suggestion: make "%doc DocsDev/html" to get html subfolder in -devel. Are the test programs required? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678774] Review Request: libscs - Software Carry-Save Multiple-Precision Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678774 --- Comment #3 from Dmitrij S. Kryzhevich 2011-02-20 02:55:24 EST --- One more. libscs-devel must Require mpfr-devel and gmp-devel. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678774] Review Request: libscs - Software Carry-Save Multiple-Precision Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678774 --- Comment #4 from Tim Niemueller 2011-02-20 05:46:22 EST --- (In reply to comment #2) > Why do you move "#include " in scslib-1.4.1/tests/test_accuracy.c? Because it is required to get a macro defined in gmp.h, which consequently makes mpfr_out_str available. > Suggestion: make "%doc DocsDev/html" to get html subfolder in -devel. Since the HTML documentation is the only thing packaged as %doc it only adds on more meaningless level of hierarchy. > Are the test programs required? They provide valuable run-time data specific to the host system the application is running on, therefore they should be shipped with the library afaik. > One more. libscs-devel must Require mpfr-devel and gmp-devel. Added. Spec changed in place, new SRPM is at http://fedorapeople.org/~timn/misc/libscs-1.4.1-3.fc14.src.rpm. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678774] Review Request: libscs - Software Carry-Save Multiple-Precision Library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=678774
Dmitrij S. Kryzhevich changed:
What|Removed |Added
Flag||fedora-review+
--- Comment #5 from Dmitrij S. Kryzhevich 2011-02-20 06:23:34
EST ---
(In reply to comment #4)
> Because it is required to get a macro defined in gmp.h, which consequently
> makes mpfr_out_str available.
Hm. The order of #include influences on the result. Greate.
> Since the HTML documentation is the only thing packaged as %doc it only adds
> on
> more meaningless level of hierarchy.
Ok.
> They provide valuable run-time data specific to the host system the
> application
> is running on, therefore they should be shipped with the library afaik.
Ok.
Review ===
+ rpmlint was run on the source rpm and all binary rpms the build produces.
+ The package was named according to the Package Naming Guidelines.
+ The spec file name matchs the base package %{name}.
+ The package meets the Packaging Guidelines.
+ The package is licensed with a Fedora approved license LGPLv2+.
+ The License field in the package spec file must match the actual license.
+ File, containing the text of the license(s) for the package is included in
%doc.
+ The spec file must is written in American English.
+ The spec file for the package is legible.
+ The sources used to build the package matchs the upstream source.
+ The package is successfully compiled and build into binary rpms on at least
one primary architecture.
+ All build dependencies must are listed in BuildRequires.
+ Binary RPM package calls ldconfig in %post and %postun.
+ Packages do NOT bundle copies of system libraries.
+ A package owns all directories that it creates.
+ A package do not list a file more than once in the spec file's %files
listings.
+ Permissions on files are set properly.
+ Package consistently uses macros.
+ The package contains code, or permissable content.
* No localization.
* No large documentaion.
+ Everything included as %doc do not affect the runtime of the application.
+ Header files are in a -devel package.
* No static libraries.
+ Library files that end in .so (without suffix) are in a -devel package.
+ Devel packages requires the base package in proper way.
+ Packages do NOT contain any .la libtool archives.
* Not a GUI application.
+ Packages do not own files or directories already owned by other packages.
+ All filenames in rpm packages must be valid UTF-8.
Approved.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678774] Review Request: libscs - Software Carry-Save Multiple-Precision Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678774 Tim Niemueller changed: What|Removed |Added Flag||fedora-cvs? --- Comment #6 from Tim Niemueller 2011-02-20 08:57:23 EST --- Thanks for the thorough review. New Package SCM Request === Package Name: libscs Short Description: Software Carry-Save Multiple-Precision Library Owners: timn Branches: f14 f15 el5 el6 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678774] Review Request: libscs - Software Carry-Save Multiple-Precision Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678774 --- Comment #7 from Jason Tibbitts 2011-02-21 15:34:04 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678774] Review Request: libscs - Software Carry-Save Multiple-Precision Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678774 --- Comment #8 from Fedora Update System 2011-02-21 18:38:25 EST --- libscs-1.4.1-4.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/libscs-1.4.1-4.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678774] Review Request: libscs - Software Carry-Save Multiple-Precision Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678774 --- Comment #9 from Fedora Update System 2011-02-21 18:38:54 EST --- libscs-1.4.1-4.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/libscs-1.4.1-4.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678774] Review Request: libscs - Software Carry-Save Multiple-Precision Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678774 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678774] Review Request: libscs - Software Carry-Save Multiple-Precision Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678774 --- Comment #11 from Fedora Update System 2011-02-21 18:39:55 EST --- libscs-1.4.1-4.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/libscs-1.4.1-4.el6 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678774] Review Request: libscs - Software Carry-Save Multiple-Precision Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678774 --- Comment #10 from Fedora Update System 2011-02-21 18:39:26 EST --- libscs-1.4.1-4.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/libscs-1.4.1-4.el5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678774] Review Request: libscs - Software Carry-Save Multiple-Precision Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678774 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #12 from Fedora Update System 2011-02-22 13:53:27 EST --- libscs-1.4.1-4.fc14 has been pushed to the Fedora 14 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update libscs'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/libscs-1.4.1-4.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678774] Review Request: libscs - Software Carry-Save Multiple-Precision Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678774 --- Comment #13 from Fedora Update System 2011-03-02 22:34:55 EST --- libscs-1.4.1-4.fc15 has been pushed to the Fedora 15 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678774] Review Request: libscs - Software Carry-Save Multiple-Precision Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678774 --- Comment #14 from Fedora Update System 2011-03-03 03:23:05 EST --- libscs-1.4.1-4.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678774] Review Request: libscs - Software Carry-Save Multiple-Precision Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678774 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||libscs-1.4.1-4.fc14 Resolution||ERRATA Last Closed||2011-03-03 03:23:10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678774] Review Request: libscs - Software Carry-Save Multiple-Precision Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678774 --- Comment #16 from Fedora Update System 2011-03-10 12:23:58 EST --- libscs-1.4.1-4.el6 has been pushed to the Fedora EPEL 6 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678774] Review Request: libscs - Software Carry-Save Multiple-Precision Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678774 --- Comment #15 from Fedora Update System 2011-03-10 12:23:50 EST --- libscs-1.4.1-4.el5 has been pushed to the Fedora EPEL 5 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
