[Bug 678887] Review Request: libst2205 - Library for accessing the display of hacked st2205 photo frames
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678887 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|libst2205-1.4.3-2.fc14 |libst2205-1.4.3-2.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678887] Review Request: libst2205 - Library for accessing the display of hacked st2205 photo frames
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678887 --- Comment #13 from Fedora Update System upda...@fedoraproject.org 2011-03-03 03:39:59 EST --- libst2205-1.4.3-2.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678887] Review Request: libst2205 - Library for accessing the display of hacked st2205 photo frames
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678887 --- Comment #14 from Fedora Update System upda...@fedoraproject.org 2011-03-03 03:41:51 EST --- libst2205-1.4.3-2.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678887] Review Request: libst2205 - Library for accessing the display of hacked st2205 photo frames
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678887 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|libst2205-1.4.3-2.fc15 |libst2205-1.4.3-2.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678887] Review Request: libst2205 - Library for accessing the display of hacked st2205 photo frames
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678887 --- Comment #12 from Fedora Update System upda...@fedoraproject.org 2011-03-02 22:26:45 EST --- libst2205-1.4.3-2.fc15 has been pushed to the Fedora 15 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678887] Review Request: libst2205 - Library for accessing the display of hacked st2205 photo frames
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678887 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||libst2205-1.4.3-2.fc15 Resolution||ERRATA Last Closed||2011-03-02 22:26:53 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678887] Review Request: libst2205 - Library for accessing the display of hacked st2205 photo frames
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678887 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678887] Review Request: libst2205 - Library for accessing the display of hacked st2205 photo frames
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678887 --- Comment #8 from Fedora Update System upda...@fedoraproject.org 2011-02-22 04:32:38 EST --- libst2205-1.4.3-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/libst2205-1.4.3-2.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678887] Review Request: libst2205 - Library for accessing the display of hacked st2205 photo frames
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678887 --- Comment #10 from Fedora Update System upda...@fedoraproject.org 2011-02-22 04:34:20 EST --- libst2205-1.4.3-2.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/libst2205-1.4.3-2.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678887] Review Request: libst2205 - Library for accessing the display of hacked st2205 photo frames
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678887 --- Comment #9 from Fedora Update System upda...@fedoraproject.org 2011-02-22 04:33:45 EST --- libst2205-1.4.3-2.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/libst2205-1.4.3-2.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678887] Review Request: libst2205 - Library for accessing the display of hacked st2205 photo frames
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678887 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #11 from Fedora Update System upda...@fedoraproject.org 2011-02-22 13:48:24 EST --- libst2205-1.4.3-2.fc14 has been pushed to the Fedora 14 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update libst2205'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/libst2205-1.4.3-2.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678887] Review Request: libst2205 - Library for accessing the display of hacked st2205 photo frames
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=678887
Tim Lauridsen t...@rasmil.dk changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #4 from Tim Lauridsen t...@rasmil.dk 2011-02-21 03:22:04 EST ---
Package Review
==
Key:
- = N/A
x = Check
! = Problem
? = Not evaluated
[x] : MUST - Package successfully compiles and builds into binary rpms on at
least one supported architecture.
[x] : MUST - Buildroot is correct (EPEL5 Fedora 10)
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
[x] : MUST - Package has a %clean section, which contains rm -rf %{buildroot}
(or $RPM_BUILD_ROOT).
[x] : MUST - Each %files section contains %defattr
[x] : MUST - Spec file lacks Packager, Vendor, PreReq tags.
[x] : MUST - Package run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) and the
beginning of %install.
[x] : MUST - Package use %makeinstall only when make install DESTDIR=...
doesn't work.
[x] : MUST - Package is named according to the Package Naming Guidelines.
[!] : MUST - Rpmlint output is silent.
rpmlint libst2205-1.4.3-2.fc15.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
rpmlint libst2205-1.4.3-2.fc14.i686.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
rpmlint libst2205-devel-1.4.3-2.fc14.i686.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
rpmlint libst2205-debuginfo-1.4.3-2.fc14.i686.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
rpmlint libst2205-tools-1.4.3-2.fc14.i686.rpm
libst2205-tools.i686: W: no-documentation
libst2205-tools.i686: W: no-manual-page-for-binary st2205-setpic
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
[x] : MUST - Sources used to build the package matches the upstream source, as
provided in the spec URL.
MD5SUM this package : c87f05a5f692e869d2d050aa3d4fd6c5
MD5SUM upstream package : c87f05a5f692e869d2d050aa3d4fd6c5
[x] : MUST - Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x] : MUST - Spec file is legible and written in American English.
[x] : MUST - Spec uses macros instead of hard-coded directory names.
[x] : MUST - Package consistently uses macros.
[x] : MUST - Macros in Summary, %description expandable at SRPM build time.
[x] : MUST - Requires correct, justified where necessary.
[x] : MUST - All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[-] : MUST - The spec file handles locales properly.
[x] : MUST - Changelog in prescribed format.
[x] : MUST - License field in the package spec file matches the actual license.
[x] : MUST - If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[x] : MUST - License file installed when any subpackage combination is
installed.
[x] : MUST - Package is licensed with an open-source compatible license and
meets other legal requirements as defined in the legal section of Packaging
Guidelines.
[x] : MUST - Sources contain only permissible code or content.
[x] : MUST - Compiler flags are appropriate.
[x] : MUST - %build honors applicable compiler flags or justifies otherwise.
[x] : MUST - ldconfig called in %post and %postun if required.
[x] : MUST - Package must own all directories that it creates.
[x] : MUST - Package does not own files or directories owned by other packages.
[x] : MUST - Package requires other packages for directories it uses.
[x] : MUST - Package does not contain duplicates in %files.
[x] : MUST - Permissions on files are set properly.
[-] : MUST - No %config files under /usr.
[-] : MUST - %config files are marked noreplace
[Bug 678887] Review Request: libst2205 - Library for accessing the display of hacked st2205 photo frames
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678887 --- Comment #5 from Hans de Goede hdego...@redhat.com 2011-02-21 03:26:00 EST --- Thanks for the review! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678887] Review Request: libst2205 - Library for accessing the display of hacked st2205 photo frames
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678887 Hans de Goede hdego...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #6 from Hans de Goede hdego...@redhat.com 2011-02-21 03:27:35 EST --- New Package SCM Request === Package Name: libst2205 Short Description: Library for accessing the display of hacked st2205 photo frames Owners: jwrdegoede Branches: f13 f14 f15 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678887] Review Request: libst2205 - Library for accessing the display of hacked st2205 photo frames
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678887 --- Comment #7 from Jason Tibbitts ti...@math.uh.edu 2011-02-21 15:34:24 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678887] Review Request: libst2205 - Library for accessing the display of hacked st2205 photo frames
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678887 Tim Lauridsen t...@rasmil.dk changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|t...@rasmil.dk -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678887] Review Request: libst2205 - Library for accessing the display of hacked st2205 photo frames
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678887 Tim Lauridsen t...@rasmil.dk changed: What|Removed |Added Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678887] Review Request: libst2205 - Library for accessing the display of hacked st2205 photo frames
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678887 Tim Lauridsen t...@rasmil.dk changed: What|Removed |Added Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678887] Review Request: libst2205 - Library for accessing the display of hacked st2205 photo frames
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678887 Sergio Belkin seb...@gmail.com changed: What|Removed |Added CC||seb...@gmail.com --- Comment #2 from Sergio Belkin seb...@gmail.com 2011-02-20 14:06:07 EST --- Hi Hans I am (still) not member of packaging group, however I hope my review be useful: AFAIK these are non-fatal errors: 1. BuildRoot is not needed anymore. 2. The same goes for clean section. http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag The following is a fatal error, sorry for my insolenece taking into account that I'm not still of packaging group... 3. I don't know if I miss something but I see that koji is failing trying to compile the package: main.c:25:16: fatal error: gd.h: No such file or directory The same applies for mock. You should add BuildRequieres: gd-devel Also, is failing to find st2205.h, fix the %build section accordingly. Greets -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678887] Review Request: libst2205 - Library for accessing the display of hacked st2205 photo frames
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678887 --- Comment #3 from Hans de Goede hdego...@redhat.com 2011-02-20 14:22:59 EST --- Sergio, Thanks for the feedback, here is a fixed version: Spec URL: http://people.fedoraproject.org/~jwrdegoede/libst2205.spec SRPM URL: http://people.fedoraproject.org/~jwrdegoede/libst2205-1.4.3-2.fc15.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
