[Bug 679401] Review Request: qtsoap - The Simple Object Access Protocol Qt-based client side library
https://bugzilla.redhat.com/show_bug.cgi?id=679401 Eric Smith space...@gmail.com changed: What|Removed |Added CC||space...@gmail.com Flags|fedora-cvs+ |fedora-cvs? --- Comment #15 from Eric Smith space...@gmail.com --- Package Change Request == Package Name: qtsoap New Branches: el7 Owners: jreznik brouhaha -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 679401] Review Request: qtsoap - The Simple Object Access Protocol Qt-based client side library
https://bugzilla.redhat.com/show_bug.cgi?id=679401 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 679401] Review Request: qtsoap - The Simple Object Access Protocol Qt-based client side library
https://bugzilla.redhat.com/show_bug.cgi?id=679401 --- Comment #16 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 679401] Review Request: qtsoap - The Simple Object Access Protocol Qt-based client side library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=679401 Jaroslav Reznik jrez...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE Flag|needinfo?(wm...@wm161.net) | Last Closed||2011-07-19 05:02:37 --- Comment #12 from Jaroslav Reznik jrez...@redhat.com 2011-07-19 05:02:37 EDT --- imported built for rawhide -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 679401] Review Request: qtsoap - The Simple Object Access Protocol Qt-based client side library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=679401 Jaroslav Reznik jrez...@redhat.com changed: What|Removed |Added Flag||needinfo?(wm...@wm161.net) --- Comment #11 from Jaroslav Reznik jrez...@redhat.com 2011-07-14 09:23:46 EDT --- Trever, could you share your SPEC file with me (the one Rex is talking about)? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 679401] Review Request: qtsoap - The Simple Object Access Protocol Qt-based client side library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=679401 --- Comment #8 from Jaroslav Reznik jrez...@redhat.com 2011-07-07 04:31:03 EDT --- (In reply to comment #7) ping? Rex, I'd like to implement suggested enhancements but I was busy... So probably I should just import it in the current state... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 679401] Review Request: qtsoap - The Simple Object Access Protocol Qt-based client side library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=679401 Jaroslav Reznik jrez...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #9 from Jaroslav Reznik jrez...@redhat.com 2011-07-07 05:22:10 EDT --- New Package SCM Request === Package Name: qtsoap Short Description: The Simple Object Access Protocol Qt-based client side library Owners: jreznik rdieter kkofler than Branches: f14 f15 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 679401] Review Request: qtsoap - The Simple Object Access Protocol Qt-based client side library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=679401 --- Comment #10 from Jon Ciesla l...@jcomserv.net 2011-07-07 06:09:47 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 679401] Review Request: qtsoap - The Simple Object Access Protocol Qt-based client side library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=679401 --- Comment #7 from Rex Dieter rdie...@math.unl.edu 2011-07-06 11:19:44 EDT --- ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 679401] Review Request: qtsoap - The Simple Object Access Protocol Qt-based client side library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=679401 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Alias||qtsoap -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 679401] Review Request: qtsoap - The Simple Object Access Protocol Qt-based client side library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=679401
--- Comment #6 from Jaroslav Reznik jrez...@redhat.com 2011-05-20 10:44:13
EDT ---
(In reply to comment #5)
licensing: OK
scriptlets: OK
naming: OK
URL provided doesn't work for me, please find something better. Not a
blocker.
rpmlint: clean, OK
builds/installs OK
In a perfect world, I'd like to see comment #3 addressed too, wrt keeping
library naming more consistent, using something from trever's .spec he showed
us earlier today:
%build
echo 'yes' | \
./configure -library
echo QTSOAP_LIBNAME = \$\$qtLibraryTarget(qtsoap) common.pri
echo VERSION=%{version} common.pri
qmake-qt4
make %{?_smp_mflags}
But, I'll leave it up to you on how best to resolve that (with some potential
upstream poking). not a blocker.
Otherwise, looks good, APPROVED
There's no upstream anymore but I'll try to incorporate this change into my
fedora qt-soap branch.
Thanks for review, good spot guys.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 679401] Review Request: qtsoap - The Simple Object Access Protocol Qt-based client side library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=679401 --- Comment #2 from Jaroslav Reznik jrez...@redhat.com 2011-05-19 11:56:59 EDT --- spec URL: http://rezza.hofyland.cz/fedora/packages/qtsoap/qtsoap.spec SRPM URL: http://rezza.hofyland.cz/fedora/packages/qtsoap/qtsoap-2.7-1.fc14.src.rpm Fixed version. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 679401] Review Request: qtsoap - The Simple Object Access Protocol Qt-based client side library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=679401 Trever Fischer wm...@wm161.net changed: What|Removed |Added CC||wm...@wm161.net --- Comment #3 from Trever Fischer wm...@wm161.net 2011-05-19 12:05:42 EDT --- Not a review, but a brief comment: the library should be installed as 'libqtsoap', not 'libQtSolutions_SOAP', for consistency with the package name. Or vice-versa, calling the package 'qtsolutions-soap'. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 679401] Review Request: qtsoap - The Simple Object Access Protocol Qt-based client side library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=679401 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added CC||rdie...@math.unl.edu AssignedTo|nob...@fedoraproject.org|rdie...@math.unl.edu Flag||fedora-review? --- Comment #4 from Rex Dieter rdie...@math.unl.edu 2011-05-19 13:54:09 EDT --- I can review this. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 679401] Review Request: qtsoap - The Simple Object Access Protocol Qt-based client side library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=679401
Rex Dieter rdie...@math.unl.edu changed:
What|Removed |Added
Status|NEW |ASSIGNED
Flag|fedora-review? |fedora-review+
--- Comment #5 from Rex Dieter rdie...@math.unl.edu 2011-05-19 14:04:20 EDT
---
licensing: OK
scriptlets: OK
naming: OK
URL provided doesn't work for me, please find something better. Not a blocker.
rpmlint: clean, OK
builds/installs OK
In a perfect world, I'd like to see comment #3 addressed too, wrt keeping
library naming more consistent, using something from trever's .spec he showed
us earlier today:
%build
echo 'yes' | \
./configure -library
echo QTSOAP_LIBNAME = \$\$qtLibraryTarget(qtsoap) common.pri
echo VERSION=%{version} common.pri
qmake-qt4
make %{?_smp_mflags}
But, I'll leave it up to you on how best to resolve that (with some potential
upstream poking). not a blocker.
Otherwise, looks good, APPROVED
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 679401] Review Request: qtsoap - The Simple Object Access Protocol Qt-based client side library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=679401 Jaroslav Reznik jrez...@redhat.com changed: What|Removed |Added Blocks||680174 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 679401] Review Request: qtsoap - The Simple Object Access Protocol Qt-based client side library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=679401 Jaroslav Reznik jrez...@redhat.com changed: What|Removed |Added Blocks||656997(kde-reviews) --- Comment #1 from Jaroslav Reznik jrez...@redhat.com 2011-02-22 08:58:18 EST --- rpmlint qtsoap.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint ../RPMS/x86_64/qtsoap-* 3 packages and 0 specfiles checked; 0 errors, 0 warnings. This package is needed for herqq (hupnp) which currently bundles own copy of qtsoap (it's intention of qtsoap developers). The final dependency is kio-upnp-ms (to be packaged). Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2857314 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
