[Bug 681558] Review Request: libvirt-snmp - SNMP support for libvirt
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=681558 Tomas Mraz tm...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||libvirt-snmp-0.0.2-1.fc16 Resolution||NEXTRELEASE Last Closed||2011-08-16 05:03:36 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 681558] Review Request: libvirt-snmp - SNMP support for libvirt
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=681558 Kevin Kofler ke...@tigcc.ticalc.org changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) Depends on|177841(FE-NEEDSPONSOR) | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 681558] Review Request: libvirt-snmp - SNMP support for libvirt
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=681558 Michal Privoznik mpriv...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #9 from Michal Privoznik mpriv...@redhat.com 2011-03-16 06:47:18 EDT --- New Package SCM Request === Package Name: libvirt-snmp Short Description: Provide full snmp functionality for libvirtd Owners: mprivozn Branches: f15 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 681558] Review Request: libvirt-snmp - SNMP support for libvirt
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=681558 --- Comment #10 from Jason Tibbitts ti...@math.uh.edu 2011-03-16 08:25:39 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 681558] Review Request: libvirt-snmp - SNMP support for libvirt
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=681558 Tomas Mraz tm...@redhat.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #8 from Tomas Mraz tm...@redhat.com 2011-03-15 17:17:51 EDT --- The rpmlint output: rpmlint -v libvirt-snmp-0.0.1-3.fc13.src.rpm libvirt-snmp-0.0.1-3.fc13.x86_64.rpm libvirt-snmp-debuginfo-0.0.1-3.fc13.x86_64.rpm libvirt-snmp.src: I: checking libvirt-snmp.src: I: checking-url http://libvirt.org (timeout 10 seconds) libvirt-snmp.src:40: W: macro-in-%changelog %doc This is harmless, but please correct it before you import. Just remove the % so it is not interpreted. libvirt-snmp.src: I: checking-url http://www.libvirt.org/sources/snmp/libvirt-snmp-0.0.1.tar.gz (timeout 10 seconds) libvirt-snmp.x86_64: I: checking libvirt-snmp.x86_64: I: checking-url http://libvirt.org (timeout 10 seconds) libvirt-snmp-debuginfo.x86_64: I: checking libvirt-snmp-debuginfo.x86_64: I: checking-url http://libvirt.org (timeout 10 seconds) 3 packages and 0 specfiles checked; 0 errors, 1 warnings. Other than the non-blocker issue the rpmlint is silent. The package seems to comply with Fedora packaging guidelines. APPROVED. I will sponsor you for fedora packager group. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 681558] Review Request: libvirt-snmp - SNMP support for libvirt
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=681558 --- Comment #7 from Michal Privoznik mpriv...@redhat.com 2011-03-11 05:27:59 EST --- Updated. SRPM URL: ftp://libvirt.org/libvirt/snmp/libvirt-snmp-0.0.1-3.fc14.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 681558] Review Request: libvirt-snmp - SNMP support for libvirt
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=681558 Michal Privoznik mpriv...@redhat.com changed: What|Removed |Added Flag|needinfo?(mprivozn@redhat.c | |om) | --- Comment #4 from Michal Privoznik mpriv...@redhat.com 2011-03-10 09:30:53 EST --- Updated. Spec URL: http://www.libvirt.org/git/?p=libvirt-snmp.git;a=blob;f=libvirt-snmp.spec.in;hb=HEAD SRPM URL: ftp://libvirt.org/libvirt/snmp/libvirt-snmp-0.0.1-2.fc14.src.rpm new tarball: ftp://libvirt.org/libvirt/snmp/libvirt-snmp-0.0.1-2.tar.gz LIBVIRT-MIB.txt is also in %doc, because it is part of documentation to allow users see what information they can gather/set. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 681558] Review Request: libvirt-snmp - SNMP support for libvirt
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=681558 --- Comment #5 from Tomas Mraz tm...@redhat.com 2011-03-10 10:19:33 EST --- (In reply to comment #4) Updated. Spec URL: http://www.libvirt.org/git/?p=libvirt-snmp.git;a=blob;f=libvirt-snmp.spec.in;hb=HEAD SRPM URL: ftp://libvirt.org/libvirt/snmp/libvirt-snmp-0.0.1-2.fc14.src.rpm new tarball: ftp://libvirt.org/libvirt/snmp/libvirt-snmp-0.0.1-2.tar.gz This does not make much sense - the tarball should stay the same if you're just changing the .spec file and not the source files. I know that you have the .spec.in in the upstream git repository however the Fedora spec should track the upstream spec only on rebases of the sources. So I recommend to use the 0.0.x versioning for the upstream tarball and have the spec file changes tracked only in the upstream git. Not to change the tarball with all the spec changes. LIBVIRT-MIB.txt is also in %doc, because it is part of documentation to allow users see what information they can gather/set. This does not make much sense to me. The file is in the filesystem at one place and there is no reason to duplicate it as %doc somewhere else. Perhaps at most duplicate it as a symlink in the doc. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 681558] Review Request: libvirt-snmp - SNMP support for libvirt
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=681558 --- Comment #6 from Stanislav Ochotnicky socho...@redhat.com 2011-03-10 11:08:14 EST --- (In reply to comment #5) LIBVIRT-MIB.txt is also in %doc, because it is part of documentation to allow users see what information they can gather/set. This does not make much sense to me. The file is in the filesystem at one place and there is no reason to duplicate it as %doc somewhere else. Perhaps at most duplicate it as a symlink in the doc. That was my suggestion because looking at contents of rpm I noticed *.txt file that was not in %doc. I almost changed my mind, but I really believe this file can be useful for users/developers so I believe you should keep it in spec. Symlink will do of course. Would anyone care to explain why do these files even have *.txt extension? It's doesn't make much sense to me... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 681558] Review Request: libvirt-snmp - SNMP support for libvirt
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=681558 Tomas Mraz tm...@redhat.com changed: What|Removed |Added Flag||needinfo?(mprivozn@redhat.c ||om) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 681558] Review Request: libvirt-snmp - SNMP support for libvirt
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=681558 --- Comment #3 from Tomas Mraz tm...@redhat.com 2011-03-09 06:14:24 EST --- The libvirt tarball from the .src.rpm is different from the one at the URL. Please correct that. If you update the .src.rpm and spec, please always bump the Release and add Changelog entry. I noted that the license is GPLv3 - only - is that intentional? The source files do not contain any copyright comment - it is not required however it is recommended that they contain it (at least the non-autogenerated ones). There is the COPYING file that contains GPLv3 (which by itself allows the code to be licensed under the later future GPL licenses). However README states that the license is GPLv3 which limits it. Why is the LIBVIRT-MIB.txt both in %doc and in the snmp/mibs data dir? I do not think it should be %doc - it is not in the net-snmp-libs package which contains most of the mib files. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 681558] Review Request: libvirt-snmp - SNMP support for libvirt
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=681558 Tomas Mraz tm...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||tm...@redhat.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 681558] Review Request: libvirt-snmp - SNMP support for libvirt
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=681558 Tomas Mraz tm...@redhat.com changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|tm...@redhat.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 681558] Review Request: libvirt-snmp - SNMP support for libvirt
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=681558
--- Comment #2 from Michal Privoznik mpriv...@redhat.com 2011-03-03 07:27:15
EST ---
(In reply to comment #1)
Not a sponsor, just a quick look and few hints:
--
Release:1%{?dist}%{?extra_release}
should be just
Release:1%{?dist}
--
I disagree. It is there for performing our automated builds and for people who
want to rebuild RPM and append unique string to identify their build. All our
virt related RPMS have this.
Other hints taken in. URLs stays the same.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 681558] Review Request: libvirt-snmp - SNMP support for libvirt
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=681558 Michal Privoznik mpriv...@redhat.com changed: What|Removed |Added Depends on||177841(FE-NEEDSPONSOR) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 681558] Review Request: libvirt-snmp - SNMP support for libvirt
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=681558
Stanislav Ochotnicky socho...@redhat.com changed:
What|Removed |Added
CC||socho...@redhat.com
--- Comment #1 from Stanislav Ochotnicky socho...@redhat.com 2011-03-02
11:25:45 EST ---
Not a sponsor, just a quick look and few hints:
--
Release:1%{?dist}%{?extra_release}
should be just
Release:1%{?dist}
--
%clean sections and rm -rf $RPM_BUILD_ROOT at the beginning of %install is no
longer needed. (unless you plan to get this to EL-5)
--
Shouldn't this be %doc as well?
%{_datadir}/snmp/mibs/LIBVIRT-MIB.txt
--
I am guessing this will be automatically added by rpm when building package so
no need for it:
Requires: net-snmp
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
