[Bug 683071] Review Request: libvirt-php - PHP bindings for libvirt virtualization toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=683071 --- Comment #1 from Michal Novotny 2011-03-08 08:24:23 EST --- Here's the Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2894059 . There was no arch-override and it compiled for i386 and x86_64 systems fine so I guess the other platforms don't have PHP support. Michal -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 683071] Review Request: libvirt-php - PHP bindings for libvirt virtualization toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=683071 Richard W.M. Jones changed: What|Removed |Added Status|NEW |ASSIGNED CC||rjo...@redhat.com AssignedTo|nob...@fedoraproject.org|rjo...@redhat.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 683071] Review Request: libvirt-php - PHP bindings for libvirt virtualization toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=683071 Richard W.M. Jones changed: What|Removed |Added AssignedTo|rjo...@redhat.com |nob...@fedoraproject.org -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 683071] Review Request: libvirt-php - PHP bindings for libvirt virtualization toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=683071 Tomas Mraz changed: What|Removed |Added CC||tm...@redhat.com AssignedTo|nob...@fedoraproject.org|tm...@redhat.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 683071] Review Request: libvirt-php - PHP bindings for libvirt virtualization toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=683071 --- Comment #2 from Tomas Mraz 2011-03-09 07:52:21 EST --- (In reply to comment #1) > Here's the Koji build: > There was no arch-override and it compiled for i386 and x86_64 systems fine > so I guess the > other platforms don't have PHP support. Not really - Fedora primary architectures are i386 (i686) and x86_64 only. The other architectures are secondary and handled by a different koji instance and builds are initiated separately by the secondary arch builders. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 683071] Review Request: libvirt-php - PHP bindings for libvirt virtualization toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=683071 Tomas Mraz changed: What|Removed |Added Flag||needinfo?(minovotn@redhat.c ||om) --- Comment #3 from Tomas Mraz 2011-03-09 08:33:25 EST --- The tarball at the source URL and in the .src.rpm differs. According to the https://fedoraproject.org/wiki/Packaging:PHP#Naming_scheme the package should be named php-libvirt instead of libvirt-php. Note that you have included the html doc in both main package and the -doc subpackage. Also the %doc must be on the same line as the filename specification. The licensing is confusing/wrong - in the README you specify that the license is GPL (if so, there should be COPYING with the correct GPL version). In the .spec file there is License: PHP. The source files do not contain any copyright statements nor license names - these are not required but they are recommended. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 683071] Review Request: libvirt-php - PHP bindings for libvirt virtualization toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=683071 Michal Novotny changed: What|Removed |Added Flag|needinfo?(minovotn@redhat.c |needinfo?(tm...@redhat.com) |om) | --- Comment #4 from Michal Novotny 2011-03-09 08:48:49 EST --- (In reply to comment #3) > The tarball at the source URL and in the .src.rpm differs. > > According to the https://fedoraproject.org/wiki/Packaging:PHP#Naming_scheme > the package should be named php-libvirt instead of libvirt-php. > Well, originally the project was named php-libvirt but it got renamed to comply with the names at http://libvirt.org/git . This was not my idea however I already got used to the libvirt-php name. > Note that you have included the html doc in both main package and the -doc > subpackage. Also the %doc must be on the same line as the filename > specification. This is because rpmlint was complaining the main package was not having any documentation. Shouldn't be I having it in the main package then? > > The licensing is confusing/wrong - in the README you specify that the license > is GPL (if so, there should be COPYING with the correct GPL version). In the > .spec file there is License: PHP. The source files do not contain any > copyright > statements nor license names - these are not required but they are > recommended. Oh, I'll fix it. I guess this was done by multiple people contributing to this so it made some kind of mess there however for the PHP modules the licence should be a PHP licence, right? Or should be easily be GPL licence as well since it's just about the module/extension? Michal -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 683071] Review Request: libvirt-php - PHP bindings for libvirt virtualization toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=683071 --- Comment #5 from Richard W.M. Jones 2011-03-09 08:53:05 EST --- (In reply to comment #4) > (In reply to comment #3) > > The tarball at the source URL and in the .src.rpm differs. > > > > According to the https://fedoraproject.org/wiki/Packaging:PHP#Naming_scheme > > the package should be named php-libvirt instead of libvirt-php. > > > > > Well, originally the project was named php-libvirt but it got renamed to > comply > with the names at http://libvirt.org/git . This was not my idea however I > already got used to the libvirt-php name. Don't confuse the upstream name and the Fedora name. They can be different if we need them to be. > > Note that you have included the html doc in both main package and the -doc > > subpackage. Also the %doc must be on the same line as the filename > > specification. > > This is because rpmlint was complaining the main package was not having any > documentation. Shouldn't be I having it in the main package then? You can ignore rpmlint if you think it is getting things wrong, although it's often a good idea to add a small comment in the spec file. In this case, how about putting the README and license file (eg. COPYING) into the main package, and the rest of the documentation in the -doc subpackage. > > > > The licensing is confusing/wrong - in the README you specify that the > > license > > is GPL (if so, there should be COPYING with the correct GPL version). In the > > .spec file there is License: PHP. The source files do not contain any > > copyright > > statements nor license names - these are not required but they are > > recommended. > > > Oh, I'll fix it. I guess this was done by multiple people contributing to this > so it made some kind of mess there however for the PHP modules the licence > should be a PHP licence, right? Or should be easily be GPL licence as well > since it's just about the module/extension? You really need to be clear about licensing before anything can be incorporated into Fedora. It's a legal requirement and could get people into trouble. Maybe clarify this with upstream on libvir-list? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 683071] Review Request: libvirt-php - PHP bindings for libvirt virtualization toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=683071 Tomas Mraz changed: What|Removed |Added Flag|needinfo?(tm...@redhat.com) | --- Comment #6 from Tomas Mraz 2011-03-09 08:58:42 EST --- Basically everything was already answered by Richard. The licensing must be clear and the Fedora package name can be different from the upstream tarball name. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 683071] Review Request: libvirt-php - PHP bindings for libvirt virtualization toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=683071 --- Comment #7 from Michal Novotny 2011-03-09 11:58:26 EST --- (In reply to comment #5) > (In reply to comment #4) > > (In reply to comment #3) > > > The tarball at the source URL and in the .src.rpm differs. > > > > > > According to the > > > https://fedoraproject.org/wiki/Packaging:PHP#Naming_scheme > > > the package should be named php-libvirt instead of libvirt-php. > > > > > > > > > Well, originally the project was named php-libvirt but it got renamed to > > comply > > with the names at http://libvirt.org/git . This was not my idea however I > > already got used to the libvirt-php name. > > Don't confuse the upstream name and the Fedora name. They can > be different if we need them to be. > Well, I maintain the upstream for libvirt-php. If the names can be different then I rename the project for Fedora. > > > Note that you have included the html doc in both main package and the -doc > > > subpackage. Also the %doc must be on the same line as the filename > > > specification. > > > > This is because rpmlint was complaining the main package was not having any > > documentation. Shouldn't be I having it in the main package then? > > You can ignore rpmlint if you think it is getting things wrong, > although it's often a good idea to add a small comment in the > spec file. Oh, ok. I won't be putting docs in the main package then. > > In this case, how about putting the README and license file (eg. COPYING) > into the main package, and the rest of the documentation in the > -doc subpackage. > > > > > > > The licensing is confusing/wrong - in the README you specify that the > > > license > > > is GPL (if so, there should be COPYING with the correct GPL version). In > > > the > > > .spec file there is License: PHP. The source files do not contain any > > > copyright > > > statements nor license names - these are not required but they are > > > recommended. > > > > > > Oh, I'll fix it. I guess this was done by multiple people contributing to > > this > > so it made some kind of mess there however for the PHP modules the licence > > should be a PHP licence, right? Or should be easily be GPL licence as well > > since it's just about the module/extension? > > You really need to be clear about licensing before anything > can be incorporated into Fedora. It's a legal requirement and > could get people into trouble. Maybe clarify this with upstream > on libvir-list? Well, upstream libvir-list has nothing to do with the binding since I maintain the PHP bindings. However I should ask about the licence. Michal -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 683071] Review Request: libvirt-php - PHP bindings for libvirt virtualization toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=683071 Michal Novotny changed: What|Removed |Added Flag||needinfo?(tm...@redhat.com) --- Comment #8 from Michal Novotny 2011-03-10 09:03:53 EST --- Spec URL: http://minovotn.fedorapeople.org/php-libvirt.spec SRPM URL: http://minovotn.fedorapeople.org/php-libvirt-0.4.1-2.fc14.src.rpm Description: Libvirt bindings for PHP is just a libvirt bindings for PHP platform to allow management of the virtual machines from your PHP scripts. For more information please refer to http://libvirt.org/php . Tomas, could you please review it? Thanks, Michal -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
