[Bug 683610] Review Request: hxtools - A collection of several tools
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=683610 Jerry James changed: What|Removed |Added Status|NEW |ASSIGNED CC||loganje...@gmail.com AssignedTo|nob...@fedoraproject.org|loganje...@gmail.com Flag||fedora-review? --- Comment #6 from Jerry James 2011-11-23 22:38:08 EST --- I saw your request for a review swap. I'll review this one. Would you care to review one of the following? ocaml-dpt: bug 693831 TOPCOM: bug 700959 python3-cvxopt: bug 706299 (python3 version of an existing python2 package) lrslib: bug 723752 polybori: bug 742388 (rename review) ocaml-menhir: bug 754245 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 683610] Review Request: hxtools - A collection of several tools
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=683610
--- Comment #7 from Jerry James 2011-11-23 23:00:40 EST
---
Unless you plan to use this spec file for EPEL also, some elements of the spec
file are not needed: BuildRoot, "rm -rf $RPM_BUILD_ROOT" at the top of
%install, the %clean script, and %defattr at the top of %files.
Even though autoreconf is in the autoconf package, it can also invoke aclocal
and automake, both of which are in the automake package. Since automake
Requires autoconf, I suggest using a BR on automake instead of autoconf. This
isn't just a hypothetical concern; here is a snippet from the mock build log:
+ ./autogen.sh
Can't exec "aclocal": No such file or directory at
/usr/share/autoconf/Autom4te/FileUtils.pm line 326.
autoreconf: failed to run aclocal: No such file or directory
Legend:
+: OK
-: must be fixed
=: should be fixed (at your discretion)
N: not applicable
MUST:
[+] rpmlint output:
hxtools.x86_64: W: spelling-error %description -l en_US pam -> map, Pam, pan
hxtools.spec:44: W: macro-in-comment %exclude
hxtools.spec:44: W: macro-in-comment %files
hxtools.spec:46: W: macro-in-comment %{_libexecdir}
hxtools.spec:47: W: macro-in-comment %{_libexecdir}
hxtools.spec:48: W: macro-in-comment %{_datadir}
hxtools.spec:49: W: macro-in-comment %{_mandir}
2 packages and 1 specfiles checked; 0 errors, 7 warnings.
Those macros in comments need doubled % signs.
[+] follows package naming guidelines
[+] spec file base name matches package name
[+] package meets the packaging guidelines
[+] package uses a Fedora approved license
[+] license field matches the actual license
[+] license file is included in %doc
[+] spec file is in American English
[+] spec file is legible
[+] sources match upstream
[+] package builds on at least one primary arch (tried x86_64)
[N] appropriate use of ExcludeArch
[=] all build requirements in BuildRequires: maybe need automake, see above
[N] spec file handles locales properly
[N] ldconfig in %post and %postun
[+] no bundled copies of system libraries
[N] no relocatable packages
[+] package owns all directories that it creates
[+] no files listed twice in %files
[+] proper permissions on files
[+] consistent use of macros
[+] code or permissible content
[N] large documentation in -doc
[+] no runtime dependencies in %doc
[N] header files in -devel
[N] static libraries in -static
[N] .so in -devel
[N] -devel requires main package
[+] package contains no libtool archives
[N] package contains a desktop file, uses desktop-file-install
[+] package does not own files/dirs owned by other packages
[+] all filenames in UTF-8
SHOULD:
[N] query upstream for license text
[N] description and summary contains available translations
[+] package builds in mock: tried fedora-rawhide-i386
[+] package builds on all supported arches: tried i386 and x86_64
[+] package functions as described: minimal testing only
[+] sane scriptlets
[N] subpackages require the main package
[N] placement of pkgconfig files
[N] file dependencies versus package dependencies
[+] package contains man pages for binaries/scripts
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 683610] Review Request: hxtools - A collection of several tools
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=683610 --- Comment #8 from Till Maas 2011-11-24 14:35:14 EST --- Thank you, the package has been updated. I plan to use it in EPEL in the long term, therefore I keep the deprecated macros. Updated files: Spec URL: http://till.fedorapeople.org/review/hxtools.spec SRPM URL: http://till.fedorapeople.org/review/hxtools-20110721-2.tillf15.src.rpm Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3538267 I will try to look into your review submissions soon. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 683610] Review Request: hxtools - A collection of several tools
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=683610 Jerry James changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #9 from Jerry James 2011-11-24 16:05:30 EST --- OK, everything looks good. This package is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 683610] Review Request: hxtools - A collection of several tools
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=683610 Till Maas changed: What|Removed |Added Flag||fedora-cvs? --- Comment #10 from Till Maas 2011-11-24 16:31:22 EST --- New Package SCM Request === Package Name: hxtools Short Description: A collection of several tools Owners: till Branches: f15 f16 el6 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 683610] Review Request: hxtools - A collection of several tools
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=683610 --- Comment #11 from Jon Ciesla 2011-11-24 22:31:50 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 683610] Review Request: hxtools - A collection of several tools
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=683610 --- Comment #12 from Jerry James 2011-12-15 11:32:51 EST --- Till, I plan to beg for review swaps on fedora-devel-list again soon. Do you want to reserve one of the packages in comment 6 for yourself before I do so? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 683610] Review Request: hxtools - A collection of several tools
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=683610 --- Comment #13 from Till Maas 2011-12-15 17:14:18 EST --- (In reply to comment #12) > Till, I plan to beg for review swaps on fedora-devel-list again soon. Do you > want to reserve one of the packages in comment 6 for yourself before I do so? Thank you for asking, I take the python package then. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 683610] Review Request: hxtools - A collection of several tools
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=683610 Till Maas changed: What|Removed |Added Blocks||648173 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 683610] Review Request: hxtools - A collection of several tools
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=683610 Till Maas changed: What|Removed |Added CC||opensou...@till.name --- Comment #1 from Till Maas 2011-03-09 16:11:29 EST --- Spec URL: http://till.fedorapeople.org/review/hxtools.spec SRPM URL: http://till.fedorapeople.org/review/hxtools-20110308-2.tillf14.src.rpm Changelog: - Include license files -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 683610] Review Request: hxtools - A collection of several tools
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=683610 Matthew Miller changed: What|Removed |Added CC||mat...@mattdm.org --- Comment #2 from Matthew Miller 2011-03-10 16:07:22 EST --- I would suggest making a sub-package like "hxtools-pam_mount" (or whatever) and putting the stuff you need in there. Then if people want to add other things for separate reasons, they can go in their own sub packages without causing crazy bloat. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 683610] Review Request: hxtools - A collection of several tools
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=683610 --- Comment #3 from Till Maas 2011-03-10 16:22:50 EST --- (In reply to comment #2) > I would suggest making a sub-package like "hxtools-pam_mount" (or whatever) > and > putting the stuff you need in there. Then if people want to add other things > for separate reasons, they can go in their own sub packages without causing > crazy bloat. I thought about this, too. But Imho it is very unlikely that someone else will want other items from the package. Therefore this would add unecessary complexity to the package without much gain. In the surprising case that this happens, subpackages can still be created. The current binaries only require libHX, which is the general purpose lib from the same author, that is probably used by all his binary tools. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 683610] Review Request: hxtools - A collection of several tools
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=683610 Sergio Belkin changed: What|Removed |Added CC||seb...@gmail.com --- Comment #4 from Sergio Belkin 2011-03-11 17:29:40 EST --- Some comments: *BuildRequires: - You are using autoreconf in autogen.sh, so you must include it. *Remove the blank line at the end of the file. The following are not oficially part of guideliness (but I think that are in its spirit): *Summary - The problem with hxtools summary is that says nothing specific to the package! Would you install some package that you ever heard in the life with such a description? :-) *Well let's read the description - Oh, I see, now it's clear enough! No, not really, I am joking. You are forcing to either read the code, go to the project site or read the man pages *I think you made two interesting programs that make *two specific tasks" Why don't you make two different packages in the UNUX-style? :) HTH -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 683610] Review Request: hxtools - A collection of several tools
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=683610 --- Comment #5 from Till Maas 2011-07-23 05:22:42 EDT --- (In reply to comment #4) > Some comments: > > *BuildRequires: > - You are using autoreconf in autogen.sh, so you must include it. Done. > *Remove the blank line at the end of the file. Done > The following are not oficially part of guideliness (but I think that are in > its spirit): > > *Summary > - The problem with hxtools summary is that says nothing specific to the > package! Would you install some package that you ever heard in the life with > such a description? :-) > > *Well let's read the description > - Oh, I see, now it's clear enough! No, not really, I am joking. You are > forcing to either read the code, go to the project site or read the man pages > > *I think you made two interesting programs that make *two specific tasks" Why > don't you make two different packages in the UNUX-style? :) I am not the author of the tools/package and I only need two of them to be able to update pam_mount in Fedora. There is no real similiarity between the tools except the upstream author, therefore no good summary or description can be given. Updated files: Spec URL: http://till.fedorapeople.org/review/hxtools.spec SRPM URL: http://till.fedorapeople.org/review/hxtools-20110721-1.tillf14.src.rpm Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3224706 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
