[Bug 684835] Review Request: deltacloud-core - Deltacloud REST API server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=684835 --- Comment #19 from Fedora Update System upda...@fedoraproject.org 2011-05-19 01:03:31 EDT --- deltacloud-core-0.3.0-4.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 684835] Review Request: deltacloud-core - Deltacloud REST API server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=684835 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|deltacloud-core-0.3.0-4.fc1 |deltacloud-core-0.3.0-4.fc1 |4 |5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 684835] Review Request: deltacloud-core - Deltacloud REST API server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=684835 --- Comment #18 from Fedora Update System upda...@fedoraproject.org 2011-05-16 21:06:24 EDT --- deltacloud-core-0.3.0-4.fc14 has been pushed to the Fedora 14 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 684835] Review Request: deltacloud-core - Deltacloud REST API server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=684835 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||deltacloud-core-0.3.0-4.fc1 ||4 Resolution||ERRATA Last Closed||2011-05-16 21:06:29 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 684835] Review Request: deltacloud-core - Deltacloud REST API server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=684835 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #17 from Fedora Update System upda...@fedoraproject.org 2011-05-13 19:15:24 EDT --- deltacloud-core-0.3.0-4.fc14 has been pushed to the Fedora 14 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 684835] Review Request: deltacloud-core - Deltacloud REST API server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=684835 --- Comment #14 from Fedora Update System upda...@fedoraproject.org 2011-05-11 03:22:55 EDT --- deltacloud-core-0.3.0-3.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/deltacloud-core-0.3.0-3.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 684835] Review Request: deltacloud-core - Deltacloud REST API server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=684835 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 684835] Review Request: deltacloud-core - Deltacloud REST API server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=684835 --- Comment #13 from Fedora Update System upda...@fedoraproject.org 2011-05-11 03:22:10 EDT --- deltacloud-core-0.3.0-3.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/deltacloud-core-0.3.0-3.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 684835] Review Request: deltacloud-core - Deltacloud REST API server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=684835 --- Comment #15 from Fedora Update System upda...@fedoraproject.org 2011-05-11 06:12:33 EDT --- deltacloud-core-0.3.0-4.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/deltacloud-core-0.3.0-4.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 684835] Review Request: deltacloud-core - Deltacloud REST API server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=684835 --- Comment #16 from Fedora Update System upda...@fedoraproject.org 2011-05-11 09:40:17 EDT --- deltacloud-core-0.3.0-4.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/deltacloud-core-0.3.0-4.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 684835] Review Request: deltacloud-core - Deltacloud REST API server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=684835 --- Comment #11 from Michal Fojtik mfoj...@redhat.com 2011-05-06 04:34:41 EDT --- Ah I'm sorry I copypasted wrong request New Package CVS Request === Package Name: deltacloud-core Short Description: Deltacloud REST API server Owners: mfojtik Branches: F-14 F-15 EL-5 EL-6 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 684835] Review Request: deltacloud-core - Deltacloud REST API server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=684835 --- Comment #12 from Jason Tibbitts ti...@math.uh.edu 2011-05-06 14:11:07 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 684835] Review Request: deltacloud-core - Deltacloud REST API server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=684835 --- Comment #7 from Michal Fojtik mfoj...@redhat.com 2011-05-05 08:22:29 EDT --- -- version 0.3.0-r2 - http://mifo.sk/fedora/deltacloud-core/master/deltacloud-core.spec http://mifo.sk/fedora/deltacloud-core/master/deltacloud-core-0.3.0-2.fc14.src.rpm Changes: * Fixed documentation generation * Replaced moving with copying * Removed support folder from doc subpackage -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 684835] Review Request: deltacloud-core - Deltacloud REST API server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=684835 --- Comment #8 from Vít Ondruch vondr...@redhat.com 2011-05-05 08:57:27 EDT --- I have no other objections. The package is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 684835] Review Request: deltacloud-core - Deltacloud REST API server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=684835 Vít Ondruch vondr...@redhat.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 684835] Review Request: deltacloud-core - Deltacloud REST API server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=684835 Michal Fojtik mfoj...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #9 from Michal Fojtik mfoj...@redhat.com 2011-05-05 10:38:01 EDT --- Package Change Request == Package Name: deltacloud-core New Branches: EL-5 EL-6 F14 F15 Owners: mfojtik -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 684835] Review Request: deltacloud-core - Deltacloud REST API server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=684835 --- Comment #10 from Jason Tibbitts ti...@math.uh.edu 2011-05-05 14:20:10 EDT --- This package does not appear to exist in pkgdb currently; you cannot submit a change request for somethng that does not exist. Can you please describe what you need the SVM admins to do for you? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 684835] Review Request: deltacloud-core - Deltacloud REST API server
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=684835
--- Comment #6 from Vít Ondruch vondr...@redhat.com 2011-05-04 07:38:08 EDT
---
* the line mkdir -p %{buildroot}%{_bindir} in %install section is duplicated.
* support folder content
- If I admit that support folder has some meaning for the original gem, it
has
not much sense on Fedora.
- If I admit the Folder would be on Fedora, it should contain up-to-date
content, e.g. the RPM spec file should be the same I am currently
reviewing,
but I am afraid you can never ever achieve it.
- The easiest solution would be to delete it IMO.
* Deleting the %{_builddir}
- It is bad practice to delete %{_builddir} in installation step. It is not
harmful in this particular case, but once there would be binary extensions
it may cause troubles. This is coming from Ruby guidelines:
Finally at %install stage the whole tree under the directory created at %prep
stage should be copied (not moved) to under %{buildroot}%{gemdir}.
When all tree under the directory created at %prep stage is moved to under
%{buildroot}, find_debuginfo.sh will complain that the corresponding
source
files are missing.
I pointed this once but I have to stress it again. Please, do not delete
anything in %{_builddir}, unless you have very good reason.
This time you are not exactly deleting but moving and the result might be the
same. Moreover, the documentation is not generated due to move instead of
copy
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 684835] Review Request: deltacloud-core - Deltacloud REST API server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=684835 --- Comment #5 from Michal Fojtik mfoj...@redhat.com 2011-04-29 06:59:54 EDT --- -- version 0.3.0-r1 - http://mifo.sk/fedora/deltacloud-core/master/deltacloud-core.spec http://mifo.sk/fedora/deltacloud-core/master/deltacloud-core-0.3.0-1.fc14.src.rpm Changes: * Updated deltacloud-core to version 0.3.0 * Koji build: * http://koji.fedoraproject.org/koji/taskinfo?taskID=3035468 * rpmlint: rpmlint ~/rpmbuild/SRPMS/deltacloud-core-0.3.0-1.fc14.src.rpm deltacloud-core.src: I: enchant-dictionary-not-found en_US 1 packages and 0 specfiles checked; 0 errors, 0 warnings. rpmlint ~/rpmbuild/RPMS/noarch/deltacloud-core-0.3.0-1.fc14.noarch.rpm deltacloud-core.noarch: I: enchant-dictionary-not-found en_US deltacloud-core.noarch: W: no-manual-page-for-binary deltacloudd 1 packages and 0 specfiles checked; 0 errors, 1 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 684835] Review Request: deltacloud-core - Deltacloud REST API server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=684835 Vít Ondruch vondr...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||vondr...@redhat.com AssignedTo|nob...@fedoraproject.org|vondr...@redhat.com Flag||fedora-review? --- Comment #2 from Vít Ondruch vondr...@redhat.com 2011-03-15 08:01:27 EDT --- I am taking this one. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 684835] Review Request: deltacloud-core - Deltacloud REST API server
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=684835
--- Comment #3 from Vít Ondruch vondr...@redhat.com 2011-03-15 09:48:24 EDT
---
* Cleaning
- rm -rf %{buildroot} at the top of %install and %clean sections
is no longer needed:
https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean
* Duplicated BuildRequires
- BuildRequires: rubygem(json) is duplicated
* Test suite
- It is interesting is that following commands provides different output:
1) testrb tests/*_test.rb tests/drivers/mock/*_test.rb
2) testrb tests/drivers/mock/*_test.rb tests/*_test.rb
3) rake test
while they should be equivalent.
* Missing runtime Requires:
[vondruch@dhcp-25-40 result]$ deltacloudd -i mock
Starting Deltacloud API :: mock :: http://localhost:3001/api
ERROR: no such file to load -- rack/accept
- Please compare with the BuildRequires which are sufficient. There are very
probably missing nokogiri, rake-accept and may be others.
* Deleting the %{_builddir}
- It is bad practice to delete %{_builddir} in installation step. It is not
harmful in this particular case, but once there would be binary extensions
it may cause troubles. This is coming from Ruby guidelines:
Finally at %install stage the whole tree under the directory created at %prep
stage should be copied (not moved) to under %{buildroot}%{gemdir}.
When all tree under the directory created at %prep stage is moved to under
%{buildroot}, find_debuginfo.sh will complain that the corresponding source
files are missing.
* Garbage in support folder?
- It seems that folder /usr/share/deltacloud-core/support contains some
unnecessary stuff, potentially garbage? There is only deltacloud-core
which is later moved into %{_initdir}, the rest should not be installed,
nor it should be part of the gem IMO.
* Upstream
- The upstream package is not available yet. Please synchronize the release
with upstream.
* Documentation
- COPYING file should be marked as %doc.
- Rakefile should be moved into doc subpackage, since it is not required by
runtime
* MUST: A package must own all directories that it creates.
- Package does not own the %{app_root}/public directory (at least it stays on
my system after uninstall).
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 684835] Review Request: deltacloud-core - Deltacloud REST API server
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=684835
--- Comment #4 from Michal Fojtik mfoj...@redhat.com 2011-03-15 12:35:34 EDT
---
(In reply to comment #3)
* Cleaning
- rm -rf %{buildroot} at the top of %install and %clean sections
is no longer needed:
https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean
Fixed.
* Duplicated BuildRequires
- BuildRequires: rubygem(json) is duplicated
Removed.
* Test suite
- It is interesting is that following commands provides different output:
1) testrb tests/*_test.rb tests/drivers/mock/*_test.rb
2) testrb tests/drivers/mock/*_test.rb tests/*_test.rb
3) rake test
while they should be equivalent.
??
* Missing runtime Requires:
[vondruch@dhcp-25-40 result]$ deltacloudd -i mock
Starting Deltacloud API :: mock :: http://localhost:3001/api
ERROR: no such file to load -- rack/accept
I moved some of BuildRequires to Requires. Thanks for pointing me on this.
- Please compare with the BuildRequires which are sufficient. There are very
probably missing nokogiri, rake-accept and may be others.
* Deleting the %{_builddir}
- It is bad practice to delete %{_builddir} in installation step. It is not
harmful in this particular case, but once there would be binary extensions
it may cause troubles. This is coming from Ruby guidelines:
Finally at %install stage the whole tree under the directory created at %prep
stage should be copied (not moved) to under %{buildroot}%{gemdir}.
When all tree under the directory created at %prep stage is moved to under
%{buildroot}, find_debuginfo.sh will complain that the corresponding
source
files are missing.
I removed that rmdir, but for this particular case I don't think this is
necessary, since this package don't have any binary extensions (so no
debug-info is needed)
* Garbage in support folder?
- It seems that folder /usr/share/deltacloud-core/support contains some
unnecessary stuff, potentially garbage? There is only deltacloud-core
which is later moved into %{_initdir}, the rest should not be installed,
nor it should be part of the gem IMO.
Hmm this one is really weird, I check support folder and it's part of %doc
subpackage.
* Upstream
- The upstream package is not available yet. Please synchronize the release
with upstream.
Will do.
* Documentation
- COPYING file should be marked as %doc.
- Rakefile should be moved into doc subpackage, since it is not required by
runtime
Files marked and moved Rakefile to %doc.
* MUST: A package must own all directories that it creates.
- Package does not own the %{app_root}/public directory (at least it stays
on
my system after uninstall).
Marked with %dir
-- rev 4 ---
Spec URL: http://mifo.sk/fedora/deltacloud-core/master/deltacloud-core.spec
SRPM URL:
http://mifo.sk/fedora/deltacloud-core/master/deltacloud-core-0.2.0-4.fc14.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 684835] Review Request: deltacloud-core - Deltacloud REST API server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=684835 --- Comment #1 from Michal Fojtik mfoj...@redhat.com 2011-03-14 11:48:21 EDT --- Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2911216 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
