[Bug 690305] Review Request: pdfgrep - Tool to search text in PDF files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=690305 Fedora Update System changed: What|Removed |Added Fixed In Version|pdfgrep-1.2-2.fc13 |pdfgrep-1.2-2.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 690305] Review Request: pdfgrep - Tool to search text in PDF files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=690305 --- Comment #12 from Fedora Update System 2011-04-15 17:13:51 EDT --- pdfgrep-1.2-2.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 690305] Review Request: pdfgrep - Tool to search text in PDF files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=690305 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||pdfgrep-1.2-2.fc14 Resolution||ERRATA Last Closed||2011-04-10 17:19:24 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 690305] Review Request: pdfgrep - Tool to search text in PDF files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=690305 Fedora Update System changed: What|Removed |Added Fixed In Version|pdfgrep-1.2-2.fc14 |pdfgrep-1.2-2.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 690305] Review Request: pdfgrep - Tool to search text in PDF files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=690305 --- Comment #10 from Fedora Update System 2011-04-10 17:19:19 EDT --- pdfgrep-1.2-2.fc14 has been pushed to the Fedora 14 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 690305] Review Request: pdfgrep - Tool to search text in PDF files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=690305 --- Comment #11 from Fedora Update System 2011-04-10 17:19:31 EDT --- pdfgrep-1.2-2.fc13 has been pushed to the Fedora 13 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 690305] Review Request: pdfgrep - Tool to search text in PDF files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=690305 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #9 from Fedora Update System 2011-04-02 18:50:47 EDT --- pdfgrep-1.2-2.fc13 has been pushed to the Fedora 13 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 690305] Review Request: pdfgrep - Tool to search text in PDF files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=690305 --- Comment #8 from Fedora Update System 2011-04-02 07:50:31 EDT --- pdfgrep-1.2-2.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/pdfgrep-1.2-2.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 690305] Review Request: pdfgrep - Tool to search text in PDF files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=690305 --- Comment #7 from Fedora Update System 2011-04-02 07:49:43 EDT --- pdfgrep-1.2-2.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/pdfgrep-1.2-2.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 690305] Review Request: pdfgrep - Tool to search text in PDF files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=690305 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 690305] Review Request: pdfgrep - Tool to search text in PDF files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=690305 --- Comment #6 from Fedora Update System 2011-04-02 07:48:54 EDT --- pdfgrep-1.2-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/pdfgrep-1.2-2.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 690305] Review Request: pdfgrep - Tool to search text in PDF files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=690305 --- Comment #5 from Jason Tibbitts 2011-03-27 15:42:21 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 690305] Review Request: pdfgrep - Tool to search text in PDF files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=690305 --- Comment #4 from Mario Blättermann 2011-03-26 15:24:54 EDT --- (In reply to comment #2) > I've added the German summary and description. Despite my last name I do not > speak Dutch, only German... Sorry, I thought because your files are hosted in a .nl domain, you are a native Dutch speaker. Anyway, adding some non-English descriptions could be the first step to a global translation system in Fedora. Don't know how to setup this, but other distributions already have it (Debian and its derivatives, Mandriva...). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 690305] Review Request: pdfgrep - Tool to search text in PDF files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=690305 Joachim de Groot changed: What|Removed |Added Flag||fedora-cvs? --- Comment #3 from Joachim de Groot 2011-03-26 14:57:28 EDT --- New Package SCM Request === Package Name: pdfgrep Short Description: Tool to search text in PDF files Owners: jaydg Branches: f13 f14 f15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 690305] Review Request: pdfgrep - Tool to search text in PDF files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=690305 --- Comment #2 from Joachim de Groot 2011-03-26 14:50:59 EDT --- Thank you for the review! I've added the German summary and description. Despite my last name I do not speak Dutch, only German... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 690305] Review Request: pdfgrep - Tool to search text in PDF files
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=690305
Mario Blättermann changed:
What|Removed |Added
Status|NEW |ASSIGNED
Flag||fedora-review+
--- Comment #1 from Mario Blättermann 2011-03-25 16:21:19
EDT ---
As you already wrote, rpmlint is silent, neither the spec file nor the packages
itself produce any output, besides the usual expat issues.
-
key:
[+] OK
[.] OK, not applicable
[X] needs work
-
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license.
- GPLv2+
[+] MUST: The License field in the package spec file must match the actual
license.
[+] MUST: The file containing the text of the license(s) for the package must
be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source.
$ md5sum pdfgrep*
80dc5159e9776c99af377550da4c907d pdfgrep-1.2.tar.gz
80dc5159e9776c99af377550da4c907d pdfgrep-1.2.tar.gz.orig
[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
- Koji build was succesful.
[.] MUST: If the package does not successfully compile, build or work on an
architecture, ...
[+] MUST: All build dependencies must be listed in BuildRequires.
[.] MUST: The spec file MUST handle locales properly.
[.] MUST: If a package installs files below %{_datadir}/icons, the icon cache
must be updated.
[.] MUST: Packages storing shared library files (not just symlinks) must call
ldconfig in %post and %postun.
[.] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, ...
[+] MUST: A package must own all directories that it creates.
[+] MUST: A Fedora package must not list a file more than once in %files.
[+] MUST: Permissions on files must be set properly.
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.
[.] MUST: Large documentation files must go in a -doc subpackage.
[+] MUST: Files in %doc must not affect the runtime of the application.
[.] MUST: Header files must be in a -devel package.
[.] MUST: Static libraries must be in a -static package.
[.] MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), ...
[.] MUST: devel packages must require the base package using a fully versioned
dependency.
[.] MUST: Packages must NOT contain any .la libtool archives.
[.] MUST: Packages containing GUI applications must include a %{name}.desktop
file.
[.] MUST: .desktop files must be properly installed with desktop-file-install
in the %install section.
[+] MUST: Packages must not own files or directories already owned by other
packages.
[+] MUST: All filenames in rpm packages must be valid UTF-8.
[.] SHOULD: If the source package does not include license text(s) as a
separate file from upstream, ...
[+] SHOULD: The reviewer should test that the package builds in mock.
- Builds properly (f14, x86)
[+] SHOULD: The package should compile and build into binary rpms on all
supported architectures.
[+] SHOULD: The reviewer should test that the package functions as described.
- Just a short test, but it works fine for me.
[.] SHOULD: If scriptlets are used, those scriptlets must be sane.
[.] SHOULD: Usually, subpackages other than devel should require the base
package using a fully versioned dependency.
[.] SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg.
[.] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin,
/usr/bin, or /usr/sbin consider requiring the package which provides the file
instead of the file itself.
[+] SHOULD: Your package should contain man pages for binaries/scripts.
Package APPROVED
By the way, perhaps you could add a Dutch description...? However, it is not
required and less documented. Look here:
http://wiki.mandriva.com/en/Policies/Charset#Why.3F
And additionally, you could add the following for German:
Summary(de): Suchwerkzeug für Text in PDF-Dateien
%description -l de
Pdfgrep ist ein Werkzeug für die Textsuche in PDF-Dateien.
Seine Funktionsweise ähnelt der von grep.
Funktionsmerkmale:
* Suchen nach regulären Ausdrücken.
* Unterstützung für wichtige grep-Optionen, wie:
* Ausgabe des Dateinamens.
* Ausgabe der Seitennummer.
* optionale Berücksich
[Bug 690305] Review Request: pdfgrep - Tool to search text in PDF files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=690305 Mario Blättermann changed: What|Removed |Added CC||mari...@gnome.org AssignedTo|nob...@fedoraproject.org|mari...@gnome.org -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
