[Bug 690954] Review Request: postler - An ultra simple desktop mail client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=690954 --- Comment #22 from Fedora Update System upda...@fedoraproject.org 2011-05-09 00:03:41 EDT --- postler-0.1.1-4.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 690954] Review Request: postler - An ultra simple desktop mail client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=690954 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|postler-0.1.1-4.fc14|postler-0.1.1-4.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 690954] Review Request: postler - An ultra simple desktop mail client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=690954 --- Comment #21 from Fedora Update System upda...@fedoraproject.org 2011-05-07 15:55:58 EDT --- postler-0.1.1-4.fc14 has been pushed to the Fedora 14 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 690954] Review Request: postler - An ultra simple desktop mail client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=690954 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||postler-0.1.1-4.fc14 Resolution||ERRATA Last Closed||2011-05-07 15:56:04 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 690954] Review Request: postler - An ultra simple desktop mail client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=690954 --- Comment #18 from Fedora Update System upda...@fedoraproject.org 2011-04-22 08:48:41 EDT --- postler-0.1.1-4.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/postler-0.1.1-4.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 690954] Review Request: postler - An ultra simple desktop mail client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=690954 --- Comment #19 from Fedora Update System upda...@fedoraproject.org 2011-04-22 08:48:50 EDT --- postler-0.1.1-4.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/postler-0.1.1-4.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 690954] Review Request: postler - An ultra simple desktop mail client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=690954 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED Bug 690954 depends on bug 690953, which changed state. Bug 690953 Summary: Review Request: dexter - Address Book that goes hand in hand with Postler https://bugzilla.redhat.com/show_bug.cgi?id=690953 What|Old Value |New Value Resolution||ERRATA Status|ON_QA |CLOSED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 690954] Review Request: postler - An ultra simple desktop mail client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=690954 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #20 from Fedora Update System upda...@fedoraproject.org 2011-04-22 17:18:01 EDT --- postler-0.1.1-4.fc14 has been pushed to the Fedora 14 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 690954] Review Request: postler - An ultra simple desktop mail client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=690954 --- Comment #17 from Jason Tibbitts ti...@math.uh.edu 2011-04-07 10:54:48 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 690954] Review Request: postler - An ultra simple desktop mail client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=690954 Bug 690954 depends on bug 693526, which changed state. Bug 693526 Summary: Compilation error when passing a N_ wrapped string to a const array https://bugzilla.redhat.com/show_bug.cgi?id=693526 What|Old Value |New Value Resolution||CURRENTRELEASE Status|NEW |CLOSED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 690954] Review Request: postler - An ultra simple desktop mail client
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=690954
--- Comment #14 from Michel Alexandre Salim michel+...@sylvestre.me
2011-04-06 06:43:11 EDT ---
I was waiting for a fix for the Vala issue (which I just backported from Git
yesterday), before finishing my Postler packaging -- sorry for the duplicate
request!
Thomas, let me know if you'd like a comaintainer for this. I have some
differences in my specs:
- CFLAGS needs to be manually exported; when packaging I searched for any
guidelines for packaging with waf (we still really need to write one!) Funnily
all the people involved in that thread on the mailing list are here -- me, you
(waf maintainer) and Christoph who started the thread.
- waf build probably needs the -v option (verbose) -- that's how I discovered
the wrong compiler flags were being used, and %{?_smp_mflags}
- link against libdb-devel (BerkeleyDB 5) rather than db4
- use system waf rather than the bundled version
Also, I started using the virtual pkgconfig(...) rather than package names, as
they match up with upstream's dependency checking better.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 690954] Review Request: postler - An ultra simple desktop mail client
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=690954
--- Comment #15 from Thomas Moschny thomas.mosc...@gmx.de 2011-04-06 07:26:23
EDT ---
(In reply to comment #14)
I was waiting for a fix for the Vala issue (which I just backported from Git
yesterday), before finishing my Postler packaging -- sorry for the duplicate
request!
Thanks for applying the Vala fix!
Thomas, let me know if you'd like a comaintainer for this.
Sure.
I have some differences in my specs:
- CFLAGS needs to be manually exported; when packaging I searched for any
Right, I will fix that while importing the package (maybe in the evening).
guidelines for packaging with waf (we still really need to write one!) Funnily
all the people involved in that thread on the mailing list are here -- me, you
(waf maintainer) and Christoph who started the thread.
There has been a long thread on the devel mailing list some time ago with no
real outcome. Also see below.
- waf build probably needs the -v option (verbose) -- that's how I discovered
The -v switch didn't work on my F13 machine, and caused waf itself to crash.
the wrong compiler flags were being used, and %{?_smp_mflags}
Not really needed, as waf automatically builds in parallel, using as many
threads as it finds cores. Maybe it's nevertheless a good idea to pass -j
%{?_smp_mflags}, so koji has more control.
- link against libdb-devel (BerkeleyDB 5) rather than db4
Why's that?
- use system waf rather than the bundled version
This is something we shouldn't do (in general, for any package, that is). I was
still hoping someone else filed a request for an exception at the packaging
committee. But now that I also own a package using waf, so maybe I have to do
it myself.
Postler bundles waf 1.5.X, but in rawhide we are at 1.6. I didn't thoroughly
test whether there are incompatibilities for postler, but in general, each
package should use its bundled waf copy and not the system one. As waf is a
development tool and not some sort of runtime library, the usual security
argument against bundling doesn't really hold. The bundled copy is what
upstream has released and tested their package with, and deviating from that is
not worth the effort.
Also, I started using the virtual pkgconfig(...) rather than package names,
as they match up with upstream's dependency checking better.
Will consider this.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 690954] Review Request: postler - An ultra simple desktop mail client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=690954 Thomas Moschny thomas.mosc...@gmx.de changed: What|Removed |Added Flag||fedora-cvs? --- Comment #16 from Thomas Moschny thomas.mosc...@gmx.de 2011-04-06 17:22:23 EDT --- New Package SCM Request === Package Name: postler Short Description: An ultra simple desktop mail client Owners: thm Branches: f14 f15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 690954] Review Request: postler - An ultra simple desktop mail client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=690954 --- Comment #11 from Thomas Moschny thomas.mosc...@gmx.de 2011-04-05 17:32:12 EDT --- (In reply to comment #10) You will need a patch for renaming the icon because internet-mail also appears in the source code twice (in postler/postler-app.vala and postler/postler-accounts.vala). Thanks for the hint. Spec URL: http://thm.fedorapeople.org/postler/postler.spec SRPM URL: http://thm.fedorapeople.org/postler/postler-0.1.1-3.fc14.src.rpm %changelog * Tue Apr 5 2011 Thomas Moschny .. - 0.1.1-3 - Use a patch for renaming the icon. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 690954] Review Request: postler - An ultra simple desktop mail client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=690954 Christoph Wickert cwick...@fedoraproject.org changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #12 from Christoph Wickert cwick...@fedoraproject.org 2011-04-05 20:18:27 EDT --- Ok, the vala issue are fixed and a scratch build was successfull, see http://koji.fedoraproject.org/koji/taskinfo?taskID=2977217 Package APPROVED! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 690954] Review Request: postler - An ultra simple desktop mail client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=690954 Christoph Wickert cwick...@fedoraproject.org changed: What|Removed |Added CC||michel+...@sylvestre.me --- Comment #13 from Christoph Wickert cwick...@fedoraproject.org 2011-04-05 20:53:56 EDT --- *** Bug 693931 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 690954] Review Request: postler - An ultra simple desktop mail client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=690954 Thomas Moschny thomas.mosc...@gmx.de changed: What|Removed |Added Summary|Review Request: postler - A |Review Request: postler - |super sexy, ultra simple|An ultra simple desktop |desktop mail client built |mail client |in vala | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 690954] Review Request: postler - An ultra simple desktop mail client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=690954 --- Comment #6 from Thomas Moschny thomas.mosc...@gmx.de 2011-04-04 15:35:58 EDT --- Spec URL: http://thm.fedorapeople.org/postler/postler.spec SRPM URL: http://thm.fedorapeople.org/postler/postler-0.1.1-2.fc14.src.rpm %changelog * Mon Apr 4 2011 Thomas Moschny .. - 0.1.1-2 - Changes suggested in the review ticket: - Fix License and Summary tags. - Rename icon to avoid clashes with icon theme packages. - BR dexter (bz 690953). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 690954] Review Request: postler - An ultra simple desktop mail client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=690954 --- Comment #7 from Thomas Moschny thomas.mosc...@gmx.de 2011-04-04 15:37:54 EDT --- (In reply to comment #5) [...] ../postler/postler-accounts.vala:69.44-69.44: error: Value must be constant Waf: Leaving directory `/builddir/build/BUILD/postler-0.1.1/_build_' Build failed: - task failed (err #1): This is a known vala issue, covered here: - for postler: https://bugs.launchpad.net/postler/+bug/723282 - for vala: https://bugzilla.gnome.org/show_bug.cgi?id=643010 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 690954] Review Request: postler - An ultra simple desktop mail client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=690954 --- Comment #8 from Thomas Moschny thomas.mosc...@gmx.de 2011-04-04 15:43:10 EDT --- (In reply to comment #3) The two warnings form desktop-file-validate are bogus: According to the spec Email needs either Office or Network but not both and the latter is in place. The x-scheme-handler/mailto MIME type is required for GNOME3's default applications dialog, see bug 690298. There is no need to contact upstream about the desktop file warnings, I just spoke to him. Was that postler's or desktop-file-utils' upstream? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 690954] Review Request: postler - An ultra simple desktop mail client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=690954 --- Comment #9 from Christoph Wickert cwick...@fedoraproject.org 2011-04-04 17:04:02 EDT --- (In reply to comment #8) Was that postler's or desktop-file-utils' upstream? Postler's. For desktop-file-utils there already is a bug report and a patch at https://bugs.freedesktop.org/show_bug.cgi?id=35844 I suggest to ignore both warnings. (In reply to comment #7) (In reply to comment #5) [...] ../postler/postler-accounts.vala:69.44-69.44: error: Value must be constant Waf: Leaving directory `/builddir/build/BUILD/postler-0.1.1/_build_' Build failed: - task failed (err #1): This is a known vala issue, covered here: But this is a showstopper for us. :( The rest looks good, however I cannot approve the package now. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 690954] Review Request: postler - An ultra simple desktop mail client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=690954 Christoph Wickert cwick...@fedoraproject.org changed: What|Removed |Added Depends on||693526 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 690954] Review Request: postler - An ultra simple desktop mail client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=690954 --- Comment #10 from Christoph Wickert cwick...@fedoraproject.org 2011-04-04 20:02:18 EDT --- You will need a patch for renaming the icon because internet-mail also appears in the source code twice (in postler/postler-app.vala and postler/postler-accounts.vala). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
