[Bug 691619] Review Request: openvas-manager - Open Vulnerability Assessment (OpenVAS) Manager (edit)
https://bugzilla.redhat.com/show_bug.cgi?id=691619 --- Comment #23 from Michal Ambroz --- Package Change Request == Package Name: openvas-manager New Branches: epel7 Owners: rebus Hello SCM team, plase can you add epel7 branch for the openvas-manager package? Thank you Michal Ambroz -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 691619] Review Request: openvas-manager - Open Vulnerability Assessment (OpenVAS) Manager (edit)
https://bugzilla.redhat.com/show_bug.cgi?id=691619 Michal Ambroz changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 691619] Review Request: openvas-manager - Open Vulnerability Assessment (OpenVAS) Manager (edit)
https://bugzilla.redhat.com/show_bug.cgi?id=691619 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 691619] Review Request: openvas-manager - Open Vulnerability Assessment (OpenVAS) Manager (edit)
https://bugzilla.redhat.com/show_bug.cgi?id=691619 --- Comment #24 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 691619] Review Request: openvas-manager - Open Vulnerability Assessment (OpenVAS) Manager (edit)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=691619 Michal Ambroz changed: What|Removed |Added Alias||openvas-manager -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 691619] Review Request: openvas-manager - Open Vulnerability Assessment (OpenVAS) Manager (edit)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=691619 Carl Thompson changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|fed...@red-dragon.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 691619] Review Request: openvas-manager - Open Vulnerability Assessment (OpenVAS) Manager (edit)
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=691619
Carl Thompson changed:
What|Removed |Added
CC||fed...@red-dragon.com
--- Comment #1 from Carl Thompson 2011-03-29 23:57:31
EDT ---
+ = OK
- = NA
? = Issue
+ MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
rpmlint openvas-manager.spec
0 packages and 1 specfiles checked; 0 errors, 0 warnings.
+ MUST: The package must be named according to the Package Naming Guidelines .
+ MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
+ MUST: The package must meet the Packaging Guidelines .
+ MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
+ MUST: The License field in the package spec file must match the actual
license.
+ MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.
+ MUST: The spec file must be written in American English.
+ MUST: The spec file for the package MUST be legible.
+ MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
5680a523cfeac8aec4d52f5f964d1713 openvas-manager-2.0.2.tar.gz (package)
5680a523cfeac8aec4d52f5f964d1713 openvas-manager-2.0.2.tar.gz (upstream)
? MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture.
#output
-- Configuring the Manager...
-- The C compiler identification is GNU
-- Check for working C compiler: /usr/lib/ccache/gcc
-- Check for working C compiler: /usr/lib/ccache/gcc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Install prefix: /usr
-- checking for module 'libopenvas>=4.0.0'
-- found libopenvas, version 4.0.3
-- checking for module 'gnutls'
-- found gnutls, version 2.10.5
-- checking for module 'glib-2.0'
-- found glib-2.0, version 2.28.4
-- checking for module 'sqlite3'
-- found sqlite3, version 3.7.5
-- checking for module 'uuid'
-- package 'uuid' not found
CMake Error at /usr/share/cmake/Modules/FindPkgConfig.cmake:266 (message):
A required package was not found
Call Stack (most recent call first):
/usr/share/cmake/Modules/FindPkgConfig.cmake:320
(_pkg_check_modules_internal)
CMakeLists.txt:180 (pkg_check_modules)
-- Looking for pcap...
-- Looking for pcap... PCAP-NOTFOUND
CMake Error at CMakeLists.txt:186 (message):
The pcap library is required.
-- Configuring incomplete, errors occurred!
#end output
probably needs some additional requires defined such as libpcap-devel,
libuuid-devel
I recomend cleaning your mock and re initializing it to ensure a minimal
environment when you build
? MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
see previous item
? MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
see previous item (2 up, build failure)
+ MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
+ MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun.
+ MUST: Packages must NOT bundle copies of system libraries.
- MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
? MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory.
The %{_datadir}/openvas is not owned by the package, may consider naming the
directory openvas-%{version} as well
+ MUST: A Fedora package must not list a file more than once in the spec file's
%files listings. (Notable
[Bug 691619] Review Request: openvas-manager - Open Vulnerability Assessment (OpenVAS) Manager (edit)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=691619 Carl Thompson changed: What|Removed |Added Status Whiteboard||build failure -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 691619] Review Request: openvas-manager - Open Vulnerability Assessment (OpenVAS) Manager (edit)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=691619 Carl Thompson changed: What|Removed |Added Status Whiteboard|build failure |BuildFails -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 691619] Review Request: openvas-manager - Open Vulnerability Assessment (OpenVAS) Manager (edit)
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=691619
--- Comment #2 from Michal Ambroz 2011-03-30 09:22:55 EDT ---
Hello Carl,
thank you for feedback. I address the issues and upload new package at the
evening.
>? MUST: The package MUST successfully compile and build into binary rpms on at
Sorry for that - I will review dev dependencies once again.
>- MUST: If the package is designed to be relocatable, the packager must state
MA: Packageis not designed as relocatable and doesn't contain Prefix
>? MUST: A package must own all directories that it creates. If it does not
I will add dir %{_datadir}/openvas. Expect modified version uploaded this
evening.
I will not change to openvas-%{version} as the directory is used by other
openvas
packages as well and there is not a stong link to the version
>- MUST: Header files must be in a -devel package.
there are no header files
>- MUST: Static libraries must be in a -static package.
there are no static libraries
main binary openvasmd is linked dynamically
>- MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1),
not applicable
>- MUST: In the vast majority of cases, devel packages must require the base
not applicable - this is not devel package
>- MUST: Packages must NOT contain any .la libtool archives, these must be
not applicable - doesn't contain .la archives
>- MUST: Packages containing GUI applications must include a %{name}.desktop
not applicable - doesn't contain GUI application
>? SHOULD: If the source package does not include license text(s) as a separate
Not applicable - the package does include license text
>- SHOULD: The description and summary sections in the package spec file should
>contain translations for supported Non-English languages, if available.
Not applicable - translation is not available now.
>- SHOULD: Usually, subpackages other than devel should require the base package
>using a fully versioned dependency.
Not applicable - this is standalone module of openvas and is not tightly
limited for usage of all packages of the same version.
Version specific requirement for compiled library is computed automatically
during
build as recommended by the packagin guideline:
"Packages must not contain explicit Requires on libraries except when
absolutely necessary. "
>- SHOULD: The placement of pkgconfig(.pc) files depends on their usecase, and
not applicable - .pc files not included in the binary package
>- SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin,
I will add as this dependency was not detected by RPM, it is within /usr/bin
and explicit linking whole library is prohibited by the packaging guideline
Requires: /usr/bin/xsltproc
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 691619] Review Request: openvas-manager - Open Vulnerability Assessment (OpenVAS) Manager (edit)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=691619 --- Comment #3 from Carl Thompson 2011-03-30 12:13:03 EDT --- the - ones you don't have to worry about because they are not applicable, only the ? ones. Just update the bug when you get the dependencies tied up and get a new rpm and spec up. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 691619] Review Request: openvas-manager - Open Vulnerability Assessment (OpenVAS) Manager (edit)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=691619 --- Comment #4 from Michal Ambroz 2011-03-30 19:05:48 EDT --- Hello, here is the updated package: Spec URL: http://rebus.fedorapeople.org/SPECS/openvas-manager.spec SRPM URL: http://rebus.fedorapeople.org/SRPMS/openvas-manager-2.0.2-2.fc14.src.rpm Thank you Michal Ambroz -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 691619] Review Request: openvas-manager - Open Vulnerability Assessment (OpenVAS) Manager (edit)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=691619 --- Comment #5 from Carl Thompson 2011-03-30 19:58:05 EDT --- Unable to retrieve src.rpm rpmlint returns a warning so you know: rpmlint openvas-manager.spec openvas-manager.spec:26: W: mixed-use-of-spaces-and-tabs (spaces: line 26, tab: line 1) openvas-manager.spec: W: invalid-url Source0: http://wald.intevation.org/frs/download.php/858/openvas-manager-2.0.2.tar.gz 0 packages and 1 specfiles checked; 0 errors, 2 warnings. You used many tabs but on line 26 you used spaces. Not a blocker in my opinion but we do need to be able to pull down the src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 691619] Review Request: openvas-manager - Open Vulnerability Assessment (OpenVAS) Manager (edit)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=691619 --- Comment #6 from Michal Ambroz 2011-03-31 03:14:01 EDT --- Hi Carl, the src.rpm is really there - I have double-checked now. I am able to download. I even see it the http://rebus.fedorapeople.org/SRPMS/ directory. Please can you check you do not have some problems with your proxy? Space is just typo - I will fix it. Mik -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 691619] Review Request: openvas-manager - Open Vulnerability Assessment (OpenVAS) Manager (edit)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=691619 --- Comment #7 from Michal Ambroz 2011-03-31 03:24:12 EDT --- Link http://wald.intevation.org/frs/download.php/858/openvas-manager-2.0.2.tar.gz is the correct one as well and is working now. It is also officiall download link taken from http://www.openvas.org/. Please check again. Mik -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 691619] Review Request: openvas-manager - Open Vulnerability Assessment (OpenVAS) Manager (edit)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=691619 --- Comment #8 from Carl Thompson 2011-03-31 19:05:17 EDT --- Michal, When I get back to the house I'll try to review again. I don't run a proxy and didn't have issues with anything else. Could have been a link issue from my location to server or the server wasn't responsive at the time. Carl -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 691619] Review Request: openvas-manager - Open Vulnerability Assessment (OpenVAS) Manager (edit)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=691619 Michal Ambroz changed: What|Removed |Added See Also||https://bugzilla.redhat.com ||/show_bug.cgi?id=692733 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 691619] Review Request: openvas-manager - Open Vulnerability Assessment (OpenVAS) Manager (edit)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=691619 --- Comment #9 from Michal Ambroz 2011-03-31 19:55:58 EDT --- Thank you Carl. For testing you might need openvas-cli client. https://bugzilla.redhat.com/show_bug.cgi?id=692733 Mik -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 691619] Review Request: openvas-manager - Open Vulnerability Assessment (OpenVAS) Manager (edit)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=691619 --- Comment #10 from Carl Thompson 2011-04-01 02:19:44 EDT --- Looks like all builds and runs without issues that I could find in rawhide. It will not build in any other release. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 691619] Review Request: openvas-manager - Open Vulnerability Assessment (OpenVAS) Manager (edit)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=691619 Carl Thompson changed: What|Removed |Added Fixed In Version||openvas-manager-2.0.2-2 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 691619] Review Request: openvas-manager - Open Vulnerability Assessment (OpenVAS) Manager (edit)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=691619 Carl Thompson changed: What|Removed |Added Flag|fedora-review? |fedora-review+ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 691619] Review Request: openvas-manager - Open Vulnerability Assessment (OpenVAS) Manager (edit)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=691619 --- Comment #11 from Michal Ambroz 2011-04-01 15:31:54 EDT --- Hello Carl. >It will not build in any other release. Chicken and egg problem - you know. OpenVAS 4 needs 5 more packages (openvas-manager, openvas-cli, openvas-administrator and openvas-gsa, openvas-gsd ) to get the full solution. openvas-cli wont build in other releases as the other releases are now with OpenVAS 3.1 and not OpenVAS 4.0 Personally I am up to upgrading openvas from 3.1 to 4 for the other releases as well as it is fixing some serious bugs and brings some new features as well. Best regards Michal Ambroz -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 691619] Review Request: openvas-manager - Open Vulnerability Assessment (OpenVAS) Manager (edit)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=691619 --- Comment #12 from Michal Ambroz 2011-04-01 15:45:58 EDT --- Oops - I missed you already set the review as completed - thank you Carl. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 691619] Review Request: openvas-manager - Open Vulnerability Assessment (OpenVAS) Manager (edit)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=691619 Michal Ambroz changed: What|Removed |Added Flag||fedora-cvs? --- Comment #13 from Michal Ambroz 2011-04-01 15:57:33 EDT --- New Package SCM Request === Package Name: openvas-manager Short Description: Manager module for the Open Vulnerability Assessment System (OpenVAS) Owners: rebus sgros huzaifas xavierb Branches: f13 f14 f15 el5 el6 InitialCC: rebus sgros huzaifas xavierb -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 691619] Review Request: openvas-manager - Open Vulnerability Assessment (OpenVAS) Manager (edit)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=691619 --- Comment #14 from Jason Tibbitts 2011-04-05 11:26:23 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 691619] Review Request: openvas-manager - Open Vulnerability Assessment (OpenVAS) Manager (edit)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=691619 --- Comment #15 from Michal Ambroz 2011-04-05 20:28:09 EDT --- Package imported to the devel branch. Build in the devel branch is without issues: http://koji.fedoraproject.org/koji/taskinfo?taskID=2977156 Pending build of openvas-libraries for OpenVAS 4 in other branches: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 691619] Review Request: openvas-manager - Open Vulnerability Assessment (OpenVAS) Manager (edit)
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=691619
--- Comment #16 from Xavier Bachelot 2011-04-06 04:43:25
EDT ---
This is only nitpicking but the %clean section could be made simpler. you can
remove all of "[ "%{buildroot}" = "/" ] || "
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 691619] Review Request: openvas-manager - Open Vulnerability Assessment (OpenVAS) Manager (edit)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=691619 --- Comment #17 from Michal Ambroz 2011-04-06 10:39:20 EDT --- OK. I agree that in situation where most of the related packages (openvas-libraries, openvas-scanner) doesn't have such safety check it won't save anybody anyway - I will remove it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 691619] Review Request: openvas-manager - Open Vulnerability Assessment (OpenVAS) Manager (edit)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=691619 Michal Ambroz changed: What|Removed |Added See Also||https://bugzilla.redhat.com ||/show_bug.cgi?id=694139 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 691619] Review Request: openvas-manager - Open Vulnerability Assessment (OpenVAS) Manager (edit)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=691619 Michal Ambroz changed: What|Removed |Added Blocks||563471(FE-SECLAB) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 691619] Review Request: openvas-manager - Open Vulnerability Assessment (OpenVAS) Manager (edit)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=691619 Fedora Update System changed: What|Removed |Added Status|NEW |MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 691619] Review Request: openvas-manager - Open Vulnerability Assessment (OpenVAS) Manager (edit)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=691619 --- Comment #18 from Fedora Update System 2011-04-19 17:25:59 EDT --- openvas-manager-2.0.3-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/openvas-manager-2.0.3-1.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 691619] Review Request: openvas-manager - Open Vulnerability Assessment (OpenVAS) Manager (edit)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=691619 --- Comment #19 from Fedora Update System 2011-04-19 17:26:10 EDT --- openvas-manager-2.0.3-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/openvas-manager-2.0.3-1.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 691619] Review Request: openvas-manager - Open Vulnerability Assessment (OpenVAS) Manager (edit)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=691619 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #20 from Fedora Update System 2011-04-19 22:42:28 EDT --- openvas-manager-2.0.3-1.fc15 has been pushed to the Fedora 15 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 691619] Review Request: openvas-manager - Open Vulnerability Assessment (OpenVAS) Manager (edit)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=691619 --- Comment #21 from Fedora Update System 2011-05-06 22:51:53 EDT --- openvas-manager-2.0.3-1.fc14 has been pushed to the Fedora 14 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 691619] Review Request: openvas-manager - Open Vulnerability Assessment (OpenVAS) Manager (edit)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=691619 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version|openvas-manager-2.0.2-2 |openvas-manager-2.0.3-1.fc1 ||4 Resolution||ERRATA Last Closed||2011-05-06 22:51:59 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 691619] Review Request: openvas-manager - Open Vulnerability Assessment (OpenVAS) Manager (edit)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=691619 --- Comment #22 from Fedora Update System 2011-05-08 23:55:58 EDT --- openvas-manager-2.0.3-1.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 691619] Review Request: openvas-manager - Open Vulnerability Assessment (OpenVAS) Manager (edit)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=691619 Fedora Update System changed: What|Removed |Added Fixed In Version|openvas-manager-2.0.3-1.fc1 |openvas-manager-2.0.3-1.fc1 |4 |5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
