[Bug 692437] Review Request: tycho - plugins and extensions for building Eclipse plugins and OSGI bundles with Maven
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=692437 Alexander Kurtakov changed: What|Removed |Added Blocks||695711 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 692437] Review Request: tycho - plugins and extensions for building Eclipse plugins and OSGI bundles with Maven
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=692437 Alexander Kurtakov changed: What|Removed |Added Status|NEW |ASSIGNED CC||akurt...@redhat.com AssignedTo|nob...@fedoraproject.org|akurt...@redhat.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 692437] Review Request: tycho - plugins and extensions for building Eclipse plugins and OSGI bundles with Maven
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=692437
--- Comment #1 from Alexander Kurtakov 2011-05-02
09:51:26 EDT ---
Package Review
==
Key:
- = N/A
x = Check
! = Problem
? = Not evaluated
=== REQUIRED ITEMS ===
[!] Rpmlint output:
tycho.noarch: W: spelling-error %description -l en_US metadata -> meta data,
meta-data, metatarsal
tycho.noarch: W: spelling-error %description -l en_US runtime -> run time,
run-time, rudiment
tycho.noarch: W: spelling-error %description -l en_US lifecycle -> life cycle,
life-cycle, Wycliffe
tycho.noarch: W: spelling-error %description -l en_US classpath -> class path,
class-path, classmate
tycho.noarch: W: no-documentation
Readme.md looks like a good candidate.
tycho.noarch: W: non-conffile-in-etc /etc/maven/fragments/tycho
tycho-javadoc.noarch: W: spelling-error Summary(en_US) Javadocs -> Java docs,
Java-docs, Avocados
[x] Package is named according to the Package Naming Guidelines[1].
[x] Spec file name must match the base package name, in the format
%{name}.spec.
[x] Package meets the Packaging Guidelines[2].
[x] Package successfully compiles and builds into binary rpms.
[x] Buildroot definition is not present
[x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging
Guidelines[3,4].
[x] License field in the package spec file matches the actual license.
License type: ASL 2.0
[-] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
[-] All independent sub-packages have license of their own
[x] Spec file is legible and written in American English.
[-] Sources used to build the package matches the upstream source, as provided
in the spec URL.
[x] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines[5].
[x] Package must own all directories that it creates.
[x] Package requires other packages for directories it uses.
[x] Package does not contain duplicates in %files.
[x] Permissions on files are set properly.
[x] Package does NOT have a %clean section which contains rm -rf %{buildroot}
(or $RPM_BUILD_ROOT). (not needed anymore)
[x] Package consistently uses macros (no %{buildroot} and $RPM_BUILD_ROOT
mixing)
[x] Package contains code, or permissable content.
[x] Fully versioned dependency in subpackages, if present.
[-] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
[x] Package does not own files or directories owned by other packages.
[x] Javadoc documentation files are generated and included in -javadoc
subpackage
[x] Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlinks)
[x] Packages have proper BuildRequires/Requires on jpackage-utils
[x] Javadoc subpackages have Require: jpackage-utils
[x] Package uses %global not %define
[x] If package uses tarball from VCS include comment how to re-create that
tarball (svn export URL, git clone URL, ...)
[x] If source tarball includes bundled jar/class files these need to be
removed prior to building
[x] All filenames in rpm packages must be valid UTF-8.
[x] Jar files are installed to %{_javadir}/%{name}.jar (see [6] for details)
[x] If package contains pom.xml files install it (including depmaps) even when
building with ant
[x] pom files has correct add_to_maven_depmap call which resolves to the pom
file (use "JPP." and "JPP-" correctly)
=== Maven ===
[x] Use %{_mavenpomdir} macro for placing pom files instead of
%{_datadir}/maven2/poms
[-] If package uses "-Dmaven.test.skip=true" explain why it was needed in a
comment
[x] If package uses custom depmap "-Dmaven2.jpp.depmap.file=*" explain why
it's needed in a comment
[x] Package uses %update_maven_depmap in %post/%postun
[x] Packages have Requires(post) and Requires(postun) on jpackage-utils (for
%update_maven_depmap macro)
=== Other suggestions ===
[x] If possible use upstream build method (maven/ant/javac)
[x] Avoid having BuildRequires on exact NVR unless necessary
[x] Package has BuildArch: noarch (if possible)
[-] Latest version is packaged.
[x] Reviewer should test that the package builds in mock.
I have tested both the bootstrap and non-bootstrap version. Builds fine and
works for simple projects.
Issues:
1. Fix the empty %doc with proper documentation
2. Silence a bit by removing -X from mvn calls and -v from tar calls.
3. Fix the git clone command to the correct command for the tarball creation
4. Is there a reason to not use xz for the tarballs?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
p
[Bug 692437] Review Request: tycho - plugins and extensions for building Eclipse plugins and OSGI bundles with Maven
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=692437 --- Comment #2 from Stanislav Ochotnicky 2011-05-03 09:31:16 EDT --- Spec URL: http://sochotni.fedorapeople.org/packages/tycho.spec SRPM URL: http://sochotni.fedorapeople.org/packages/tycho-0.10.0-2.fc14.src.rpm * Tue May 3 2011 Stanislav Ochotnicky - 0.10.0-2 - Add README and make build more silent also fixed those comments for checking out repo -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 692437] Review Request: tycho - plugins and extensions for building Eclipse plugins and OSGI bundles with Maven
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=692437 Alexander Kurtakov changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #3 from Alexander Kurtakov 2011-05-03 09:42:58 EDT --- Thanks, APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 692437] Review Request: tycho - plugins and extensions for building Eclipse plugins and OSGI bundles with Maven
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=692437 Stanislav Ochotnicky changed: What|Removed |Added Flag||fedora-cvs? --- Comment #4 from Stanislav Ochotnicky 2011-05-03 09:58:14 EDT --- Thank you for the review New Package SCM Request === Package Name: tycho Short Description: Plugins and extensions for building Eclipse plugins and OSGI bundles with Maven Owners: sochotni Branches: f15 InitialCC: java-sig -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 692437] Review Request: tycho - plugins and extensions for building Eclipse plugins and OSGI bundles with Maven
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=692437 --- Comment #5 from Jason Tibbitts 2011-05-05 14:38:19 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 692437] Review Request: tycho - plugins and extensions for building Eclipse plugins and OSGI bundles with Maven
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=692437 Stanislav Ochotnicky changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE Last Closed||2011-05-06 09:54:04 --- Comment #6 from Stanislav Ochotnicky 2011-05-06 09:54:04 EDT --- Thank you, project built for rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=3054018 f15 will be added later on. Closing -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
