[Bug 693131] Review Request: sudoku-savant - Solve and generate sudoku puzzles through logical means
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=693131
Martin Gieseking changed:
What|Removed |Added
CC||martin.giesek...@uos.de
--- Comment #1 from Martin Gieseking 2011-04-03
09:46:25 EDT ---
Here are a couple of initial comments:
- The license seems to be GPLv3 only because there's no hint about later
versions. Please also ask upstream to add the missing copyright headers to
the
source files as requested by the GPL.
- Add a short comment about what the patch does.
- Drop BR: gcc-c++. It's always present in the build environment. See
http://fedoraproject.org/wiki/PackagingGuidelines#Exceptions_2
- Drop the GTK icon cache scriptlets. They are only needed if you put something
into or below %{_datadir}/icons/hicolor.
- Drop INSTALL from %doc. It's not of much use in a binary package.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 693131] Review Request: sudoku-savant - Solve and generate sudoku puzzles through logical means
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=693131 --- Comment #2 from Martin Gieseking 2011-04-03 09:50:08 EDT --- You can also remove the initial cleaning of the buildroot in %install if you don't plan to maintain the package for EPEL < 6. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 693131] Review Request: sudoku-savant - Solve and generate sudoku puzzles through logical means
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=693131 --- Comment #3 from Mario Blättermann 2011-04-03 10:31:07 EDT --- Bug filed for Sudoku Savant: https://sourceforge.net/tracker/?func=detail&aid=3272054&group_id=172187&atid=860784 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 693131] Review Request: sudoku-savant - Solve and generate sudoku puzzles through logical means
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=693131 --- Comment #4 from Mario Blättermann 2011-04-27 09:54:29 EDT --- Thanks for your hints. Spec URL: http://dl.dropbox.com/u/19373040/Fedora/SPECS/sudoku-savant.spec SRPM URL: http://dl.dropbox.com/u/19373040/Fedora/sudoku-savant-1.3-2.fc14.src.rpm Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3029768 No answer from the upstream developers yet. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 693131] Review Request: sudoku-savant - Solve and generate sudoku puzzles through logical means
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=693131
Martin Gieseking changed:
What|Removed |Added
Status|NEW |ASSIGNED
AssignedTo|nob...@fedoraproject.org|martin.giesek...@uos.de
Flag||fedora-review?
--- Comment #5 from Martin Gieseking 2011-04-28
04:05:38 EDT ---
OK, the package is almost ready. I had a deeper look into the sources and
wasn't able to find any hint about the GPL version intended. Even on the
website there's no further information. Thus, the package is licensed under
GPL+ since we can't rely on the version number given in COPYING:
http://fedoraproject.org/wiki/Licensing:FAQ#How_do_I_figure_out_what_version_of_the_GPL.2FLGPL_my_package_is_under.3F
Please also send the patch to the developer (if not yet done), and add a
comment with the link pointing to the upstream bug ticket.
(http://fedoraproject.org/wiki/PackagingGuidelines#All_patches_should_have_an_upstream_bug_link_or_comment)
$ rpmlint /var/lib/mock/fedora-14-x86_64/result/*.rpm
sudoku-savant.x86_64: W: no-manual-page-for-binary sudoku-savant
3 packages and 0 specfiles checked; 0 errors, 1 warnings.
-
key:
[+] OK
[.] OK, not applicable
[X] needs work
-
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license.
- COPYING contains GPLv3 license text
- src/aboutbox.cpp just mentions GPL but no version
- no further copyright information in the sources nor on
the project website
=> GPL+
[X] MUST: The License field in the package spec file must match the actual
license.
- please change the License tag to GPL+ and add a short comment to it
that the sources/docs lack any concrete licensing information
[+] MUST: The file containing the text of the license(s) for the package must
be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source.
$ md5sum sudoku-savant-1.3.tar.bz2*
668e77f35c6e8106da860a88c71f3c73 sudoku-savant-1.3.tar.bz2
668e77f35c6e8106da860a88c71f3c73 sudoku-savant-1.3.tar.bz2.1
[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
[.] MUST: If the package does not successfully compile, build or work on an
architecture, ...
[+] MUST: All build dependencies must be listed in BuildRequires.
[+] MUST: When compiling C, C++, or Fortran files, %{optflags} must be applied.
[+] MUST: The spec file MUST handle locales properly.
[.] MUST: If a package installs files below %{_datadir}/icons, the icon cache
must be updated.
[.] MUST: Packages storing shared library files (not just symlinks) must call
ldconfig in %post and %postun.
[+] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, ...
[+] MUST: A package must own all directories that it creates.
[+] MUST: A Fedora package must not list a file more than once in %files.
[+] MUST: Permissions on files must be set properly.
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.
[.] MUST: Large documentation files must go in a -doc subpackage.
[+] MUST: Files in %doc must not affect the runtime of the application.
[.] MUST: Header files must be in a -devel package.
[.] MUST: Static libraries must be in a -static package.
[.] MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), ...
[.] MUST: devel packages must require the base package using a fully versioned
dependency.
[+] MUST: Packages must NOT contain any .la libtool archives.
[+] MUST: Packages containing GUI applications must include a %{name}.desktop
file.
[+] MUST: .desktop files must be properly installed with desktop-file-install
in the %install section.
[+] MUST: Packages must not own files or directories already owned by other
packages.
[+] MUST: All filenames in rpm packages must be valid UTF-8.
[.] SHOULD: If the source package does not include license text(s) as a
separate file from upstream, ...
[+] SHOULD: The reviewer should test that the package builds in mock.
[+] SHOULD: The reviewer should test that the package functions as described.
[.] SHOULD: If scriptlets are used, those scriptlets must be sane.
[.] SHOULD: Usually, subpackages other than devel should require the base
package using a fully version
[Bug 693131] Review Request: sudoku-savant - Solve and generate sudoku puzzles through logical means
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=693131 --- Comment #6 from Mario Blättermann 2011-04-28 09:50:18 EDT --- Spec URL: http://dl.dropbox.com/u/19373040/Fedora/SPECS/sudoku-savant.spec SRPM URL: http://dl.dropbox.com/u/19373040/Fedora/sudoku-savant-1.3-3.fc14.src.rpm I've added some comments regarding the license and build problems, including links to the appropriate upstream bugs. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 693131] Review Request: sudoku-savant - Solve and generate sudoku puzzles through logical means
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=693131 Martin Gieseking changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #7 from Martin Gieseking 2011-04-28 10:10:03 EDT --- OK, the package looks good now. There's a small typo in the German %description you can fix before checking the package into Git (no need to bump the Release number for that, though): "Das manuelle Lösen..." (capital L) Package APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 693131] Review Request: sudoku-savant - Solve and generate sudoku puzzles through logical means
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=693131 --- Comment #8 from Mario Blättermann 2011-04-28 10:20:38 EDT --- Thanks for your review. The spelling error in the German description is already changed in the Dropbox files. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 693131] Review Request: sudoku-savant - Solve and generate sudoku puzzles through logical means
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=693131 Mario Blättermann changed: What|Removed |Added Flag||fedora-cvs? --- Comment #9 from Mario Blättermann 2011-04-28 10:22:43 EDT --- New Package SCM Request === Package Name: sudoku-savant Short Description: Solve and generate sudoku puzzles through logical means Owners: mariobl Branches: f14 f15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 693131] Review Request: sudoku-savant - Solve and generate sudoku puzzles through logical means
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=693131 --- Comment #10 from Dennis Gilmore 2011-04-28 12:42:23 EDT --- Mario you need to have the fas email match the one in bugzilla -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 693131] Review Request: sudoku-savant - Solve and generate sudoku puzzles through logical means
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=693131 --- Comment #11 from Mario Blättermann 2011-04-28 14:55:16 EDT --- (In reply to comment #10) > Mario you need to have the fas email match the one in bugzilla Done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 693131] Review Request: sudoku-savant - Solve and generate sudoku puzzles through logical means
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=693131 --- Comment #12 from Jason Tibbitts 2011-04-29 12:09:42 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 693131] Review Request: sudoku-savant - Solve and generate sudoku puzzles through logical means
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=693131 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 693131] Review Request: sudoku-savant - Solve and generate sudoku puzzles through logical means
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=693131 --- Comment #13 from Fedora Update System 2011-04-29 12:52:57 EDT --- sudoku-savant-1.3-3.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/sudoku-savant-1.3-3.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 693131] Review Request: sudoku-savant - Solve and generate sudoku puzzles through logical means
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=693131 --- Comment #14 from Fedora Update System 2011-04-29 13:01:04 EDT --- sudoku-savant-1.3-3.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/sudoku-savant-1.3-3.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 693131] Review Request: sudoku-savant - Solve and generate sudoku puzzles through logical means
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=693131 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #15 from Fedora Update System 2011-04-29 18:20:02 EDT --- sudoku-savant-1.3-3.fc14 has been pushed to the Fedora 14 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 693131] Review Request: sudoku-savant - Solve and generate sudoku puzzles through logical means
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=693131 --- Comment #16 from Fedora Update System 2011-05-05 01:01:51 EDT --- sudoku-savant-1.3-3.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 693131] Review Request: sudoku-savant - Solve and generate sudoku puzzles through logical means
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=693131 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||sudoku-savant-1.3-3.fc15 Resolution||ERRATA Last Closed||2011-05-05 01:01:59 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 693131] Review Request: sudoku-savant - Solve and generate sudoku puzzles through logical means
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=693131 --- Comment #17 from Fedora Update System 2011-05-08 21:52:45 EDT --- sudoku-savant-1.3-3.fc14 has been pushed to the Fedora 14 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 693131] Review Request: sudoku-savant - Solve and generate sudoku puzzles through logical means
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=693131 Fedora Update System changed: What|Removed |Added Fixed In Version|sudoku-savant-1.3-3.fc15|sudoku-savant-1.3-3.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
