[Bug 697673] Review Request: sjinn - Simple tool for sending receiving data from RS-232 devices
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=697673 --- Comment #13 from Fedora Update System upda...@fedoraproject.org 2011-05-19 00:42:58 EDT --- sjinn-1.01-2.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 697673] Review Request: sjinn - Simple tool for sending receiving data from RS-232 devices
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=697673 --- Comment #12 from Fedora Update System upda...@fedoraproject.org 2011-05-10 17:21:50 EDT --- sjinn-1.01-2.fc14 has been pushed to the Fedora 14 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 697673] Review Request: sjinn - Simple tool for sending receiving data from RS-232 devices
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=697673 John W. Linville linvi...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE Last Closed||2011-05-02 13:45:04 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 697673] Review Request: sjinn - Simple tool for sending receiving data from RS-232 devices
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=697673 --- Comment #10 from Fedora Update System upda...@fedoraproject.org 2011-05-02 13:46:28 EDT --- sjinn-1.01-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/sjinn-1.01-2.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 697673] Review Request: sjinn - Simple tool for sending receiving data from RS-232 devices
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=697673 --- Comment #11 from Fedora Update System upda...@fedoraproject.org 2011-05-02 13:56:33 EDT --- sjinn-1.01-2.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/sjinn-1.01-2.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 697673] Review Request: sjinn - Simple tool for sending receiving data from RS-232 devices
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=697673 --- Comment #9 from Jason Tibbitts ti...@math.uh.edu 2011-04-30 14:09:55 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 697673] Review Request: sjinn - Simple tool for sending receiving data from RS-232 devices
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=697673
Mario Blättermann mari...@freenet.de changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||mari...@freenet.de
AssignedTo|nob...@fedoraproject.org|mari...@freenet.de
Flag||fedora-review+
--- Comment #2 from Mario Blättermann mari...@freenet.de 2011-04-29 09:32:50
EDT ---
From rpmlint:
sjinn.i686: E: incorrect-fsf-address /usr/share/doc/sjinn-1.01/COPYING
Common problem, see bug #697680 and bug #699586. Not a blocker though, but
worth an upstream bug.
Looks fine so far.
-
key:
[+] OK
[.] OK, not applicable
[X] needs work
-
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license.
GPLv2+
[+] MUST: The License field in the package spec file must match the actual
license.
[+] MUST: The file containing the text of the license(s) for the package must
be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source.
$ md5sum *
b38969d4a614b660919090ba0c8d5c7d sjinn-1.01.tar.gz
b38969d4a614b660919090ba0c8d5c7d sjinn-1.01.tar.gz.packaged
[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
- Succesful Koji build available:
http://koji.fedoraproject.org/koji/taskinfo?taskID=3009531
[.] MUST: If the package does not successfully compile, build or work on an
architecture, ...
[+] MUST: All build dependencies must be listed in BuildRequires.
- the basic build environment is sufficient here.
[.] MUST: The spec file MUST handle locales properly.
[.] MUST: If a package installs files below %{_datadir}/icons, the icon cache
must be updated.
[.] MUST: Packages storing shared library files (not just symlinks) must call
ldconfig in %post and %postun.
[.] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, ...
[+] MUST: A package must own all directories that it creates.
[+] MUST: A Fedora package must not list a file more than once in %files.
[+] MUST: Permissions on files must be set properly.
[+] MUST: Packages must not provide RPM dependency information when that
information is not global in nature, or are otherwise handled.
[.] MUST: When filtering automatically generated RPM dependency information,
the filtering system implemented by Fedora must be used.
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.
[.] MUST: Large documentation files must go in a -doc subpackage.
[+] MUST: Files in %doc must not affect the runtime of the application.
[.] MUST: Header files must be in a -devel package.
[.] MUST: Static libraries must be in a -static package.
[.] MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), ...
[.] MUST: devel packages must require the base package using a fully versioned
dependency.
[.] MUST: Packages must NOT contain any .la libtool archives.
[.] MUST: Packages containing GUI applications must include a %{name}.desktop
file
[.] MUST: .desktop files must be properly installed with desktop-file-install
in the %install section.
[+] MUST: Packages must not own files or directories already owned by other
packages.
[+] MUST: All filenames in rpm packages must be valid UTF-8.
[.] SHOULD: If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream...
[+] SHOULD: Timestamps of files should be preserved.
[+] SHOULD: The reviewer should test that the package builds in mock.
See Koji build above (which uses mock anyway)
[+] SHOULD: The reviewer should test that the package functions as described.
I assume the packager has tested it.
[.] SHOULD: If scriptlets are used, those scriptlets must be sane.
[.] SHOULD: Usually, subpackages other than devel should require the base
package using a fully versioned dependency.
[.] SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg.
[.] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin,
/usr/bin, or /usr/sbin ...
[.] SHOULD: Your package should contain man pages for binaries/scripts.
PACKAGE APPROVED
--
Configure bugmail:
[Bug 697673] Review Request: sjinn - Simple tool for sending receiving data from RS-232 devices
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=697673 Mario Blättermann mari...@freenet.de changed: What|Removed |Added Flag|fedora-review+ | --- Comment #3 from Mario Blättermann mari...@freenet.de 2011-04-29 09:41:48 EDT --- Oops, just found a problem: sjinn-debuginfo.i686: W: spurious-executable-perm /usr/src/debug/sjinn/rs232.h sjinn-debuginfo.i686: W: spurious-executable-perm /usr/src/debug/sjinn/rs232main.c sjinn-debuginfo.i686: W: spurious-executable-perm /usr/src/debug/sjinn/rs232ctl.c sjinn-debuginfo.i686: W: spurious-executable-perm /usr/src/debug/sjinn/rs232opts.c There remains an executable bit on the mentioned files in the debug package. $ rpmlint -I spurious-executable-perm spurious-executable-perm: The file is installed with executable permissions, but was identified as one that probably should not be executable. Verify if the executable bits are desired, and remove if not. You should have a deeper look at this. Although you have removed the executable bits from the files in the spec, they remains on the files in the debug package. I've removed the approved flag from this review request for the time being. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 697673] Review Request: sjinn - Simple tool for sending receiving data from RS-232 devices
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=697673 --- Comment #4 from Mario Blättermann mari...@freenet.de 2011-04-29 09:46:23 EDT --- Found the problem probably. All the files in the tarball have the executable bit set. You should remove it generally from all files. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 697673] Review Request: sjinn - Simple tool for sending receiving data from RS-232 devices
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=697673
Martin Gieseking martin.giesek...@uos.de changed:
What|Removed |Added
CC||martin.giesek...@uos.de
--- Comment #5 from Martin Gieseking martin.giesek...@uos.de 2011-04-29
10:34:37 EDT ---
Have the patches been sent upstream? Please also add comments about what the
patches do.
http://fedoraproject.org/wiki/PackagingGuidelines#All_patches_should_have_an_upstream_bug_link_or_comment
Please don't add the compressed manpage coming with the tarball. Decompress it
in %prep and let rpmbuild choose the compression format.
Also, decompress the example scripts and add the scripts folder with %doc.
Use the plain sed command instead of the macro:
http://fedoraproject.org/wiki/PackagingGuidelines#Macros
%{?_smp_mflags} and the definition of CFLAGS are not required in make
install.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 697673] Review Request: sjinn - Simple tool for sending receiving data from RS-232 devices
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=697673 --- Comment #6 from John W. Linville linvi...@redhat.com 2011-04-29 11:38:59 EDT --- Spec URL: http://linville.fedorapeople.org/sjinn.spec SRPM URL: http://linville.fedorapeople.org/sjinn-1.01-2.fc14.src.rpm Thanks for the reviews! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 697673] Review Request: sjinn - Simple tool for sending receiving data from RS-232 devices
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=697673 Mario Blättermann mari...@freenet.de changed: What|Removed |Added Flag||fedora-review+ --- Comment #7 from Mario Blättermann mari...@freenet.de 2011-04-29 12:14:33 EDT --- $ rpmlint -v * sjinn.src: I: checking sjinn.src: W: spelling-error %description -l en_US stty - titty, atty, sty sjinn.src: I: checking-url http://sjinn.sourceforge.net/ (timeout 10 seconds) sjinn.src: I: checking-url http://downloads.sourceforge.net/sjinn/sjinn-1.01.tar.gz (timeout 10 seconds) sjinn.i686: I: checking sjinn.i686: W: spelling-error %description -l en_US stty - titty, atty, sty sjinn.i686: I: checking-url http://sjinn.sourceforge.net/ (timeout 10 seconds) sjinn.i686: E: incorrect-fsf-address /usr/share/doc/sjinn-1.01/COPYING sjinn-debuginfo.i686: I: checking sjinn-debuginfo.i686: I: checking-url http://sjinn.sourceforge.net/ (timeout 10 seconds) sjinn-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/sjinn/rs232main.c sjinn-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/sjinn/rs232ctl.c sjinn-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/sjinn/rs232opts.c sjinn.spec: I: checking-url http://downloads.sourceforge.net/sjinn/sjinn-1.01.tar.gz (timeout 10 seconds) 3 packages and 1 specfiles checked; 4 errors, 2 warnings. Besides some spelling errors and the old FSF address, it looks good now. - PACKAGE APPROVED (again!) - -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 697673] Review Request: sjinn - Simple tool for sending receiving data from RS-232 devices
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=697673 John W. Linville linvi...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #8 from John W. Linville linvi...@redhat.com 2011-04-29 12:59:36 EDT --- New Package SCM Request === Package Name: sjinn Short Description: Simple tool for sending receiving data from RS-232 devices Owners: linville Branches: f14 f15 InitialCC: linville -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 697673] Review Request: sjinn - Simple tool for sending receiving data from RS-232 devices
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=697673 --- Comment #1 from John W. Linville linvi...@redhat.com 2011-04-18 17:38:22 EDT --- http://koji.fedoraproject.org/koji/taskinfo?taskID=3009531 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
