[Bug 698576] Review Request: pal - Command line calendar that displays holidays and events
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=698576 --- Comment #17 from Fedora Update System upda...@fedoraproject.org 2011-06-08 19:56:26 EDT --- pal-0.4.3-2.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698576] Review Request: pal - Command line calendar that displays holidays and events
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=698576 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|pal-0.4.3-2.fc14|pal-0.4.3-2.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698576] Review Request: pal - Command line calendar that displays holidays and events
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=698576 --- Comment #16 from Fedora Update System upda...@fedoraproject.org 2011-05-24 22:54:48 EDT --- pal-0.4.3-2.fc14 has been pushed to the Fedora 14 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698576] Review Request: pal - Command line calendar that displays holidays and events
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=698576 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||pal-0.4.3-2.fc14 Resolution||ERRATA Last Closed||2011-05-24 22:54:53 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698576] Review Request: pal - Command line calendar that displays holidays and events
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=698576 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #15 from Fedora Update System upda...@fedoraproject.org 2011-05-13 19:15:10 EDT --- pal-0.4.3-2.fc14 has been pushed to the Fedora 14 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698576] Review Request: pal - Command line calendar that displays holidays and events
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=698576 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698576] Review Request: pal - Command line calendar that displays holidays and events
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=698576 --- Comment #13 from Fedora Update System upda...@fedoraproject.org 2011-05-12 10:23:04 EDT --- pal-0.4.3-2.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/pal-0.4.3-2.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698576] Review Request: pal - Command line calendar that displays holidays and events
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=698576 --- Comment #14 from Fedora Update System upda...@fedoraproject.org 2011-05-12 10:27:29 EDT --- pal-0.4.3-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/pal-0.4.3-2.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698576] Review Request: pal - Command line calendar that displays holidays and events
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=698576 --- Comment #12 from Jason Tibbitts ti...@math.uh.edu 2011-05-10 11:36:06 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698576] Review Request: pal - Command line calendar that displays holidays and events
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=698576 Martin Cermak mcer...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #11 from Martin Cermak mcer...@redhat.com 2011-05-07 06:38:19 EDT --- New Package SCM Request === Package Name: pal Short Description: Command line calendar that displays holidays and events Owners: mcermak Branches: f14 f15 InitialCC: jwrdegoede -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698576] Review Request: pal - Command line calendar that displays holidays and events
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=698576 --- Comment #7 from Martin Cermak mcer...@redhat.com 2011-05-06 04:30:58 EDT --- I belive pal-0.4.3-2 contains all the requested fixes: Spec URL: http://www.physics.muni.cz/~cermak/pal-0.4.3-2/pal.spec SRPM URL: http://www.physics.muni.cz/~cermak/pal-0.4.3-2/pal-0.4.3-2.fc14.src.rpm + rpmlint pal.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. + rpmlint pal-0.4.3-2.fc14.src.rpm pal.src: W: spelling-error %description -l en_US gcal - gal, cal, goal 1 packages and 0 specfiles checked; 0 errors, 1 warnings. + rpmlint pal-debuginfo-0.4.3-2.fc14.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. + rpmlint pal-0.4.3-2.fc14.x86_64.rpm pal.x86_64: W: spelling-error %description -l en_US gcal - gal, cal, goal 1 packages and 0 specfiles checked; 0 errors, 1 warnings. Hans, please, review my changes. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698576] Review Request: pal - Command line calendar that displays holidays and events
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=698576 Hans de Goede hdego...@redhat.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #8 from Hans de Goede hdego...@redhat.com 2011-05-06 04:39:29 EDT --- Looks good now, approved! If you can go and create a fas account (if you've not done so already) and tell me your fas username, I'll add you to the packager group and sponsor you, see: http://fedoraproject.org/wiki/PackageMaintainers/Join#Get_a_Fedora_Account -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698576] Review Request: pal - Command line calendar that displays holidays and events
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=698576 --- Comment #9 from Martin Cermak mcer...@redhat.com 2011-05-06 09:11:38 EDT --- Great, thanks! My fas username is mcermak. What should I do next? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698576] Review Request: pal - Command line calendar that displays holidays and events
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=698576 --- Comment #10 from Hans de Goede hdego...@redhat.com 2011-05-06 09:26:54 EDT --- Hi, (In reply to comment #9) Great, thanks! My fas username is mcermak. What should I do next? I've just added you to the packager group and sponsored you, the next steps, are described here: http://fedoraproject.org/wiki/PackageMaintainers/Join The first thing to do is request creation of git and bugzilla modules for your approved packages, see: http://fedoraproject.org/wiki/Package_SCM_admin_requests Note that it may take up to an hour for your newer packager rights to propagate to all servers, and you won't be able to set the fedora-cvs flag until you've those rights. Regards, Hans -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698576] Review Request: pal - Command line calendar that displays holidays and events
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=698576 --- Comment #6 from Hans de Goede hdego...@redhat.com 2011-05-04 03:18:53 EDT --- (In reply to comment #5) Uhm, could you please read the description again? Pal is command-line calendar program that can keep track of events pal is a command-line calendar program for Unix/Linux systems that can keep track of events. [...] I think this should really be corrected (e.g. remove the first part until pal is a...). Agreed, Martin you can add that to the needswork list... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698576] Review Request: pal - Command line calendar that displays holidays and events
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=698576 --- Comment #5 from Golo Fuchert packa...@golotop.de 2011-05-03 15:33:38 EDT --- Uhm, could you please read the description again? Pal is command-line calendar program that can keep track of events pal is a command-line calendar program for Unix/Linux systems that can keep track of events. [...] I think this should really be corrected (e.g. remove the first part until pal is a...). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698576] Review Request: pal - Command line calendar that displays holidays and events
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=698576 --- Comment #3 from Jason Tibbitts ti...@math.uh.edu 2011-04-30 14:12:17 EDT --- I see no SCM request to process here. Perhaps the wrong flag was set by mistake? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698576] Review Request: pal - Command line calendar that displays holidays and events
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=698576 Hans de Goede hdego...@redhat.com changed: What|Removed |Added Flag||fedora-review? --- Comment #4 from Hans de Goede hdego...@redhat.com 2011-04-30 15:09:02 EDT --- (In reply to comment #3) I see no SCM request to process here. Perhaps the wrong flag was set by mistake? My bad, I meant to set fedora-review to ?, same for bug 700833, don't know how this happened... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698576] Review Request: pal - Command line calendar that displays holidays and events
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=698576 Hans de Goede hdego...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||hdego...@redhat.com Blocks|177841(FE-NEEDSPONSOR) | AssignedTo|nob...@fedoraproject.org|hdego...@redhat.com --- Comment #1 from Hans de Goede hdego...@redhat.com 2011-04-29 08:22:04 EDT --- I'll review this (and your other submission), and assuming all goes well sponsor you eventually, removing FE_NEEDSPONSOR blocker. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698576] Review Request: pal - Command line calendar that displays holidays and events
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=698576
Hans de Goede hdego...@redhat.com changed:
What|Removed |Added
Flag||fedora-cvs?
--- Comment #2 from Hans de Goede hdego...@redhat.com 2011-04-29 09:00:10 EDT
---
Full review done, results:
Good:
=
- rpmlint checks return:
pal.src: W: spelling-error %description -l en_US gcal - gal, cal, goal
pal.x86_64: W: spelling-error %description -l en_US gcal - gal, cal, goal
These can be ignored
- package meets naming guidelines
- package meets packaging guidelines
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- locales handled properly
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file
Needs work:
===
- rpmlint checks return:
pal-debuginfo.x86_64: E: empty-debuginfo-package
This is caused by the Makefile stripping the binary directly after the build,
you can stop it from doing this by passing DEBUG=1 on the make cmdline.
- The license should be GPLv2+
- Fedora has a standard url for sf.net downloads, please use:
Source0:http://downloads.sourceforge.net/palcal/pal-%{version}.tgz
- No need to pass: -n %{name}-%{version} to %setup, this is the default
- The preferred form for %defattr in fedora is:
%defattr(-,root,root,-)
- The files under %{_datadir}/doc/pal-%{version} should be marked as %doc,
not gzipped and not include INSTALL. The easiest way is to add the following
line to %files:
%doc doc/example.css COPYING ChangeLog
Note traditionally this lines comes directly after the %defattr line
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698576] Review Request: pal - Command line calendar that displays holidays and events
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=698576 Martin Cermak mcer...@redhat.com changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
