[Bug 698692] Review Request: grilo-plugins - Plugins for the Grilo framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=698692 Fedora Update System changed: What|Removed |Added Fixed In Version||grilo-plugins-0.1.15-4.fc15 Resolution|NEXTRELEASE |ERRATA --- Comment #16 from Fedora Update System 2011-11-14 17:24:40 EST --- grilo-plugins-0.1.15-4.fc15, grilo-0.1.15-3.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698692] Review Request: grilo-plugins - Plugins for the Grilo framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=698692 Bastien Nocera changed: What|Removed |Added Depends on||698681 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698692] Review Request: grilo-plugins - Plugins for the Grilo framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=698692 Bastien Nocera changed: What|Removed |Added Depends on|698681 | --- Comment #1 from Bastien Nocera 2011-05-04 10:24:29 EDT --- Grilo itself is built in F15 and rawhide, removing the dependency. Anyone interested in reviewing the package? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698692] Review Request: grilo-plugins - Plugins for the Grilo framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=698692 --- Comment #2 from Bastien Nocera 2011-05-20 09:05:20 EDT --- With a few fixes: http://people.fedoraproject.org/~hadess/grilo/grilo-plugins.spec http://people.fedoraproject.org/~hadess/grilo/grilo-plugins-0.1.15-2.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698692] Review Request: grilo-plugins - Plugins for the Grilo framework
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=698692
Kalev Lember changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||ka...@smartlink.ee
AssignedTo|nob...@fedoraproject.org|ka...@smartlink.ee
Flag||fedora-review?
--- Comment #3 from Kalev Lember 2011-05-20 09:35:11 EDT
---
Taking for review.
1) The BuildRoot tag, the 'rm -rf $RPM_BUILD_ROOT' at the beginning of %install
section, the whole %clean section, and the %defattr lines are no longer needed
in current Fedora releases and you could remove them, if you want to.
2) You are removing %{_libdir}/grilo-0.1/*.a in %install section after building
them, but it might be cleaner to avoid building the static libs in the first
place. Does configure --disable-static work for this package?
3) Some of the directories aren't owned by any package and that would cause
empty directories to be left behind when uninstalling the package.
Either (a) grilo, or (b) all grilo's plugin packages should own these dirs:
%{_libdir}/grilo-0.1/
%{_datadir}/grilo-0.1/
%{_datadir}/grilo-0.1/plugins/
4) The source URL currently looks like this:
http://ftp.gnome.org/pub/GNOME/sources/grilo-plugins/0.1/grilo-plugins-%{version}.tar.bz2
It might be nice to automatically figure out the '0.1' directory name, so that
it would only be necessary to update the Version: field when building updates.
I have used shell scripting in a some packages to accomplish that; not sure if
it's something you'd want to use here.
At the top of the spec file I've put this:
# first two digits of version
%define release_version %(echo %{version} | awk -F. '{print $1"."$2}')
... and in the Source0 tag, instead of the hardcoded '0.1' goes
%{release_version} macro.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698692] Review Request: grilo-plugins - Plugins for the Grilo framework
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=698692
--- Comment #4 from Bastien Nocera 2011-05-20 09:41:27 EDT
---
(In reply to comment #3)
> Taking for review.
>
> 1) The BuildRoot tag, the 'rm -rf $RPM_BUILD_ROOT' at the beginning of
> %install
> section, the whole %clean section, and the %defattr lines are no longer needed
> in current Fedora releases and you could remove them, if you want to.
Done.
> 2) You are removing %{_libdir}/grilo-0.1/*.a in %install section after
> building
> them, but it might be cleaner to avoid building the static libs in the first
> place. Does configure --disable-static work for this package?
That works indeed.
> 3) Some of the directories aren't owned by any package and that would cause
> empty directories to be left behind when uninstalling the package.
> Either (a) grilo, or (b) all grilo's plugin packages should own these dirs:
> %{_libdir}/grilo-0.1/
> %{_datadir}/grilo-0.1/
> %{_datadir}/grilo-0.1/plugins/
I'll add those directories in grilo itself.
> 4) The source URL currently looks like this:
> http://ftp.gnome.org/pub/GNOME/sources/grilo-plugins/0.1/grilo-plugins-%{version}.tar.bz2
>
> It might be nice to automatically figure out the '0.1' directory name, so that
> it would only be necessary to update the Version: field when building updates.
> I have used shell scripting in a some packages to accomplish that; not sure if
> it's something you'd want to use here.
Pretty much every single GNOME tarball has that exact same problem.
> At the top of the spec file I've put this:
> # first two digits of version
> %define release_version %(echo %{version} | awk -F. '{print $1"."$2}')
>
> ... and in the Source0 tag, instead of the hardcoded '0.1' goes
> %{release_version} macro.
But I've done that now.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698692] Review Request: grilo-plugins - Plugins for the Grilo framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=698692 --- Comment #5 from Bastien Nocera 2011-05-20 09:41:56 EDT --- http://people.fedoraproject.org/~hadess/grilo/grilo-plugins.spec http://people.fedoraproject.org/~hadess/grilo/grilo-plugins-0.1.15-3.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698692] Review Request: grilo-plugins - Plugins for the Grilo framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=698692 --- Comment #6 from Kalev Lember 2011-05-20 10:21:40 EDT --- (In reply to comment #4) > > 1) The BuildRoot tag, the 'rm -rf $RPM_BUILD_ROOT' at the beginning of > > %install > > section, the whole %clean section, and the %defattr lines are no longer > > needed > > in current Fedora releases and you could remove them, if you want to. > > Done. I'm just nitpicking here, it's not very important, but ... looks like you missed the the BuildRoot definition near the top of the spec file and the %clean section, these can also be removed. > > 4) The source URL currently looks like this: [...] > Pretty much every single GNOME tarball has that exact same problem. Yeah. If we can figure out a good way to do it, it's something that other GNOME packages could also use. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698692] Review Request: grilo-plugins - Plugins for the Grilo framework
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=698692
Kalev Lember changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #7 from Kalev Lember 2011-05-20 10:22:32 EDT
---
Fedora review grilo-plugins-0.1.15-3.src.rpm 2011-05-20
+ OK
! needs attention
koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=3083534
$ rpmlint grilo-plugins \
grilo-plugins-0.1.15-3.src.rpm \
grilo-plugins-debuginfo-0.1.15-3.x86_64.rpm
grilo-plugins.src: W: spelling-error %description -l en_US pluggable -> plug
gable, plug-gable, plugged
grilo-plugins.src: W: spelling-error %description -l en_US fm -> FM, Fm, gm
grilo-plugins.src: W: spelling-error %description -l en_US metadata -> meta
data, meta-data, metatarsal
grilo-plugins.x86_64: W: spelling-error %description -l en_US pluggable -> plug
gable, plug-gable, plugged
grilo-plugins.x86_64: W: spelling-error %description -l en_US fm -> FM, Fm, gm
grilo-plugins.x86_64: W: spelling-error %description -l en_US metadata -> meta
data, meta-data, metatarsal
3 packages and 0 specfiles checked; 0 errors, 6 warnings.
+ rpmlint warnings are harmless and can be ignored
+ The package is named according to Fedora packaging guidelines
+ The spec file name matches the package base name
+ The package meets the Packaging Guidelines
+ The package is licensed with a Fedora approved license and meets the
Licensing Guidelines.
+ The license field in the spec file matches the actual license
+ The package contains the license file (COPYING)
+ Spec file is written in American English
+ Spec file is legible
+ Upstream sources match sources in the srpm. md5sum:
29efa89f3842787c21271a7513a9a1ab grilo-plugins-0.1.15.tar.bz2
29efa89f3842787c21271a7513a9a1ab Download/grilo-plugins-0.1.15.tar.bz2
+ The package builds in koji
n/a ExcludeArch bugs filed
+ BuildRequires look sane
n/a The spec file MUST handle locales properly
n/a ldconfig in %post and %postun
+ Package does not bundle copies of system libraries
n/a Package isn't relocatable
! Package currently doesn't own all directories it creates,
but it's going to be fixed in grilo package as per comment #4
+ No duplicate files in %files
+ Permissions are properly set
+ Consistent use of macros
+ The package must contain code or permissible content
n/a Large documentation files should go in -doc subpackage
+ Files marked %doc should not affect package
n/a Header files should be in -devel
n/a Static libraries should be in -static
n/a Library files that end in .so must go in a -devel package
It's a plugin package, not applicable.
n/a -devel must require the fully versioned base
+ Packages should not contain libtool .la files
n/a Packages containing GUI apps must include %{name}.desktop file
+ Directory ownership sane
+ Filenames are valid UTF-8
Remaining issues:
- add the missing directories to grilo package;
- take a look at comment #6 if you want to remove BuildRoot and %clean
- I'd suggest to add the %{?dist} macro to Release
These can all be fixed before importing the package.
APPROVED
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698692] Review Request: grilo-plugins - Plugins for the Grilo framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=698692 --- Comment #8 from Bastien Nocera 2011-05-20 10:37:16 EDT --- grilo-0.1.15-3.fc16 is built, so I'll add it to the same update. http://people.fedoraproject.org/~hadess/grilo/grilo-plugins.spec and http://people.fedoraproject.org/~hadess/grilo/grilo-plugins-0.1.15-4.fc15.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698692] Review Request: grilo-plugins - Plugins for the Grilo framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=698692 Bastien Nocera changed: What|Removed |Added Flag||fedora-cvs? --- Comment #9 from Bastien Nocera 2011-05-20 10:39:14 EDT --- New Package SCM Request === Package Name: grilo-plugins Short Description: Plugins for the Grilo framework Owners: hadess Branches: f15 el6 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698692] Review Request: grilo-plugins - Plugins for the Grilo framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=698692 --- Comment #10 from Kalev Lember 2011-05-20 10:52:12 EDT --- If you're building for el6, I believe it needs the %clean section: https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698692] Review Request: grilo-plugins - Plugins for the Grilo framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=698692 --- Comment #11 from Kevin Fenzi 2011-05-20 18:30:00 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698692] Review Request: grilo-plugins - Plugins for the Grilo framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=698692 --- Comment #12 from Bastien Nocera 2011-05-21 22:00:15 EDT --- (In reply to comment #10) > If you're building for el6, I believe it needs the %clean section: > https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean I don't want to build for el6, so I really wouldn't worry. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698692] Review Request: grilo-plugins - Plugins for the Grilo framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=698692 --- Comment #13 from Bastien Nocera 2011-05-21 22:01:45 EDT --- Huh, I see that the request included el6. I don't know why I copied that from the example page. I don't intend on building it for RHEL 6. Ever. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698692] Review Request: grilo-plugins - Plugins for the Grilo framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=698692 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698692] Review Request: grilo-plugins - Plugins for the Grilo framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=698692 --- Comment #14 from Fedora Update System 2011-05-21 22:24:12 EDT --- grilo-plugins-0.1.15-4.fc15,grilo-0.1.15-3.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/grilo-plugins-0.1.15-4.fc15,grilo-0.1.15-3.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698692] Review Request: grilo-plugins - Plugins for the Grilo framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=698692 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #15 from Fedora Update System 2011-05-24 22:33:20 EDT --- grilo-plugins-0.1.15-4.fc15, grilo-0.1.15-3.fc15 has been pushed to the Fedora 15 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698692] Review Request: grilo-plugins - Plugins for the Grilo framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=698692 Kalev Lember changed: What|Removed |Added Status|ON_QA |CLOSED Resolution||NEXTRELEASE Last Closed||2011-07-19 03:05:52 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
