[Bug 700350] Review Request: perl-CGI-Session-Driver-memcached - CGI::Session driver for memcached

2012-01-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=700350

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||perl-CGI-Session-Driver-mem
   ||cached-0.04-2.fc16
 Resolution||ERRATA
Last Closed||2012-01-02 16:48:27

--- Comment #10 from Fedora Update System  
2012-01-02 16:48:27 EST ---
perl-CGI-Session-Driver-memcached-0.04-2.fc16 has been pushed to the Fedora 16
stable repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 700350] Review Request: perl-CGI-Session-Driver-memcached - CGI::Session driver for memcached

2011-12-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=700350

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA

--- Comment #9 from Fedora Update System  2011-12-23 
17:23:24 EST ---
perl-CGI-Session-Driver-memcached-0.04-2.fc16 has been pushed to the Fedora 16
testing repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 700350] Review Request: perl-CGI-Session-Driver-memcached - CGI::Session driver for memcached

2011-12-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=700350

--- Comment #8 from Fedora Update System  2011-12-22 
21:21:27 EST ---
perl-CGI-Session-Driver-memcached-0.04-2.fc16 has been submitted as an update
for Fedora 16.
https://admin.fedoraproject.org/updates/perl-CGI-Session-Driver-memcached-0.04-2.fc16

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 700350] Review Request: perl-CGI-Session-Driver-memcached - CGI::Session driver for memcached

2011-12-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=700350

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 700350] Review Request: perl-CGI-Session-Driver-memcached - CGI::Session driver for memcached

2011-10-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=700350

--- Comment #7 from Jon Ciesla  2011-10-27 08:27:14 EDT ---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 700350] Review Request: perl-CGI-Session-Driver-memcached - CGI::Session driver for memcached

2011-10-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=700350

Nicholas van Oudtshoorn  changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #6 from Nicholas van Oudtshoorn  2011-10-26 
23:08:05 EDT ---
Thanks Ian!

New Package SCM Request
===
Package Name: perl-CGI-Session-Driver-memcached
Short Description: CGI::Session driver for memcached
Owners: vanoudt
Branches: f15 f16 
InitialCC: perl-sig

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 700350] Review Request: perl-CGI-Session-Driver-memcached - CGI::Session driver for memcached

2011-10-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=700350

--- Comment #5 from Iain Arnell  2011-10-26 22:59:54 EDT ---
This one is approved and ready for you too.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 700350] Review Request: perl-CGI-Session-Driver-memcached - CGI::Session driver for memcached

2011-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=700350

--- Comment #4 from Iain Arnell  2011-05-31 00:54:08 EDT ---
Another good package. You can remove the buildroot/clean/defattr stuff, but
that's not a blocker, so APPROVED.

koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3101244

Spec looks sane, clean and consistent; license is correct (GPL+ or Artistic);
make test passes cleanly.

Source tarballs match upstream (sha1sum):
0c8131fc4044f39ed3701aab8b35b5874beccf1c
CGI-Session-Driver-memcached-0.04.tar.gz
0c8131fc4044f39ed3701aab8b35b5874beccf1c
CGI-Session-Driver-memcached-0.04.tar.gz.srpm

Final provides / requires are sane:

==> perl-CGI-Session-Driver-memcached-0.04-2.fc16.noarch.rpm <==
> rpmlint
perl-CGI-Session-Driver-memcached.noarch: E: incorrect-fsf-address
/usr/share/doc/perl-CGI-Session-Driver-memcached-0.04/LICENSE
1 packages and 0 specfiles checked; 1 errors, 0 warnings.
> provides
perl(CGI::Session::Driver::memcached) = 0.04
perl-CGI-Session-Driver-memcached = 0.04-2.fc16
> requires
perl(Cache::Memcached)  
perl(Carp)  
perl(CGI::Session) >= 4
perl(CGI::Session::Driver)  
perl(:MODULE_COMPAT_5.12.3)  
perl(strict)  
> obsoletes
> conflicts

==> perl-CGI-Session-Driver-memcached-0.04-2.fc16.src.rpm <==
> rpmlint
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
> provides
> requires
memcached  
perl(Cache::Memcached)  
perl(CGI::Session) >= 4
perl(ExtUtils::MakeMaker)  
perl(Test::More)  
> obsoletes
> conflicts


> mock install
INFO: mock.py version 1.1.10 starting...
State Changed: init plugins
INFO: selinux enabled
State Changed: start
Mock Version: 1.1.10
INFO: Mock Version: 1.1.10
State Changed: lock buildroot
INFO: installing package(s):
perl-CGI-Session-Driver-memcached-0.04-2.fc16.noarch.rpm
INFO: 

 Package   Arch   Version   Repository Size

Installing:
 perl-CGI-Session-Driver-memcached noarch 0.04-2.fc16  
/perl-CGI-Session-Driver-memcached-0.04-2.fc16.noarch
   26 k
Installing for dependencies:
 libevent  x86_64 2.0.10-2.fc15 fedora157 k
 mailcap   noarch 2.1.37-1.fc15 fedora 28 k
 perl-AnyEvent noarch 5.27-4.fc16   fedora318 k
 perl-AnyEvent-AIO noarch 1.1-6.fc15fedora8.1 k
 perl-AnyEvent-BDB noarch 1.1-5.fc15fedora8.2 k
 perl-Async-MergePoint noarch 0.03-5.fc15   fedora 19 k
 perl-BDB  x86_64 1.88-3.fc15   fedora 84 k
 perl-CGI  noarch 3.51-2.fc15   fedora200 k
 perl-CGI-Session  noarch 4.35-8.fc16   fedora118 k
 perl-CPAN noarch 1.9402-160.fc16   fedora246 k
 perl-Cache-Memcached  noarch 1.29-3.fc15   fedora 27 k
 perl-Compress-Raw-Bzip2   x86_64 2.035-1.fc16  fedora 31 k
 perl-Compress-Raw-Zlibx86_64 2.035-1.fc16  fedora 58 k
 perl-Coro x86_64 5.372-3.fc16  fedora236 k
 perl-Curses   x86_64 1.28-2.fc15   fedora108 k
 perl-DBD-Pg   x86_64 2.18.0-2.fc16 fedora200 k
 perl-DBI  x86_64 1.616-3.fc16  fedora780 k
 perl-Data-Peekx86_64 0.33-1.fc16   fedora 27 k
 perl-Digest-SHA   x86_64 1:5.47-160.fc16   fedora 63 k
 perl-EV   x86_64 4.03-5.fc16   fedora260 k
 perl-Encode-Localenoarch 1.02-2.fc16   fedora 14 k
 perl-Eventx86_64 1.15-1.fc16   fedora288 k
 perl-Event-Libx86_64 1.03-14.fc15  fedora 53 k
 perl-ExtUtils-MakeMaker   noarch 6.56-160.fc16 fedora289 k
 perl-ExtUtils-ParseXS noarch 1:2.2206-160.fc16 fedora 44 k
 perl-FCGI x86_64 1:0.71-5.fc15 fedora 41 k
 perl-FreezeThaw   noarch 0.5001-4.fc15 fedora 20 k
 perl-Glib x86_64 1.223-2.fc15  fedora370 k
 perl-Guardx86_64 1.021-4.fc15  fedora 18 k
 perl-HTML-Parser  x86_64 3.68-3.fc15   fedora111 k
 perl-HTML-Tagset  noarch 3.20-7.fc15   fedora 17 k
 perl-HTTP-Datenoarch 6.00-1.fc16   fedora 12 k
 perl-HTTP-Messag

[Bug 700350] Review Request: perl-CGI-Session-Driver-memcached - CGI::Session driver for memcached

2011-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=700350

Iain Arnell  changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 700350] Review Request: perl-CGI-Session-Driver-memcached - CGI::Session driver for memcached

2011-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=700350

--- Comment #3 from Iain Arnell  2011-05-31 00:50:00 EDT ---
Koji (success) http://koji.fedoraproject.org/koji/taskinfo?taskID=3101244

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 700350] Review Request: perl-CGI-Session-Driver-memcached - CGI::Session driver for memcached

2011-05-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=700350

--- Comment #2 from Nicholas van Oudtshoorn  2011-05-30 
21:39:47 EDT ---
Hi Iain,

Thanks for that. I've already notified upstream about the FSF address - and
have now removed the patch from the package.

All your other suggested changes have also been applied. New URLs follow

Spec URL:
http://dl.dropbox.com/u/8648526/perl-CGI-Session-Driver-memcached.spec
SRPM URL:
http://dl.dropbox.com/u/8648526/perl-CGI-Session-Driver-memcached-0.04-2.fc14.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 700350] Review Request: perl-CGI-Session-Driver-memcached - CGI::Session driver for memcached

2011-05-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=700350

--- Comment #1 from Iain Arnell  2011-05-29 00:55:52 EDT ---
There are a couple of issues with this one.

Please don't patch the LICENSE file to fix the address. It's good to see that
you're running rpmlint on your packages, but the incorrect-fsf-address "error"
is not a review blocker and should be handled simply by asking upstream to
update the address.

You should remove the perl(Test::More) runtime dependency.

And, as always, I would like to see the test suite actually test something
rather than bail out because memcached isn't running. You could buildrequire
memcached and perl(Cache::Memcached), then start memcached in %check and ensure
that it is killed properly after running the tests. Something like:

%check
memcached -l 127.0.0.1 &
make test || rc=$?
kill %1
exit $rc

(And while testing this, I discovered an error in perl-CGI-Session packaging -
it needs to explicitly require perl(CGI). Fixed in rawhide, and I've submitted
updates for f14 and f15).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 700350] Review Request: perl-CGI-Session-Driver-memcached - CGI::Session driver for memcached

2011-05-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=700350

Iain Arnell  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|nob...@fedoraproject.org|iarn...@gmail.com

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 700350] Review Request: perl-CGI-Session-Driver-memcached - CGI::Session driver for memcached

2011-05-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=700350

Iain Arnell  changed:

   What|Removed |Added

   Flag||fedora-review?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 700350] Review Request: perl-CGI-Session-Driver-memcached - CGI::Session driver for memcached

2011-04-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=700350

Nicholas van Oudtshoorn  changed:

   What|Removed |Added

 Blocks||177841(FE-NEEDSPONSOR)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review