[Bug 700427] Review Request: jopt-simple - A Java command line parser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=700427 --- Comment #18 from Fedora Update System upda...@fedoraproject.org 2011-09-06 20:05:34 EDT --- jopt-simple-3.3-3.fc15 has been pushed to the Fedora 15 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 700427] Review Request: jopt-simple - A Java command line parser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=700427 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||jopt-simple-3.3-3.fc15 Resolution||ERRATA Last Closed||2011-09-06 20:05:41 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 700427] Review Request: jopt-simple - A Java command line parser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=700427 --- Comment #19 from Fedora Update System upda...@fedoraproject.org 2011-09-06 23:37:14 EDT --- jopt-simple-3.3-3.fc16 has been pushed to the Fedora 16 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 700427] Review Request: jopt-simple - A Java command line parser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=700427 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|jopt-simple-3.3-3.fc15 |jopt-simple-3.3-3.fc16 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 700427] Review Request: jopt-simple - A Java command line parser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=700427 --- Comment #11 from Karel Klíč kk...@redhat.com 2011-08-11 09:16:03 EDT --- Spec URL: http://kklic.fedorapeople.org/jopt-simple.spec SRPM URL: http://kklic.fedorapeople.org/jopt-simple-3.3-3.fc14.src.rpm * Thu Aug 11 2011 Karel Klíč kk...@redhat.com - 3.3-3 - Include the license text in the javadoc package, which is independent from the main package - Use %%add_maven_depmap instead of %%add_to_maven_depmap -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 700427] Review Request: jopt-simple - A Java command line parser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=700427 Alexander Kurtakov akurt...@redhat.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #12 from Alexander Kurtakov akurt...@redhat.com 2011-08-11 09:23:03 EDT --- Looks good. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 700427] Review Request: jopt-simple - A Java command line parser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=700427 Karel Klíč kk...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #13 from Karel Klíč kk...@redhat.com 2011-08-11 09:42:53 EDT --- Thank you for the review. New Package SCM Request === Package Name: jopt-simple Short Description: A Java command line parser Owners: kklic Branches: f15 f16 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 700427] Review Request: jopt-simple - A Java command line parser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=700427 --- Comment #14 from Jon Ciesla l...@jcomserv.net 2011-08-11 10:03:06 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 700427] Review Request: jopt-simple - A Java command line parser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=700427 --- Comment #15 from Fedora Update System upda...@fedoraproject.org 2011-08-11 11:43:33 EDT --- jopt-simple-3.3-3.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/jopt-simple-3.3-3.fc16 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 700427] Review Request: jopt-simple - A Java command line parser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=700427 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 700427] Review Request: jopt-simple - A Java command line parser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=700427 --- Comment #16 from Fedora Update System upda...@fedoraproject.org 2011-08-11 11:43:43 EDT --- jopt-simple-3.3-3.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/jopt-simple-3.3-3.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 700427] Review Request: jopt-simple - A Java command line parser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=700427 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #17 from Fedora Update System upda...@fedoraproject.org 2011-08-12 00:21:01 EDT --- Package jopt-simple-3.3-3.fc16: * should fix your issue, * was pushed to the Fedora 16 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing jopt-simple-3.3-3.fc16' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/jopt-simple-3.3-3.fc16 then log in and leave karma (feedback). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 700427] Review Request: jopt-simple - A Java command line parser
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=700427
--- Comment #10 from Alexander Kurtakov akurt...@redhat.com 2011-08-10
03:13:25 EDT ---
Package Review
==
Key:
- = N/A
x = Check
! = Problem
? = Not evaluated
=== REQUIRED ITEMS ===
[x] Rpmlint output:
./jopt-simple.spec: W: invalid-url Source0:
https://download.github.com/pholser-jopt-simple-jopt-simple-3.3-0-g59a05aa.tar.gz
HTTP Error 404: Not Found
The usual github crap.
[x] Package is named according to the Package Naming Guidelines[1].
[x] Spec file name must match the base package name, in the format
%{name}.spec.
[x] Package meets the Packaging Guidelines[2].
[x] Package successfully compiles and builds into binary rpms.
[x] Buildroot definition is not present
[x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging
Guidelines[3,4].
[x] License field in the package spec file matches the actual license.
License type: MIT
[x] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
[!] All independent sub-packages have license of their own
Javadoc is independent and misses the license
[x] Spec file is legible and written in American English.
[x] Sources used to build the package matches the upstream source, as provided
in the spec URL.
[x] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines[5].
[x] Package must own all directories that it creates.
[x] Package requires other packages for directories it uses.
[x] Package does not contain duplicates in %files.
[x] File sections do not contain %defattr(-,root,root,-) unless changed with
good reason
[x] Permissions on files are set properly.
[x] Package does NOT have a %clean section which contains rm -rf %{buildroot}
(or $RPM_BUILD_ROOT). (not needed anymore)
[x] Package consistently uses macros (no %{buildroot} and $RPM_BUILD_ROOT
mixing)
[x] Package contains code, or permissable content.
[-] Fully versioned dependency in subpackages, if present.
[-] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
[x] Package does not own files or directories owned by other packages.
[x] Javadoc documentation files are generated and included in -javadoc
subpackage
[x] Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlinks)
[x] Packages have proper BuildRequires/Requires on jpackage-utils
[x] Javadoc subpackages have Require: jpackage-utils
[x] Package uses %global not %define
[x] If package uses tarball from VCS include comment how to re-create that
tarball (svn eport URL, git clone URL, ...)
[x] If source tarball includes bundled jar/class files these need to be
removed prior to building
[x] All filenames in rpm packages must be valid UTF-8.
[x] Jar files are installed to %{_javadir}/%{name}.jar (see [6] for details)
[x] If package contains pom.xml files install it (including depmaps) even when
building with ant
[!] pom files has correct add_maven_depmap
=== Maven ===
[x] Use %{_mavenpomdir} macro for placing pom files instead of
%{_datadir}/maven2/poms
[x] If package uses -Dmaven.test.skip=true explain why it was needed in a
comment
[-] If package uses custom depmap -Dmaven.local.depmap.file=* explain why
it's needed in a comment
[x] Package DOES NOT use %update_maven_depmap in %post/%postun
[x] Packages DOES NOT have Requires(post) and Requires(postun) on
jpackage-utils for %update_maven_depmap macro
=== Other suggestions ===
[x] If possible use upstream build method (maven/ant/javac)
[x] Avoid having BuildRequires on exact NVR unless necessary
[x] Package has BuildArch: noarch (if possible)
[x] Latest version is packaged.
Problems:
1. Missing license for javadoc
2. Use the new add_maven_depmap macro
%add_to_maven_depmap net.sf.jopt-simple %{name} %{version} JPP %{name} should
become
%add_maven_depmap JPP-%{name}.pom %{name}.jar
A lot easier and readable, isn't it ?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 700427] Review Request: jopt-simple - A Java command line parser
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=700427
--- Comment #9 from Karel Klíč kk...@redhat.com 2011-07-29 15:21:04 EDT ---
Yes, I am, thanks. I have checked that this version can be built in Rawhide and
F-15.
Spec URL: http://kklic.fedorapeople.org/jopt-simple.spec
SRPM URL: http://kklic.fedorapeople.org/jopt-simple-3.3-2.fc15.src.rpm
* Fri Jul 29 2011 Karel Klíč kk...@redhat.com - 3.3-2
- Use %%{_mavenpomdir} instead of %%{_datadir}/maven2/poms
- Removed %%post(un) %%update_maven_depmap calls, not needed in F-15+
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 700427] Review Request: jopt-simple - A Java command line parser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=700427 --- Comment #8 from Alexander Kurtakov akurt...@redhat.com 2011-07-26 09:07:02 EDT --- Are you still interested in finishing this review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 700427] Review Request: jopt-simple - A Java command line parser
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=700427
Alexander Kurtakov akurt...@redhat.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
AssignedTo|nob...@fedoraproject.org|akurt...@redhat.com
Flag||fedora-review?
--- Comment #7 from Alexander Kurtakov akurt...@redhat.com 2011-07-07
14:59:36 EDT ---
I would do this one.
Initial issues:
* doesn't build - you use %{_mavenpomdir} in install but
%{_datadir}/maven2/poms in files and they are not equal anymore
* we do not need post/postun calls in F-15 and rawhide (pending FPC approval)
* no need for the Requires(post) postun because of the previous one
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 700427] Review Request: jopt-simple - A Java command line parser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=700427 --- Comment #6 from Karel Klíč kk...@redhat.com 2011-06-29 16:43:05 EDT --- Spec URL: http://kklic.fedorapeople.org/jopt-simple.spec SRPM URL: http://kklic.fedorapeople.org/jopt-simple-3.3-1.fc15.src.rpm * Wed Jun 29 2011 Karel Klíč kk...@redhat.com - 3.3-1 - Use maven3 instead of maven2 to build the package. - Updated to upstream final 3.3 release. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 700427] Review Request: jopt-simple - A Java command line parser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=700427 --- Comment #5 from Alexander Kurtakov akurt...@redhat.com 2011-06-02 15:10:42 EDT --- Still interested in review? Pending on maven 3 change. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 700427] Review Request: jopt-simple - A Java command line parser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=700427 --- Comment #4 from Karel Klíč kk...@redhat.com 2011-05-16 15:13:49 EDT --- Alexander, thanks. I'm going to modify the jopt-simple package to use maven v3 when Fedora 15 is released. I cannot develop/test/use maven v3 package on my computers running F-14, and it's too much hassle to do it in a virtual machine. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 700427] Review Request: jopt-simple - A Java command line parser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=700427 --- Comment #3 from Alexander Kurtakov akurt...@redhat.com 2011-05-12 05:29:58 EDT --- If you start using maven (v 3) I'll review it :). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 700427] Review Request: jopt-simple - A Java command line parser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=700427 Alexander Kurtakov akurt...@redhat.com changed: What|Removed |Added CC||akurt...@redhat.com --- Comment #2 from Alexander Kurtakov akurt...@redhat.com 2011-04-30 05:42:58 EDT --- New packages would be better to use maven (v 3) package instead of the old maven2 package. There is also a new script mvn-rpmbuild especially for rpm builds. See http://fedoraproject.org/wiki/Packaging/Java#maven_3 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 700427] Review Request: jopt-simple - A Java command line parser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=700427 Karel Klíč kk...@redhat.com changed: What|Removed |Added Blocks||700566 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 700427] Review Request: jopt-simple - A Java command line parser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=700427 --- Comment #1 from Karel Klíč kk...@redhat.com 2011-04-28 18:56:39 EDT --- Spec URL: http://kklic.fedorapeople.org/jopt-simple.spec SRPM URL: http://kklic.fedorapeople.org/jopt-simple-3.3-0.2.git12c0e63.fc14.src.rpm * Thu Apr 28 2011 Karel Klíč kk...@redhat.com - 3.3-0.2.git12c0e63 - Added jpackage-utils dependency to -javadoc package (needed for directory) - Better versioning -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
