[Bug 700551] Review Request: xwax - Open source vinyl emulation software for Linux
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=700551 John Brier changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 700551] Review Request: xwax - Open source vinyl emulation software for Linux
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=700551
--- Comment #2 from Adam Huffman 2011-04-30 11:08:28 EDT
---
You should also consider using macros consistently i.e. %{buildroot} instead of
$RPM_BUILD_ROOT
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 700551] Review Request: xwax - Open source vinyl emulation software for Linux
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=700551
--- Comment #1 from Adam Huffman 2011-04-30 11:07:24 EDT
---
NB: I can't sponsor you, this is just an informal review.
Have just run this through Tim Lauridsen's review tool, and it's found some
problems:
Package Review
==
Key:
- = N/A
x = Check
! = Problem
? = Not evaluated
[x] : MUST - Package successfully compiles and builds into binary rpms on at
least one supported architecture.
[x] : MUST - Package does not contain any libtool archives (.la)
[x] : MUST - Package use %makeinstall only when make install DESTDIR=...
doesn't work.
[x] : MUST - Package is named according to the Package Naming Guidelines.
[x] : MUST - Sources used to build the package matches the upstream source, as
provided in the spec URL.
MD5SUM this package : 37152a16cbeb6878818ca406959af9b2
MD5SUM upstream package : 37152a16cbeb6878818ca406959af9b2
[x] : MUST - Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[-] : MUST - %config files are marked noreplace or the reason is justified.
[-] : MUST - Package contains a properly installed %{name}.desktop using
desktop-file-install file if it is a GUI application.
[-] : MUST - Fully versioned dependency in subpackages, if present.
[-] : MUST - Header files in -devel subpackage, if present.
[-] : MUST - ldconfig called in %post and %postun if required.
[-] : MUST - License file installed when any subpackage combination is
installed.
[-] : MUST - The spec file handles locales properly.
[-] : MUST - No %config files under /usr.
[-] : MUST - Development .so files in -devel subpackage, if present.
[-] : MUST - Static libraries in -static subpackage, if present.
[!] : MUST - Spec file lacks Packager, Vendor, PreReq tags.
Found : Packager: Adam Huffman
[!] : MUST - Rpmlint output is silent.
rpmlint xwax-0.9-2.fc16.i686.rpm
xwax.i686: W: spelling-error %description -l en_US turntablists ->
turntables, turntable, establishments
xwax.i686: W: spelling-error %description -l en_US timecoded -> time
coded, time-coded, timecard
xwax.i686: W: spelling-error %description -l en_US spinbacks -> spin
backs, spin-backs, finbacks
xwax.i686: W: invalid-license GPL
1 packages and 0 specfiles checked; 0 errors, 4 warnings.
rpmlint xwax-debuginfo-0.9-2.fc16.i686.rpm
xwax-debuginfo.i686: W: invalid-license GPL
xwax-debuginfo.i686: E: debuginfo-without-sources
1 packages and 0 specfiles checked; 1 errors, 1 warnings.
rpmlint xwax-0.9-2.fc16.src.rpm
xwax.src: W: spelling-error %description -l en_US turntablists ->
turntables, turntable, establishments
xwax.src: W: spelling-error %description -l en_US timecoded -> time
coded, time-coded, timecard
xwax.src: W: spelling-error %description -l en_US spinbacks -> spin
backs, spin-backs, finbacks
xwax.src: W: invalid-license GPL
xwax.src:12: W: macro-in-comment %40redhat
1 packages and 0 specfiles checked; 0 errors, 5 warnings.
[ ] : MUST - Package is licensed with an open-source compatible license and
meets other legal requirements as defined in the legal section of Packaging
Guidelines.
[ ] : MUST - %build honors applicable compiler flags or justifies otherwise.
[ ] : MUST - All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[ ] : MUST - Package contains no bundled libraries.
[ ] : MUST - Changelog in prescribed format.
[ ] : MUST - Sources contain only permissible code or content.
[ ] : MUST - Macros in Summary, %description expandable at SRPM build time.
[ ] : MUST - Package requires other packages for directories it uses.
[ ] : MUST - Package uses nothing in %doc for runtime.
[ ] : MUST - Package is not known to require ExcludeArch.
[ ] : MUST - Permissions on files are set properly.
[ ] : MUST - Package does not contain duplicates in %files.
[ ] : MUST - Large documentation files are in a -doc subpackage, if required.
[ ] : MUST - If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[ ] : MUST - License field in the package spec file matches the actual lice
[Bug 700551] Review Request: xwax - Open source vinyl emulation software for Linux
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=700551 --- Comment #3 from John Brier 2011-05-01 20:19:50 EDT --- Spec URL: http://people.redhat.com/~jbrier/rpms/xwax.spec SRPM URL: http://people.redhat.com/~jbrier/rpms/xwax-0.9-3.fc14.src.rpm (In reply to comment #1) > NB: I can't sponsor you, this is just an informal review. Thank you very much for this! > You can ignore the spelling complaints, but you need to fix the licensing and > investigate the debuginfo problem. I believe I have fixed both issues. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 700551] Review Request: xwax - Open source vinyl emulation software for Linux
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=700551
--- Comment #4 from Adam Huffman 2011-05-02 06:14:50 EDT
---
Thanks for the new version. Some more comments:
- I assume you've added the Requires: line because of the issue mentioned
regarding decoders? Normally the automatic checker is sufficient.
- you need to use macros in the %files section e.g
%{_bindir}/xwax
%{_libexecdir}/xwax/xwax-import
and you should own the %{_libexecdir}/xwax/ directory
- you don't need the full path for those doc files
%doc CHANGES COPYING README
should be enough and you should use macros for the manpage
%doc %{_mandir}/man1/xwax.1.gz
To help persuade someone to sponsor you, it would be a good idea to submit a
couple more new packages and do some informal reviews yourself.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 700551] Review Request: xwax - Open source vinyl emulation software for Linux
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=700551
--- Comment #5 from John Brier 2011-05-18 18:29:15 EDT ---
(In reply to comment #4)
> Thanks for the new version. Some more comments:
>
> - I assume you've added the Requires: line because of the issue mentioned
> regarding decoders? Normally the automatic checker is sufficient.
Yes, the decoder is only referenced in a bash script so I don't think the
automatic checker would catch it.
> - you need to use macros in the %files section e.g
>
> %{_bindir}/xwax
> %{_libexecdir}/xwax/xwax-import
>
> and you should own the %{_libexecdir}/xwax/ directory
>
> - you don't need the full path for those doc files
>
> %doc CHANGES COPYING README
>
> should be enough and you should use macros for the manpage
>
> %doc %{_mandir}/man1/xwax.1.gz
>
>
> To help persuade someone to sponsor you, it would be a good idea to submit a
> couple more new packages and do some informal reviews yourself.
I will look into all of the above. Thanks again.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
