[Bug 700818] Review Request: libircclient - Library implementing client-server IRC protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=700818 Jussi Lehtola changed: What|Removed |Added CC||jussi.leht...@iki.fi --- Comment #4 from Jussi Lehtola 2012-01-04 16:12:54 EST --- It is rather odd that the package uses autotools in some way, but doesn't really use them for the compilation or for the generation of the libraries... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 700818] Review Request: libircclient - Library implementing client-server IRC protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=700818 Jussi Lehtola changed: What|Removed |Added Alias||libircclient -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 700818] Review Request: libircclient - Library implementing client-server IRC protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=700818 Jussi Lehtola changed: What|Removed |Added Blocks||771885 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 700818] Review Request: libircclient - Library implementing client-server IRC protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=700818 --- Comment #5 from Adam Huffman 2012-01-08 07:18:25 EST --- Yes, I ended up ignoring the upstream makefiles. However, it still needs config.h, which is why I still run configure. New version at: http://verdurin.fedorapeople.org/reviews/libircclient/libircclient.spec http://verdurin.fedorapeople.org/reviews/libircclient/libircclient-1.3-7.fc16.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 700818] Review Request: libircclient - Library implementing client-server IRC protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=700818 --- Comment #6 from Jussi Lehtola 2012-01-08 07:34:49 EST --- The warnings dcc.c: In function 'libirc_dcc_process_descriptors': dcc.c:333:8: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] dcc.c:369:31: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] should be fixed before the package is approved. This kind of pointer handling can cause crashes. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 700818] Review Request: libircclient - Library implementing client-server IRC protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=700818 --- Comment #7 from Adam Huffman 2012-01-08 12:31:52 EST --- I've contacted upstream about these warnings. If there's no response then I'll fix them myself. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 700818] Review Request: libircclient - Library implementing client-server IRC protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=700818 --- Comment #8 from Adam Huffman 2012-01-11 17:30:31 EST --- The warnings are fixed now. New version at: http://verdurin.fedorapeople.org/reviews/libircclient/libircclient.spec http://verdurin.fedorapeople.org/reviews/libircclient/libircclient-1.3-8.fc16.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 700818] Review Request: libircclient - Library implementing client-server IRC protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=700818 --- Comment #9 from Jussi Lehtola 2012-01-19 16:03:02 EST --- Looks like version 1.5 was released yesterday. http://www.ulduzsoft.com/libircclient/ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 700818] Review Request: libircclient - Library implementing client-server IRC protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=700818 --- Comment #10 from Adam Huffman 2012-01-19 17:15:57 EST --- Hmm, nothing new in the ChangeLog. Will take a look tomorrow. Thanks for letting me know. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 700818] Review Request: libircclient - Library implementing client-server IRC protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=700818 --- Comment #11 from Adam Huffman 2012-01-20 08:30:35 EST --- Update to new upstream release 1.5 at: http://verdurin.fedorapeople.org/reviews/libircclient/libircclient.spec http://verdurin.fedorapeople.org/reviews/libircclient/libircclient-1.5-1.fc16.src.rpm The patches to fix those warnings don't seem to be necessary any more so I've disabled them. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 700818] Review Request: libircclient - Library implementing client-server IRC protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=700818 Adam Huffman changed: What|Removed |Added Blocks||700814 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 700818] Review Request: libircclient - Library implementing client-server IRC protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=700818 --- Comment #1 from Adam Huffman 2011-04-29 09:42:52 EDT --- This is based on the work of Conrad Meyer at: http://konradm.fedorapeople.org/fedora/SPECS/libircclient.spec There is a problem with debuginfo generation which I haven't yet been able to fix. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 700818] Review Request: libircclient - Library implementing client-server IRC protocol
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=700818
--- Comment #2 from Michael Schwendt 2011-05-02 06:16:44
EDT ---
Not a full review:
> gcc -shared -Wl,-soname,libircclient.so.1 libircclient.o -o libircclient.so
You've got it backwards. With a soname of libirrclient.so.1, the file name
ought to be libircclient.so.1 with the *.so symlink pointing to it.
> %files
> ...
> %{_libdir}/libircclient.so*
Here a dot is missing. It must be
%{_libdir}/libircclient.so.*
so you can include the *.so symlink in the -devel package where it belongs.
> There is a problem with debuginfo generation which I haven't yet been able
> to fix.
The problem is the "-s" that strips the library:
install -s -m 0755 libircclient.so %{buildroot}%{_libdir}/
http://fedoraproject.org/wiki/Packaging/Debuginfo
> /usr/share/doc/libircclient-1.3/examples/
Looks like the wrong subpackage for these examples. The included Makefile* for
these examples are not usable, btw.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 700818] Review Request: libircclient - Library implementing client-server IRC protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=700818 --- Comment #3 from Adam Huffman 2011-05-02 07:00:24 EDT --- Thanks for taking a look and clearing up my confusion regarding sonames. I think that was part of the debuginfo problem, too - I'd added the '-s' flag in desperation as nothing else I'd tried had fixed it. The documentation for this on the wiki isn't particularly clear, I found. New version at: http://verdurin.fedorapeople.org/reviews/libircclient/libircclient.spec http://verdurin.fedorapeople.org/reviews/libircclient/libircclient-1.3-6.fc14.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
