[Bug 701801] Review Request: ast - A Library for Handling World Coordinate Systems in Astronomy
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=701801 Orion Poplawski changed: What|Removed |Added Flag||needinfo?(sergio.pasra@gmai ||l.com) --- Comment #3 from Orion Poplawski 2011-11-22 15:58:21 EST --- Sergio - Are you still up for doing this review, or should I put it back in the queue? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 701801] Review Request: ast - A Library for Handling World Coordinate Systems in Astronomy
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=701801 Sergio Pascual changed: What|Removed |Added Flag|needinfo?(sergio.pasra@gmai | |l.com) | --- Comment #4 from Sergio Pascual 2011-11-24 07:15:44 EST --- I would like to do the review this weekend... I've been very busy these months -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 701801] Review Request: ast - A Library for Handling World Coordinate Systems in Astronomy
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=701801 --- Comment #5 from Sergio Pascual 2011-11-28 05:02:23 EST --- These are blockers, after fixing them the package should be ok. License --- * There are some files proj.c proj.h wcsmath.h wcstrig.c wcstrig.h (from an old version of wcslib) under LGPLv2+. So the license tag should be: GPLv2+ and LGPLv2+ * The FSF address is wrong. You should report it upstream Libraries - * In the installed package there are some pgplot related libraries. As pgplot is not free and can't be distributed by Fedora, I suggest to remove the libraries /usr/lib64/libast_pgplot3d.so /usr/lib64/libast_pgplot3d.so.0 /usr/lib64/libast_pgplot3d.so.0.0.0 /usr/lib64/libast_pgplot.so /usr/lib64/libast_pgplot.so.0 /usr/lib64/libast_pgplot.so.0.0.0 Documentation - * rpmlint complains about hidden directories and empty files. They should be removed. ast-doc.x86_64: W: hidden-file-or-dir /usr/share/doc/ast/sun210.htx/.star2html-init ast-doc.x86_64: E: zero-length /usr/share/doc/ast/sun210.htx/star2html.sty ast-doc.x86_64: E: zero-length /usr/share/doc/ast/sun211.htx/star2html.sty ast-doc.x86_64: W: hidden-file-or-dir /usr/share/doc/ast/sun211.htx/.star2html-init * Tex files are included. They should be removed unless they are needed for something. * In the spec, you create a /usr/share/doc/ast directory and move there the documentation installed. But the name of the directory is incorrect. Everything in docdir is named "package-version", in this case ast-doc-5.7.2 I would let rpm do its job and grab the docs from the source dir %files doc %doc sun210.htx sun210.ps sun211.htx sun211.ps Other recommendations, not blockers * The following macros are not needed anymore, so you can remove them safely from the specfile: BuildRoot, %clean and %defattr * If you are willing and have time, you can try to educate upstream about: - its weird versioning scheme - linking to wcstools instead of pasting wcstools files in the code - using pkgconfig instead of home-made solutions - creating pgplot libraries only if pgplot is present -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 701801] Review Request: ast - A Library for Handling World Coordinate Systems in Astronomy
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=701801 --- Comment #6 from Orion Poplawski 2011-11-28 18:20:28 EST --- http://www.cora.nwra.com/~orion/fedora/ast.spec http://www.cora.nwra.com/~orion/fedora/ast-6.0.1-1.fc16.src.rpm * Mon Nov 28 2011 Orion Poplawski 6.0.1-1 - Update to 6.0-1 - Fixup some lib linkages - Fix license tag - Fix FSF license - Fixup doc install - Drop BuildRoot, clean, defattr I've sent an email upstream about the various issues. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 701801] Review Request: ast - A Library for Handling World Coordinate Systems in Astronomy
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=701801
Sergio Pascual changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #7 from Sergio Pascual 2011-12-03 11:19:51
EST ---
Rpmlint output:
ast.src:12: W: macro-in-comment %{srcver}
ast.src: W: invalid-url Source0: ast-6.0-1.tar.gz
ast-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/ast-6.0-1/loader.h
ast-devel.x86_64: W: spelling-error %description -l en_US prog -> prig, prof,
pro
ast-devel.x86_64: W: no-documentation
ast-devel.x86_64: W: no-manual-page-for-binary ast_link
Package and spec are named according the guidelines
License is GPLv2+ and LGPLv2+
Specfile legible
Source matches upstream, source follows the convention for Troublesome URLs
(see http://fedoraproject.org/wiki/Packaging/SourceURL)
Package builds, No ExcludeArch needed
BuildRequires listed
ldconfig called properly
No bundled libraries (the files from wcslib have been modified by ast
developers, so I don't consider it to be the same library.)
Owns directories it creates
Macros are consistent
Large docs are in -doc subpackage
Headers and .so are in -devel subpackage
-devel requires base package
No .la files
BuildRoot is not needed
%clean is not needed
Package is APPROVED
By the way, you are not required to fix the incorrect FSF address. But if you
do, please fix also loader.h before uploading
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 701801] Review Request: ast - A Library for Handling World Coordinate Systems in Astronomy
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=701801 Orion Poplawski changed: What|Removed |Added Flag||fedora-cvs? --- Comment #8 from Orion Poplawski 2011-12-05 16:11:24 EST --- Thanks for the review. New Package SCM Request === Package Name: ast Short Description: A Library for Handling World Coordinate Systems in Astronomy Owners: orion Branches: f15 f16 el6 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 701801] Review Request: ast - A Library for Handling World Coordinate Systems in Astronomy
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=701801 --- Comment #9 from Jon Ciesla 2011-12-05 16:19:05 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 701801] Review Request: ast - A Library for Handling World Coordinate Systems in Astronomy
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=701801 Orion Poplawski changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE Last Closed||2011-12-05 16:47:31 --- Comment #10 from Orion Poplawski 2011-12-05 16:47:31 EST --- Checked in and built. Thanks Jon. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 701801] Review Request: ast - A Library for Handling World Coordinate Systems in Astronomy
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=701801 Sergio Pascual changed: What|Removed |Added CC||sergio.pa...@gmail.com AssignedTo|nob...@fedoraproject.org|sergio.pa...@gmail.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 701801] Review Request: ast - A Library for Handling World Coordinate Systems in Astronomy
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=701801 --- Comment #1 from Sergio Pascual 2011-05-11 18:19:13 EDT --- Hi, some comments: * The description is too long. I haven't found a guideline about this but IMHO with less than 10 lines is enough. Consider that $ rpm -qi ast outputs almost two screens full of text, hiding the rpm information. * The upstream version of the package is 5.6-0. What do you thonk of translating this to 5.6.0-1 instead of 5.6-1? If upstream releases 5.6-3 you will have to edit the Source macro to get the correct source. (Weird versioning, by the way) * Source should contain a full URL * Everything inside /usr/share/ast is documentation and is not needed to work with the libraries. As such, I think the contents should go to %docs * Furthermore, the docs are about 40 M in size. Removing the .tex files reduces the size to around 25 M. These files are good candidates to go to a ast-doc package. If you don't want to make a separate doc package, the library documentation should be in -devel subpackage. When I have more time, I will see if the Makefile can be patched to "remove the unresolved symbol" warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 701801] Review Request: ast - A Library for Handling World Coordinate Systems in Astronomy
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=701801 Orion Poplawski changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #2 from Orion Poplawski 2011-10-14 14:04:34 EDT --- * Fri Oct 14 2011 Orion Poplawski 5.7.2-1 - Update to 5.7-2 - Truncate description - Move documentation to subpackage I'm not sure how to get a usable URL. I put it in as a comment in the spec. http://www.cora.nwra.com/~orion/fedora/ast.spec http://www.cora.nwra.com/~orion/fedora/ast-5.7.2-1.fc15.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
