[Bug 701982] Review Request: osm-gps-map - A Gtk+ widget for displaying OpenStreetMap tiles

2011-05-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=701982

--- Comment #11 from Fedora Update System upda...@fedoraproject.org 
2011-05-24 22:36:12 EDT ---
osm-gps-map-0.7.3-3.fc14 has been pushed to the Fedora 14 stable repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 701982] Review Request: osm-gps-map - A Gtk+ widget for displaying OpenStreetMap tiles

2011-05-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=701982

--- Comment #12 from Fedora Update System upda...@fedoraproject.org 
2011-05-24 22:38:13 EDT ---
osm-gps-map-0.7.3-3.fc13 has been pushed to the Fedora 13 stable repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 701982] Review Request: osm-gps-map - A Gtk+ widget for displaying OpenStreetMap tiles

2011-05-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=701982

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

   Fixed In Version|osm-gps-map-0.7.3-3.fc15|osm-gps-map-0.7.3-3.fc14

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 701982] Review Request: osm-gps-map - A Gtk+ widget for displaying OpenStreetMap tiles

2011-05-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=701982

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

   Fixed In Version|osm-gps-map-0.7.3-3.fc14|osm-gps-map-0.7.3-3.fc13

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 701982] Review Request: osm-gps-map - A Gtk+ widget for displaying OpenStreetMap tiles

2011-05-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=701982

--- Comment #10 from Fedora Update System upda...@fedoraproject.org 
2011-05-19 00:49:54 EDT ---
osm-gps-map-0.7.3-3.fc15 has been pushed to the Fedora 15 stable repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 701982] Review Request: osm-gps-map - A Gtk+ widget for displaying OpenStreetMap tiles

2011-05-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=701982

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||osm-gps-map-0.7.3-3.fc15
 Resolution||ERRATA
Last Closed||2011-05-19 00:50:00

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 701982] Review Request: osm-gps-map - A Gtk+ widget for displaying OpenStreetMap tiles

2011-05-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=701982

--- Comment #5 from Jason Tibbitts ti...@math.uh.edu 2011-05-10 12:04:40 EDT 
---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 701982] Review Request: osm-gps-map - A Gtk+ widget for displaying OpenStreetMap tiles

2011-05-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=701982

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 701982] Review Request: osm-gps-map - A Gtk+ widget for displaying OpenStreetMap tiles

2011-05-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=701982

--- Comment #6 from Fedora Update System upda...@fedoraproject.org 2011-05-10 
13:17:31 EDT ---
osm-gps-map-0.7.3-3.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/osm-gps-map-0.7.3-3.fc15

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 701982] Review Request: osm-gps-map - A Gtk+ widget for displaying OpenStreetMap tiles

2011-05-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=701982

--- Comment #7 from Fedora Update System upda...@fedoraproject.org 2011-05-10 
13:20:01 EDT ---
osm-gps-map-0.7.3-3.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/osm-gps-map-0.7.3-3.fc14

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 701982] Review Request: osm-gps-map - A Gtk+ widget for displaying OpenStreetMap tiles

2011-05-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=701982

--- Comment #8 from Fedora Update System upda...@fedoraproject.org 2011-05-10 
13:21:12 EDT ---
osm-gps-map-0.7.3-3.fc13 has been submitted as an update for Fedora 13.
https://admin.fedoraproject.org/updates/osm-gps-map-0.7.3-3.fc13

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 701982] Review Request: osm-gps-map - A Gtk+ widget for displaying OpenStreetMap tiles

2011-05-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=701982

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA

--- Comment #9 from Fedora Update System upda...@fedoraproject.org 2011-05-11 
01:49:48 EDT ---
osm-gps-map-0.7.3-3.fc15 has been pushed to the Fedora 15 testing repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 701982] Review Request: osm-gps-map - A Gtk+ widget for displaying OpenStreetMap tiles

2011-05-08 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=701982

Michael Schwendt mschwe...@gmail.com changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+

--- Comment #3 from Michael Schwendt mschwe...@gmail.com 2011-05-08 14:19:10 
EDT ---
The added BuildRequires cairo-gobject-devel isn't needed, is it?

Other than that, the rpmdev-diff output looks fine.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 701982] Review Request: osm-gps-map - A Gtk+ widget for displaying OpenStreetMap tiles

2011-05-08 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=701982

Jeffrey C. Ollie j...@ocjtech.us changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #4 from Jeffrey C. Ollie j...@ocjtech.us 2011-05-08 22:25:03 EDT 
---
Michael, thanks for the review.  Yes, the cairo-gobject-devel is not necessary,
I added that when I was testing the gobject introspection but forgot to take it
back out.  I'll fix that when I import the package.

New Package SCM Request
===
Package Name: osm-gps-map
Short Description: Gtk+ widget for displaying OpenStreetMap tiles
Owners: jcollie
Branches: devel f15 f14 f13
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 701982] Review Request: osm-gps-map - A Gtk+ widget for displaying OpenStreetMap tiles

2011-05-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=701982

Michael Schwendt mschwe...@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||mschwe...@gmail.com
 AssignedTo|nob...@fedoraproject.org|mschwe...@gmail.com
   Flag||fedora-review?

--- Comment #1 from Michael Schwendt mschwe...@gmail.com 2011-05-06 16:30:03 
EDT ---
 License:GPLv3

The included file COPYING is GPLv2. The source files include GPLv2 headers.
Upstream web page says GPLv3, so please ask them to clarify.


 Name:   osm-gps-map
 Group:  Development/Libraries

The group for library base packages typically is System
Environment/Libraries.


 Summary:A Gtk+ widget for displaying OpenStreetMap tiles

I still think we should get rid of even more A, An, The articles at the
beginning of these summaries. It makes a better reading during installation and
in package installer tools.

Your summary for the -devel package also doesn't start with The. ;)


 %description
 A Gtk+ widget (and Python bindings) ...

The Python bindings are not included in this package, but in a separate one.


 %doc AUTHORS COPYING README

What about file NEWS?


 %files devel
 %doc COPYING

It is not necessary to duplicate that file in the subpackage.
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Subpackage_Licensing


 make %{?_smp_mflags}

Consider using

  make V=1 %{?_smp_mflags}

so the build output is less silent and e.g. shows full compiler flags.


 osm-gps-map v0.7.3
 Prefix... : /usr
 libsoup.. : 2.4
 Introspection support : no
 gtk-doc documentation : no

$ grep -i introspec build.log 
checking for gobject-introspection... no
Introspection support : no

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 701982] Review Request: osm-gps-map - A Gtk+ widget for displaying OpenStreetMap tiles

2011-05-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=701982

--- Comment #2 from Jeffrey C. Ollie j...@ocjtech.us 2011-05-07 00:18:04 EDT 
---
Michael, I've addressed your comments.  For now, if the source says GPLv2
that's what I'll go with.  I'll work with upstream to clarify in the future.  I
also explicitly disabled gobject introspection because it doesn't compile
correctly on F15 and from what I can tell isn't that interesting on F14.

Here's a new scratch build:

http://koji.fedoraproject.org/koji/taskinfo?taskID=3055990

and a link to the new SRPM:

http://jcollie.fedorapeople.org/osm-gps-map-0.7.3-2.fc15.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 701982] Review Request: osm-gps-map - A Gtk+ widget for displaying OpenStreetMap tiles

2011-05-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=701982

Jeffrey C. Ollie j...@ocjtech.us changed:

   What|Removed |Added

 Blocks||702103

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review