[Bug 703248] Review Request: rubygem-foreigner - Foreign keys for Rails
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=703248 --- Comment #6 from Jason Tibbitts ti...@math.uh.edu 2011-05-12 12:41:06 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 703248] Review Request: rubygem-foreigner - Foreign keys for Rails
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=703248 Darryl L. Pierce dpie...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE Last Closed||2011-05-12 14:49:45 --- Comment #7 from Darryl L. Pierce dpie...@redhat.com 2011-05-12 14:49:45 EDT --- (In reply to comment #6) Git done (by process-git-requests). Thanks, Jason. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 703248] Review Request: rubygem-foreigner - Foreign keys for Rails
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=703248
--- Comment #4 from Darryl L. Pierce dpie...@redhat.com 2011-05-11 07:27:20
EDT ---
(In reply to comment #3)
Thanks for quick update. Now it looks fine. APPROVED.
My pleasure, and thank you for reviewing the package so quickly. :)
Minor suggestion related to 3 is that now README.rdoc is not marked as %doc.
Perhaps you might want to do something like the following in %files, if you
don't think it's too much :)
%dir %{geminstdir}
%{geminstdir}/lib
%doc %{geminstdir}/MIT-LICENSE
%doc %{geminstdir}/README.rdoc
%{geminstdir}/Rakefile
%{geminstdir}/test
Not too much at all. I won't claim to be an expert at packaging, so appreciate
the tip I've added those changes as part of the first official release. :)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 703248] Review Request: rubygem-foreigner - Foreign keys for Rails
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=703248 Darryl L. Pierce dpie...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #5 from Darryl L. Pierce dpie...@redhat.com 2011-05-11 07:31:08 EDT --- New Package SCM Request === Package Name: rubygem-foreigner Short Description: Adds helpers to migrations and correctly dumps foreign keys to schema.rb. Owners: mcpierce Branches: f14 f15 InitialCC: mcpierce -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 703248] Review Request: rubygem-foreigner - Foreign keys for Rails
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=703248
Daiki Ueno du...@redhat.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||du...@redhat.com
AssignedTo|nob...@fedoraproject.org|du...@redhat.com
Flag||fedora-review?
--- Comment #1 from Daiki Ueno du...@redhat.com 2011-05-10 02:44:42 EDT ---
I'm taking the review. You could check:
http://lukas.zapletalovi.com/2011/01/how-to-prepare-gemfile-package-for.html
if you use rubygem-gem2rpm in F-14.
1. Use %global instead of %define
2. Add Requires: ruby(abi) = 1.8 as described in the Ruby packaging guideline
https://fedoraproject.org/wiki/Packaging:Ruby#Ruby_Packaging_Guidelines
3. I get File listed twice warning when building
warning: File listed twice:
/usr/lib/ruby/gems/1.8/gems/foreigner-0.9.2/README.rdoc
This is because of the following lines in %files:
%{gemdir}/gems/%{gemname}-%{version}/
%doc %{geminstdir}/README.rdoc
where %{geminstdir} == %{gemdir}/gems/%{gemname}-%{version}/. You could work
around this by listing files/dirs under %{geminstdir} individually.
4. You can drop preparing/cleaning buildroot
5. License is MIT (not GPLv2+ and Ruby)
6. It is recommended to run test suite in %check
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 703248] Review Request: rubygem-foreigner - Foreign keys for Rails
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=703248
--- Comment #2 from Darryl L. Pierce dpie...@redhat.com 2011-05-10 08:35:00
EDT ---
(In reply to comment #1)
I'm taking the review. You could check:
http://lukas.zapletalovi.com/2011/01/how-to-prepare-gemfile-package-for.html
if you use rubygem-gem2rpm in F-14.
Following the steps about removing the build and prep sections results in
additional warnings from rpmlint, so I'm leaving them in for now. Otherwise,
I've followed the suggestions. Thanks. :)
1. Use %global instead of %define
Done
2. Add Requires: ruby(abi) = 1.8 as described in the Ruby packaging
guideline
https://fedoraproject.org/wiki/Packaging:Ruby#Ruby_Packaging_Guidelines
Done.
3. I get File listed twice warning when building
warning: File listed twice:
/usr/lib/ruby/gems/1.8/gems/foreigner-0.9.2/README.rdoc
This is because of the following lines in %files:
%{gemdir}/gems/%{gemname}-%{version}/
%doc %{geminstdir}/README.rdoc
where %{geminstdir} == %{gemdir}/gems/%{gemname}-%{version}/. You could work
around this by listing files/dirs under %{geminstdir} individually.
Fixed.
4. You can drop preparing/cleaning buildroot
Done.
5. License is MIT (not GPLv2+ and Ruby)
Corrected.
6. It is recommended to run test suite in %check
I'm working with the upstream to fix his tests, which are currently not working
correctly.
Updated SPEC: http://mcpierce.fedorapeople.org/rpms/rubygem-foreigner.spec
Updated SRPM:
http://mcpierce.fedorapeople.org/rpms/rubygem-foreigner-0.9.2-2.fc14.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 703248] Review Request: rubygem-foreigner - Foreign keys for Rails
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=703248
Daiki Ueno du...@redhat.com changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #3 from Daiki Ueno du...@redhat.com 2011-05-10 21:39:55 EDT ---
Thanks for quick update. Now it looks fine. APPROVED.
Minor suggestion related to 3 is that now README.rdoc is not marked as %doc.
Perhaps you might want to do something like the following in %files, if you
don't think it's too much :)
%dir %{geminstdir}
%{geminstdir}/lib
%doc %{geminstdir}/MIT-LICENSE
%doc %{geminstdir}/README.rdoc
%{geminstdir}/Rakefile
%{geminstdir}/test
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
