[Bug 703721] Review Request: sound-theme-acoustic - Sound theme made on an acoustic guitar
https://bugzilla.redhat.com/show_bug.cgi?id=703721 Mattia Verga changed: What|Removed |Added Status|ASSIGNED|CLOSED CC||mattia.ve...@protonmail.com Resolution|--- |ERRATA Last Closed||2020-05-27 16:44:05 --- Comment #8 from Mattia Verga --- This package was approved and imported in repositories, but this review ticket was never closed. I'm closing it now. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 703721] Review Request: sound-theme-acoustic - Sound theme made on an acoustic guitar
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=703721 AnujMore changed: What|Removed |Added Summary|Review Request: |Review Request: |sound-theme-acoustic - A|sound-theme-acoustic - |contribution to Fedora |Sound theme made on an |Sounds project. |acoustic guitar -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 703721] Review Request: sound-theme-acoustic - Sound theme made on an acoustic guitar
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=703721 Elad Alfassa changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 703721] Review Request: sound-theme-acoustic - Sound theme made on an acoustic guitar
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=703721 AnujMore changed: What|Removed |Added Summary|[FE-NEEDSPONSOR] Review |Review Request: |Request:|sound-theme-acoustic - |sound-theme-acoustic - |Sound theme made on an |Sound theme made on an |acoustic guitar |acoustic guitar | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 703721] Review Request: sound-theme-acoustic - Sound theme made on an acoustic guitar
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=703721 Elad Alfassa changed: What|Removed |Added Status|NEW |ASSIGNED Blocks|177841(FE-NEEDSPONSOR) | AssignedTo|nob...@fedoraproject.org|el...@doom.co.il --- Comment #1 from Elad Alfassa 2011-10-22 07:20:17 EDT --- Since you don't need a sponsor anymore, I can do the review. :) -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 703721] Review Request: sound-theme-acoustic - Sound theme made on an acoustic guitar
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=703721 Elad Alfassa changed: What|Removed |Added Flag||fedora-review+ --- Comment #2 from Elad Alfassa 2011-10-22 07:26:03 EDT --- + Package meets naming and packaging guidelines + Spec file matches base package name. + Spec has consistent macro usage. + Meets Packaging Guidelines. + License + License field in spec matches + License file included in package + Spec in American English + Spec is legible. - Package needs ExcludeArch - BuildRequires correct - Spec handles locales/find_lang - Package is relocatable and has a reason to be. + Package has %defattr and permissions on files is good. - Package has a correct %clean section. - Package has correct buildroot %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) + Package is code or permissible content. - Doc subpackage needed/used. - Packages %doc files don't affect runtime. - Headers/static libs in -devel subpackage. - Spec has needed ldconfig in post and postun - .pc files in -devel subpackage/requires pkgconfig - .so files in -devel subpackage. - -devel package Requires: %{name} = %{version}-%{release} - .la files are removed. - Package is a GUI app and has a .desktop file + Package compiles and builds on at least one arch. + Package has no duplicate files in %files. - Package doesn't own any directories other packages own. + Package owns all the directories it creates. + No rpmlint output. + final provides and requires are sane: SHOULD Items: - Should build in mock. - Should build on all supported archs + Should function as described. - Should have sane scriptlets. - Should have subpackages require base package with fully versioned depend. + Should have dist tag - Should package latest version - check for outstanding bugs on package. (For core merge reviews) Seems fine, package is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 703721] Review Request: sound-theme-acoustic - Sound theme made on an acoustic guitar
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=703721 AnujMore changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 703721] Review Request: sound-theme-acoustic - Sound theme made on an acoustic guitar
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=703721 --- Comment #3 from AnujMore 2011-10-22 07:38:10 EDT --- New Package SCM Request === Package Name: sound-theme-acoustic Short Description: Sound theme made on an acoustic guitar Owners: AnujMore Branches: f14 f15 f16 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 703721] Review Request: sound-theme-acoustic - Sound theme made on an acoustic guitar
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=703721 --- Comment #4 from Jon Ciesla 2011-10-23 19:30:53 EDT --- AnjuMore is not a falid FAS account name. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 703721] Review Request: sound-theme-acoustic - Sound theme made on an acoustic guitar
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=703721 Elad Alfassa changed: What|Removed |Added Flag||needinfo?(anujmorex@gmail.c ||om) --- Comment #5 from Elad Alfassa 2011-10-24 01:52:01 EDT --- he has a typo there, his FAS name is anujmore elad661: User: anujmore, Name: Anuj More, email: anujmo...@gmail.com, Creation: 2010-01-23, IRC Nick: execat, Timezone: Asia/Kolkata, Locale: en, Extension: 5143354, GPG key ID: , Status: active elad661: Unapproved Groups: marketing magazine elad661: Approved Groups: fedorabugs packager gitmuffin cla_fedora cla_done ambassadors cla_fpca Anuj, please fix your SCM request. -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 703721] Review Request: sound-theme-acoustic - Sound theme made on an acoustic guitar
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=703721 AnujMore changed: What|Removed |Added Flag|needinfo?(anujmorex@gmail.c | |om) | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 703721] Review Request: sound-theme-acoustic - Sound theme made on an acoustic guitar
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=703721 --- Comment #6 from AnujMore 2011-11-07 06:34:34 EST --- New Package SCM Request === Package Name: sound-theme-acoustic Short Description: Sound theme made on an acoustic guitar Owners: anujmore Branches: f14 f15 f16 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 703721] Review Request: sound-theme-acoustic - Sound theme made on an acoustic guitar
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=703721 AnujMore changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 703721] Review Request: sound-theme-acoustic - Sound theme made on an acoustic guitar
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=703721 --- Comment #7 from Jon Ciesla 2011-11-07 08:25:27 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review