[Bug 705587] Review Request: android-tools - Android platform tools (adb, fastboot, etc)
https://bugzilla.redhat.com/show_bug.cgi?id=705587 Adam Miller changed: What|Removed |Added CC||admil...@redhat.com Flags|fedora-cvs+ |fedora-cvs? --- Comment #33 from Adam Miller --- Package Change Request == Package Name: android-tools New Branches: el6 Owners: maxamillion I would like to maintain this package for EPEL EL6, I have contacted Ivan (package owner for Fedora) and he said he doesn't have any RHEL/EL machines but wouldn't mind if I maintained. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 705587] Review Request: android-tools - Android platform tools (adb, fastboot, etc)
https://bugzilla.redhat.com/show_bug.cgi?id=705587 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 705587] Review Request: android-tools - Android platform tools (adb, fastboot, etc)
https://bugzilla.redhat.com/show_bug.cgi?id=705587 --- Comment #34 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 705587] Review Request: android-tools - Android platform tools (adb, fastboot, etc)
https://bugzilla.redhat.com/show_bug.cgi?id=705587 Adam Miller changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #35 from Adam Miller --- Package Change Request == Package Name: android-tools New Branches: epel7 Owners: maxamillion -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 705587] Review Request: android-tools - Android platform tools (adb, fastboot, etc)
https://bugzilla.redhat.com/show_bug.cgi?id=705587 --- Comment #36 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 705587] Review Request: android-tools - Android platform tools (adb, fastboot, etc)
https://bugzilla.redhat.com/show_bug.cgi?id=705587 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 705587] Review Request: android-tools - Android platform tools (adb, fastboot, etc)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=705587 --- Comment #13 from Ivan Afonichev 2011-11-15 15:30:08 EST --- Spec URL: https://github.com/vanaf/android-tools-fedora/blob/master/android-tools.spec SRPM URL: http://baldr.sgu.ru/rpm/android-tools-2015.4a25390-1.fc16.src.rpm - Change upstream git repo URL - Update to upstream git commit 4a25390 - Added more udev devices -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 705587] Review Request: android-tools - Android platform tools (adb, fastboot, etc)
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=705587
--- Comment #14 from Thomas Spura 2011-11-15
17:29:14 EST ---
- As you are adding your own Makefiles anyway, could you use "install -p" there
to preserve timestamps?:
https://fedoraproject.org/wiki/Packaging:Guidelines#Timestamps
- version is slightly wrong:
https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Non-Numeric_Version_in_Release
Please use, e.g. %{date}git%{git_commit}
(Out of curiosity, why do you use $git_commit and not a tagged release?)
- License issues:
You need to add a comment, which file has what license, for an example see:
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Multiple_Licensing_Scenarios
(It would make reviewing a lot easier, when you delete not needed directories
either in %prep or when generating the source...)
- $ rpmlint ~/rpmbuild/SRPMS/android-tools-2015.4a25390-1.fc16.src.rpm
~/rpmbuild/RPMS/x86_64/android-tools-*2015.4a25390*
android-tools.src: W: spelling-error Summary(en_US) adb -> dab, adv, ad
android-tools.src: W: spelling-error Summary(en_US) fastboot -> fast boot,
fast-boot, fastball
android-tools.src: W: spelling-error %description -l en_US adb -> dab, adv, ad
android-tools.src: W: spelling-error %description -l en_US Fastboot -> Fast
boot, Fast-boot, Fastball
android-tools.src: W: spelling-error %description -l en_US filesystem -> file
system, file-system, systemically
android-tools.src: W: spelling-error %description -l en_US fastboot -> fast
boot, fast-boot, fastball
android-tools.src:15: W: macro-in-comment %{packdname}
android-tools.src:15: W: macro-in-comment %{git_commit}
android-tools.src:15: W: macro-in-comment %{packdname}
android-tools.src: W: invalid-url Source0: core-4a25390.tar.xz
android-tools.x86_64: W: spelling-error %description -l en_US Fastboot -> Fast
boot, Fast-boot, Fastball
android-tools.x86_64: W: spelling-error %description -l en_US filesystem ->
file system, file-system, systemically
android-tools.x86_64: W: non-conffile-in-etc /etc/udev/rules.d/51-android.rules
android-tools.x86_64: W: no-manual-page-for-binary adb
android-tools.x86_64: W: no-manual-page-for-binary fastboot
3 packages and 0 specfiles checked; 0 errors, 15 warnings.
- macro-in-comment: Please use two %%, so the warning is gone (you can't use
the macros anyway)
RFC:
- non-conffile-in-etc: I don't consider udev rules as conf file...
Anyone else here?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 705587] Review Request: android-tools - Android platform tools (adb, fastboot, etc)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=705587 --- Comment #15 from nucleo 2011-11-15 17:41:08 EST --- (In reply to comment #14) > RFC: > - non-conffile-in-etc: I don't consider udev rules as conf file... > Anyone else here? Looks like this should be fixed. Right place for rules is /lib/udev/rules.d/. See bug 748205 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 705587] Review Request: android-tools - Android platform tools (adb, fastboot, etc)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=705587 --- Comment #16 from nucleo 2011-11-17 17:39:44 EST --- "(adb, fastboot, etc)" should not be in Summary (The summary should be a short and concise description of the package. The description expands upon this.) http://fedoraproject.org/wiki/Packaging/Guidelines#Summary_and_description If you want yum search to find adb and fastboot than you can add Provides: adb Provides: fastboot -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 705587] Review Request: android-tools - Android platform tools (adb, fastboot, etc)
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=705587
--- Comment #17 from nucleo 2011-11-17 17:46:46 EST
---
So if there are tags available then maybe it would be more correct to use tag
number in Version and %{date}git%{git_commit} in Release as for pre-release
packages?
https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Pre-Release_packages
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 705587] Review Request: android-tools - Android platform tools (adb, fastboot, etc)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=705587 --- Comment #18 from nucleo 2011-11-17 18:51:54 EST --- adb ans fastboot are statically linked with libzipfile (adb also with libcutils). Can you modify makefiles for using shared libs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 705587] Review Request: android-tools - Android platform tools (adb, fastboot, etc)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=705587 --- Comment #19 from nucleo 2011-11-19 12:17:19 EST --- License text adb/NOTICE also should be added in %doc. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 705587] Review Request: android-tools - Android platform tools (adb, fastboot, etc)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=705587 --- Comment #20 from Ivan Afonichev 2011-11-20 14:22:01 EST --- Spec URL: https://github.com/vanaf/android-tools-fedora/blob/master/android-tools.spec SRPM URL: http://baldr.sgu.ru/rpm/android-tools-2020git4a25390-1.fc16.src.rpm - Versioning changes - Use only needed sources - Udev rules moved to lib - More license info added - adb and fastboot moved to provides from summary It seems that git tags have very little relation to platform tools part of this git repository. Git tags also have no info about how next release will be called. libzipfile and libcutils seems to be used only in android project and there are not currently packaged in Fedora... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 705587] Review Request: android-tools - Android platform tools (adb, fastboot, etc)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=705587 --- Comment #21 from nucleo 2011-11-20 14:48:46 EST --- /lib/udev/rules.d/ is owned by udev, so "Requires: udev" should be added. There are two issues with libzipfile: 1. libzipfile compiled in both in adb and fastboot 2. libzipfile have ASL 2.0 license but fastboot is BSD So building at least libzipfile as shared library will eliminate its code duplication in adb and fastboot and made two binaries with different licenses. Is it possible to build libzipfile as shared library? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 705587] Review Request: android-tools - Android platform tools (adb, fastboot, etc)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=705587 nucleo changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|alekc...@googlemail.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 705587] Review Request: android-tools - Android platform tools (adb, fastboot, etc)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=705587 --- Comment #22 from Ivan Afonichev 2011-11-22 15:28:23 EST --- Spec URL: https://github.com/vanaf/android-tools-fedora/blob/master/android-tools.spec SRPM URL: http://baldr.sgu.ru/rpm/android-tools-2020git4a25390-2.fc16.src.rpm - Require udev -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 705587] Review Request: android-tools - Android platform tools (adb, fastboot, etc)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=705587 --- Comment #23 from nucleo 2011-11-22 16:58:36 EST --- If libzipfile and mkbootimg will be compiled in fatsboot then fastboot license will be "ASL 2.0 and BSD" but adb license is ASL 2.0. So resulting License tag should be License: ASL 2.0 and (ASL 2.0 and BSD) See https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Combined_Dual_and_Multiple_Licensing_Scenario Please also add comment before License: # The entire source code is ASL 2.0 except fastboot/ which is BSD Also please change URL to more specific for android tools http://developer.android.com/guide/developing/tools/ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 705587] Review Request: android-tools - Android platform tools (adb, fastboot, etc)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=705587 --- Comment #24 from Ivan Afonichev 2011-11-23 14:49:03 EST --- Spec URL: https://github.com/vanaf/android-tools-fedora/blob/master/android-tools.spec SRPM URL: http://baldr.sgu.ru/rpm/android-tools-2020git4a25390-3.fc16.src.rpm - Fix license - More specific URL -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 705587] Review Request: android-tools - Android platform tools (adb, fastboot, etc)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=705587 nucleo changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #25 from nucleo 2011-11-23 15:10:43 EST --- Name: ok License: ok BuildRequires/Requires: ok Macros used consistently: ok ldconfig: NA Locales: NA Devel: NA Files: ok Builds in mock: ok rpmlint output: android-tools.src: W: spelling-error %description -l en_US adb -> dab, adv, ad android-tools.src: W: spelling-error %description -l en_US Fastboot -> Fast boot, Fast-boot, Fastball android-tools.src: W: spelling-error %description -l en_US filesystem -> file system, file-system, systemically android-tools.src: W: spelling-error %description -l en_US fastboot -> fast boot, fast-boot, fastball android-tools.src: W: invalid-url URL: http://developer.android.com/guide/developing/tools/ HTTP Error 405: Method Not Allowed android-tools.src: W: strange-permission adb-Makefile 0660L android-tools.src: W: strange-permission fastboot-Makefile 0660L android-tools.src: W: strange-permission core-Makefile 0660L android-tools.src:28: W: unversioned-explicit-provides adb android-tools.src:29: W: unversioned-explicit-provides fastboot android-tools.src: W: invalid-url Source0: core-4a25390.tar.xz android-tools.i686: W: spelling-error %description -l en_US Fastboot -> Fast boot, Fast-boot, Fastball android-tools.i686: W: spelling-error %description -l en_US filesystem -> file system, file-system, systemically android-tools.i686: W: invalid-url URL: http://developer.android.com/guide/developing/tools/ HTTP Error 405: Method Not Allowed android-tools.i686: W: no-manual-page-for-binary adb android-tools.i686: W: no-manual-page-for-binary fastboot android-tools-debuginfo.i686: W: invalid-url URL: http://developer.android.com/guide/developing/tools/ HTTP Error 405: Method Not Allowed unversioned-explicit-provides is ok because there is no update from previous versions. You can set 644 permissions for makefiles when uploading them to git but this is not blocker. All other warnings are harmless. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 705587] Review Request: android-tools - Android platform tools (adb, fastboot, etc)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=705587 Ivan Afonichev changed: What|Removed |Added Flag||fedora-cvs? --- Comment #26 from Ivan Afonichev 2011-11-23 15:46:07 EST --- New Package SCM Request === Package Name: android-tools Short Description: Android platform tools Owners: van Branches: f15 f16 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 705587] Review Request: android-tools - Android platform tools (adb, fastboot, etc)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=705587 --- Comment #27 from Jon Ciesla 2011-11-24 22:34:15 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 705587] Review Request: android-tools - Android platform tools (adb, fastboot, etc)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=705587 Fedora Update System changed: What|Removed |Added Status|NEW |MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 705587] Review Request: android-tools - Android platform tools (adb, fastboot, etc)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=705587 --- Comment #28 from Fedora Update System 2011-11-27 16:30:36 EST --- android-tools-2020git4a25390-3.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/android-tools-2020git4a25390-3.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 705587] Review Request: android-tools - Android platform tools (adb, fastboot, etc)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=705587 --- Comment #29 from Fedora Update System 2011-11-27 16:30:46 EST --- android-tools-2020git4a25390-3.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/android-tools-2020git4a25390-3.fc16 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 705587] Review Request: android-tools - Android platform tools (adb, fastboot, etc)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=705587 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #30 from Fedora Update System 2011-11-28 19:03:04 EST --- android-tools-2020git4a25390-3.fc15 has been pushed to the Fedora 15 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 705587] Review Request: android-tools - Android platform tools (adb, fastboot, etc)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=705587 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||android-tools-2020git4a ||25390-3.fc15 Resolution||ERRATA Last Closed||2011-12-10 14:47:57 --- Comment #31 from Fedora Update System 2011-12-10 14:47:57 EST --- android-tools-2020git4a25390-3.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 705587] Review Request: android-tools - Android platform tools (adb, fastboot, etc)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=705587 Fedora Update System changed: What|Removed |Added Fixed In Version|android-tools-2020git4a |android-tools-2020git4a |25390-3.fc15|25390-3.fc16 --- Comment #32 from Fedora Update System 2011-12-10 15:08:29 EST --- android-tools-2020git4a25390-3.fc16 has been pushed to the Fedora 16 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 705587] Review Request: android-tools - Android platform tools (adb, fastboot, etc)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=705587 --- Comment #1 from Ivan Afonichev 2011-07-26 14:53:51 EDT --- Spec URL: https://github.com/vanaf/android-tools-fedora/blob/master/android-tools.spec SRPM URL: http://baldr.sgu.ru/rpm/android-tools-20110726.212282c-1.fc15.src.rpm -Updated to the latest upstream commit -Added more USB Vendors -fix source URL -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 705587] Review Request: android-tools - Android platform tools (adb, fastboot, etc)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=705587 --- Comment #2 from Mohamed El Morabity 2011-07-30 05:08:01 EDT --- Be careful: the Fedora compilation flags are not set. CLFAGS must include $RPM_OPT_FLAGS. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 705587] Review Request: android-tools - Android platform tools (adb, fastboot, etc)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=705587 nucleo changed: What|Removed |Added CC||alekc...@googlemail.com --- Comment #3 from nucleo 2011-07-30 07:28:51 EDT --- Files in fastboot/ have BSD license. Resulting License tag should be ASL 2.0 and BSD. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 705587] Review Request: android-tools - Android platform tools (adb, fastboot, etc)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=705587 --- Comment #4 from Ivan Afonichev 2011-07-31 16:16:18 EDT --- Spec URL: https://github.com/vanaf/android-tools-fedora/blob/master/android-tools.spec SRPM URL: http://baldr.sgu.ru/rpm/android-tools-20110731.810cf41-1.fc15.src.rpm - Update to upstream git commit 810cf41 - Fix License - Use optflags - Added more udev devices - Remove Epoch -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 705587] Review Request: android-tools - Android platform tools (adb, fastboot, etc)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=705587 --- Comment #5 from Ivan Afonichev 2011-08-16 15:18:29 EDT --- Spec URL: https://github.com/vanaf/android-tools-fedora/blob/master/android-tools.spec SRPM URL: http://baldr.sgu.ru/rpm/android-tools-20110816.80d508f-1.fc15.src.rpm - Update to upstream git commit 80d508f - Added more udev devices -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 705587] Review Request: android-tools - Android platform tools (adb, fastboot, etc)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=705587 Volker Fröhlich changed: What|Removed |Added CC||volke...@gmx.at --- Comment #6 from Volker Fröhlich 2011-08-23 15:53:40 EDT --- I can't download the SRPM. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 705587] Review Request: android-tools - Android platform tools (adb, fastboot, etc)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=705587 --- Comment #7 from Ivan Afonichev 2011-08-24 18:04:23 EDT --- Sorry there were some network problems on baldr.sgu.ru fixed now. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 705587] Review Request: android-tools - Android platform tools (adb, fastboot, etc)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=705587 --- Comment #8 from Volker Fröhlich 2011-08-26 16:27:18 EDT --- If you aim for EPEL5 and older, define a buildroot. If not, delete the rm in the install section. Defattr is not necessary anymore as well. The install macro is not used anymore; just use the install command. I'm under the impression, the description only describes one part of the package. Is this correct? The description could probably be more concise in the end. "etc" and "etc.." should be "etc." There are a few files licensed under GPL: debuggerd/arm/pr-support.c: GPL debuggerd/arm/unwind.c: GPL sh/arith.c: GPL (with incorrect FSF address) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 705587] Review Request: android-tools - Android platform tools (adb, fastboot, etc)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=705587 --- Comment #9 from Ivan Afonichev 2011-08-26 18:08:02 EDT --- Spec URL: https://github.com/vanaf/android-tools-fedora/blob/master/android-tools.spec SRPM URL: http://baldr.sgu.ru/rpm/android-tools-20110816.80d508f-2.fc15.src.rpm - Remove the rm in the install section - Remove defattr - Use install command(not macro) - Add description of fastboot This package includes only adb and fastboot binaries. As far as I know debuggerd/arm/pr-support.c: GPL debuggerd/arm/unwind.c: GPL sh/arith.c: GPL (with incorrect FSF address) are not used for them and some binary files in adb/ and fastboot/ dirs also are not necessary for building this package -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 705587] Review Request: android-tools - Android platform tools (adb, fastboot, etc)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=705587 --- Comment #10 from Volker Fröhlich 2011-09-05 02:15:11 EDT --- You're right, they're not used. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 705587] Review Request: android-tools - Android platform tools (adb, fastboot, etc)
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=705587
--- Comment #11 from Thomas Spura 2011-10-16
16:49:34 EDT ---
I tried to build it (and use it, but I'm not familiar with manually doing
something with android devices yet ;)) and this is now in my dmesg:
SYSFS{}= will be removed in a future udev version, please use ATTR{}= to match
the event device, or ATTRS{}= to match a parent device, in
/etc/udev/rules.d/51-android.rules
(Repeating several times ~20-30)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 705587] Review Request: android-tools - Android platform tools (adb, fastboot, etc)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=705587 --- Comment #12 from Ivan Afonichev 2011-10-16 17:41:57 EDT --- Spec URL: https://github.com/vanaf/android-tools-fedora/blob/master/android-tools.spec SRPM URL: http://baldr.sgu.ru/rpm/android-tools-20110816.80d508f-3.fc15.src.rpm - Update udev rules (s/SYSFS/ATTR/g) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
