[Bug 705798] Review Request: perl-Data-Hexify - Perl extension for hexdumping arbitrary data
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=705798 --- Comment #16 from Fedora Update System upda...@fedoraproject.org 2011-06-21 13:25:44 EDT --- perl-Data-Hexify-1.00-1.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 705798] Review Request: perl-Data-Hexify - Perl extension for hexdumping arbitrary data
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=705798 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||perl-Data-Hexify-1.00-1.fc1 ||5 Resolution||ERRATA Last Closed||2011-06-21 13:25:51 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 705798] Review Request: perl-Data-Hexify - Perl extension for hexdumping arbitrary data
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=705798 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #15 from Fedora Update System upda...@fedoraproject.org 2011-06-11 00:23:42 EDT --- perl-Data-Hexify-1.00-1.fc15 has been pushed to the Fedora 15 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 705798] Review Request: perl-Data-Hexify - Perl extension for hexdumping arbitrary data
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=705798 Petr Pisar ppi...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||ppi...@redhat.com AssignedTo|nob...@fedoraproject.org|ppi...@redhat.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 705798] Review Request: perl-Data-Hexify - Perl extension for hexdumping arbitrary data
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=705798 --- Comment #5 from Petr Pisar ppi...@redhat.com 2011-06-09 08:02:55 EDT --- Source tar ball is original. Ok. Summary verified from lib/Data/Hexify.pm. Ok. License verified from lib/Data/Hexify.pm. Ok. TODO: You can remove BuildRoot: definition and all occurrences of it's deletion (as the whole %clean section) if you are not going to package this software for EPEL as they are not needed in Fedora anymore (they are done by rpmbuild automatically). Package does not contain Perl C binding. noarch architecture is Ok. Description is reasonable (maybe replacing `hexdumping' with some codified words would be better). Ok. FIX: BuildRequire perl(Exporter) because of running test as this module can dual-live in the future (lib/Data/Hexify.pm:18, http://search.cpan.org/~ferreira/Exporter/). TODO: Remove %defattr from %files section as it's done automatically by rpmbuild. All tests pass. Ok. $ rpmlint perl-Data-Hexify.spec ../SRPMS/perl-Data-Hexify-1.00-1.fc15.src.rpm ../RPMS/noarch/perl-Data-Hexify-1.00-1.fc15.noarch.rpm perl-Data-Hexify.src: W: spelling-error Summary(en_US) hexdumping - hex dumping, hex-dumping, thumping perl-Data-Hexify.src: W: spelling-error %description -l en_US hexdumping - hex dumping, hex-dumping, thumping perl-Data-Hexify.noarch: W: spelling-error Summary(en_US) hexdumping - hex dumping, hex-dumping, thumping perl-Data-Hexify.noarch: W: spelling-error %description -l en_US hexdumping - hex dumping, hex-dumping, thumping 2 packages and 1 specfiles checked; 0 errors, 4 warnings. I recommend to use the hyphen variation. rpmlint is OK. $ rpm -q -lv -p ../RPMS/noarch/perl-Data-Hexify-1.00-1.fc15.noarch.rpm drwxr-xr-x2 rootroot0 čen 9 13:54 /usr/share/doc/perl-Data-Hexify-1.00 -rw-r--r--1 rootroot 224 lis 5 2004 /usr/share/doc/perl-Data-Hexify-1.00/Changes -rw-r--r--1 rootroot 1627 čen 29 2004 /usr/share/doc/perl-Data-Hexify-1.00/README -rw-r--r--1 rootroot 3085 čen 9 13:54 /usr/share/man/man3/Data::Hexify.3pm.gz drwxr-xr-x2 rootroot0 čen 9 13:54 /usr/share/perl5/vendor_perl/Data -rw-r--r--1 rootroot 8407 lis 5 2004 /usr/share/perl5/vendor_perl/Data/Hexify.pm File permissions and layout is Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Data-Hexify-1.00-1.fc15.noarch.rpm |sort |uniq -c 1 perl(bytes) 1 perl(Carp) 1 perl(Exporter) 1 perl(:MODULE_COMPAT_5.12.3) 1 perl(strict) 1 perl(warnings) 1 perl = 0:5.006 1 rpmlib(CompressedFileNames) = 3.0.4-1 1 rpmlib(FileDigests) = 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) = 4.0-1 1 rpmlib(PayloadIsXz) = 5.2-1 Binary requires Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-Data-Hexify-1.00-1.fc15.noarch.rpm |sort |uniq -c 1 perl(Data::Hexify) = 1.00 1 perl-Data-Hexify = 1.00-1.fc15 Binary provides Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Data-Hexify-1.00-1.fc15.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F16 (http://koji.fedoraproject.org/koji/taskinfo?taskID=3121493). Ok. Otherwise package is in line with Fedora and perl packaging guidelines. Please correct all `FIX' prefixed issues, consider fixing `TODO' issues, and provide new spec file. Resolution: Package NOT approved. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 705798] Review Request: perl-Data-Hexify - Perl extension for hexdumping arbitrary data
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=705798 --- Comment #6 from Richard W.M. Jones rjo...@redhat.com 2011-06-09 08:16:08 EDT --- Updated package (I rebuilt it but didn't bump the release): http://oirase.annexia.org/reviews/evtx/perl-Data-Hexify.spec http://oirase.annexia.org/reviews/evtx/perl-Data-Hexify-1.00-1.fc15.src.rpm This should address all of the concerns there. rpmlint is still complaining that hexdump isn't a word, but I think it's a perfectly cromulent word. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 705798] Review Request: perl-Data-Hexify - Perl extension for hexdumping arbitrary data
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=705798
Petr Pisar ppi...@redhat.com changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #7 from Petr Pisar ppi...@redhat.com 2011-06-09 08:52:07 EDT ---
Spec file changes:
--- perl-Data-Hexify.spec 2011-05-19 09:49:02.0 +0200
+++ perl-Data-Hexify.spec.1 2011-06-09 14:14:47.0 +0200
@@ -1,20 +1,20 @@
Name: perl-Data-Hexify
Version:1.00
Release:1%{?dist}
-Summary:Perl extension for hexdumping arbitrary data
+Summary:Perl extension to hexdump arbitrary data
License:GPL+ or Artistic
Group: Development/Libraries
URL:http://search.cpan.org/dist/Data-Hexify/
Source0:
http://www.cpan.org/authors/id/J/JV/JV/Data-Hexify-%{version}.tar.gz
-BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
BuildArch: noarch
BuildRequires: perl(ExtUtils::MakeMaker)
BuildRequires: perl(Test::More)
+BuildRequires: perl(Exporter)
Requires: perl(:MODULE_COMPAT_%(eval `%{__perl} -V:version`; echo
$version))
%description
-Perl extension for hexdumping arbitrary data.
+Perl extension to hexdump arbitrary data.
%prep
@@ -46,7 +46,6 @@
%files
-%defattr(-,root,root,-)
%doc Changes README
%{perl_vendorlib}/*
%{_mandir}/man3/*
TODO: You can remove BuildRoot: definition and all occurrences of it's
deletion (as the whole %clean section) if you are not going to package this
software for EPEL as they are not needed in Fedora anymore (they are done by
rpmbuild automatically).
-BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
Ok.
TODO: I meant to remove `rm -rf $RPM_BUILD_ROOT' commands either and the %clean
section itself as it became empty.
FIX: BuildRequire perl(Exporter) because of running test as this module can
dual-live in the future (lib/Data/Hexify.pm:18,
http://search.cpan.org/~ferreira/Exporter/).
+BuildRequires: perl(Exporter)
Ok.
TODO: Remove %defattr from %files section as it's done automatically by
rpmbuild.
-%defattr(-,root,root,-)
Ok.
$ rpmlint perl-Data-Hexify.spec ../SRPMS/perl-Data-Hexify-1.00-1.fc15.src.rpm
../RPMS/noarch/perl-Data-Hexify-1.00-1.fc15.noarch.rpm
perl-Data-Hexify.src: W: spelling-error Summary(en_US) hexdump - hex dump,
hex-dump, headlamp
perl-Data-Hexify.src: W: spelling-error %description -l en_US hexdump - hex
dump, hex-dump, headlamp
perl-Data-Hexify.noarch: W: spelling-error Summary(en_US) hexdump - hex dump,
hex-dump, headlamp
perl-Data-Hexify.noarch: W: spelling-error %description -l en_US hexdump - hex
dump, hex-dump, headlamp
2 packages and 1 specfiles checked; 0 errors, 4 warnings.
I don't think changing noun to verb with the same stem is such an improvement.
Package builds in F16
(http://koji.fedoraproject.org/koji/taskinfo?taskID=3121578). Ok.
Please consider fixing the `TODO' issues before building the package.
Resolution: Package APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 705798] Review Request: perl-Data-Hexify - Perl extension for hexdumping arbitrary data
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=705798 --- Comment #8 from Richard W.M. Jones rjo...@redhat.com 2011-06-09 09:17:41 EDT --- I've removed the two rm -rf commands and the %clean section. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 705798] Review Request: perl-Data-Hexify - Perl extension for hexdumping arbitrary data
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=705798 Richard W.M. Jones rjo...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #9 from Richard W.M. Jones rjo...@redhat.com 2011-06-09 09:25:59 EDT --- Thanks for the review! Here is the git request. New Package SCM Request === Package Name: perl-Data-Hexify Short Description: Perl extension to hexdump arbitrary data Owners: rjones Branches: f15 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 705798] Review Request: perl-Data-Hexify - Perl extension for hexdumping arbitrary data
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=705798 --- Comment #10 from Petr Pisar ppi...@redhat.com 2011-06-09 09:41:37 EDT --- Please add `perl-sig' to InitalCC of SCM Request structure. All Perl packages should do so. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 705798] Review Request: perl-Data-Hexify - Perl extension for hexdumping arbitrary data
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=705798 --- Comment #11 from Richard W.M. Jones rjo...@redhat.com 2011-06-09 09:51:22 EDT --- New Package SCM Request === Package Name: perl-Data-Hexify Short Description: Perl extension to hexdump arbitrary data Owners: rjones Branches: f15 InitialCC: perl-sig -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 705798] Review Request: perl-Data-Hexify - Perl extension for hexdumping arbitrary data
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=705798 --- Comment #12 from Jon Ciesla l...@jcomserv.net 2011-06-09 09:56:20 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 705798] Review Request: perl-Data-Hexify - Perl extension for hexdumping arbitrary data
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=705798 --- Comment #13 from Richard W.M. Jones rjo...@redhat.com 2011-06-09 10:12:18 EDT --- Thanks everyone. I've pushed this and built it in Rawhide and F15: http://koji.fedoraproject.org/koji/taskinfo?taskID=3121708 http://koji.fedoraproject.org/koji/taskinfo?taskID=3121710 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 705798] Review Request: perl-Data-Hexify - Perl extension for hexdumping arbitrary data
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=705798 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 705798] Review Request: perl-Data-Hexify - Perl extension for hexdumping arbitrary data
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=705798 --- Comment #14 from Fedora Update System upda...@fedoraproject.org 2011-06-09 10:13:24 EDT --- perl-Data-Hexify-1.00-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/perl-Data-Hexify-1.00-1.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 705798] Review Request: perl-Data-Hexify - Perl extension for hexdumping arbitrary data
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=705798 Ralf Corsepius rc040...@freenet.de changed: What|Removed |Added CC||rc040...@freenet.de --- Comment #3 from Ralf Corsepius rc040...@freenet.de 2011-05-19 02:11:02 EDT --- One remark: perl(Test::More) is a build-time-only requirement. It is not required at run-time. = R: perl(Test::More) should be removed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 705798] Review Request: perl-Data-Hexify - Perl extension for hexdumping arbitrary data
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=705798 --- Comment #4 from Richard W.M. Jones rjo...@redhat.com 2011-05-19 03:49:21 EDT --- (In reply to comment #3) One remark: perl(Test::More) is a build-time-only requirement. It is not required at run-time. = R: perl(Test::More) should be removed. Agreed. I removed that line from the spec file, although I didn't bother to rebuild the SRPM. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 705798] Review Request: perl-Data-Hexify - Perl extension for hexdumping arbitrary data
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=705798 --- Comment #1 from Richard W.M. Jones rjo...@redhat.com 2011-05-18 10:08:34 EDT --- Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3078701 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 705798] Review Request: perl-Data-Hexify - Perl extension for hexdumping arbitrary data
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=705798 Richard W.M. Jones rjo...@redhat.com changed: What|Removed |Added Blocks||705799 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 705798] Review Request: perl-Data-Hexify - Perl extension for hexdumping arbitrary data
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=705798 --- Comment #2 from Richard W.M. Jones rjo...@redhat.com 2011-05-18 10:09:29 EDT --- rpmlint output can all be ignored I think: perl-Data-Hexify.src: W: spelling-error Summary(en_US) hexdumping - hex dumping, hex-dumping, thumping perl-Data-Hexify.src: W: spelling-error %description -l en_US hexdumping - hex dumping, hex-dumping, thumping perl-Data-Hexify.noarch: W: spelling-error Summary(en_US) hexdumping - hex dumping, hex-dumping, thumping perl-Data-Hexify.noarch: W: spelling-error %description -l en_US hexdumping - hex dumping, hex-dumping, thumping 2 packages and 0 specfiles checked; 0 errors, 4 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
